Change in vdsm[master]: sp: use setDomainsMap in reconstructMaster

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: use setDomainsMap in reconstructMaster .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5948/ : SUCCESS http:

Change in vdsm[master]: MonkeyPatch: fix reverting staticmethods.

2014-01-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: MonkeyPatch: fix reverting staticmethods. .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23378/2/tests/monkeypatch.py File tests/monkeypatch.py: Line 19:

Change in vdsm[master]: MonkeyPatch: fix reverting staticmethods.

2014-01-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: MonkeyPatch: fix reverting staticmethods. .. Patch Set 2: Code-Review-1 (1 comment) Nice catch - but note that this module was not meant to patch classes - hence

Change in vdsm[master]: ipwrapper: switch link polling to netlink

2014-01-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: ipwrapper: switch link polling to netlink .. Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/23248/9/lib/vdsm/netlink.py File lib/vdsm/netlink.py: Line 61:

Change in vdsm[master]: ipwrapper: switch link polling to netlink

2014-01-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: ipwrapper: switch link polling to netlink .. Patch Set 10: Note that I reviewed patch set 9. -- To view, visit http://gerrit.ovirt.org/23248 To unsubscribe, visit

Change in vdsm[master]: ipwrapper: switch link polling to netlink

2014-01-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: ipwrapper: switch link polling to netlink .. Patch Set 9: (15 comments) See comments http://gerrit.ovirt.org/#/c/23248/9/lib/vdsm/netlink.py File lib/vdsm/netlink

Change in vdsm[master]: ipwrapper: switch link polling to netlink

2014-01-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: ipwrapper: switch link polling to netlink .. Patch Set 10: Looks good, but need more documentation and some cleanup. -- To view, visit http://gerrit.ovirt.org/232

Change in vdsm[master]: vm: per-attribute monitor response check

2014-01-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: per-attribute monitor response check .. Patch Set 3: (2 comments) Thanks for the great commit message. The patch looks good, but can be refined - see the comm

Change in vdsm[master]: sd: add inquireClusterLock method to StorageDomain

2014-01-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sd: add inquireClusterLock method to StorageDomain .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21426 To unsubscribe, visit http://gerri

Change in vdsm[master]: ipwrapper: switch link polling to netlink

2014-01-17 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: ipwrapper: switch link polling to netlink .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.ovirt.org/23248 To unsubscribe, visit http://gerr

Change in vdsm[master]: netinfo: use link objects for getting known information

2014-01-17 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: use link objects for getting known information .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/23291 To unsubscribe, visi

Change in vdsm[master]: MonkeyPatch: fix reverting staticmethods.

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: MonkeyPatch: fix reverting staticmethods. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5951/ : SUCCESS ht

Change in vdsm[master]: MonkeyPatch: fix reverting staticmethods.

2014-01-17 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: MonkeyPatch: fix reverting staticmethods. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/23378 To unsubscribe, visit http://gerri

Change in vdsm[master]: ipwrapper: switch link polling to netlink

2014-01-17 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: ipwrapper: switch link polling to netlink .. Patch Set 9: (4 comments) Thanks for the review Francesco http://gerrit.ovirt.org/#/c/23248/9/lib/vdsm/ne

Change in vdsm[master]: netinfo: use link objects for getting known information

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: use link objects for getting known information .. Patch Set 4: -Verified Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerri

Change in vdsm[master]: Extend setupNetworks API to accept defaultRoute

2014-01-17 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Extend setupNetworks API to accept defaultRoute .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22720 To unsubscribe, visit htt

Change in vdsm[master]: Add netinfo.getDefaultGateway()

2014-01-17 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Add netinfo.getDefaultGateway() .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23346 To unsubscribe, visit http://gerrit.ovirt

Change in vdsm[master]: Change MANAGEMENT_NETWORK to MANAGEMENT_NETWORK*S*

2014-01-17 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Change MANAGEMENT_NETWORK to MANAGEMENT_NETWORK*S* .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23182 To unsubscribe, visit

Change in vdsm[master]: Extend setupNetworks API to accept defaultRoute

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend setupNetworks API to accept defaultRoute .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5923/

Change in vdsm[master]: Add netinfo.getDefaultGateway()

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add netinfo.getDefaultGateway() .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5922/ : SUCCESS http:

Change in vdsm[master]: netconfig: set ETHTOOL_OPTS when a NIC goes up

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconfig: set ETHTOOL_OPTS when a NIC goes up .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5921/ :

Change in vdsm[master]: ipwrapper: switch link polling to netlink

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapper: switch link polling to netlink .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5920/ : SUCC

Change in vdsm[master]: netinfo: use link objects for getting known information

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: use link objects for getting known information .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_e

Change in vdsm[master]: ipwrapper: switch link polling to netlink

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapper: switch link polling to netlink .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5918/ : FAIL

Change in vdsm[master]: netinfo: use link objects for getting known information

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: use link objects for getting known information .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_e

Change in vdsm[master]: ipwrapper: make Link's _detectType module level

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapper: make Link's _detectType module level .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5916/ : SUCCESS

Change in vdsm[master]: ipwrapper: make Link's _detectType module level

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapper: make Link's _detectType module level .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5915/ : FAILURE

Change in vdsm[master]: Add netinfo.getDefaultGateway()

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add netinfo.getDefaultGateway() .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5905/ : SUCCESS http:

Change in vdsm[master]: Move virt things into vdsm/virt

2014-01-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Move virt things into vdsm/virt .. Patch Set 7: Code-Review+1 Looks fine. -- To view, visit http://gerrit.ovirt.org/21792 To unsubscribe, visit http://gerri

Change in vdsm[master]: ipwrapper: make Link's _detectType module level

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapper: make Link's _detectType module level .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5914/ : FAILURE

Change in vdsm[master]: vdsm: allow hooks to pass down dictionaries in json format

2014-01-17 Thread majopela
Miguel Angel Ajo Pelayo has posted comments on this change. Change subject: vdsm: allow hooks to pass down dictionaries in json format .. Patch Set 10: Verified+1 Dan, thank you very much for fixing the documentation grammar.

Change in vdsm[master]: vdsm: allow hooks to pass down dictionaries in json format

2014-01-17 Thread majopela
Miguel Angel Ajo Pelayo has posted comments on this change. Change subject: vdsm: allow hooks to pass down dictionaries in json format .. Patch Set 9: (2 comments) http://gerrit.ovirt.org/#/c/20330/9/vdsm/configNetwork.py File

Change in vdsm[master]: tests: add missing attribute in LibvirtMock object

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: add missing attribute in LibvirtMock object .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5950/ : SUCCES

Change in vdsm[master]: vdsm: allow hooks to pass down dictionaries in json format

2014-01-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: allow hooks to pass down dictionaries in json format .. Patch Set 9: (2 comments) http://gerrit.ovirt.org/#/c/20330/9/vdsm/configNetwork.py File vdsm/con

Change in vdsm[master]: vdsm: allow hooks to pass down dictionaries in json format

2014-01-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: allow hooks to pass down dictionaries in json format .. Patch Set 10: Verified+1 Code-Review+2 Pushed a version with minor textual changes, passed functio

Change in vdsm[master]: mkimage: do not create world-readable image

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: mkimage: do not create world-readable image .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5929/ : SUCCESS http

Change in vdsm[master]: Extend setupNetworks API to accept defaultRoute

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend setupNetworks API to accept defaultRoute .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5904/

Change in vdsm[master]: testing. DO NOT MERGE!

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: testing. DO NOT MERGE! .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5908/ : SUCCESS http://jenkins.ovirt.org/

Change in vdsm[master]: testing storageTest.py as CI job. DO NOT MERGE!

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: testing storageTest.py as CI job. DO NOT MERGE! .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5910/

Change in vdsm[master]: sp: refactor out the metadata access from StoragePool

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: refactor out the metadata access from StoragePool .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/

Change in vdsm[master]: sp: receive domains map in connectStoragePool

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: receive domains map in connectStoragePool .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5945/ :

Change in vdsm[master]: sp: use setDomainsMap in reconstructMaster

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: use setDomainsMap in reconstructMaster .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5948/ : SUC

Change in vdsm[master]: gluster: additional parsing of host UUID in verb glusterVolu...

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: additional parsing of host UUID in verb glusterVolumesList .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_t

Change in vdsm[master]: jsonrpc: Vdsm changes

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Vdsm changes .. Patch Set 19: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5943/ : SUCCESS

Change in vdsm[master]: caps: check availability abort on EIO in libvirt

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: caps: check availability abort on EIO in libvirt .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5936/ : SUCCESS

Change in vdsm[master]: sd: add inquireClusterLock method to StorageDomain

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sd: add inquireClusterLock method to StorageDomain .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/594

Change in vdsm[master]: gluster: Enhancing glusterVolumeStatus verb to include volum...

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Enhancing glusterVolumeStatus verb to include volume stats info. .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_

Change in vdsm[master]: gluster: Get size information of a gluster volume

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Get size information of a gluster volume .. Patch Set 12: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/593

Change in vdsm[master]: MonkeyPatch: fix reverting staticmethods.

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: MonkeyPatch: fix reverting staticmethods. .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5940/ : SUCC

Change in vdsm[master]: guest: Add support for guest cpu topology

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: guest: Add support for guest cpu topology .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5932/ : SUCC

Change in vdsm[master]: guestIF: Adding guest agent API versioning support

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: guestIF: Adding guest agent API versioning support .. Patch Set 11: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/59

Change in vdsm[master]: caps: check availability abort on EIO in libvirt

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: caps: check availability abort on EIO in libvirt .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5924/ : SUCC

Change in vdsm[master]: schema: Updates based on the current code base

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: Updates based on the current code base .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5930/ :

Change in vdsm[master]: Schema: Typemap changes

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Schema: Typemap changes .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5931/ : SUCCESS http://jenkin

Change in vdsm[master]: guestIF: Adding guest agent API versioning support

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: guestIF: Adding guest agent API versioning support .. Patch Set 10: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/59

Change in vdsm[master]: tests: add missing attribute in LibvirtMock object

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: add missing attribute in LibvirtMock object .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/592

Change in vdsm[master]: guest: Add support for guest cpu topology

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: guest: Add support for guest cpu topology .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5934/ : SUCC

Change in vdsm[master]: caps: check availability abort on EIO in libvirt

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: caps: check availability abort on EIO in libvirt .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5925/ : SUCCESS

Change in vdsm[master]: remove redundant libvirt call

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: remove redundant libvirt call .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5911/ : SUCCESS http://jenkins.ovi

Change in vdsm[master]: guest: Add support for guest cpu topology

2014-01-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: guest: Add support for guest cpu topology .. Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/23258/7/vdsm/guestIF.py File vdsm/guestIF.py: Line 313: ]

Change in vdsm[master]: guestIF: Adding guest agent API versioning support

2014-01-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: guestIF: Adding guest agent API versioning support .. Patch Set 11: (3 comments) Seems good excepts for a few minor things/typos. http://gerrit.ovirt.org/#/

Change in vdsm[master]: sp: use setDomainsMap in reconstructMaster

2014-01-17 Thread Federico Simoncelli
Federico Simoncelli has uploaded a new change for review. Change subject: sp: use setDomainsMap in reconstructMaster .. sp: use setDomainsMap in reconstructMaster The metadata access executed in reconstructMaster should be repla

Change in vdsm[master]: MonkeyPatch: fix reverting staticmethods.

2014-01-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: MonkeyPatch: fix reverting staticmethods. .. Patch Set 1: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/23378/1//COMMIT_MSG Commit Message: Line 4: C

Change in vdsm[master]: MonkeyPatch: fix reverting staticmethods.

2014-01-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: MonkeyPatch: fix reverting staticmethods. .. Patch Set 1: (1 comment) A bit of more context about the issue being fixed http://gerrit.ovirt.org/#/c/23378/1/

Change in vdsm[master]: gluster: additional parsing of host UUID in verb glusterVolu...

2014-01-17 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: gluster: additional parsing of host UUID in verb glusterVolumesList .. Patch Set 5: Code-Review-1 (1 comment) One minor code comment. Rest of the changes looks g

Change in vdsm[master]: gluster: additional parsing of host UUID in verb glusterVolu...

2014-01-17 Thread dnarayan
Darshan N has posted comments on this change. Change subject: gluster: additional parsing of host UUID in verb glusterVolumesList .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/22693/4/vdsm/gluster/cli.py File vdsm/g

Change in vdsm[master]: gluster: additional parsing of host UUID in verb glusterVolu...

2014-01-17 Thread dnarayan
Darshan N has posted comments on this change. Change subject: gluster: additional parsing of host UUID in verb glusterVolumesList .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/22693/2//COMMIT_MSG Commit Message: L

Change in vdsm[master]: Changing vdsm-tool and vdsmd pre-tasks outputs to be more me...

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Changing vdsm-tool and vdsmd pre-tasks outputs to be more meaningful to user .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vd

Change in vdsm[master]: get max_tasks and thread_pool_size from config by getint()

2014-01-17 Thread alitke
Adam Litke has posted comments on this change. Change subject: get max_tasks and thread_pool_size from config by getint() .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/9035 To unsubscribe, visit http://g

Change in vdsm[master]: vm: per-attribute monitor response check

2014-01-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: per-attribute monitor response check .. Patch Set 3: Verification: hibernation/dehibernation OK -- To view, visit http://gerrit.ovirt.org/23138 To unsub

Change in vdsm[master]: vm: janitorial: introduce a recovering attribute

2014-01-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: janitorial: introduce a recovering attribute .. Patch Set 3: Verification: hibernation/dehibernation OK. More tests on this topic pending. -- To view, v

Change in vdsm[master]: ipwrapper: switch link polling to netlink

2014-01-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: ipwrapper: switch link polling to netlink .. Patch Set 9: (4 comments) Few initial comments http://gerrit.ovirt.org/#/c/23248/9/lib/vdsm/netlink.py File lib

Change in vdsm[master]: MonkeyPatch: fix reverting staticmethods.

2014-01-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: MonkeyPatch: fix reverting staticmethods. .. Patch Set 1: (2 comments) nice fix. Just a few minor things, after those is +1 for me. http://gerrit.ovirt.org/

Change in vdsm[master]: ipwrapper: switch link polling to netlink

2014-01-17 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: ipwrapper: switch link polling to netlink .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.ovirt.org/23248 To unsubscribe, visit http://gerri

Change in vdsm[master]: netinfo: use link objects for getting known information

2014-01-17 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: use link objects for getting known information .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/23291 To unsubscribe, visi

Change in vdsm[master]: ipwrapper: make Link's _detectType module level

2014-01-17 Thread asegurap
Antoni Segura Puimedon has abandoned this change. Change subject: ipwrapper: make Link's _detectType module level .. Abandoned The monkeypatch fix makes this unnecessary. -- To view, visit http://gerrit.ovirt.org/23365 To uns

Change in vdsm[master]: MonkeyPatch: fix reverting staticmethods.

2014-01-17 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: MonkeyPatch: fix reverting staticmethods. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/23378 To unsubscribe, visit http://gerri

Change in vdsm[master]: gluster: Get size information of a gluster volume

2014-01-17 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: gluster: Get size information of a gluster volume .. Patch Set 12: No changes after Patchset 11, dependent patch got updated. -- To view, visit http://gerrit.ovi

Change in vdsm[master]: MonkeyPatch: fix reverting staticmethods.

2014-01-17 Thread asegurap
Antoni Segura Puimedon has uploaded a new change for review. Change subject: MonkeyPatch: fix reverting staticmethods. .. MonkeyPatch: fix reverting staticmethods. Under some circumstances setattr can make an object of type func

Change in vdsm[master]: gluster: Get size information of a gluster volume

2014-01-17 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: gluster: Get size information of a gluster volume .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.ovirt.org/17822 To unsubscribe, visit http://gerrit.

Change in vdsm[master]: testing. DO NOT MERGE!

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: testing. DO NOT MERGE! .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5906/ : SUCCESS http://jenkins.ovirt.org/

Change in vdsm[master]: testing storageTest.py as CI job. DO NOT MERGE!

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: testing storageTest.py as CI job. DO NOT MERGE! .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5903/

Change in vdsm[master]: Change MANAGEMENT_NETWORK to MANAGEMENT_NETWORK*S*

2014-01-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Change MANAGEMENT_NETWORK to MANAGEMENT_NETWORK*S* .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/590

Change in vdsm[master]: vm: per-attribute monitor response check

2014-01-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: per-attribute monitor response check .. Patch Set 3: Verification: * booted a few VMs OK. * created a new VM OK. -- To view, visit http://gerrit.ovirt.o

Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup

2014-01-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 6: Verified+1 Tested using the same tests of: http://gerrit.ovirt.org/#/c/22925/ Marking as verified;

Change in vdsm[master]: vm: janitorial: introduce a recovering attribute

2014-01-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: janitorial: introduce a recovering attribute .. Patch Set 3: Verification: * created few new VMs OK -- To view, visit http://gerrit.ovirt.org/22783 To u

Change in vdsm[master]: vm: janitorial: introduce a recovering attribute

2014-01-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: janitorial: introduce a recovering attribute .. Patch Set 3: Verification (still in progress): * existing VM runs OK * VM creation OK -- To view, visit

Change in vdsm[master]: caps: check availability abort on EIO in libvirt

2014-01-17 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: caps: check availability abort on EIO in libvirt .. caps: check availability abort on EIO in libvirt commit bbeb165e42673cddc87495c3d12c4a7f7572013c ad

Change in vdsm[master]: caps: check availability abort on EIO in libvirt

2014-01-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: caps: check availability abort on EIO in libvirt .. Patch Set 5: Code-Review+2 Thanks for the fix! -- To view, visit http://gerrit.ovirt.org/23273 To unsubscr

Change in vdsm[master]: caps: check availability abort on EIO in libvirt

2014-01-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: caps: check availability abort on EIO in libvirt .. Patch Set 5: Verified OK on RHEL 6.5 (clusterLevel 3.4 is reported) -- To view, visit http://gerrit.ovir

Change in vdsm[master]: caps: check availability abort on EIO in libvirt

2014-01-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: caps: check availability abort on EIO in libvirt .. Patch Set 5: Verified+1 Changes v5: drop the "as" rename. -- To view, visit http://gerrit.ovirt.org/2327

Change in vdsm[master]: guestIF: Adding guest agent API versioning support

2014-01-17 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: guestIF: Adding guest agent API versioning support .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.ovirt.org/17004 To unsubscribe, visit http://g

Change in vdsm[master]: guest: Add support for guest cpu topology

2014-01-17 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: guest: Add support for guest cpu topology .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/23258 To unsubscribe, visit http://gerrit.ovir

Change in vdsm[master]: guest: Add support for guest cpu topology

2014-01-17 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: guest: Add support for guest cpu topology .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/23258 To unsubscribe, visit http://gerrit.ovir

Change in vdsm[master]: guestIF: Adding guest agent API versioning support

2014-01-17 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: guestIF: Adding guest agent API versioning support .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.ovirt.org/17004 To unsubscribe, visit http://g

Change in vdsm[master]: caps: check availability abort on EIO in libvirt

2014-01-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: caps: check availability abort on EIO in libvirt .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/23273/4/vdsm/caps.py File vdsm/caps.py: Line 398:

Change in vdsm[master]: caps: check availability abort on EIO in libvirt

2014-01-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: caps: check availability abort on EIO in libvirt .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/23273/4/vdsm/caps.py File vdsm/caps.py: Line 398:

Change in vdsm[master]: tests: add missing attribute in LibvirtMock object

2014-01-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: add missing attribute in LibvirtMock object .. Patch Set 1: Verified+1 verified: * message is gone * tests behave like before (green before, green afte

Change in vdsm[master]: tests: add missing attribute in LibvirtMock object

2014-01-17 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: tests: add missing attribute in LibvirtMock object .. tests: add missing attribute in LibvirtMock object libvirtconnectionTests used to deliver an attribute

Change in vdsm[master]: gluster: additional parsing of host UUID in verb glusterVolu...

2014-01-17 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: additional parsing of host UUID in verb glusterVolumesList .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/22693/4/vdsm/gluster/cli.py File vdsm

  1   2   >