Change in vdsm[master]: sp: fix spm start when failing to produce domain

2014-03-19 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: sp: fix spm start when failing to produce domain .. Patch Set 2: Code-Review-2 (1 comment) http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py File vdsm/storage/sp

Change in vdsm[master]: sp: fix spm start when failing to produce domain

2014-03-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: sp: fix spm start when failing to produce domain .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py File vdsm/storage/sp.py: L

Change in vdsm[master]: vdsm: Add ACPI support for VM shutdown/reboot

2014-03-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Add ACPI support for VM shutdown/reboot .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/23457/6/vdsm/vmCommands.py File vdsm/vmCommands.py: Line

Change in vdsm[master]: setupNetworks: Fix incorrect mtu overriding when adding mult...

2014-03-19 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: setupNetworks: Fix incorrect mtu overriding when adding multiple networks .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25343/2/tests/functi

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 6: we would like integration to be able to proceed with proper build. please merge this as-is, which will ease

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 6: Code-Review+1 Kiril do you know if ivdsm is really needed, and if not could you move it to contrib? I

Change in vdsm[master]: setupNetworks: Fix incorrect mtu overriding when adding mult...

2014-03-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: setupNetworks: Fix incorrect mtu overriding when adding multiple networks .. Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/25343/2/tests/

Change in vdsm[master]: vdsm: Add ACPI support for VM shutdown/reboot

2014-03-19 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm: Add ACPI support for VM shutdown/reboot .. Patch Set 6: Code-Review-1 (3 comments) Some minor nits and a problem. The problem is that just as you

Change in vdsm[master]: revert 484246d: Live Merge: Add new scanVolumeChain API

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: revert 484246d: Live Merge: Add new scanVolumeChain API .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6726/

Change in vdsm[master]: pre-start: touch/configure vdsm logs

2014-03-19 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: pre-start: touch/configure vdsm logs .. Patch Set 2: Verified+1 Generated RPMs at http://people.redhat.com/dlandgra/newRPMS and ryan barry generate

Change in vdsm[master]: WIP: LiveMerge: Add Image.scanVolumes API

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: LiveMerge: Add Image.scanVolumes API .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6728/ : SUCCESS ht

Change in vdsm[master]: WIP: LiveMerge: Add Image.scanVolumes API

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: LiveMerge: Add Image.scanVolumes API .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6727/ : SUCCESS ht

Change in vdsm[master]: Live Merge: Add new scanVolumeChain API

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Live Merge: Add new scanVolumeChain API .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6725/ : SUCCESS http

Change in vdsm[master]: revert 484246d: Live Merge: Add new scanVolumeChain API

2014-03-19 Thread alitke
Adam Litke has abandoned this change. Change subject: revert 484246d: Live Merge: Add new scanVolumeChain API .. Abandoned -- To view, visit http://gerrit.ovirt.org/25917 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: Live Merge: Add new scanVolumeChain API

2014-03-19 Thread alitke
Adam Litke has abandoned this change. Change subject: Live Merge: Add new scanVolumeChain API .. Abandoned -- To view, visit http://gerrit.ovirt.org/25916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageT

Change in vdsm[master]: Live Merge: Add new scanVolumeChain API

2014-03-19 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: Live Merge: Add new scanVolumeChain API .. Live Merge: Add new scanVolumeChain API For live merge, we need a way to determine the actual volume chain for a given d

Change in vdsm[master]: revert 484246d: Live Merge: Add new scanVolumeChain API

2014-03-19 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: revert 484246d: Live Merge: Add new scanVolumeChain API .. revert 484246d: Live Merge: Add new scanVolumeChain API Change-Id: Ie22a58d00e0b980df2a0193f160c919f0e8a

Change in vdsm[master]: LiveMerge: Add Image.scanVolumes API

2014-03-19 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: LiveMerge: Add Image.scanVolumes API .. LiveMerge: Add Image.scanVolumes API TODO: - Revisit function naming Change-Id: I9e50d7292b98b5dbf1f0978efe5f0de589b3dbc0

Change in vdsm[master]: vm: report exit reason for migration failed

2014-03-19 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: vm: report exit reason for migration failed .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25164 To unsubscribe, visit htt

Change in vdsm[master]: pre-start: touch/configure vdsm logs

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: pre-start: touch/configure vdsm logs .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6724/ : SUCCESS http://

Change in vdsm[master]: core: Add boot time to the getVdsStats API

2014-03-19 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: core: Add boot time to the getVdsStats API .. Patch Set 2: Code-Review-1 (1 comment) minor comment http://gerrit.ovirt.org/#/c/25877/2/lib/vdsm/ut

Change in vdsm[master]: pre-start: touch/configure vdsm logs

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: pre-start: touch/configure vdsm logs .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6723/ : SUCCESS http://

Change in vdsm[master]: pre-start: touch/configure vdsm logs

2014-03-19 Thread dougsland
Douglas Schilling Landgraf has uploaded a new change for review. Change subject: pre-start: touch/configure vdsm logs .. pre-start: touch/configure vdsm logs During pre-start of vdsm we must create vdsm logs files with proper pe

Change in vdsm[ovirt-3.4]: openstack_net hook: search for ovs_vsctl only when needed

2014-03-19 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: openstack_net hook: search for ovs_vsctl only when needed .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25900 To unsubscribe,

Change in vdsm[master]: network: Introduce the network package

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: Introduce the network package .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/388/ : FAILUR

Change in vdsm[master]: network: Introduce the network package

2014-03-19 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: network: Introduce the network package .. Patch Set 2: Verified+1 passed unit tests. passed functional tests. ran the modules successfully from cmdline

Change in vdsm[master]: network: Introduce the network package

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: Introduce the network package .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/387/ : FAILUR

Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup

2014-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 4: (1 comment) Meta comment. http://gerrit.ovirt.org/#/c/24636/4/vdsm/clientIF.py File vdsm/clientIF.py:

Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup

2014-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 4: (4 comments) Puting some code in the final else makes the code more clear and allow dropping some comm

Change in vdsm[master]: Initial commit for vdsm-tool testing infrastructure

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Initial commit for vdsm-tool testing infrastructure .. Patch Set 12: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tes

Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup

2014-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 4: (1 comment) And the helper function name got worse. http://gerrit.ovirt.org/#/c/24636/4/vdsm/clientIF.

Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup

2014-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 4: Code-Review-1 (1 comment) Some parts became worse then the original code in latest patches. http://ger

Change in vdsm[master]: Use shell parameter expansion instead of if

2014-03-19 Thread mtayer
mooli tayer has uploaded a new change for review. Change subject: Use shell parameter expansion instead of if .. Use shell parameter expansion instead of if Change-Id: I2cd8fd16a5407ae12942718d0d9cf3c2d999e778 Signed-off-by: Moo

Change in vdsm[master]: Use shell parameter expansion instead of if

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Use shell parameter expansion instead of if .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6720/ : FAILURE http

Change in vdsm[master]: Adding remove/disable verbs to vdsm-tool for admin usages

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding remove/disable verbs to vdsm-tool for admin usages .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6718/

Change in vdsm[ovirt-3.4]: openstack_net hook: search for ovs_vsctl only when needed

2014-03-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: openstack_net hook: search for ovs_vsctl only when needed .. Patch Set 1: Verified+1 Copying Martin's verification from master. -- To view, visit http://gerri

Change in vdsm[ovirt-3.4]: openstack_net hook: search for ovs_vsctl only when needed

2014-03-19 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: openstack_net hook: search for ovs_vsctl only when needed .. openstack_net hook: search for ovs_vsctl only when needed Change-Id: I397e17782f61a94f734cf060d5ec

Change in vdsm[master]: openstack_net hook: search for ovs_vsctl only when needed

2014-03-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: openstack_net hook: search for ovs_vsctl only when needed .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25889 To unsubscribe, visit h

Change in vdsm[master]: openstack_net hook: search for ovs_vsctl only when needed

2014-03-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: openstack_net hook: search for ovs_vsctl only when needed .. openstack_net hook: search for ovs_vsctl only when needed Change-Id: I397e17782f61a94f734c

Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6717/ : SUCCESS

Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup

2014-03-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 3: patch set 4: addressed reviewers comments. _prepareVolumeFromPayload -> _makePayloadVolume renamed

Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup

2014-03-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/24636/3/vdsm/clientIF.py File vdsm/clientIF.py: Line 28

Change in vdsm[master]: performance: switch to cPickle

2014-03-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 5: Verified+1 verification (redone as per patch set #3): * runned existing VM (OK) * restarted VM while VM was ru

Change in vdsm[master]: performance: switch to cPickle

2014-03-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25860 To unsubscribe, visit http://gerrit.ovirt.org/sett

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 6: Code-Review-1 Since the motivation for this patch is only to make the tarball more similar to the git tree

Change in vdsm[master]: performance: switch to cPickle

2014-03-19 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25860 To unsubscribe, visit http://gerrit.ov

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/25861/6//COMMIT_MSG Commit Message: Line 4: Commit:

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25861 To unsubscribe, visit http://ger

Change in vdsm[master]: openstack_net hook: search for ovs_vsctl only when needed

2014-03-19 Thread masayag
Moti Asayag has posted comments on this change. Change subject: openstack_net hook: search for ovs_vsctl only when needed .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25889 To unsubscribe, visit http

Change in vdsm[master]: openstack_net hook: search for ovs_vsctl only when needed

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: openstack_net hook: search for ovs_vsctl only when needed .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/671

Change in vdsm[master]: openstack_net hook: search for ovs_vsctl only when needed

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: openstack_net hook: search for ovs_vsctl only when needed .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/671

Change in vdsm[master]: openstack_net hook: search for ovs_vsctl only when needed

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: openstack_net hook: search for ovs_vsctl only when needed .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/671

Change in vdsm[master]: openstack_net hook: search for ovs_vsctl only when needed

2014-03-19 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: openstack_net hook: search for ovs_vsctl only when needed .. openstack_net hook: search for ovs_vsctl only when needed Change-Id: I397e17782f61a94f734cf060d5ec

Change in vdsm[master]: Initial commit for vdsm-tool testing infrastructure

2014-03-19 Thread mtayer
mooli tayer has posted comments on this change. Change subject: Initial commit for vdsm-tool testing infrastructure .. Patch Set 11: I'm taking over this patch. Since i would like to use monkey patch here, and cannot do so bec

Change in vdsm[master]: performance: switch to cPickle

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6713/ : SUCCESS http://jenkin

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/25861/6//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014

Change in vdsm[master]: performance: switch to cPickle

2014-03-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 4: patch set 2-4: eventually found all the pickle imports. patch set 5: be forward compatible with py3 -- To vie

Change in vdsm[master]: core: Add boot time to the getVdsStats API

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add boot time to the getVdsStats API .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6712/ : SUCCESS h

Change in vdsm[master]: performance: switch to cPickle

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6711/ : SUCCESS http://jenkin

Change in vdsm[master]: performance: switch to cPickle

2014-03-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 4: Code-Review+1 My only problem is that "cPickle" does not exist -- To view, visit http://gerrit.ovirt.org/25860

Change in vdsm[master]: performance: switch to cPickle

2014-03-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 3: Hi Douglas. I definitely think yes. As we can see in the revision history, git grep somehow failed me and I m

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread knesenko
Kiril Nesenko has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/25861/6//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-03-18

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/25861/6//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-03-1

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25861 To unsubscribe, visit http://gerrit.ovi

Change in vdsm[master]: Allow moving of sparse images to a block domains

2014-03-19 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 3: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/25778/3/vdsm/storage/image.py File

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25861 To unsubscribe, visit http://gerrit.ovirt.org/

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6710/ : SUCCESS http://

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6709/ : SUCCESS http://

Change in vdsm[master]: Allow getFileStats for non NFS ISO domains

2014-03-19 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: Allow getFileStats for non NFS ISO domains .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25627 To unsubscribe, visit http://gerr

Change in vdsm[master]: Add the host uptime in seconds to host stats

2014-03-19 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: Add the host uptime in seconds to host stats .. Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/25835/2//COMMIT_MSG Commit Message: Line 3: AuthorD

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread knesenko
Kiril Nesenko has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/25861 To unsubscribe, visit http://gerrit.ovirt.org/se

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread knesenko
Kiril Nesenko has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/25861/5/vdsm/Makefile.am File vdsm/Makefile.am: Line 21: SUBDIRS =

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 5: (1 comment) one last note http://gerrit.ovirt.org/#/c/25861/5/vdsm/Makefile.am File vdsm/Makefile.am: Line

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread knesenko
Kiril Nesenko has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/25861 To unsubscribe, visit http://gerrit.ovirt.org/se

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 4: Code-Review-1 its way historical , i never used ivdsm and im not sure who does. i would like to here danke

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/25861/4/vdsm/ut/Makefile.am File vdsm/ut/Makefile.am: Line 19: # Li

Change in vdsm[master]: vm: migration: exponential downtime increment

2014-03-19 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: vm: migration: exponential downtime increment .. Patch Set 1: I wonder if we can factor in the convergence/progress of the migration as well. E.g. for a case

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread knesenko
Kiril Nesenko has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/25861/4/vdsm/ut/Makefile.am File vdsm/ut/Makefile.am: Line 19: # L

Change in vdsm[master]: Convert vm status strings to constants

2014-03-19 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Convert vm status strings to constants .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21790 To unsubscribe, visit http://gerri

Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup

2014-03-19 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 3: (2 comments) Some minor nits. http://gerrit.ovirt.org/#/c/24636/3/vdsm/clientIF.py File vd

Change in vdsm[master]: Add vdsm/ut directory to the tarball

2014-03-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/25861/4/vdsm/ut/Makefile.am File vdsm/ut/Makefile.am: Line 19: # Li

Change in vdsm[master]: setupNetworks: Fix incorrect mtu overriding when adding mult...

2014-03-19 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: setupNetworks: Fix incorrect mtu overriding when adding multiple networks .. Patch Set 2: Verified+1 Verified with help of the debugger. When running

Change in vdsm[master]: core: Add boot time to the getVdsStats API

2014-03-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add boot time to the getVdsStats API .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6708/ : FAILURE http:

Change in vdsm[master]: core: Add boot time to the getVdsStats API

2014-03-19 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: core: Add boot time to the getVdsStats API .. core: Add boot time to the getVdsStats API Calculate boot time from /proc/uptime and encode ISO8601 string with t

Change in vdsm[master]: sp: fix spm start when failing to produce domain

2014-03-19 Thread laravot
Liron Ar has posted comments on this change. Change subject: sp: fix spm start when failing to produce domain .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 20