oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtconnection: retry to establish connection
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8904/ : SUCCESS
h
Douglas Schilling Landgraf has posted comments on this change.
Change subject: libvirtconnection: retry to establish connection
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/27754
To unsubscribe, visit h
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: libvirtconnection: retry to establish connection
..
libvirtconnection: retry to establish connection
Currently if ovirt-node-plugin-vdsm or other a
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/9/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/c
Nir Soffer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 9:
(2 comments)
http://gerrit.ovirt.org/#/c/27298/9/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/co
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/9/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/c
Nir Soffer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 9:
(5 comments)
http://gerrit.ovirt.org/#/c/27298/9/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/co
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Correct and faster list2cmdline
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8903/ : SUCCESS
http://
Nir Soffer has posted comments on this change.
Change subject: utils: Correct and faster list2cmdline
..
Patch Set 5: -Code-Review
--
To view, visit http://gerrit.ovirt.org/27548
To unsubscribe, visit http://gerrit.ovirt.org/s
Nir Soffer has posted comments on this change.
Change subject: utils: Correct and faster list2cmdline
..
Patch Set 5: Verified+1 Code-Review+1
Changes:
- Address Dan comments
- Fix quoting of single quote
- Remove the repr() w
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: macbind - Attach vm nics to specified bridge
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/130
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: macbind - Attach vm nics to specified bridge
..
hooks: macbind - Attach vm nics to specified bridge
This hook support binding specified vNIC ide
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: macbind - Attach vm nics to specified bridge
..
Patch Set 10: Code-Review+2
I'm not crazy for this competition to hook-extnet, but if it's useful - you g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Stomp support
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8902/ : SUCCESS
http://jenkins.ovirt.org/j
oVirt Jenkins CI Server has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 12:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8901/ : SUCCESS
http://jenkins.ovirt
Antoni Segura Puimedon has posted comments on this change.
Change subject: hooks: macbind - Attach vm nics to specified bridge
..
Patch Set 10: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17895
To unsubscribe, visi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: macbind - Attach vm nics to specified bridge
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8900/ : SUCCES
Amador Pahim has posted comments on this change.
Change subject: hooks: macbind - Attach vm nics to specified bridge
..
Patch Set 10: Verified+1
--
To view, visit http://gerrit.ovirt.org/17895
To unsubscribe, visit http://gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: Remove uneeded error handler
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1307/ : SUCCESS
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: Add logging on filesystem altering operations
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sp: Remove uneeded error handler
..
sp: Remove uneeded error handler
domainMointor module does not raise StorageException and handling it
does not help
Dan Kenigsberg has submitted this change and it was merged.
Change subject: storage: Add logging on filesystem altering operations
..
storage: Add logging on filesystem altering operations
The rationale behind this patch is to
Dan Kenigsberg has posted comments on this change.
Change subject: storage: Add logging on filesystem altering operations
..
Patch Set 9: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/26046/9/vdsm/storage/fileSD.py
Fil
oVirt Jenkins CI Server has posted comments on this change.
Change subject: volume: remove unused imgPath argument from clone
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8899/ : SUCCE
Federico Simoncelli has uploaded a new change for review.
Change subject: volume: remove unused imgPath argument from clone
..
volume: remove unused imgPath argument from clone
This patch removes the unused imgPath argument from
Xavi Francisco has posted comments on this change.
Change subject: storage: Add logging on filesystem altering operations
..
Patch Set 9:
Changelog bewteen patch set 8 and pat set 9:
* Write log messages outside try/except blo
Federico Simoncelli has posted comments on this change.
Change subject: sp: Remove uneeded error handler
..
Patch Set 1: Code-Review+2
I don't think there's any storage operation in the flow that could raise a
StorageException
Nir Soffer has posted comments on this change.
Change subject: storage: Add logging on filesystem altering operations
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26046
To unsubscribe, visit http://g
Antoni Segura Puimedon has posted comments on this change.
Change subject: hooks: macbind - Attach vm nics to specified bridge
..
Patch Set 9: Code-Review-1
(1 comment)
Only one very minor thing, otherwise it is fine.
http://
Amador Pahim has posted comments on this change.
Change subject: hooks: macbind - Attach vm nics to specified bridge
..
Patch Set 9: -Code-Review
--
To view, visit http://gerrit.ovirt.org/17895
To unsubscribe, visit http://ger
Nir Soffer has posted comments on this change.
Change subject: storage: Add logging on filesystem altering operations
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/26046/8/vdsm/storage/fileSD.py
File vdsm/storage/fil
oVirt Jenkins CI Server has posted comments on this change.
Change subject: faqemu: move hook logic out of vdsm
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8898/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: Add logging on filesystem altering operations
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8897/ : SUCC
Xavi Francisco has posted comments on this change.
Change subject: storage: Add logging on filesystem altering operations
..
Patch Set 9: Verified+1
Same verification process
--
To view, visit http://gerrit.ovirt.org/26046
To
Dan Kenigsberg has posted comments on this change.
Change subject: faqemu: move hook logic out of vdsm
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/27705/1/vdsm/caps.py
File vdsm/caps.py:
Line 294: return
oVirt Jenkins CI Server has posted comments on this change.
Change subject: misc: Cleaner readspeed
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1305/ : SUCCESS
--
To view, vi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: volume: use qemuimg and remove custom createVolume
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1304/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: misc: Cleaner readspeed
..
misc: Cleaner readspeed
When checking reading speed from storage, we used to actually read the
data from the dd process into
Dan Kenigsberg has posted comments on this change.
Change subject: misc: Cleaner readspeed
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27616
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Dan Kenigsberg has posted comments on this change.
Change subject: volume: use qemuimg and remove custom createVolume
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26871
To unsubscribe, visit http://g
Dan Kenigsberg has submitted this change and it was merged.
Change subject: volume: use qemuimg and remove custom createVolume
..
volume: use qemuimg and remove custom createVolume
This patch substitutes a custom createVolume f
Yoav Kleinberger has posted comments on this change.
Change subject: storage: Add logging on filesystem altering operations
..
Patch Set 8: Code-Review+1
(3 comments)
http://gerrit.ovirt.org/#/c/26046/8//COMMIT_MSG
Commit Mess
Dan Kenigsberg has posted comments on this change.
Change subject: storage: Add logging on filesystem altering operations
..
Patch Set 8:
(2 comments)
http://gerrit.ovirt.org/#/c/26046/8/vdsm/storage/blockSD.py
File vdsm/stora
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: move getBalloonInfo in the stats thread
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8896/ : FAILURE
http:/
Francesco Romani has posted comments on this change.
Change subject: vm: Automatically add a serial port for a console device
..
Patch Set 6:
(1 comment)
I agree with Toni here. Spice GraphicsDevices may be another case of com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Pyroute2 network configurator
..
Patch Set 1:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1356/
: To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: fix _dom access when QEMU is dying
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/216/ : SUCCESS
--
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: vm: fix _dom access when QEMU is dying
..
vm: fix _dom access when QEMU is dying
commit 8fedf8bde3c28edb07add23c3e9b72681cb48e49 introduced a tiny
wind
Yaniv Bronhaim has posted comments on this change.
Change subject: vm: fix _dom access when QEMU is dying
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27724
To unsubscribe, visit http://gerrit.ovirt.
Nir Soffer has posted comments on this change.
Change subject: utils: Decrease cpu usage when executing commands
..
Patch Set 6:
Seems that Saggi is referring to commit
812a1dd0faaac6046f960e912f5f1c2f4f838171,
related to http
mooli tayer has posted comments on this change.
Change subject: vdsm-tool: add unprefixLines() to configfile.py.
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/27737
To unsubscribe, visit http://gerrit.ov
Nir Soffer has posted comments on this change.
Change subject: utils: Decrease cpu usage when executing commands
..
Patch Set 6:
Thanks Saggi! Is this old bug still relevant in the current version we support?
--
To view, visi
Saggi Mizrahi has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 11:
(11 comments)
Amazingly good work.
Minor complaints.
Also, overall use mixedCase.
I like using_underscores as muc
mooli tayer has posted comments on this change.
Change subject: vdsm-tool: add unprefixLines() to configfile.py.
..
Patch Set 1:
Tests fail due to unknown seg fault that happens in libvirt configure.
We are not sure why it hap
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8893/ : SUCCESS
htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: add unprefixLines() to configfile.py.
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8894/ : SUCCESS
h
mooli tayer has uploaded a new change for review.
Change subject: vdsm-tool: add unprefixLines() to configfile.py.
..
vdsm-tool: add unprefixLines() to configfile.py.
new method removes 'prefix' from each line starting with it.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stats: change log to exception for missing stats
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8892/ : SUCCESS
h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stats: avoid log if cpu stats are known missing
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8891/ : SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stats: avoid log if disk stats are known missing
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8890/ : SUCCESS
h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stats: avoid log if disk latency is known missing
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8889/ : SUCCESS
Yaniv Bronhaim has abandoned this change.
Change subject: Adding remove/disable verbs to vdsm-tool for admin usages
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/21772
To unsubscribe, visit http://gerrit.ovirt.org/set
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Implement rest of os and os.path functionality
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit// : SUCCESS
htt
Xavi Francisco has posted comments on this change.
Change subject: storage: Add logging on filesystem altering operations
..
Patch Set 8: Verified+1
Steps to verify:
* Add a new Posix FS Storage domain
* Check the VDSM log f
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add createdir, cleanupdir, simplewalk functionality
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8887/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: stats: avoid log if cpu stats are known missing
..
Patch Set 6: Verified+1
rebased and amended the commit message.
--
To view, visit http://gerrit.ovirt.org
Francesco Romani has posted comments on this change.
Change subject: stats: avoid log if disk latency is known missing
..
Patch Set 6: Verified+1
rebased and amended the commit message.
--
To view, visit http://gerrit.ovirt.o
Francesco Romani has posted comments on this change.
Change subject: stats: avoid log if disk stats are known missing
..
Patch Set 4: Verified+1
rebased and amended the commit message.
--
To view, visit http://gerrit.ovirt.or
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Additional oop functionality
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8886/ : SUCCESS
http://jenkins.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove unused remote file handler method (directWriteLines)
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8885/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add createdir, cleanupdir, simplewalk functionality
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pe
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Implement rest of os and os.path functionality
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8883/ : SUCCESS
htt
Francesco Romani has posted comments on this change.
Change subject: vm: report exit reason if restore state fails
..
Patch Set 2: Verified+1
Verification: patched on the fly a failing VDSM (first time ever I saw a
restoreStat
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Change file permissions using ioprocess
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8882/ : SUCCESS
http://jen
Francesco Romani has posted comments on this change.
Change subject: vm: fix _dom access when QEMU is dying
..
Patch Set 2: Verified+1
Verification:
This is a bug very hard to trigger using standard flows, so I manually injecte
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileUtils.validateAccess ioprocess implementation
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8881/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: repoStats implementation using ioprocess instead of RFH
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8880/ : SUC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Convert file metadata to use ioprocess for read/writes
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8879/ : SUCC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Additional oop functionality
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8878/ : SUCCESS
http://jenkins.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: glob.glob ioprocess implementation
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8877/ : SUCCESS
http://jenkins.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove unused remote file handler method (directWriteLines)
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8876/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: oop: Add an option to configure oop implementation
..
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8875/ : SUCCESS
Saggi Mizrahi has posted comments on this change.
Change subject: utils: Decrease cpu usage when executing commands
..
Patch Set 4:
Sadly, Tabula Rasa ate the actual commit so I can't find the bug report. It was
years ago.
Bu
Yeela Kaplan has uploaded a new change for review.
Change subject: Add createdir, cleanupdir, simplewalk functionality
..
Add createdir, cleanupdir, simplewalk functionality
Change-Id: Ica6cb0fee5802c664548011c38e358529b155333
B
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 8:
(1 comment)
>ok, than I would suggest to:
>1. Rename allTrue to needsUpdate - because it seems that
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: adding gfs2 symlink test
..
Patch Set 3:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8874/ : To avoid
overloading
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Spaces around operators
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1303/ : SUCCESS
--
To view, vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Spaces around operators
..
Spaces around operators
Change-Id: Ib9244cf175c9bbdeb34057b3b53fe7ad625e0a01
Signed-off-by: Vinzenz Feenstra
Reviewed-on: h
Dan Kenigsberg has posted comments on this change.
Change subject: Spaces around operators
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27715
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: check if mount specification is a symlink
..
Patch Set 2:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8873/ : To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: volume: remove unneeded rebaseVolumeRollback logging
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/130
Dan Kenigsberg has posted comments on this change.
Change subject: volume: remove unneeded rebaseVolumeRollback logging
..
Patch Set 3: Code-Review+2
hear hear
--
To view, visit http://gerrit.ovirt.org/26900
To unsubscribe, v
Dan Kenigsberg has submitted this change and it was merged.
Change subject: volume: remove unneeded rebaseVolumeRollback logging
..
volume: remove unneeded rebaseVolumeRollback logging
This patch removes some unneeded extra log
Francesco Romani has posted comments on this change.
Change subject: vm: fix _dom access when QEMU is dying
..
Patch Set 1:
bz mistakenly marked as MODIFIED, it was just merged on master
--
To view, visit http://gerrit.ovirt.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: drop a non-surprising error report
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1301/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: caps: drop a non-surprising error report
..
caps: drop a non-surprising error report
Commit 60dd97a84 changed getVdsCaps to report whether we support l
Dan Kenigsberg has posted comments on this change.
Change subject: caps: drop a non-surprising error report
..
Patch Set 1: Verified+1 Code-Review+2
verified by running `getVdsCaps` with and without vdsm-hook-faqemu.
--
To vi
Federico Simoncelli has posted comments on this change.
Change subject: volume: remove unneeded rebaseVolumeRollback logging
..
Patch Set 3: Verified+1
Verified modifying a persisted task to use an unexisting storage domain
(s
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/27724
to review the following change.
Change subject: vm: fix _dom access when QEMU is dying
..
vm: fix _dom access when QEMU is
mooli tayer has abandoned this change.
Change subject: _configure mid work
..
Abandoned
will be included in http://gerrit.ovirt.org/#/c/27298/
--
To view, visit http://gerrit.ovirt.org/26959
To unsubscribe, visit http://gerri
1 - 100 of 134 matches
Mail list logo