Francesco Romani has posted comments on this change.
Change subject: make: Add check-all target
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32721
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: tool: Remove duplicate names
..
Patch Set 7: Code-Review+1
(1 comment)
ncie :)
http://gerrit.ovirt.org/#/c/31775/7//COMMIT_MSG
Commit Message:
Line 8:
Francesco Romani has posted comments on this change.
Change subject: tests: vm: add unit tests for setBalloonTarget
..
Patch Set 9: Verified+1
rebased against master. Verified by running the test themselves.
--
To view,
Francesco Romani has posted comments on this change.
Change subject: tests: add simple balloon functional testcase
..
Patch Set 15:
rebased to keep it current. Still waiting for MOM = 0.4.2.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: vm: add unit tests for setBalloonTarget
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11438/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: add simple balloon functional testcase
..
Patch Set 15:
Build Failed
Allon Mureinik has posted comments on this change.
Change subject: spec: Require qemu-kvm-rhev in EL
..
Patch Set 2:
It was requested by a community member (see
https://bugzilla.redhat.com/show_bug.cgi?id=1127460#c36).
I
Allon Mureinik has posted comments on this change.
Change subject: spec: Require qemu-kvm-rhev in EL
..
Patch Set 2: Code-Review-1
Giving myself (-1) in the meanwhile to visualize that this patch is under
debate.
Discussion
Allon Mureinik has posted comments on this change.
Change subject: multipath: Disable queuing on all multipath devices
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32277
To unsubscribe, visit
mooli tayer has posted comments on this change.
Change subject: tool: use natural numbers for configuration versioning.
..
Patch Set 2: Code-Review-1
I agree 'version' is better 'by vdsm'
Since this won't be a suffix only
Francesco Romani has posted comments on this change.
Change subject: sampling: do not produce stats for missing disks
..
Patch Set 3: Verified+1
Re-verified:
Thread-13::DEBUG::2014-09-10
mooli tayer has posted comments on this change.
Change subject: tool: bump CONF_VERSION to 4.17.
..
Patch Set 2:
Actually after inspecting the code again I see that:
1.) libvirt will ALWAYS require --force in order to not
mooli tayer has posted comments on this change.
Change subject: tool: use natural numbers for configuration versioning.
..
Patch Set 2:
Since discussion on 32707 might imply the version numbers
are not significant this needs
Francesco Romani has posted comments on this change.
Change subject: vm: always log when guest CPU state changes
..
Patch Set 3: Verified+1
Verified booting VMs and doing hibernate/resume cycles for a few VMs
--
To view,
Martin Sivák has uploaded a new change for review.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Force vdsm to stay with libvirt = 1.2.7
Libvirt removed silent support for min_guarantee parameter when
running on
Martin Sivák has posted comments on this change.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Patch Set 1:
Please take a look at this change and reject it if we need the newest libvirt
version for something
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/332/ :
Francesco Romani has posted comments on this change.
Change subject: vm: migration: exponential downtime increment
..
Patch Set 7: Verified+1
Re-verified running a migration in the following scenario:
- patched VDSM
- set
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/333/ :
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sampling: do not produce stats for missing disks
..
sampling: do not produce stats for missing disks
Adding of a new disk using hotplug (hotplugDisk
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: do not produce stats for missing disks
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1827/
Dan Kenigsberg has posted comments on this change.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/32741/2/vdsm.spec.in
File vdsm.spec.in:
Line
Hello Nir Soffer, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32749
to review the following change.
Change subject: sampling: do not produce stats for missing disks
..
sampling:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsClient: getRoute verb added
..
Patch Set 2: Code-Review-1
I am missing a functional test for the new verb. Please add it, preferably to
an existing test.
Federico Simoncelli has posted comments on this change.
Change subject: multipath: Disable queuing on all multipath devices
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/32277/3/vdsm/storage/vdsm-multipath.rules.in
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same
subnet
..
Patch Set 9:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Configure iSCSI iface.net_ifacename
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11443/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem in
getVdsCaps
..
ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem in getVdsCaps
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem in
getVdsCaps
..
Patch Set 2:
Build Successful
Francesco Romani has posted comments on this change.
Change subject: config: introduce a devel section
..
Patch Set 1: Verified+1
verified by enabling the profiler and running a few test runs.
--
To view, visit
Amador Pahim has posted comments on this change.
Change subject: Configure iSCSI iface.net_ifacename
..
Patch Set 7: Verified+1
Verified with and without http://gerrit.ovirt.org/#/c/32383/
--
To view, visit
Martin Sivák has uploaded a new change for review.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Force vdsm to stay with libvirt = 1.2.7
Libvirt removed silent support for min_guarantee parameter when
running on
Martin Sivák has uploaded a new change for review.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Force vdsm to stay with libvirt = 1.2.7
Libvirt removed silent support for min_guarantee parameter when
running on
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Configure iSCSI iface.net_ifacename
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11444/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: tool: Remove duplicate names
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31775
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/63/ :
Amador Pahim has posted comments on this change.
Change subject: Configure iSCSI iface.net_ifacename
..
Patch Set 8: Verified+1
Verified with and without http://gerrit.ovirt.org/#/c/32383/
--
To view, visit
Martin Sivák has posted comments on this change.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Patch Set 1: Verified+1
Builds and the proper conflict is present in the RPM.
--
To view, visit
Martin Sivák has posted comments on this change.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Patch Set 1: Verified+1
Builds and the proper conflict is present in the RPM.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Configure iSCSI iface.net_ifacename
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11445/ : SUCCESS
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32769
to review the following change.
Change subject: unified_persistence: only consider bonds created/touched by vdsm
..
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same
subnet
..
Patch Set 10:
Build Successful
Antoni Segura Puimedon has posted comments on this change.
Change subject: unified_persistence: only consider bonds created/touched by vdsm
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32769
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Force vdsm to stay with libvirt = 1.2.7
Libvirt removed silent support for min_guarantee parameter when
Antoni Segura Puimedon has posted comments on this change.
Change subject: unified_persistence: only consider bonds created/touched by vdsm
..
Patch Set 1:
In [2]: unified_persistence._getNetInfo()
Out[2]: ({}, {'bond11':
Francesco Romani has posted comments on this change.
Change subject: sampling: do not produce stats for missing disks
..
Patch Set 1: Verified+1
Verified the same way as master patch:
TOji 15:10:17 root [~]$ vdsClient
Dan Kenigsberg has posted comments on this change.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32763
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32764
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Force vdsm to stay with libvirt = 1.2.7
Libvirt removed silent support for min_guarantee parameter when
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/64/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/65/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/151/ : FAILURE
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sampling: do not produce stats for missing disks
..
sampling: do not produce stats for missing disks
Adding of a new disk using hotplug (hotplugDisk
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: do not produce stats for missing disks
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32749
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: unified_persistence: only consider bonds created/touched by vdsm
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32769
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem in
getVdsCaps
..
ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem in getVdsCaps
Dan Kenigsberg has submitted this change and it was merged.
Change subject: revert: libvirt is happy with redefinition of an existing
nwfilter
..
revert: libvirt is happy with redefinition of an existing nwfilter
Change-Id:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: unified_persistence: only consider bonds created/touched by vdsm
..
unified_persistence: only consider bonds created/touched by vdsm
When upgrading a
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: do not produce stats for missing disks
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/152/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: unified_persistence: only consider bonds created/touched by vdsm
..
Patch Set 2:
Build Failed
Yaniv Bronhaim has posted comments on this change.
Change subject: revert: libvirt is happy with redefinition of an existing
nwfilter
..
Patch Set 1:
revert of what patch?
--
To view, visit http://gerrit.ovirt.org/32697
To
Martin Sivák has abandoned this change.
Change subject: Force vdsm to stay with libvirt = 1.2.7
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/32741
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Sivák has uploaded a new change for review.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Do not add the memtune/min_guarantee element to the libvirt xml
VDSM does not need to put the
Martin Sivák has posted comments on this change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Patch Set 1: Verified-1
oops, I forgot to reset the tree, just second
--
To view, visit
Adam Litke has posted comments on this change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32774
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem in
getVdsCaps
..
Patch Set 2:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Patch Set 1:
Build Failed
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: Use frozenset instead of set
..
Patch Set 5:
did you verify with python 2.6?
--
To view, visit http://gerrit.ovirt.org/31786
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: Remove duplicate names
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31775
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Patch Set 2:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Patch Set 3:
The simple creation flow looks OK. I'm concerned with migrations, both live
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Patch Set 3:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Patch Set 3:
bad wording.
s/the filtering you added may be sufficient/this patch could be
Yeela Kaplan has posted comments on this change.
Change subject: oop: Use a single instance of IOProcess per SD
..
Patch Set 4:
(10 comments)
http://gerrit.ovirt.org/#/c/31501/4/lib/vdsm/config.py.in
File
Amador Pahim has posted comments on this change.
Change subject: Configure iSCSI iface.net_ifacename
..
Patch Set 8: -Verified
Running some more tests.
--
To view, visit http://gerrit.ovirt.org/31534
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: revert: libvirt is happy with redefinition of an existing
nwfilter
..
Patch Set 2:
Build Failed
Martin Sivák has posted comments on this change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Patch Set 3: Verified+1
I verified that after this is applied then all new VMs have no sign of
Francesco Romani has posted comments on this change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Patch Set 3: Code-Review+1
fine for me, I see the missing pieces will be handled in
Dan Kenigsberg has posted comments on this change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32774
To unsubscribe,
Antoni Segura Puimedon has posted comments on this change.
Change subject: ethtool_opts: provide a way to apply to all slaves
..
Patch Set 7: Verified+1
Verified by doing:
In [23]: c.setupNetworks({'ethtool': {'nic':
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ethtool_opts: provide a way to apply to all slaves
..
ethtool_opts: provide a way to apply to all slaves
There was a hole in the feature that this
oVirt Jenkins CI Server has posted comments on this change.
Change subject: oop: Use a single instance of IOProcess per SD
..
Patch Set 5: Code-Review-1 Verified-1
Build Unstable
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Do not add the memtune/min_guarantee element to the libvirt xml
VDSM does not need
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: ethtool_opts: provide a way to apply to all slaves
..
ethtool_opts: provide a way to apply to all slaves
There was a hole in the feature that this
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ethtool_opts: provide a way to apply to all slaves
..
Patch Set 8:
Build Successful
Martin Sivák has reverted this change.
Change subject: Revert Force vdsm to stay with libvirt = 1.2.7
..
Patch Set 3: Reverted
This patchset was reverted in change: Iffa726906cc8fe4f8ba7f5be377a51d19ee46078
--
To view, visit
Martin Sivák has uploaded a new change for review.
Change subject: Revert Force vdsm to stay with libvirt = 1.2.7
..
Revert Force vdsm to stay with libvirt = 1.2.7
This breaks live merge and is not needed now.
This reverts
Martin Sivák has reverted this change.
Change subject: Revert Force vdsm to stay with libvirt = 1.2.7
..
Patch Set 3: Reverted
This patchset was reverted in change: Id08f4e1c61d6b20518570ccafad847ce446fee9d
--
To view, visit
Martin Sivák has uploaded a new change for review.
Change subject: Revert Force vdsm to stay with libvirt = 1.2.7
..
Revert Force vdsm to stay with libvirt = 1.2.7
This is not needed anymore and also breaks live merge.
This
Martin Sivák has posted comments on this change.
Change subject: Revert Force vdsm to stay with libvirt = 1.2.7
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32787
To unsubscribe, visit
Martin Sivák has posted comments on this change.
Change subject: Revert Force vdsm to stay with libvirt = 1.2.7
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32786
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Patch Set 4:
Build Successful
Hello Adam Litke, Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32788
to review the following change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
Francesco Romani has posted comments on this change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32788
To
Hello Adam Litke, Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32789
to review the following change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert Force vdsm to stay with libvirt = 1.2.7
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/66/
Martin Sivák has posted comments on this change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Patch Set 1: Verified+1
All tests pass, also verified on F19 with 3.4 setup.
--
To view,
Martin Sivák has posted comments on this change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32788
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32789
To
Dan Kenigsberg has posted comments on this change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32788
To unsubscribe,
1 - 100 of 135 matches
Mail list logo
