Francesco Romani has posted comments on this change.
Change subject: virt: migration: rename cancel->stop method
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/33030/1/vdsm/virt/migration.py
File vdsm/virt/migration.p
Francesco Romani has posted comments on this change.
Change subject: virt: migration: rename cancel->stop method
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/33030/1/vdsm/virt/migration.py
File vdsm/virt/migration.p
Francesco Romani has posted comments on this change.
Change subject: config: warn about meaningless sampling windows
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/33784/2//COMMIT_MSG
Commit Message:
Line 7: config:
Francesco Romani has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 2:
(6 comments)
thanks for the review!
http://gerrit.ovirt.org/#/c/33783/2/vdsm/virt/sampling.py
File vdsm
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults
offline
..
netinfo, tool: Add a vdsm-tool to determine bonding defaults offline
dump-bond
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: netinfotests: Do not assume the existence of
/var/lib/vdsm/bonding-defaults.json
..
netinfotests: Do not assume the existence of /var/lib/vdsm/bonding-
Francesco Romani has posted comments on this change.
Change subject: virt: migration: rename cancel->stop method
..
Patch Set 2: Verified+1
just updated the commit message, no code changes. Copied score.
--
To view, visit htt
Nir Soffer has posted comments on this change.
Change subject: virt: migration: rename cancel->stop method
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33030
To unsubscribe, visit http://gerrit.ovirt
Francesco Romani has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/33783/2//COMMIT_MSG
Commit Message:
Line 7: sampling: extract
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults
offline
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfotests: Do not assume the existence of
/var/lib/vdsm/bonding-defaults.json
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_
Francesco Romani has posted comments on this change.
Change subject: sampling: update module docstring
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/33785/2/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 18:
Shahar Havivi has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 12:
(12 comments)
Thanks for reviewing Nir.
http://gerrit.ovirt.org/#/c/33309/12/vdsm/API.py
File vdsm/API.py:
Francesco Romani has uploaded a new change for review.
Change subject: conf: sampling: drop unused tunables
..
conf: sampling: drop unused tunables
With the recent consolidation of disk stats
and added support for one-item sampl
Francesco Romani has uploaded a new change for review.
Change subject: sampling: rename variables to make code nicer
..
sampling: rename variables to make code nicer
Rename internal variables of SampleWindow
methods to make the
Francesco Romani has abandoned this change.
Change subject: config: warn about meaningless sampling windows
..
Abandoned
Abandoned as anticipated. Tunables just dropped on this patch:
http://gerrit.ovirt.org/#/c/34389
--
To
Francesco Romani has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 3:
Addressed reviewer's comments.
--
To view, visit http://gerrit.ovirt.org/33783
To unsubscribe, visit ht
Francesco Romani has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/33783/2/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line
Francesco Romani has posted comments on this change.
Change subject: conf: sampling: drop unused tunables
..
Patch Set 1: Verified+1
verified by git grepping each dropped tunable to see if there are any user
left. No results,
Francesco Romani has posted comments on this change.
Change subject: sampling: update module docstring
..
Patch Set 3: Verified+1
Trivial documentation-only patch.
Verified by running a 'make check' just in case.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: clean dhclient processes that are left after functional tests
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34366
To unsubscribe, vis
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: update module docstring
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33785
To unsubscribe, visit http://gerrit.ovirt.org/s
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sampling: update module docstring
..
sampling: update module docstring
Make sampling module docstring reflect reality.
Change-Id: I47d51c51619d7babf49
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: update module docstring
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4109/ : SUCCESS
http://jen
oVirt Jenkins CI Server has posted comments on this change.
Change subject: conf: sampling: drop unused tunables
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13097/ : SUCCESS
http:
Nir Soffer has posted comments on this change.
Change subject: clean dhclient processes that are left after functional tests
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34366
To unsubscribe, visit h
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: migration: rename helper function
..
Patch Set 11: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28355
To unsubscribe, visit http://gerrit.ov
Dan Kenigsberg has submitted this change and it was merged.
Change subject: libvirt: do not always log failed libvirt calls
..
libvirt: do not always log failed libvirt calls
The libvirtconnection module provides libvirt connec
Dan Kenigsberg has posted comments on this change.
Change subject: libvirt: do not always log failed libvirt calls
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33937
To unsubscribe, visit http://gerr
Nir Soffer has posted comments on this change.
Change subject: rpc: Replace misuse of assert with TypeError
..
Patch Set 4:
I don't know if the assert is really needed, maybe it is just a leftover that
we can remove - I did no
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirt: do not always log failed libvirt calls
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4110/ : SUCCE
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Use VIR_DOMAIN_XML_BLOCK_INFO when getting volume
chain
..
Patch Set 1:
How much cost does this flag add to XMLDesc() ?
I'm wondering if it is wo
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Use VIR_DOMAIN_XML_BLOCK_INFO when getting volume
chain
..
Patch Set 1: Code-Review-1
no real objections here, just ask for information, so -1 fo
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1309
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert 'Create default multipath.conf during install'
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13100
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: use getLastSample
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/33780/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 242
Line 243
Li
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: use getLastSample
..
Patch Set 3: Verified+1
dropped tunables as Dan requested.
No code changes, copied score
--
To view, visit http://gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Use utils.persist instead of importing ovirt-node Config
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/131
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: add unpersist for symmetry
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13102/ : SUCCESS
http://j
Dan Kenigsberg has posted comments on this change.
Change subject: virt: sampling: use getLastSample
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33780
To unsubscribe, visit http://gerrit.ovirt.org/s
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: sampling: use getLastSample
..
virt: sampling: use getLastSample
This patch makes use of the new
getLastSample method when a sample
window is not
Martin Polednik has posted comments on this change.
Change subject: virt: move controller device to vmdevices.py
..
Patch Set 4: Verified+1
same as everything in the tree:
- make check
- installing and running functional tests
Dan Kenigsberg has posted comments on this change.
Change subject: conf: sampling: drop unused tunables
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34389
To unsubscribe, visit http://gerrit.ovirt.or
Dan Kenigsberg has submitted this change and it was merged.
Change subject: conf: sampling: drop unused tunables
..
conf: sampling: drop unused tunables
With the recent consolidation of disk stats
and added support for one-item
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: move controller device to vmdevices.py
..
virt: move controller device to vmdevices.py
No real code changes
Change-Id: I941a76230fd5cc3c28495c5f
Martin Polednik has uploaded a new change for review.
Change subject: devices: rename VideoDevice to Device
..
devices: rename VideoDevice to Device
No functionality changes, only naming naming changes
Change-Id: I4f33a6862a071
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Use ovirt node for persist files
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13103/ : SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: sampling: use getLastSample
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4111/ : SUCCESS
http://jen
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: change persistFile to persist
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13104/ : SUCCESS
http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: conf: sampling: drop unused tunables
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4112/ : SUCCESS
http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Move functionality from storage.misc
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13105/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move controller device to vmdevices.py
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4113/ : SUCCESS
Ido Barkan has uploaded a new change for review.
Change subject: net: source route: don't attempt to configure invalid values
..
net: source route: don't attempt to configure invalid values
If a DHCP server provides Vdsm with in
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/34393
to review the following change.
Change subject: net: source route: don't attempt to configure invalid values
..
net: sourc
oVirt Jenkins CI Server has posted comments on this change.
Change subject: multipath: use a backup file instead of rotateFiles
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13106/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: misc: use utils.persist/unpersist instead of execcmd
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13107/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: conf: sampling: drop unused tunables
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13108/ : SUCCESS
http:
Ido Barkan has posted comments on this change.
Change subject: net: source route: don't attempt to configure invalid values
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/34393
To unsubscribe, visit http:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Remove configure sanlock from %post installation
..
Remove configure sanlock from %post installation
There is no need to run this verb during post as the user
Dan Kenigsberg has posted comments on this change.
Change subject: Functional test for Multiple Gateways source routing
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34339
To unsubscribe, visit http:/
Dan Kenigsberg has posted comments on this change.
Change subject: net: source route: don't attempt to configure invalid values
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34393
To unsubscribe, visi
Antoni Segura Puimedon has posted comments on this change.
Change subject: clean dhclient processes that are left after functional tests
..
Patch Set 3: Code-Review-1
Can you explain why you do a SIGKILL rather than a 'dhclient
Antoni Segura Puimedon has posted comments on this change.
Change subject: caps: Additional ppc64 hardware information
..
Patch Set 3: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/33857/3/vdsm/ppc64HardwareInfo.py
Fil
oVirt Jenkins CI Server has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 13:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13115/ : SUCCESS
http:
Ido Barkan has posted comments on this change.
Change subject: clean dhclient processes that are left after functional tests
..
Patch Set 3:
It's not clear on the documentation which pid file is referenced when issuing
the dhc
Antoni Segura Puimedon has posted comments on this change.
Change subject: clean dhclient processes that are left after functional tests
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34366
To unsubscr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtconnection: add credentials other then defalut
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13116/
Ido Barkan has restored this change.
Change subject: fixing according to review:
..
Restored
test
--
To view, visit http://gerrit.ovirt.org/33798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: res
Ido Barkan has abandoned this change.
Change subject: fixing according to review:
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/33798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Francesco Romani has posted comments on this change.
Change subject: virt: introduce caching the parsed domain XML
..
Patch Set 27: Verified+1
I tested all the four vm creation flows without noticing any issue.
Verified migrati
Francesco Romani has posted comments on this change.
Change subject: virt: introduce caching the parsed domain XML
..
Patch Set 27:
rebased because of local conflicts (cherry-pick didn't applied cleanly).
--
To view, visit ht
Francesco Romani has posted comments on this change.
Change subject: virt: make domain_descriptor.py API pep8-friendly
..
Patch Set 4:
fixed leftover
--
To view, visit http://gerrit.ovirt.org/33672
To unsubscribe, visit http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13117/ : SUCC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Functional test for Multiple Gateways source routing
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_network_functional_tests_gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Live Merge: Use VIR_DOMAIN_XML_BLOCK_INFO when getting volume
chain
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests
Dan Kenigsberg has posted comments on this change.
Change subject: Functional test for Multiple Gateways source routing
..
Patch Set 2: Verified+1
tried the new test on el7 (with NetworkManager stopped)
# NOSE_TESTMATCH=testSe
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: log.error(exc_info=True) -> log.exception()
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13055/ : S
Dan Kenigsberg has posted comments on this change.
Change subject: virt: introduce caching the parsed domain XML
..
Patch Set 27: Code-Review+2
Nir's comments and mine are answered. Thanks.
--
To view, visit http://gerrit.ovi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: introduce caching the parsed domain XML
..
virt: introduce caching the parsed domain XML
This patch replaces the repeatively parsed domain XML wi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Functional test for Multiple Gateways source routing
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_network_functional_tests_gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: migration: promote debug to info
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13056/ : SUCCESS
http://je
Dan Kenigsberg has posted comments on this change.
Change subject: virt: log.error(exc_info=True) -> log.exception()
..
Patch Set 1: Code-Review+2
I'm sure Federico would be pleased.
--
To view, visit http://gerrit.ovirt.org/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: promote some debug messages to info
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13057/ : SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove configure sanlock from %post installation
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13119/ : SU
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net: source route: don't attempt to configure invalid values
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_network_functional_te
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: promote some debug messages to warn
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13058/ : SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: downgrade logs about expected flows
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13059/ : SUCCESS
ht
Dan Kenigsberg has posted comments on this change.
Change subject: tool: avoid swallowing errors in seboolsetup calls.
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/33737/2/vdsm.spec.in
File vdsm.spec.in:
Line 752:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: introduce caching the parsed domain XML
..
Patch Set 28:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4114/ : SUCCES
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: log xml from/to libvirt at 'info' level
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13060/ : SUCCESS
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: Use ovirt node for persist files
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33468
To unsubscribe, visit http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: log xml from/to libvirt at 'info' level
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13064/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: downgrade logs about expected flows
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13065/ : SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: promote some debug messages to warn
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13066/ : SUCCESS
ht
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: Bridge.py reducing logging level
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34397
To unsubscribe, visit http://gerrit.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: promote some debug messages to info
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13067/ : SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: migration: promote debug to info
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13068/ : SUCCESS
http://je
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: pessimistic monitor response check
..
Patch Set 16:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13079/ : SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: log exceptional monitor unresponsive case
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13080/ : SUCCE
Francesco Romani has posted comments on this change.
Change subject: libvirtconnection: add credentials other then defalut
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/34293/7/lib/vdsm/libvirtconnection.py
File lib/
1 - 100 of 189 matches
Mail list logo
