Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47.

Yaniv Bronhaim has posted comments on this change. Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47. .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/33771/7/vdsm.spec.in File vdsm.spec.in: Lin

Change in vdsm[master]: tool: persist selinux booleans on ovirt node.

Yaniv Bronhaim has posted comments on this change. Change subject: tool: persist selinux booleans on ovirt node. .. Patch Set 2: Fabian, I don't understand your comment.. please elaborate. Mooli, we just need any node installa

Change in vdsm[master]: caps: Do not memoize CPU topology

Amador Pahim has posted comments on this change. Change subject: caps: Do not memoize CPU topology .. Patch Set 3: Code-Review-1 (5 comments) I don't like the idea of getting rid from libvirt. We changed to libvirt some time

Change in vdsm[ovirt-3.5]: Support ioTune values >2^31 in getStats over xml-rpc

Nir Soffer has posted comments on this change. Change subject: Support ioTune values >2^31 in getStats over xml-rpc .. Patch Set 4: Code-Review+1 But this is a backport to 3.5, and the rest of the code use the same thing. --

Change in vdsm[master]: fix broken TestConfigNetwork.testAddNetworkValidation

oVirt Jenkins CI Server has posted comments on this change. Change subject: fix broken TestConfigNetwork.testAddNetworkValidation .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13439/

Change in vdsm[master]: tool: bugfix function called as attribute.

oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: bugfix function called as attribute. .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/163/

Change in vdsm[master]: fix broken TestConfigNetwork.testAddNetworkValidation

Dan Kenigsberg has submitted this change and it was merged. Change subject: fix broken TestConfigNetwork.testAddNetworkValidation .. fix broken TestConfigNetwork.testAddNetworkValidation this was broken after http://gerrit.ovei

Change in vdsm[master]: fix broken TestConfigNetwork.testAddNetworkValidation

Dan Kenigsberg has posted comments on this change. Change subject: fix broken TestConfigNetwork.testAddNetworkValidation .. Patch Set 2: Verified+1 Code-Review+2 Fixing commit message and shedding doubtedly unrelated change to

Change in vdsm[master]: vdsm: add functionality to detach host devices

Dan Kenigsberg has posted comments on this change. Change subject: vdsm: add functionality to detach host devices .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32389 To unsubscribe, visit http://gerri

Change in vdsm[master]: vm: return displayIp as a string in default case

Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: return displayIp as a string in default case .. vm: return displayIp as a string in default case Previously, default value of displayInfo.displayIp

Change in vdsm[master]: vm: return displayIp as a string in default case

Dan Kenigsberg has posted comments on this change. Change subject: vm: return displayIp as a string in default case .. Patch Set 1: Code-Review+2 Let it be. -- To view, visit http://gerrit.ovirt.org/34675 To unsubscribe, visi

Change in vdsm[master]: libvirtconnection: add function to create a new connection

Dan Kenigsberg has posted comments on this change. Change subject: libvirtconnection: add function to create a new connection .. Patch Set 10: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/34293/10/tests/libvirtconnect

Change in vdsm[master]: libvirtconnection: add function to create a new connection

Dan Kenigsberg has submitted this change and it was merged. Change subject: libvirtconnection: add function to create a new connection .. libvirtconnection: add function to create a new connection Added a new function open_conn

Change in vdsm[master]: storageServer: remove dead code from getSessionInfo

oVirt Jenkins CI Server has posted comments on this change. Change subject: storageServer: remove dead code from getSessionInfo .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_mer

Change in vdsm[master]: vmdevices: vm.${NAME}_DEVICES -> vmdevices.${NAME}

Dan Kenigsberg has posted comments on this change. Change subject: vmdevices: vm.${NAME}_DEVICES -> vmdevices.${NAME} .. Patch Set 2: Code-Review-1 deepcopy hacks sneaked in. Please rebase manually. -- To view, visit http://g

Change in vdsm[master]: virt: move vm.GraphicsDevice -> vmdevices.Graphics

Dan Kenigsberg has posted comments on this change. Change subject: virt: move vm.GraphicsDevice -> vmdevices.Graphics .. Patch Set 2: Code-Review-1 deepcopy hacks sneaked in, please rebase manually. -- To view, visit http://g

Change in vdsm[master]: vmdevices: vm.${NAME}_DEVICES -> vmdevices.${NAME}

Dan Kenigsberg has posted comments on this change. Change subject: vmdevices: vm.${NAME}_DEVICES -> vmdevices.${NAME} .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34556 To unsubscribe, visit http://g

Change in vdsm[master]: guestagent: Simpler and safer disk mapping hash

Dan Kenigsberg has posted comments on this change. Change subject: guestagent: Simpler and safer disk mapping hash .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34625 To unsubscribe, visit http://gerr

Change in vdsm[master]: guestagent: Simpler and safer disk mapping hash

Dan Kenigsberg has submitted this change and it was merged. Change subject: guestagent: Simpler and safer disk mapping hash .. guestagent: Simpler and safer disk mapping hash Previously diskMapingHash was initialized to the mag

Change in vdsm[master]: guestagent: Use new style class

Dan Kenigsberg has submitted this change and it was merged. Change subject: guestagent: Use new style class .. guestagent: Use new style class Using old style class is a trap for innocent developers. They do not support propert

Change in vdsm[master]: guestagent: Use new style class

Dan Kenigsberg has posted comments on this change. Change subject: guestagent: Use new style class .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/34624/1//COMMIT_MSG Commit Message: Line 6: Line 7: gue

Change in vdsm[master]: domain_descriptor: More careful falsy check

Dan Kenigsberg has submitted this change and it was merged. Change subject: domain_descriptor: More careful falsy check .. domain_descriptor: More careful falsy check Using "if self._devices" works with xml.minidom, but if we s

Change in vdsm[master]: domain_descriptor: More careful falsy check

Dan Kenigsberg has posted comments on this change. Change subject: domain_descriptor: More careful falsy check .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34623 To unsubscribe, visit http://gerrit.o

Change in vdsm[master]: domain_descriptor: Eliminate magic hash init value

Dan Kenigsberg has submitted this change and it was merged. Change subject: domain_descriptor: Eliminate magic hash init value .. domain_descriptor: Eliminate magic hash init value We used to initialize devices hash to 0 when t

Change in vdsm[master]: domain_descriptor: Eliminate magic hash init value

Dan Kenigsberg has posted comments on this change. Change subject: domain_descriptor: Eliminate magic hash init value .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34622 To unsubscribe, visit http://g

Change in vdsm[master]: tool: bugfix function called as attribute.

Dan Kenigsberg has submitted this change and it was merged. Change subject: tool: bugfix function called as attribute. .. tool: bugfix function called as attribute. to fix bug, introduced in commit 8f87f21, instead of using sel

Change in vdsm[master]: tool: bugfix function called as attribute.

Dan Kenigsberg has posted comments on this change. Change subject: tool: bugfix function called as attribute. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34487 To unsubscribe, visit http://gerrit.ov

Change in vdsm[master]: storageServer: remove dead code from getSessionInfo

Dan Kenigsberg has submitted this change and it was merged. Change subject: storageServer: remove dead code from getSessionInfo .. storageServer: remove dead code from getSessionInfo storageServer -> getSessionInfo: cleanup of

Change in vdsm[master]: oop: vdsm.config is not used anymore

Dan Kenigsberg has abandoned this change. Change subject: oop: vdsm.config is not used anymore .. Abandoned So sorry - I've missed this fix, and taken http://gerrit.ovirt.org/34896 already. -- To view, visit http://gerrit.ov

Change in vdsm[master]: External hypervisor VMs integration

Nir Soffer has posted comments on this change. Change subject: External hypervisor VMs integration .. Patch Set 18: (2 comments) http://gerrit.ovirt.org/#/c/33309/18/vdsm/v2v.py File vdsm/v2v.py: Line 121: i['dev'

Change in vdsm[master]: vm: return full copy of the conf data on status()

oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: return full copy of the conf data on status() .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merge

Change in vdsm[master]: vm: return full copy of the conf data on status()

Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: return full copy of the conf data on status() .. vm: return full copy of the conf data on status() It is unsafe for status() to return a shallow co

Change in vdsm[master]: vm: return full copy of the conf data on status()

Dan Kenigsberg has posted comments on this change. Change subject: vm: return full copy of the conf data on status() .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34147 To unsubscribe, visit http://ge

Change in vdsm[master]: tests: make pyflakes happy with outOfProcess tests

oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: make pyflakes happy with outOfProcess tests .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merg

Change in vdsm[master]: spec: remove redundant check.

oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: remove redundant check. .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/159/ : FAILURE h

Change in vdsm[master]: vm: safe(r) Vm.conf update in creation thread

oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: safe(r) Vm.conf update in creation thread .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/15

Change in vdsm[master]: tool: persist selinux booleans on ovirt node.

Fabian Deutsch has posted comments on this change. Change subject: tool: persist selinux booleans on ovirt node. .. Patch Set 2: Code-Review-1 I believe this will not work. The selinux policy will be mounted in place way to la

Change in vdsm[ovirt-3.5]: Support ioTune values >2^31 in getStats over xml-rpc

Nir Soffer has posted comments on this change. Change subject: Support ioTune values >2^31 in getStats over xml-rpc .. Patch Set 4: Iotune values are integers - you can use str() -- To view, visit http://gerrit.ovirt.org/3023

Change in vdsm[master]: tool: persist selinux booleans on ovirt node.

Douglas Schilling Landgraf has posted comments on this change. Change subject: tool: persist selinux booleans on ovirt node. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34518 To unsubscribe, visit h

Change in vdsm[master]: tests: make pyflakes happy with outOfProcess tests

Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: make pyflakes happy with outOfProcess tests .. tests: make pyflakes happy with outOfProcess tests This patch fixes python -c 'import pyflakes;

Change in vdsm[master]: tests: make pyflakes happy with outOfProcess tests

Dan Kenigsberg has posted comments on this change. Change subject: tests: make pyflakes happy with outOfProcess tests .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34896 To unsubscribe, visit http://g

Change in vdsm[master]: spec: remove redundant check.

Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: remove redundant check. .. spec: remove redundant check. if not fedora 0%{?fedora} evaluates to 0. Change-Id: I50e1706e7f8c9b07b6788fbbabf61b403

Change in vdsm[ovirt-3.5]: vm: safe(r) Vm.conf update in creation thread

Hello Piotr Kliczewski, Nir Soffer, Dan Kenigsberg, Michal Skrivanek, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/34938 to review the following change. Change subject: vm: safe(r) Vm.conf update in creation thread .

Change in vdsm[master]: vm: safe(r) Vm.conf update in creation thread

Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: safe(r) Vm.conf update in creation thread .. vm: safe(r) Vm.conf update in creation thread A VM is created asynchronously for performance's sake. I

Change in vdsm[master]: vm: safe(r) Vm.conf update in creation thread

Dan Kenigsberg has posted comments on this change. Change subject: vm: safe(r) Vm.conf update in creation thread .. Patch Set 3: Code-Review+2 Accepting this temporary patch to a much deeper problem -- To view, visit http://g

Change in vdsm[master]: vm: safe(r) Vm.conf update in creation thread

Francesco Romani has posted comments on this change. Change subject: vm: safe(r) Vm.conf update in creation thread .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/34813/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 139

Change in vdsm[master]: vm: return full copy of the conf data on status()

Martin Polednik has posted comments on this change. Change subject: vm: return full copy of the conf data on status() .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34147 To unsubscribe, visit http://g

Change in vdsm[master]: vm: safe(r) Vm.conf update in creation thread

Martin Polednik has posted comments on this change. Change subject: vm: safe(r) Vm.conf update in creation thread .. Patch Set 3: Code-Review-1 (1 comment) The patch is fine, only suggesting/starting discussion whether we need

Change in vdsm[master]: netlink: replace old ipwrapper event monitor

oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: replace old ipwrapper event monitor .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13438/ : FAILUR

Change in vdsm[master]: netlink: replace old ipwrapper event monitor

Petr Horáček has uploaded a new change for review. Change subject: netlink: replace old ipwrapper event monitor .. netlink: replace old ipwrapper event monitor Change-Id: Ie7a9765e59a8392fff9b3fd556133159aeb60b1c Signed-off-by:

Change in vdsm[master]: netlink: ignore_enodev parameter in *_info

oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: ignore_enodev parameter in *_info .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13437/ : FAILURE

Change in vdsm[master]: netlink: ignore_enodev parameter in *_info

oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: ignore_enodev parameter in *_info .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13436/ : FAILURE

Change in vdsm[master]: netlink: event monitor

oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 26: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13435/ : FAILURE http://jenkins.ovi

Change in vdsm[master]: netlink: ignore_enodev parameter in *_info

oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: ignore_enodev parameter in *_info .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13434/ : FAILURE

Change in vdsm[master]: netlink: event monitor

oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 25: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13433/ : FA

Change in vdsm[master]: netlink: ignore_enodev parameter in *_info

Petr Horáček has posted comments on this change. Change subject: netlink: ignore_enodev parameter in *_info .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34925/1/lib/vdsm/netlink/link.py File lib/vdsm/netlink/link.py

Change in vdsm[master]: netlink: ignore_enodev parameter in *_info

oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: ignore_enodev parameter in *_info .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13432/ : FAILURE

Change in vdsm[master]: netlink: ignore_enodev parameter in *_info

Petr Horáček has uploaded a new change for review. Change subject: netlink: ignore_enodev parameter in *_info .. netlink: ignore_enodev parameter in *_info When we try to get information about the removed device without the cach

Change in vdsm[master]: sampling: extract SampleWindow class

Francesco Romani has posted comments on this change. Change subject: sampling: extract SampleWindow class .. Patch Set 6: Verified+1 Verified again (just in case) by installing fedora 20 on a VM runned by a patched VDSM and obs

Change in vdsm[master]: libnl: make link_cache optional for route_info

Petr Horáček has posted comments on this change. Change subject: libnl: make link_cache optional for route_info .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32950 To unsubscribe, visit http://gerrit.

Change in vdsm[master]: netlink: event monitor

oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 24: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13430/ : FA

Change in vdsm[master]: libnl: make link_cache optional for route_info

oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: make link_cache optional for route_info .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13431/ : FAIL

Change in vdsm[master]: libnl: make link_cache optional for route_info

oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: make link_cache optional for route_info .. Patch Set 8: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-te

Change in vdsm[master]: gluster: geo replication status and status detail

oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: geo replication status and status detail .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13429/ :

Change in vdsm[master]: libnl: non-existing link exception

oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: non-existing link exception .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13427/ : FAILURE http://

Change in vdsm[master]: libnl: make link cache optional for link_info and addr_info

Petr Horáček has posted comments on this change. Change subject: libnl: make link cache optional for link_info and addr_info .. Patch Set 7: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/32949/7/lib/vdsm/netlink/link.p

Change in vdsm[master]: sampling: rename generic window constant

Francesco Romani has abandoned this change. Change subject: sampling: rename generic window constant .. Abandoned no longer needed -- To view, visit http://gerrit.ovirt.org/31607 To unsubscribe, visit http://gerrit.ovirt.org/

Change in vdsm[master]: libnl: non-existing link exception

Petr Horáček has posted comments on this change. Change subject: libnl: non-existing link exception .. Patch Set 3: Code-Review-1 have to think more about it... -- To view, visit http://gerrit.ovirt.org/34690 To unsubscribe,

Change in vdsm[master]: libnl: non-existing link exception

oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: non-existing link exception .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13426/ : FAILURE http://

Change in vdsm[master]: caps: Do not use lscpu on ppc64

Francesco Romani has posted comments on this change. Change subject: caps: Do not use lscpu on ppc64 .. Patch Set 3: Thanks for the updating the commit message. There is no way to discover which kernel versions provide the corr

Change in vdsm[master]: caps: Do not memoize CPU topology

Francesco Romani has posted comments on this change. Change subject: caps: Do not memoize CPU topology .. Patch Set 3: Code-Review+1 really nice work with tests. -- To view, visit http://gerrit.ovirt.org/34189 To unsubscribe,