Nir Soffer has posted comments on this change. Change subject: External hypervisor VMs integration ......................................................................
Patch Set 18: (2 comments) http://gerrit.ovirt.org/#/c/33309/18/vdsm/v2v.py File vdsm/v2v.py: Line 121: i['dev'] = target.get('dev') Line 122: params['networks'].append(i) Line 123: Line 124: Line 125: class InvalidVMConfiguration(Exception): It is common to define error classes at the top, specially when this error may be raised from getExternalVMList. Line 122: params['networks'].append(i) Line 123: Line 124: Line 125: class InvalidVMConfiguration(Exception): Line 126: pass This (pass) works, but it is usually more useful as: class Name(Exception): """ Description of this exception """ -- To view, visit http://gerrit.ovirt.org/33309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
