Change in vdsm[master]: assertNetworkExists should also verify that bridges are actu...

2014-12-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: assertNetworkExists should also verify that bridges are actually created .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35872 To unsu

Change in vdsm[master]: vdsm: expose hostdev via vdsClient

2014-12-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: expose hostdev via vdsClient .. Patch Set 10: Code-Review+2 Raising Francesco score -- To view, visit http://gerrit.ovirt.org/32316 To unsubscribe, visi

Change in vdsm[master]: vdsm: expose hostdev via vdsClient

2014-12-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: expose hostdev via vdsClient .. vdsm: expose hostdev via vdsClient Exposes current API verb hostdevListByCaps by vdsClient, using pretty tree gra

Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator

2014-12-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Move multipath configuration to vdsm-tool configurator .. Patch Set 21: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/30909 To unsubscribe, visit htt

Change in vdsm[master]: tests: Add tests for registering instancemethod

2014-12-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Add tests for registering instancemethod .. tests: Add tests for registering instancemethod Event class cannot be used with instance methods, so

Change in vdsm[ovirt-3.5]: sosreport: remove Base class

2014-12-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: sosreport: remove Base class .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35879 To unsubscribe, visit http://gerrit.ovirt.org/settin

Change in vdsm[master]: tests: Add tests for registering instancemethod

2014-12-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Add tests for registering instancemethod .. Patch Set 1: Code-Review+2 raising -- To view, visit http://gerrit.ovirt.org/35438 To unsubscribe, visit ht

Change in vdsm[master]: hostdev: report totalvfs

2014-12-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: hostdev: report totalvfs .. Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/35891/1/vdsm/hostdev.py File vdsm/hostdev.py: Line 145: li

Change in vdsm[master]: hostdev: report totalvfs

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: report totalvfs .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13906/ : SUCCESS http://jenkins.ovirt.org

Change in vdsm[master]: hostdev: report totalvfs

2014-12-04 Thread mpolednik
Martin Polednik has uploaded a new change for review. Change subject: hostdev: report totalvfs .. hostdev: report totalvfs Totalvfs is a parameter defined by hardware that tells us how many virtual functions we can spawn (if ban

Change in vdsm[master]: networkTests: Reorganize parameters to dnsmasq and improve c...

2014-12-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: networkTests: Reorganize parameters to dnsmasq and improve comments .. networkTests: Reorganize parameters to dnsmasq and improve comments Change-Id:

Change in vdsm[master]: networkTests: Reorganize parameters to dnsmasq and improve c...

2014-12-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: networkTests: Reorganize parameters to dnsmasq and improve comments .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35862 To unsubscri

Change in vdsm[master]: networkTests: Introduce IPv6_ADDRESS_AND_CIDR

2014-12-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: networkTests: Introduce IPv6_ADDRESS_AND_CIDR .. networkTests: Introduce IPv6_ADDRESS_AND_CIDR Change-Id: I1f5c9cd76dfc350185eb17e6fbc79dcea243b393 Sig

Change in vdsm[master]: networkTests: Introduce IPv6_ADDRESS_AND_CIDR

2014-12-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: networkTests: Introduce IPv6_ADDRESS_AND_CIDR .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35863 To unsubscribe, visit http://gerrit

Change in vdsm[master]: storage: Fix VMPathNotExists text

2014-12-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: storage: Fix VMPathNotExists text .. storage: Fix VMPathNotExists text Change-Id: I6b374a818be18340e2b9fc5d91ba8e0d4f694f6f Bug-Url: https://bugzilla.r

Change in vdsm[master]: network: Make vdsmd delNetwork use supervdsmd setupNetworks

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: Make vdsmd delNetwork use supervdsmd setupNetworks .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13905/

Change in vdsm[master]: storage: Fix VMPathNotExists text

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Fix VMPathNotExists text .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13903/ : SUCCESS http://jenkins.

Change in vdsm[master]: vm: hyperv: support all the libvirt optimizations

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: hyperv: support all the libvirt optimizations .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_creat

Change in vdsm[master]: virt: graphdev: support headless VM

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support headless VM .. Patch Set 18: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13901/ : SUCCESS http://jenki

Change in vdsm[master]: spice: allow to disable the agent file transfer

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: spice: allow to disable the agent file transfer .. Patch Set 46: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_create

Change in vdsm[master]: vm: make new timekeeping revertable

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: make new timekeeping revertable .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13899/ : SUCCESS http://jenkin

Change in vdsm[master]: virt: make vmdevices a subpackage

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make vmdevices a subpackage .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/144/ : FAILU

Change in vdsm[master]: virt: move GraphicsDevice into devices subpackage

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move GraphicsDevice into devices subpackage .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13897/ : SUCCESS

Change in vdsm[master]: virt: move Drive class into vmdevices subpackage

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move Drive class into vmdevices subpackage .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13896/ : SUCCESS

Change in vdsm[master]: virt: move NetworkInterfaceDevice into vmdevices

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move NetworkInterfaceDevice into vmdevices .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13895/ : SUCCESS

Change in vdsm[master]: virt: make vmdevices a subpackage

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make vmdevices a subpackage .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/143/ : FAILU

Change in vdsm[master]: virt: move GraphicsDevice into devices subpackage

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move GraphicsDevice into devices subpackage .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13893/ : SUCCESS

Change in vdsm[master]: vmdevices: move devices type into hwclass module

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: move devices type into hwclass module .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_create

Change in vdsm[master]: storage: Fix VMPathNotExists text

2014-12-04 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: storage: Fix VMPathNotExists text .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35880 To unsubscribe, visit http://gerrit.ovirt.

Change in vdsm[master]: network: Make vdsmd delNetwork use supervdsmd setupNetworks

2014-12-04 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: network: Make vdsmd delNetwork use supervdsmd setupNetworks .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35310/1/vdsm/API.py File vdsm/API.py: Line 147

Change in vdsm[master]: network: Make vdsmd addNetwork use supervdsmd setupNetworks

2014-12-04 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: network: Make vdsmd addNetwork use supervdsmd setupNetworks .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/35090/2/vdsm/API.py File vdsm/API.py: Line 141

Change in vdsm[master]: virt: move Drive class into vmdevices subpackage

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move Drive class into vmdevices subpackage .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13891/ : SUCCESS

Change in vdsm[master]: storage: Fix VMPathNotExists text

2014-12-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: storage: Fix VMPathNotExists text .. Patch Set 1: Verified+1 text only -- To view, visit http://gerrit.ovirt.org/35880 To unsubscribe, visit http://gerrit.ovi

Change in vdsm[master]: storage: Fix VMPathNotExists text

2014-12-04 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: storage: Fix VMPathNotExists text .. storage: Fix VMPathNotExists text Change-Id: I6b374a818be18340e2b9fc5d91ba8e0d4f694f6f Bug-Url: https://bugzilla.redhat.co

Change in vdsm[master]: virt: move NetworkInterfaceDevice into vmdevices

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move NetworkInterfaceDevice into vmdevices .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13890/ : SUCCESS

Change in vdsm[ovirt-3.5]: sosreport: remove Base class

2014-12-04 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: sosreport: remove Base class .. Patch Set 1: Verified+1 Same as upstream. does not break the build. -- To view, visit http://gerrit.ovirt.org/35879 To unsubscri

Change in vdsm[ovirt-3.5]: sosreport: remove Base class

2014-12-04 Thread ykaplan
Hello Sandro Bonazzola, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/35879 to review the following change. Change subject: sosreport: remove Base class .. sosreport: remove Base c

Change in vdsm[master]: networkTests: Extend a test to also consider DHCPv6

2014-12-04 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: networkTests: Extend a test to also consider DHCPv6 .. Patch Set 37: sorry for this half clear explanation, it's all from my memory. this should be related to sour

Change in vdsm[master]: vm: split slow disk access from normalization

2014-12-04 Thread fromani
Francesco Romani has abandoned this change. Change subject: vm: split slow disk access from normalization .. Abandoned wrong approach, fixed otherwise. -- To view, visit http://gerrit.ovirt.org/34752 To unsubscribe, visit htt

Change in vdsm[master]: vm: hyperv: support all the libvirt optimizations

2014-12-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: hyperv: support all the libvirt optimizations .. Patch Set 5: Code-Review-1 rebased. We'll need RHEL >= 7.1. -- To view, visit http://gerrit.ovirt.org/2

Change in vdsm[master]: virt: graphdev: support headless VM

2014-12-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support headless VM .. Patch Set 18: rebased. -- To view, visit http://gerrit.ovirt.org/27846 To unsubscribe, visit http://gerrit.ovirt.org/

Change in vdsm[master]: spice: allow to disable the agent file transfer

2014-12-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: spice: allow to disable the agent file transfer .. Patch Set 46: rebased to keep it current. Unfortunately, looks like we need to wait until RHEL 7.1. -- T

Change in vdsm[master]: vm: make new timekeeping revertable

2014-12-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: make new timekeeping revertable .. Patch Set 6: Code-Review-1 (hopefully) last rebase before this precaution patch could be safely abandoned. -- To view

Change in vdsm[master]: vmdevices: move devices type into hwclass module

2014-12-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vmdevices: move devices type into hwclass module .. Patch Set 6: introduce here a new module to be used properly by patches later in the series. This new appr

Change in vdsm[master]: assertNetworkExists should also verify that bridges are actu...

2014-12-04 Thread ibarkan
Ido Barkan has uploaded a new change for review. Change subject: assertNetworkExists should also verify that bridges are actually created .. assertNetworkExists should also verify that bridges are actually created Currently we

Change in vdsm[master]: virt: move GraphicsDevice into devices subpackage

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move GraphicsDevice into devices subpackage .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13888/ : SUCCESS

Change in vdsm[master]: virt: make vmdevices a subpackage

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make vmdevices a subpackage .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13887/ : SUCCESS http://jenkins.

Change in vdsm[master]: vmdevices: vm.${NAME}_DEVICES -> vmdevices.${NAME}

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: vm.${NAME}_DEVICES -> vmdevices.${NAME} .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13886/ : SUCCESS

Change in vdsm[master]: virt: move Drive class into vmdevices subpackage

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move Drive class into vmdevices subpackage .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13885/ : SUCCESS

Change in vdsm[master]: hostdev: make caps in listByCaps truly optional

2014-12-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: make caps in listByCaps truly optional .. Patch Set 1: (1 comment) possible documentation improvement. Looks fine otherwise. http://gerrit.ovirt.or

Change in vdsm[master]: virt: move NetworkInterfaceDevice into vmdevices

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move NetworkInterfaceDevice into vmdevices .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13884/ : SUCCESS

Change in vdsm[master]: hostdev: make caps in listByCaps truly optional

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: make caps in listByCaps truly optional .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13883/ : SUCCESS h

Change in vdsm[master]: hostdev: make caps in listByCaps truly optional

2014-12-04 Thread mbetak
Martin Betak has posted comments on this change. Change subject: hostdev: make caps in listByCaps truly optional .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35867 To unsubscribe, visit http://gerrit

Change in vdsm[master]: hostdev: make caps in listByCaps truly optional

2014-12-04 Thread mpolednik
Martin Polednik has uploaded a new change for review. Change subject: hostdev: make caps in listByCaps truly optional .. hostdev: make caps in listByCaps truly optional In order to make the api cleaner, removes the need to speci

Change in vdsm[master]: networkTests: Extend a test to also consider DHCPv6

2014-12-04 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: Extend a test to also consider DHCPv6 .. Patch Set 37: I misread: the test were skipped on _EL7_ with NM running. With NM stopped, the test still

Change in vdsm[ovirt-3.5]: Restore the default value of rhev_build in the spec file

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Restore the default value of rhev_build in the spec file .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_

Change in vdsm[master]: networkTests: Extend a test to also consider DHCPv6

2014-12-04 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: Extend a test to also consider DHCPv6 .. Patch Set 37: Verified-1 All instances of the test are skipped on EL6. SKIP : Failed to set device ip -

Change in vdsm[ovirt-3.5]: Add the missing --enable-rhev definition to configure.ac

2014-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add the missing --enable-rhev definition to configure.ac .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_m

Change in vdsm[master]: networkTests: Introduce IPv6_ADDRESS_AND_CIDR

2014-12-04 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: Introduce IPv6_ADDRESS_AND_CIDR .. Patch Set 1: Verified+1 As a patch of the dhcpv6-tests topic this patch works well. -- To view, visit http://

Change in vdsm[master]: networkTests: Extend a test to also consider DHCPv6

2014-12-04 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: Extend a test to also consider DHCPv6 .. Patch Set 37: Verified+1 (1 comment) The test runs and passes on my F20 VM. http://gerrit.ovirt.org/#/c

Change in vdsm[ovirt-3.5]: Add the missing --enable-rhev definition to configure.ac

2014-12-04 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Add the missing --enable-rhev definition to configure.ac .. Add the missing --enable-rhev definition to configure.ac This fixes an error reported by au

Change in vdsm[ovirt-3.5]: Restore the default value of rhev_build in the spec file

2014-12-04 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Restore the default value of rhev_build in the spec file .. Restore the default value of rhev_build in the spec file Change-Id: I8deca956e80bcacad1e644

Change in vdsm[ovirt-3.5]: Add the missing --enable-rhev definition to configure.ac

2014-12-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Add the missing --enable-rhev definition to configure.ac .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35860 To unsubscribe, visit ht

Change in vdsm[master]: fixed TestConfigNetwork.testAddNetworkValidation

2014-12-04 Thread ibarkan
Ido Barkan has abandoned this change. Change subject: fixed TestConfigNetwork.testAddNetworkValidation .. Abandoned I still do not understand why this is happening but removing vdsm from the system completely before building i

Change in vdsm[ovirt-3.5]: Add the missing --enable-rhev definition to configure.ac

2014-12-04 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Add the missing --enable-rhev definition to configure.ac .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/35860 To unsubscribe, visit http://

Change in vdsm[master]: networkTests: Introduce IPv6_ADDRESS_AND_CIDR

2014-12-04 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: networkTests: Introduce IPv6_ADDRESS_AND_CIDR .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35863 To unsubscribe, visit http://gerrit.ovi

Change in vdsm[master]: networkTests: Reorganize parameters to dnsmasq and improve c...

2014-12-04 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: Reorganize parameters to dnsmasq and improve comments .. Patch Set 1: Verified+1 The patch behaves well. I ran it together with the rest of the d

Change in vdsm[master]: fixed TestConfigNetwork.testAddNetworkValidation

2014-12-04 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: fixed TestConfigNetwork.testAddNetworkValidation .. Patch Set 1: Dan, do you remember an almost _identical_ patch of mine? I had the same problem in the past.

Change in vdsm[ovirt-3.5]: Restore the default value of rhev_build in the spec file

2014-12-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Restore the default value of rhev_build in the spec file .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.ovirt.org/35859 To unsubscrib

Change in vdsm[master]: networkTests: Fix operator precedence so a parameter to dnsm...

2014-12-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: networkTests: Fix operator precedence so a parameter to dnsmasq is not empty .. networkTests: Fix operator precedence so a parameter to dnsmasq is not

Change in vdsm[master]: networkTests: Fix operator precedence so a parameter to dnsm...

2014-12-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: networkTests: Fix operator precedence so a parameter to dnsmasq is not empty .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35861 To

Change in vdsm[master]: net_func_tests: add calling method name to setupNetworks

2014-12-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net_func_tests: add calling method name to setupNetworks .. net_func_tests: add calling method name to setupNetworks It is usually difficult to know wh

Change in vdsm[master]: net_func_tests: add calling method name to setupNetworks

2014-12-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net_func_tests: add calling method name to setupNetworks .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35711 To unsubscribe, visit ht