Change in vdsm[master]: ipwrapperTests: prevent infinite stuck of iterator

2014-12-12 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: ipwrapperTests: prevent infinite stuck of iterator .. ipwrapperTests: prevent infinite stuck of iterator Sometimes, ipwrapper monitor.start() is not fast enough

Change in vdsm[master]: schema: verification of API.py and schema during UT

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: verification of API.py and schema during UT .. Patch Set 9: Build Failed

Change in vdsm[master]: jsonrpc: LVMVolumeGroup_create

2014-12-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: LVMVolumeGroup_create .. Patch Set 8: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/35534/8/vdsm/rpc/vdsmapi-schema.json File

Change in vdsm[master]: jsonrpc: VM_updateVmPolicy

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: VM_updateVmPolicy .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13403/ : FAILURE

Change in vdsm[master]: jsonrpc: Image_upload

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Image_upload .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13404/ : FAILURE

Change in vdsm[master]: jsonrpc: LVMVolumeGroup_create

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: LVMVolumeGroup_create .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13405/ : FAILURE

Change in vdsm[master]: ipwrapperTests: prevent infinite stuck of iterator

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapperTests: prevent infinite stuck of iterator .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13406/

Change in vdsm[master]: ipwrapperTests: prevent infinite stuck of iterator

2014-12-12 Thread dcaroest
David Caro has posted comments on this change. Change subject: ipwrapperTests: prevent infinite stuck of iterator .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/36121 To unsubscribe, visit

Change in vdsm[master]: hostdev: report totalvfs

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: report totalvfs .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13407/ : FAILURE

Change in vdsm[master]: hostdev: report physfn

2014-12-12 Thread mpolednik
Martin Polednik has uploaded a new change for review. Change subject: hostdev: report physfn .. hostdev: report physfn Each sr-iov virtual function is actually a separate function on a pci bus. Libvirt reports these functions

Change in vdsm[master]: hostdev: report physfn

2014-12-12 Thread mpolednik
Martin Polednik has abandoned this change. Change subject: hostdev: report physfn .. Abandoned wrong Change-Id... -- To view, visit http://gerrit.ovirt.org/36123 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: hostdev: report physfn

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: report physfn .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13408/ : FAILURE

Change in vdsm[master]: hostdev: report physfn

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: report physfn .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13409/ : FAILURE

Change in vdsm[master]: ipwrapperTests: prevent infinite stuck of iterator

2014-12-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ipwrapperTests: prevent infinite stuck of iterator .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/36121/1/tests/ipwrapperTests.py File

Change in vdsm[master]: hostdev: report totalvfs

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: report totalvfs .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13410/ : FAILURE

Change in vdsm[master]: hostdev: report physfn

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: report physfn .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13411/ : FAILURE

Change in vdsm[master]: hostdev: report physfn

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: report physfn .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13412/ : FAILURE

Change in vdsm[master]: hostdev: report totalvfs

2014-12-12 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: hostdev: report totalvfs .. Patch Set 7: Verified+1 Manual testing (checking hostdevListByCaps on SR-IOV enabled hosts), simple unit test -- To view, visit

Change in vdsm[master]: hostdev: report physfn

2014-12-12 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: hostdev: report physfn .. Patch Set 5: Verified+1 Manual testing (checking hostdevListByCaps on SR-IOV enabled hosts), ran added tests -- To view, visit

Change in vdsm[master]: hostdev: report physfn

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: report physfn .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13413/ : FAILURE

Change in vdsm[master]: net tests: fix api.addNetwork call

2014-12-12 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: net tests: fix api.addNetwork call .. net tests: fix api.addNetwork call commit 7b39590d4 forgot to rename the function in this test. Change-Id:

Change in vdsm[master]: net tests: fix api.addNetwork call

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: net tests: fix api.addNetwork call .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13414/ : FAILURE

Change in vdsm[master]: net tests: fix api.addNetwork call

2014-12-12 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net tests: fix api.addNetwork call .. Patch Set 1: Verified+1 Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36125 To unsubscribe, visit

Change in vdsm[master]: net tests: fix api.addNetwork call

2014-12-12 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net tests: fix api.addNetwork call .. net tests: fix api.addNetwork call commit 7b39590d4 forgot to rename the function in this test. Change-Id:

Change in vdsm[master]: net tests: fix api.addNetwork call

2014-12-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net tests: fix api.addNetwork call .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/36125 To unsubscribe, visit

Change in vdsm[master]: net tests: check why brctl fails

2014-12-12 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: net tests: check why brctl fails .. net tests: check why brctl fails Change-Id: If952a347f592aa80d7e6465a398f0238db197d6a Signed-off-by: Dan Kenigsberg

Change in vdsm[master]: schema: verify line length to be shorter than 80

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: verify line length to be shorter than 80 .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13415/ :

Change in vdsm[master]: net tests: check why brctl fails

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: net tests: check why brctl fails .. Patch Set 1: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: net tests: fix api.addNetwork call

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: net tests: fix api.addNetwork call .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/370/ :

Change in vdsm[master]: storageServer: Improve iscsi connection logging

2014-12-12 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: storageServer: Improve iscsi connection logging .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36028/1/vdsm/storage/storageServer.py File

Change in vdsm[master]: rpc: Replace misuse of assert with TypeError

2014-12-12 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: rpc: Replace misuse of assert with TypeError .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29307 To unsubscribe, visit

Change in vdsm[master]: netlink: ignore_enodev parameter in *_info

2014-12-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netlink: ignore_enodev parameter in *_info .. Patch Set 17: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/34925/17/lib/vdsm/netlink/addr.py File

Change in vdsm[master]: net tests: check why brctl fails

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: net tests: check why brctl fails .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13417/ : FAILURE

Change in vdsm[master]: netlink: event monitor

2014-12-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 38: Code-Review-1 (7 comments) http://gerrit.ovirt.org/#/c/32626/38/lib/vdsm/netlink/__init__.py File

Change in vdsm[master]: vm: abort vm start if can't read pid

2014-12-12 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vm: abort vm start if can't read pid .. vm: abort vm start if can't read pid If for whatever (quite unlikely) cause the PID can't be read, or it is invalid,

Change in vdsm[master]: iscsiadm.iface_list() to return iface.net_ifacename

2014-12-12 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: iscsiadm.iface_list() to return iface.net_ifacename .. Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/35807/3/tests/iscsiTests.py File

Change in vdsm[master]: ipwrapperTests: prevent infinite stuck of iterator

2014-12-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ipwrapperTests: prevent infinite stuck of iterator .. Patch Set 2: Verified+1 Code-Review+2 Copying V+1 flag, as comment has changed. -- To view, visit

Change in vdsm[master]: tcTests: bridge deleted before downed

2014-12-12 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: tcTests: bridge deleted before downed .. tcTests: bridge deleted before downed Change-Id: I485932d45cce01eef7be2cceb19f66d9aa3a03b5 Signed-off-by: Petr Horáček

Change in vdsm[master]: ipwrapperTests: prevent infinite stuck of iterator

2014-12-12 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: ipwrapperTests: prevent infinite stuck of iterator .. ipwrapperTests: prevent infinite stuck of iterator Sometimes, ipwrapper monitor.start() is not

Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4349 - Still Failing!

2014-12-12 Thread Dan Kenigsberg
On Thu, Dec 11, 2014 at 08:10:14PM +0100, David Caro wrote: On 12/11, Petr Horacek wrote: - Original Message - From: David Caro dc...@redhat.com To: Dan Kenigsberg dan...@redhat.com Cc: phora...@redhat.com, Jenkins ci oVirt Server jenk...@ovirt.org, ee...@redhat.com,

Change in vdsm[master]: ipwrapperTests: prevent infinite stuck of iterator

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapperTests: prevent infinite stuck of iterator .. Patch Set 3: Build Failed

Change in vdsm[master]: hba: Run fc-scan in supervdsm

2014-12-12 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: hba: Run fc-scan in supervdsm .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35587 To unsubscribe, visit

Change in vdsm[master]: tcTests: bridge deleted before downed

2014-12-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tcTests: bridge deleted before downed .. Patch Set 1: Code-Review+2 yuck. -- To view, visit http://gerrit.ovirt.org/36130 To unsubscribe, visit

Change in vdsm[master]: hba: Run fc-scan in supervdsm

2014-12-12 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hba: Run fc-scan in supervdsm .. hba: Run fc-scan in supervdsm On master zombiereaper is available in supervdsm, so we can run fc-scan from suprevdsm

Change in vdsm[master]: jsonrpc: LVMVolumeGroup_create

2014-12-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: LVMVolumeGroup_create .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35534 To unsubscribe, visit

Change in vdsm[master]: jsonrpc: LVMVolumeGroup_create

2014-12-12 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: LVMVolumeGroup_create .. jsonrpc: LVMVolumeGroup_create Align naming between API.py and schema. Change-Id:

Change in vdsm[master]: Simplify testAddVlanedBridgeless

2014-12-12 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: Simplify testAddVlanedBridgeless .. Patch Set 1: Code-Review+1 Looks better! -- To view, visit http://gerrit.ovirt.org/36003 To unsubscribe, visit

Change in vdsm[master]: hba: Run fc-scan in supervdsm

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hba: Run fc-scan in supervdsm .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/372/ : SUCCESS

Change in vdsm[master]: jsonrpc: VM_updateVmPolicy

2014-12-12 Thread alitke
Adam Litke has posted comments on this change. Change subject: jsonrpc: VM_updateVmPolicy .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35556 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: jsonrpc: LVMVolumeGroup_create

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: LVMVolumeGroup_create .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/373/ : SUCCESS

Change in vdsm[master]: tcTests: bridge deleted before downed

2014-12-12 Thread dcaroest
David Caro has posted comments on this change. Change subject: tcTests: bridge deleted before downed .. Patch Set 1: That test passes now, but there are other three that fail, I think it might just be a messed cleanup (they

Change in vdsm[master]: ipwrapperTests: prevent infinite stuck of iterator

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapperTests: prevent infinite stuck of iterator .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13419/

Change in vdsm[master]: vm: abort vm start if can't read pid

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: abort vm start if can't read pid .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13418/ : FAILURE

Change in vdsm[master]: tcTests: bridge deleted before downed

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tcTests: bridge deleted before downed .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13420/ : FAILURE

Change in vdsm[master]: schema: verify line length to be shorter than 80

2014-12-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: schema: verify line length to be shorter than 80 .. Patch Set 1: Code-Review-1 (1 comment) Although I like the idea and I'm happy to see this change, I

Change in vdsm[master]: hostdev: report physfn

2014-12-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: report physfn .. Patch Set 5: (1 comment) Nice improvements http://gerrit.ovirt.org/#/c/35974/5/vdsm/hostdev.py File vdsm/hostdev.py: Line 37:

Change in vdsm[master]: jsonrpc: VM_updateVmPolicy

2014-12-12 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: VM_updateVmPolicy .. jsonrpc: VM_updateVmPolicy Align naming between API.py and schema. Change-Id: I39c3e0a675b0574c25a2602f672ed6a36a05547c

Change in vdsm[master]: hostdev: report totalvfs

2014-12-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: report totalvfs .. Patch Set 7: Code-Review+1 comments from Dan addressed in rev 6 and 7, looks good to me. -- To view, visit

Change in vdsm[master]: teach delNetworks to remove a network entity under a bridge

2014-12-12 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: teach delNetworks to remove a network entity under a bridge .. Patch Set 7: Code-Review-1 (1 comment) Remarks to formatting in logging functions (it follows

Change in vdsm[master]: jsonrpc: VM_updateVmPolicy

2014-12-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: VM_updateVmPolicy .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/374/ : SUCCESS

Change in vdsm[master]: jsonrpc: Image_upload

2014-12-12 Thread alitke
Adam Litke has posted comments on this change. Change subject: jsonrpc: Image_upload .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35533 To unsubscribe, visit http://gerrit.ovirt.org/settings