Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Optimize guest agent string filtering
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/36630/6/vdsm/virt/guestagent.py
File
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Check the full range of replaceble chars in filtering
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36952/1/vdsm/virt/guestagent.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Added geo-replication status and status detail
..
Patch Set 15:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: virt: Optimize guest agent string filtering
..
Patch Set 6: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/36630/6/vdsm/virt/guestagent.py
File
Petr Horáček has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 22:
(2 comments)
http://gerrit.ovirt.org/#/c/36197/22/tests/netlinkTests.py
File tests/netlinkTests.py:
Line 27:
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: fix el6 'format' issue
..
hostdev: fix el6 'format' issue
Since we're using python 2.6 in RHEL6 deployments, the formatting
string in python is
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hostdev: fix el6 'format' issue
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15086/ : SUCCESS
Martin Polednik has posted comments on this change.
Change subject: hostdev: fix el6 'format' issue
..
Patch Set 1: Verified+1
testParseSRIOV_PFDeviceParams OK
testParseSRIOV_VFDeviceParams
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hostdev: add dynamic udev rule creation for iommu groups
..
Patch Set 3:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: hostdev: fix el6 'format' issue
..
Patch Set 1:
Toni, probably it was (is) never fully enforced.
--
To view, visit http://gerrit.ovirt.org/36977
To
Francesco Romani has posted comments on this change.
Change subject: hostdev: fix el6 'format' issue
..
Patch Set 1: Code-Review+1
btw, patch looks fine :)
--
To view, visit http://gerrit.ovirt.org/36977
To unsubscribe,
Martin Polednik has posted comments on this change.
Change subject: hostdev: fix el6 'format' issue
..
Patch Set 1:
hopefully, sneaking in formats one by one might result in their allowance :)
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Retry sync on recoverable errors
..
Patch Set 1: Code-Review+1
looks OK.
Vaguely related to this patch: I believe that it is time to separate VM
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Update drive.format after active layer merge
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/36923/1/vdsm/virt/vm.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: cleaner retrieval of graphics stats
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6312/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: cleaner getVMList implementation
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6313/ :
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: fix el6 'format' issue
..
hostdev: fix el6 'format' issue
Since we're using python 2.6 in RHEL6 deployments, the formatting
string in python
Dan Kenigsberg has posted comments on this change.
Change subject: hostdev: fix el6 'format' issue
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/36977
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Restore watermark tracking
..
Patch Set 1: Code-Review-1
(4 comments)
A few initial remarks. Most important: we need some form of dependency
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 23: Code-Review-1
(4 comments)
http://gerrit.ovirt.org/#/c/36197/23/lib/vdsm/netlink/monitor.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 23: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hostdev: fix el6 'format' issue
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6314/ :
SUCCESS
Nir Soffer has uploaded a new change for review.
Change subject: tests: Move assertXMLEqual to testlib [3/4]
..
tests: Move assertXMLEqual to testlib [3/4]
This patch separates extracting xml fragments from asserting. The path
Nir Soffer has uploaded a new change for review.
Change subject: tests: Move assertXMLEqual to testlib [2/4]
..
tests: Move assertXMLEqual to testlib [2/4]
This patch changes the the element argument to xml string, so the
Nir Soffer has uploaded a new change for review.
Change subject: test: Move assertXMLEqual to testlib [1/4]
..
test: Move assertXMLEqual to testlib [1/4]
assertXMLEqual should be part of testlib, so we can use it in other
tests
Nir Soffer has uploaded a new change for review.
Change subject: tests: Move assertXMLEqual to testlib [4/4]
..
tests: Move assertXMLEqual to testlib [4/4]
This patch introduces testlib.XMLTestCase and move assertXMLEqual up to
Nir Soffer has posted comments on this change.
Change subject: test: Move assertXMLEqual to testlib [1/4]
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36981
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Move assertXMLEqual to testlib [2/4]
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36982
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Make it easy to debug assertXMLEqual failures
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/36930
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Move assertXMLEqual to testlib [3/4]
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36983
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Move assertXMLEqual to testlib [4/4]
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36984
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: test: Move assertXMLEqual to testlib [1/4]
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15090/ : FAILURE
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: add glusterStorageDevicesList verb
..
Patch Set 15: Code-Review+2
Raising Bala's score
--
To view, visit http://gerrit.ovirt.org/35028
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 24:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/306/ :
SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: add glusterStorageDevicesList verb
..
gluster: add glusterStorageDevicesList verb
This patch adds new verb glusterStorageDevicesList
which
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Move assertXMLEqual to testlib [2/4]
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15091/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Move assertXMLEqual to testlib [3/4]
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15092/ :
Francesco Romani has posted comments on this change.
Change subject: test: Move assertXMLEqual to testlib [1/4]
..
Patch Set 1: Code-Review+1
Yep, seems unused. Good riddance to this method.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Move assertXMLEqual to testlib [4/4]
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15093/ :
Dan Kenigsberg has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Delete a lease file left over by
dhclient
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/36974
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: testSetupNetworksAddDelDhcp: Delete a lease file left over by
dhclient
..
testSetupNetworksAddDelDhcp: Delete a lease file left over by dhclient
The
Francesco Romani has posted comments on this change.
Change subject: tests: Move assertXMLEqual to testlib [2/4]
..
Patch Set 1:
(1 comment)
Nice cleanup (here and in the series). I think we can improve a little more.
Francesco Romani has posted comments on this change.
Change subject: tests: Move assertXMLEqual to testlib [3/4]
..
Patch Set 1: Code-Review+1
seems nicer this way.
--
To view, visit http://gerrit.ovirt.org/36983
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: add glusterStorageDevicesList verb
..
Patch Set 16:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6315/ :
Nir Soffer has posted comments on this change.
Change subject: tests: Move assertXMLEqual to testlib [2/4]
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36982/1/tests/vmTests.py
File tests/vmTests.py:
Line 175:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Delete a lease file left over by
dhclient
..
Patch Set 8:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: volume snapshot info and status verbs.
..
Patch Set 5:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 25:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/308/ :
SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 26:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/309/ :
SUCCESS
Petr Horáček has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 27: Verified+1
Built OK, netlinkTests.py passed hundreds of times.
--
To view, visit http://gerrit.ovirt.org/36197
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 27:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/310/ :
SUCCESS
Dan Kenigsberg has uploaded a new change for review.
Change subject: store-net-config: persist ifcfg mgmt on node
..
store-net-config: persist ifcfg mgmt on node
With unified network persistence, we would like to persist only
oVirt Jenkins CI Server has posted comments on this change.
Change subject: store-net-config: persist ifcfg mgmt on node
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15098/ :
Amador Pahim has posted comments on this change.
Change subject: Simplify tests for qemuimg to allow additional capabilities
checks
..
Patch Set 5:
(3 comments)
http://gerrit.ovirt.org/#/c/36366/5/tests/qemuimgTests.py
File
Federico Simoncelli has posted comments on this change.
Change subject: utils: move nice ionice sid and sudo out of execCmd
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/33691/4//COMMIT_MSG
Commit Message:
Line 6:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Simplify tests for qemuimg to allow additional capabilities
checks
..
Patch Set 6:
Build Failed
Amador Pahim has posted comments on this change.
Change subject: qemu-img convert: check/use -T src_cache option when available
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/36308/8/lib/vdsm/qemuimg.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: qemu-img: check/use -T src_cache option in convert/rebase
when available
..
Patch Set 9:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 27: Code-Review-1
(1 comment)
nit
http://gerrit.ovirt.org/#/c/36197/27/tests/netlinkTests.py
File tests/netlinkTests.py:
Nir Soffer has posted comments on this change.
Change subject: fileUtils: Improve logging when creating directories
..
Patch Set 3:
rebase, no code change.
--
To view, visit http://gerrit.ovirt.org/36780
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for filesUtils.createdir
..
Patch Set 3:
rebase, no code change.
--
To view, visit http://gerrit.ovirt.org/36778
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: fileUtils: Fix bug when mode is not specified
..
Patch Set 3:
rebase, no code change.
--
To view, visit http://gerrit.ovirt.org/36781
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileUtils: Improve logging when creating directories
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15102/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Add tests for filesUtils.createdir
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15103/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileUtils: Fix bug when mode is not specified
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15101/ :
Francesco Romani has posted comments on this change.
Change subject: virt: move GraphicsDevice into devices subpackage
..
Patch Set 14: Verified+1
rebased
Verified again by running a VM using both spice and VNC.
--
To view,
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Check the full range of replaceble chars in filtering
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/36952
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Optimize guest agent string filtering
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/36630
To unsubscribe, visit
Federico Simoncelli has uploaded a new change for review.
Change subject: gluster: fix volume name parsing in getVmVolumeInfo
..
gluster: fix volume name parsing in getVmVolumeInfo
It is permitted to use slashes '/' in gluster
Federico Simoncelli has uploaded a new change for review.
Change subject: virt: enable libgfapi with snapshot support
..
virt: enable libgfapi with snapshot support
Change-Id: Ie0965bef605ba67297670c0bf7924f88fa3b0460
Fabian Deutsch has posted comments on this change.
Change subject: store-net-config: persist ifcfg mgmt on node
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/36985/1/vdsm/vdsm-store-net-config.in
File
Francesco Romani has posted comments on this change.
Change subject: virt: move GraphicsDevice into devices subpackage
..
Patch Set 15: Verified+1
version 15 just fixes the ordering of the imports in API.py
re-verified quickly
On Fri, Jan 16, 2015 at 11:57:28AM +, Jenkins ci oVirt Server wrote:
Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/
Build: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4481/
Build Number: 4481
Build Status: Still Failing
Triggered By: Triggered by
Francesco Romani has posted comments on this change.
Change subject: tests: Move assertXMLEqual to testlib [2/4]
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/36982/1/tests/vmTests.py
File
Francesco Romani has posted comments on this change.
Change subject: tests: Move assertXMLEqual to testlib [4/4]
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36984
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: virt: move GraphicsDevice into devices subpackage
..
Patch Set 15: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34557
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: move GraphicsDevice into devices subpackage
..
virt: move GraphicsDevice into devices subpackage
Move the Graphics class and its related
Dan Kenigsberg has posted comments on this change.
Change subject: test: Move assertXMLEqual to testlib [1/4]
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/36981
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: test: Move assertXMLEqual to testlib [1/4]
..
test: Move assertXMLEqual to testlib [1/4]
assertXMLEqual should be part of testlib, so we can use it in
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Move assertXMLEqual to testlib [2/4]
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/36982
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Optimize guest agent string filtering
..
Patch Set 7: Code-Review+1
nice
--
To view, visit http://gerrit.ovirt.org/36630
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Check the full range of replaceble chars in filtering
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36952
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Optimize guest agent string filtering
..
Patch Set 7: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Check the full range of replaceble chars in filtering
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Only filter guest agent data, only on XMLRPC
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15108/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Check the full range of replaceble chars in filtering
..
Patch Set 3: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Only filter guest agent data, only on XMLRPC
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15110/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move GraphicsDevice into devices subpackage
..
Patch Set 16:
Build Failed
Nir Soffer has uploaded a new change for review.
Change subject: fileUtils: Remove bogus warning from log [2/2]
..
fileUtils: Remove bogus warning from log [2/2]
To ensure we will check the callers of fileUtils.createdir() it
Nir Soffer has posted comments on this change.
Change subject: fileUtils: Remove bogus warning from log [1/2]
..
Patch Set 5: Verified+1
This version is rebased on the createdir-cleanup branch and improves the commit
message.
Nir Soffer has posted comments on this change.
Change subject: fileUtils: Remove bogus warning from log [2/2]
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37003
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileUtils: Remove bogus warning from log [1/2]
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15113/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileUtils: Remove bogus warning from log [2/2]
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15114/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: test: Move assertXMLEqual to testlib [1/4]
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6318/ :
Nir Soffer has posted comments on this change.
Change subject: virt: Check the full range of replaceble chars in filtering
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/36952/3/vdsm/virt/guestagent.py
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: store-net-config: persist ifcfg mgmt on node
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36985/1//COMMIT_MSG
Commit Message:
Line 14:
Nir Soffer has posted comments on this change.
Change subject: virt: Check the full range of replaceble chars in filtering
..
Patch Set 3:
My comments belong to the previous patch
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: virt: Optimize guest agent string filtering
..
Patch Set 7:
(2 comments)
Nice
http://gerrit.ovirt.org/#/c/36630/7/vdsm/virt/guestagent.py
File
Nir Soffer has posted comments on this change.
Change subject: tests: -T src_cache option in qemu-img convert command
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/36374/2/tests/qemuimgTests.py
File
Nir Soffer has posted comments on this change.
Change subject: utils: move nice ionice sid and sudo out of execCmd
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/33691/4//COMMIT_MSG
Commit Message:
Line 6:
Line 7:
1 - 100 of 137 matches
Mail list logo
