Francesco Romani has posted comments on this change.
Change subject: tests: Move virt storage tests to new module
..
Patch Set 1: Code-Review+1
good patch. We should really started earlier to modularize the vmTests.py
behemoth
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf_persistence: teach PersistentConfig to atomically store
itself
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-te
Ido Barkan has posted comments on this change.
Change subject: netconf_persistence: teach PersistentConfig to atomically store
itself
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/35709
To unsubscribe,
Ido Barkan has posted comments on this change.
Change subject: netconf_persistence: teach PersistentConfig to atomically store
itself
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/35709/2/lib/vdsm/netc
oVirt Jenkins CI Server has posted comments on this change.
Change subject: reorder methods of netconfpersistence module
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15606/ : SUCCES
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf_persistence: teach PersistentConfig to atomically store
itself
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-te
Ido Barkan has posted comments on this change.
Change subject: netconf_persistence: teach PersistentConfig to atomically store
itself
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/35709
To unsubscribe,
Ido Barkan has posted comments on this change.
Change subject: reorder methods of netconfpersistence module
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37534
To unsubscribe, visit http://gerrit.ovirt.o
Ido Barkan has uploaded a new change for review.
Change subject: reorder methods of netconfpersistence module
..
reorder methods of netconfpersistence module
Trying to improve readability by placing public methods first
Change-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: volume snapshot list verb.
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/412/ :
SU
Ido Barkan has posted comments on this change.
Change subject: Require newer dhclient on el7
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37103
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ido Barkan has posted comments on this change.
Change subject: Better logging for network restoration.
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37506
To unsubscribe, visit http://gerrit.ovirt.org/se
Ido Barkan has posted comments on this change.
Change subject: tests: Remove unused import
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37531
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Bala.FA has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 14: Code-Review-1
(3 comments)
Also address comments in patch set #12
http://gerrit.ovirt.org/#/c/35498/14/vdsm/gluster/fs
Bala.FA has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 12:
(7 comments)
http://gerrit.ovirt.org/#/c/35498/12/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 20:
Nir Soffer has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 1:
Please check and address my comments here:
http://gerrit.ovirt.org/#/c/34294/37/vdsm/v2v.py,cm
Nir Soffer has posted comments on this change.
Change subject: vm: Fix extend size calculation
..
Patch Set 2:
(1 comment)
This should come before the LSM patch.
http://gerrit.ovirt.org/#/c/37274/2/vdsm/virt/vmdevices/storage
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Move virt storage tests to new module
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15602/ : SUCCES
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Remove unused import
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15603/ : SUCCESS
http://jenkins
Nir Soffer has posted comments on this change.
Change subject: tests: Remove unused import
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Nir Soffer has posted comments on this change.
Change subject: tests: Move virt storage tests to new module
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37532
To unsubscribe, visit http://gerrit.ovirt.o
Nir Soffer has uploaded a new change for review.
Change subject: tests: Remove unused import
..
tests: Remove unused import
Recent commit left unused import, breaking the build.
Change-Id: Id4180e4d8fefd57130fe7a3af320d98c2aab7
Nir Soffer has uploaded a new change for review.
Change subject: tests: Move virt storage tests to new module
..
tests: Move virt storage tests to new module
This patch moves virt.vmdevices.storage.Drive.getXML tests to new
vmSt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_cre
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: volume snapshot list verb.
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/410/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/409/ :
SUCCESS
Nir Soffer has posted comments on this change.
Change subject: storageServer: Avoid bogus warnings from createdir
..
Patch Set 2:
Verified also negative flows by injecting errors.
--
To view, visit http://gerrit.ovirt.org/363
Nir Soffer has posted comments on this change.
Change subject: storageServer: Avoid bogus warnings from createdir
..
Patch Set 2: Verified+1
Rebase after previous patch changed.
Verified that positive flows.
--
To view, visi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storageServer: Fix connection error handling
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15601/ : FAILUR
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storageServer: Cleanup logging when mount fails
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15600/ : FAI
Nir Soffer has posted comments on this change.
Change subject: storageServer: Cleanup logging when mount fails
..
Patch Set 3: Verified+1
This show the OSError text in the warning if os.rmdir failed. Previously the
error was h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storageServer: Avoid bogus warnings from createdir
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15599/ :
Nir Soffer has posted comments on this change.
Change subject: storageServer: Fix connection error handling
..
Patch Set 3: Verified+1
Rebase, no code change.
Verified:
- positive flows by creating new nfs domains
- negative f
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: assertLess is not a part of TestCaseBase on el66
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Allow passing custom properties when removing networks.
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: 'ip link del dev ' fails on el6 if the bridge
device is still up.
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_creat
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: volume snapshot create and delete verbs.
..
Patch Set 17:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net_func_tests: Rollback only when an error happens
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merg
Dan Kenigsberg has posted comments on this change.
Change subject: Require newer dhclient on el7
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37103
To unsubscribe, visit http://gerrit.ovirt.org/settings
Dan Kenigsberg has posted comments on this change.
Change subject: tests: assertLess is not a part of TestCaseBase on el66
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37510
To unsubscribe, visit htt
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: assertLess is not a part of TestCaseBase on el66
..
tests: assertLess is not a part of TestCaseBase on el66
Change-Id: I08113055055d973d04a36d72
Dan Kenigsberg has posted comments on this change.
Change subject: Allow passing custom properties when removing networks.
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37482
To unsubscribe, visit htt
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Allow passing custom properties when removing networks.
..
Allow passing custom properties when removing networks.
This allows greater flexibility when
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: api: be consistent with bootproto = None
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: replace ipwrapper monitor
..
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/589/ :
SUCCE
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: 'ip link del dev ' fails on el6 if the bridge
device is still up.
..
tests: 'ip link del dev ' fails on el6 if the bridge device is
still up.
C
Dan Kenigsberg has posted comments on this change.
Change subject: tests: 'ip link del dev ' fails on el6 if the bridge
device is still up.
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37442
To unsu
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Fix return value of _setTicketForGraphicDev
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: volume snapshot create and delete verbs.
..
gluster: volume snapshot create and delete verbs.
This patch adds three new verbs to create and de
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: volume snapshot create and delete verbs.
..
Patch Set 16: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34535
To unsubscribe, visit http://g
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net_func_tests: Rollback only when an error happens
..
net_func_tests: Rollback only when an error happens
Up until now, net_func_tests used RollbackCo
Dan Kenigsberg has posted comments on this change.
Change subject: net_func_tests: Rollback only when an error happens
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29817
To unsubscribe, visit http://
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: api: be consistent with bootproto = None
..
network: api: be consistent with bootproto = None
Change-Id: I03c00b92b830d70c1a46b536955eb9abd425
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netlink: replace ipwrapper monitor
..
netlink: replace ipwrapper monitor
Change-Id: Ife2ee7d16c79eea7c8ed1f0780aafbaa00356978
Signed-off-by: Petr Horáč
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Fix return value of _setTicketForGraphicDev
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37484
To unsubscribe, visit http://ge
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: Fix return value of _setTicketForGraphicDev
..
vdsm: Fix return value of _setTicketForGraphicDev
Invoking VM.updateDevice method via json api exp
Francesco Romani has posted comments on this change.
Change subject: Adding support for cluster level 3.6
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/37384/1/vdsm/dsaversion.py.in
File vdsm/dsaversion.py.in:
Line
Sandro Bonazzola has posted comments on this change.
Change subject: Adding support for cluster level 3.6
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/37384/1/vdsm/dsaversion.py.in
File vdsm/dsaversion.py.in:
Line
Francesco Romani has posted comments on this change.
Change subject: Adding support for cluster level 3.6
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/37384/1/vdsm/dsaversion.py.in
File vdsm/dsaversion.py.in:
Line
Sandro Bonazzola has posted comments on this change.
Change subject: Adding support for cluster level 3.6
..
Patch Set 1: Code-Review+1
ack also on my side, it helps with testing
--
To view, visit http://gerrit.ovirt.org/3738
Michal Skrivanek has posted comments on this change.
Change subject: Adding support for cluster level 3.6
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/37384/1/vdsm/dsaversion.py.in
File vdsm/dsaversion
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: assertLess is not a part of TestCaseBase on el66
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1559
Adam Litke has posted comments on this change.
Change subject: fileUtils: Remove bogus warning from log [1/2]
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36764
To unsubscribe, visit http://gerrit.ov
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Restore watermark tracking
..
Patch Set 4:
(4 comments)
sorry for going out of sync. Seen lot of action between versions 3 and 4,
waiting to see
Petr Horáček has posted comments on this change.
Change subject: netlink: replace ipwrapper monitor
..
Patch Set 10: Verified+1
Passed network's functional tests and unit tests.
--
To view, visit http://gerrit.ovirt.org/37239
Petr Horáček has posted comments on this change.
Change subject: tests: assertLess is not a part of TestCaseBase on el66
..
Patch Set 1: Verified+1
Passed netlinkTests.py even on EL66 machine.
--
To view, visit http://gerrit.
Petr Horáček has uploaded a new change for review.
Change subject: tests: assertLess is not a part of TestCaseBase on el66
..
tests: assertLess is not a part of TestCaseBase on el66
Change-Id: I08113055055d973d04a36d726791149acc
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: Convert VM from external source to Data Domain
..
v2v: Convert VM from external source to Data Domain
new verb: convert VM from external source (non-kvm) t
Petr Horáček has posted comments on this change.
Change subject: network: api: be consistent with bootproto = None
..
Patch Set 1: Verified+1
Passed network's functional tests and unit tests.
--
To view, visit http://gerrit.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add feature to create dispersed volume
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15595/ : SUCCESS
htt
Timothy Asir has posted comments on this change.
Change subject: Add feature to create dispersed volume
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/37474/3/vdsm/rpc/vdsmapi-gluster-schema.json
File vdsm/rpc/vdsmap
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Better logging for networks that are added twice.
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Better logging for networks that are added twice.
..
Better logging for networks that are added twice.
This is useful in tests mainly but may come hand
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Better logging for network restoration.
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15594/ : SUCCESS
ht
Ido Barkan has uploaded a new change for review.
Change subject: Better logging for network restoration.
..
Better logging for network restoration.
This logging is done on the same log file of vdsm itself and it is now
clearer w
Timothy Asir has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 13:
(1 comment)
http://gerrit.ovirt.org/#/c/35498/13/vdsm/gluster/apiwrapper.py
File vdsm/gluster/apiwrapper.py:
Line
Timothy Asir has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 13:
Sorry i missed to add fstab.py file here i will add it in the next patch set.
--
To view, visit http://gerrit.ovi
Timothy Asir has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 13:
@bala, I have updated the code as per your review comment (patch set 11).
Please reply to the comments or let me k
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add feature to create dispersed volume
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15592/ : SUCCESS
htt
Ido Barkan has posted comments on this change.
Change subject: tests: 'ip link del dev ' fails on el6 if the bridge
device is still up.
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/37442
To unsubscribe
Ido Barkan has posted comments on this change.
Change subject: Better logging for networks that are added twice.
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/37481
To unsubscribe, visit http://gerrit.ov
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Handle bridge reconfiguration
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/586/ :
FAILURE
h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Better logging for networks that are added twice.
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15591/ : F
Ido Barkan has posted comments on this change.
Change subject: Allow passing custom properties when removing networks.
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/37482
To unsubscribe, visit http://ger
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net_func_tests: Rollback only when an error happens
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15590/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Allow passing custom properties when removing networks.
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1558
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: 'ip link del dev ' fails on el6 if the bridge
device is still up.
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-
Ido Barkan has posted comments on this change.
Change subject: fix testBeforeNetworkSetupHook
..
Patch Set 1:
(4 comments)
after Dan's comments I have changed the commit topic.
http://gerrit.ovirt.org/#/c/37482/1//COMMIT_MSG
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Handle bridge reconfiguration
..
Handle bridge reconfiguration
This fixes a regression that was introduced in
3951f078d840f6c99d3e72b8ef95a94c6fad4094.
Dan Kenigsberg has posted comments on this change.
Change subject: Handle bridge reconfiguration
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37059
To unsubscribe, visit http://gerrit.ovirt.org/setti
Dan Kenigsberg has posted comments on this change.
Change subject: spec: Require lvm >= 2.02.100-8
..
Patch Set 3: -Code-Review
(1 comment)
http://gerrit.ovirt.org/#/c/37492/3/vdsm.spec.in
File vdsm.spec.in:
Line 245: Require
Petr Horáček has posted comments on this change.
Change subject: Handle bridge reconfiguration
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37059
To unsubscribe, visit http://gerrit.ovirt.org/setting
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: routes_by_dev parameter is never None anyway so
_get_gateway can be simplified.
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/v
Tal Nisan has posted comments on this change.
Change subject: spec: Require lvm >= 2.02.100-8
..
Patch Set 3: Verified-1
I agree with Nir, I'm gonna try and contact the LVM bug assignee again to know
exactly which one we shoul
mooli tayer has posted comments on this change.
Change subject: net_func_tests: Rollback only when an error happens
..
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/29817/4/tests/functional/networkTests.py
Bala.FA has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 13: Code-Review-1
as per patch set #11
--
To view, visit http://gerrit.ovirt.org/35498
To unsubscribe, visit http://gerrit
96 matches
Mail list logo
