Dan Kenigsberg has submitted this change and it was merged.
Change subject: dnsmasqDhcp: fix an inverted condition
..
dnsmasqDhcp: fix an inverted condition
Anywhere _except_ EL6 we want to use dnsmasq with --bind-dynamic.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: report a gateway for statically configured networks
..
Patch Set 8:
Build Failed
we are enforcing pyflakes latests version via puppet class: vdsm_test_runner.pp
barak - please check that the relevant slave on the hostgroup is getting that
and updating to a version
higher than pyflakes-0.8.1-3.el6.noarch.rpm
e.
- Original Message -
From: Dan Kenigsberg
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vmchannels: downgrade logs about expected flows
..
Patch Set 7:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: make _getNicStats a function
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/622/ :
FAILURE
Dan Kenigsberg has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 26: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29392
To unsubscribe, visit
On Tue, Feb 10, 2015 at 02:19:59PM +, Jenkins ci oVirt Server wrote:
Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/
Build: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4605/
Build Number: 4605
Build Status: Failure
Triggered By: Triggered by Gerrit:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 27:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: networkTests: remove a broken approach to unmanaging devices by
NetworkManager
..
Patch Set 3:
(1 comment)
Please state with which NM versions the current
Dima Kuznetsov has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 26:
Removed double 'done' output on tests
--
To view, visit http://gerrit.ovirt.org/29392
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: do not report DHCP from (typically still valid) leases
..
Patch Set 6:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: _get_gateway: allow duplicated gateways if they are in fact the
same routes
..
Patch Set 1:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: make MBPS_TO_BPS a module constant
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/621/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: do not report DHCP from (typically still valid) leases
..
Patch Set 7:
Build Failed
Yaniv Bronhaim has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 26: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29392
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 26: Verified+1
verified by adding manually to engine and restarting vdsmd and supervdsmd
several
Dan Kenigsberg has submitted this change and it was merged.
Change subject: signals: Handle signals to non-main threads
..
signals: Handle signals to non-main threads
This patch addresses an issue of signals being delayed in
oVirt Jenkins CI Server has posted comments on this change.
Change subject: dnsmasqDhcp: fix an inverted condition
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/623/ :
Ondřej Svoboda has posted comments on this change.
Change subject: networkTests: remove a broken approach to unmanaging devices by
NetworkManager
..
Patch Set 3:
Dan, I found the real reason. It is (of course!) not that the
Bala.FA has posted comments on this change.
Change subject: Build gluster packages only for rhel 7 and above
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/37646/1//COMMIT_MSG
Commit Message:
Line 3:
Francesco Romani has posted comments on this change.
Change subject: vm: guestagent: do not access guestinfo directly
..
Patch Set 2:
rebased
--
To view, visit http://gerrit.ovirt.org/37591
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: stats: cache metadata value
..
Patch Set 2:
this version fix the rebase brokeness which we had previously.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: introduce the services infrastracture
..
Patch Set 2:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: make MBPS_TO_BPS a module constant
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/621/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 27:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: devices: remove redundant slot
..
Patch Set 1: Code-Review+1
the duplication is probably a relic of an early revision which managed to
survive until today.
Francesco Romani has posted comments on this change.
Change subject: v2v: additional info for disk and network
..
Patch Set 2: Code-Review-1
(1 comment)
'd' and 'i' are too terse names. It is not only matter of taste, using
Francesco Romani has posted comments on this change.
Change subject: hostdev: add support for reporting usb addresses
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35785
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: stats: cache metadata value
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/37592/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 717:
Line 718:
Francesco Romani has posted comments on this change.
Change subject: clientIF: add API to get all registered VMs
..
Patch Set 10: Code-Review-1
commit message is pointless. Will improve with no code changes.
A test could be a
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: stats: sample using bulk stats and services
..
Patch Set 12:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: stats: cache metadata value
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: move queryBlockJobs under services
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2342/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 26:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: virt: add ExpiringCache
..
Patch Set 10:
version 10 is a rebase, which was needed because a patch later in the series is
affected by recent merge of a patch
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: add an API to check if the domain is busy
..
Patch Set 11:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: vm: drop now unused code
..
Patch Set 2: Code-Review-1
this probably means that a(t least one) former patch breaks the build. Check
them one by one.
--
To
Petr Horáček has posted comments on this change.
Change subject: network: filter out networks with unconfigured bonds
..
Patch Set 1: Verified+1
Passed unit tests, except: testHostSampleHandlesDisappearingVlanInterfaces,
Francesco Romani has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 1:
(1 comment)
I know this is a WIP, but I had a quick look and noticed a simple silly thing.
Francesco Romani has posted comments on this change.
Change subject: vm: add an API to check if the domain is busy
..
Patch Set 11: Code-Review-1
(2 comments)
could be simplified
Francesco Romani has posted comments on this change.
Change subject: virt: Add Drive.extendable property
..
Patch Set 3: Code-Review+1
(1 comment)
I tend to like and support everything that makes the Vm class and vm.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: guestagent: do not access guestinfo directly
..
Patch Set 2:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: vm: stats: split up stats production
..
Patch Set 10: Code-Review-1
the code moved in 'vmstats.py' is now easy to test, thus should be covered by
tests.
--
Nir Soffer has posted comments on this change.
Change subject: virt: Add Drive.extendable property
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/37570/3/vdsm/virt/vmdevices/storage.py
File
Francesco Romani has posted comments on this change.
Change subject: clientIF: add API to get all registered VMs
..
Patch Set 9: Verified+1
--
To view, visit http://gerrit.ovirt.org/36719
To unsubscribe, visit
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Build gluster packages only for rhel 7 and above
..
Build gluster packages only for rhel 7 and above
Change-Id: Ib7c1a0bc8d01a3af26a05c26fe7da7e735ed8800
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: enhanced storageDevicesList function
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15517/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: enhanced storageDevicesList function
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15518/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: vm: add debug log for getStats()
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/36732/2/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Build gluster packages only for rhel 7 and above
..
Patch Set 1:
Build Failed
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: store non-Vdsm ifcfgs with unified persistence
..
network: store non-Vdsm ifcfgs with unified persistence
Unified restoration first removes
Dan Kenigsberg has posted comments on this change.
Change subject: network: store non-Vdsm ifcfgs with unified persistence
..
Patch Set 6: Code-Review+2
I hate the idea, as it makes unified persistence as joke. But at the
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Add drive_config helper
..
tests: Add drive_config helper
Instead of repeating all drive options for each test, add a helper
function to create
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Add drive_config helper
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37547
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: networkTests: use IP_MASK, there's no need for prefix2netmask
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37464
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: networkTests: use IP_MASK, there's no need for prefix2netmask
..
networkTests: use IP_MASK, there's no need for prefix2netmask
Change-Id:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: networkTests: also check we successfully report an IPv4 gateway
..
networkTests: also check we successfully report an IPv4 gateway
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: networkTests: also check we successfully report an IPv4 gateway
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37448
To unsubscribe,
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: additional info for disk and network
..
v2v: additional info for disk and network
disk now return type ('disk', 'cdrom' etc)
network now return type
Dan Kenigsberg has posted comments on this change.
Change subject: network: filter out networks with unconfigured bonds
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37569
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Add tests for drive disk type
..
tests: Add tests for drive disk type
Test Drive.networkDev and Drive.blockDev before refactoring these
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Add tests for drive disk type
..
Patch Set 1: Code-Review+2
Raising score
--
To view, visit http://gerrit.ovirt.org/37549
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Rename test class
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37548
To unsubscribe, visit http://gerrit.ovirt.org/settings
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Rename test class
..
tests: Rename test class
It is easier to grok the tests results when the name of the test case
starts with meaningful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: store non-Vdsm ifcfgs with unified persistence
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15520/ :
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netinfo: report a gateway for statically configured networks
..
netinfo: report a gateway for statically configured networks
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: report a gateway for statically configured networks
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37440
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: dnsmasqDhcp: fix an inverted condition
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37635
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Add drive_config helper
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/613/ :
FAILURE
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: _bridges_ should be among devices with active DHCP
leases
..
Patch Set 2: Code-Review-1
(1 comment)
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ipwrapper: remove the unused function 'routeList'
..
ipwrapper: remove the unused function 'routeList'
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: ipwrapper: remove the unused function 'routeList'
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37622
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Build gluster packages only for rhel 7 and above
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/37646/1/vdsm.spec.in
File vdsm.spec.in:
Shahar Havivi has posted comments on this change.
Change subject: v2v: additional info for disk and network
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37655
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: do not report DHCP from (typically still valid) leases
..
Patch Set 4: Code-Review-1
(1 comment)
Dan Kenigsberg has posted comments on this change.
Change subject: network: change objectivizeNetwork to private
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37567
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Rename test class
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/614/ :
SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: v2v: additional info for disk and network
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15521/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: additional info for disk and network
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/37655/1/vdsm/v2v.py
File vdsm/v2v.py:
Line
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: make MBPS_TO_BPS a module constant
..
vm: make MBPS_TO_BPS a module constant
There is no good reason anymore to have MBPS_TO_BPS a class constant,
Dan Kenigsberg has posted comments on this change.
Change subject: vm: make MBPS_TO_BPS a module constant
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37456
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: make _getNicStats a function
..
vm: make _getNicStats a function
_getNicStats used to be a classmethod of VmStatsThread,
but there are no valid
Dan Kenigsberg has posted comments on this change.
Change subject: vm: make _getNicStats a function
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37457
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: add ExpiringCache
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/36716/9/vdsm/virt/utils.py
File vdsm/virt/utils.py:
Line 77:
Line 78:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Add tests for drive disk type
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/615/ :
Francesco Romani has posted comments on this change.
Change subject: vm: stats: cache metadata value
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/37592/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 770: # The
Dan Kenigsberg has posted comments on this change.
Change subject: vm: guestagent: do not access guestinfo directly
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37591
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: stats: cache metadata value
..
Patch Set 1: Code-Review-1
badly rebased
--
To view, visit http://gerrit.ovirt.org/37592
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: stats: cache metadata value
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/37592/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 770:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: devices: remove redundant slot
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2336/ :
There was
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vmchannels: downgrade logs about expected flows
..
vmchannels: downgrade logs about expected flows
virt flows have plenty of steps logged, but some of
Dan Kenigsberg has posted comments on this change.
Change subject: vmchannels: downgrade logs about expected flows
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34357
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: v2v: additional info for disk and network
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/37655/1/vdsm/v2v.py
File vdsm/v2v.py:
Line 132:
Martin Polednik has uploaded a new change for review.
Change subject: devices: remove redundant slot
..
devices: remove redundant slot
'device' slot is defined in Base class (core.py), there is no need
to have it in child
Shahar Havivi has posted comments on this change.
Change subject: v2v: additional info for disk and network
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/37655
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: devices: remove redundant slot
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37656
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: hostdev: add support for reporting usb addresses
..
Patch Set 8: Verified+1
verified manually via hostdevListByCaps and tests check
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: virt: add ExpiringCache
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36716
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ondřej Svoboda has posted comments on this change.
Change subject: dnsmasqDhcp: fix an inverted condition
..
Patch Set 1: Verified+1
On Fedora 21 the journal is no longer spammed by dnsmasq complaints.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: v2v: additional info for disk and network
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15524/ : SUCCESS
1 - 100 of 138 matches
Mail list logo