Change in vdsm[master]: migration: fix spacing

automat...@ovirt.org has posted comments on this change. Change subject: migration: fix spacing .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U

Change in vdsm[master]: migration: make SourceThread.status private

automat...@ovirt.org has posted comments on this change. Change subject: migration: make SourceThread.status private .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: use only SourceThread.stop()

automat...@ovirt.org has posted comments on this change. Change subject: virt: use only SourceThread.stop() .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header ma

Change in vdsm[master]: migration: use the response module

automat...@ovirt.org has posted comments on this change. Change subject: migration: use the response module .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header ma

Change in vdsm[master]: migration: return a copy of the internal status

automat...@ovirt.org has posted comments on this change. Change subject: migration: return a copy of the internal status .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make s

Change in vdsm[master]: migration: split update from getStat

Francesco Romani has uploaded a new change for review. Change subject: migration: split update from getStat .. migration: split update from getStat Currently, migration.SourceThread.getStat() does two different, although related

Change in vdsm[master]: migration: make stop() update internal status

automat...@ovirt.org has posted comments on this change. Change subject: migration: make stop() update internal status .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: migration: make SourceThread.status private

Francesco Romani has uploaded a new change for review. Change subject: migration: make SourceThread.status private .. migration: make SourceThread.status private The status field should never be accessed directly anymore, the ge

Change in vdsm[master]: virt: do not use status after getStat()

automat...@ovirt.org has posted comments on this change. Change subject: virt: do not use status after getStat() .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: migration: fix spacing

Francesco Romani has uploaded a new change for review. Change subject: migration: fix spacing .. migration: fix spacing Change-Id: I8daf550fb1241872e2a0e5e7e8f0582402e03c04 Signed-off-by: Francesco Romani --- M vdsm/virt/migrat

Change in vdsm[master]: lib: add the response.success() helper

automat...@ovirt.org has posted comments on this change. Change subject: lib: add the response.success() helper .. Patch Set 17: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: migration: split update from getStat

automat...@ovirt.org has posted comments on this change. Change subject: migration: split update from getStat .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: use only SourceThread.stop()

Francesco Romani has uploaded a new change for review. Change subject: virt: use only SourceThread.stop() .. virt: use only SourceThread.stop() the migration orchestration code used to change the SourceThread.status from the out

Change in vdsm[master]: storage: Make StorageDomain._getRepoPath public

Federico Simoncelli has posted comments on this change. Change subject: storage: Make StorageDomain._getRepoPath public .. Patch Set 4: Also this one implies that from SDM you would use the old objects. We probably need to dis

Change in vdsm[master]: storage: Make Image.__chainSizeCalc public

Federico Simoncelli has posted comments on this change. Change subject: storage: Make Image.__chainSizeCalc public .. Patch Set 5: -Code-Review Actually now that I think of it... how can you reuse this in SDM if it uses the ol

Change in vdsm[master]: models, configurators: replace the internal 'async' flag wit...

Ondřej Svoboda has posted comments on this change. Change subject: models, configurators: replace the internal 'async' flag with blockingdhcp .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40456/3/vdsm/network/confi

Change in vdsm[master]: vmdevices: move storage methods to storage module

Francesco Romani has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/40133/4/vdsm/virt/vmdevices/storage.py File vdsm/

Change in vdsm[master]: RFE: Report downtime for each live migration

Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: RFE: Report downtime for each live migration

automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug

Change in vdsm[master]: storage: Make Image.__chainSizeCalc public

Federico Simoncelli has posted comments on this change. Change subject: storage: Make Image.__chainSizeCalc public .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38995 To unsubscribe, visit https://ge

Change in vdsm[master]: vmdevices: move storage methods to storage module

Martin Polednik has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40133/4/vdsm/virt/vmdevices/storage.py File vdsm/vi

Change in vdsm[ovirt-3.5]: netlink: fix PEP8 missing line in netlink memory leak patch

automat...@ovirt.org has posted comments on this change. Change subject: netlink: fix PEP8 missing line in netlink memory leak patch .. Patch Set 2: * Update tracker::#1158108::OK * Check TR::#1158108::OK * Set MODIFIED::bug 11

Change in vdsm[ovirt-3.5]: netlink: fix PEP8 missing line in netlink memory leak patch

Yaniv Bronhaim has submitted this change and it was merged. Change subject: netlink: fix PEP8 missing line in netlink memory leak patch .. netlink: fix PEP8 missing line in netlink memory leak patch Change-Id: I659123c9e1f18e6e

Change in vdsm[ovirt-3.5]: netlink: fix PEP8 missing line in netlink memory leak patch

Yaniv Bronhaim has posted comments on this change. Change subject: netlink: fix PEP8 missing line in netlink memory leak patch .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40488 To unsubscribe, visi

Change in vdsm[master]: virt: Use Drive.diskType instead of networkDev and blockDev

Nir Soffer has posted comments on this change. Change subject: virt: Use Drive.diskType instead of networkDev and blockDev .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40472/4/vdsm/virt/vm.py File vdsm/virt/vm.py:

Change in vdsm[master]: ceph: Support authentication using libvirt secrets

Nir Soffer has posted comments on this change. Change subject: ceph: Support authentication using libvirt secrets .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/40505/2/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vds

Change in vdsm[master]: spec: Require libvirt-python supporting blockCopy

Federico Simoncelli has posted comments on this change. Change subject: spec: Require libvirt-python supporting blockCopy .. Patch Set 7: They're not hidden, they're attached to the code that actually needs that new requiremen

Change in vdsm[master]: ceph: Validate network disk parameters

Nir Soffer has posted comments on this change. Change subject: ceph: Validate network disk parameters .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40477/2/tests/vmStorageTests.py File tests/vmStorageTests.py: Line

Change in vdsm[master]: python3: fix forgotten python2-ish syntax

mooli tayer has posted comments on this change. Change subject: python3: fix forgotten python2-ish syntax .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40511 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: network: wait for udev after configuring SRIOV

automat...@ovirt.org has posted comments on this change. Change subject: network: wait for udev after configuring SRIOV .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: ceph: Support authentication using libvirt secrets

Francesco Romani has posted comments on this change. Change subject: ceph: Support authentication using libvirt secrets .. Patch Set 2: (1 comment) looks ok except for one typo inside https://gerrit.ovirt.org/#/c/40505/2/vdsm

Change in vdsm[master]: network: wait for udev after configuring SRIOV

Ido Barkan has posted comments on this change. Change subject: network: wait for udev after configuring SRIOV .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/40400/6/vdsm/network/api.py File vdsm/network/api.py: Line

Change in vdsm[master]: virt: Use Drive.diskType instead of networkDev and blockDev

Francesco Romani has posted comments on this change. Change subject: virt: Use Drive.diskType instead of networkDev and blockDev .. Patch Set 4: Code-Review+1 (1 comment) the patch looks good. I have concerns about disks being

Change in vdsm[master]: ceph: Support hotunplug of network disks

Francesco Romani has posted comments on this change. Change subject: ceph: Support hotunplug of network disks .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38804 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: ceph: Validate network disk parameters

Francesco Romani has posted comments on this change. Change subject: ceph: Validate network disk parameters .. Patch Set 2: Code-Review-1 (1 comment) fine with the concept, but one c/p error slipped inside. -1 for visibility.

Change in vdsm[master]: ceph: Initial support for network disk

Francesco Romani has posted comments on this change. Change subject: ceph: Initial support for network disk .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38766 To unsubscribe, visit https://gerrit.ov

<    1   2   3