Bala.FA has posted comments on this change.
Change subject: gluster: Remove Vdsm's dependency on glusterfs-server pkg
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/41568/11/vdsm.spec.in
File vdsm.spec.in:
Line 279
Martin Polednik has posted comments on this change.
Change subject: virt: use new mocking in hostdevTests
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/40905/3/tests/hostdevTests.py
File tests/hostdevTests.py:
Lin
Martin Polednik has posted comments on this change.
Change subject: virt: sampling: omit stacktrace if no cpu stats
..
Patch Set 3: Code-Review+1
The code itself seems fine, will test on POWER asap (because it's one place
wher
Eyal Edri has posted comments on this change.
Change subject: Fixed scratchpad hook's image permissions and virtio device name
..
Patch Set 2:
@anton, after this will be merged,
we should consider to back-port it to 3.5.4, as w
Nir Soffer has posted comments on this change.
Change subject: gluster: Allow gluster mount with additional servers
..
Patch Set 28: -Verified
Ala, the patch you depend on no longer includes the glusterVolumeInfo code in
vdsm
Nir Soffer has posted comments on this change.
Change subject: build: Build vdsm-gluster as part of RHEV vdsm build
..
Patch Set 11: Code-Review-1
We cannot use this patch, as it introduce dependency on glusterfs packages
whic
Nir Soffer has posted comments on this change.
Change subject: gluster: Remove Vdsm's dependency on glusterfs-server pkg
..
Patch Set 11: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/41568/11/vdsm.spec.in
File vdsm.s
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: omit stacktrace if no cpu stats
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/42476/2//COMMIT_MSG
Commit Message:
Line 5: Commit
Francesco Romani has posted comments on this change.
Change subject: sampling: return correct vcpu positioning info
..
Patch Set 2: Verified+1
v2 only adds tests, no code changes -> restoring score.
--
To view, visit https://
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: virt: do not poll storage in migrations
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: return correct vcpu positioning info
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
automat...@ovirt.org has posted comments on this change.
Change subject: virt: sampling: omit stacktrace if no cpu stats
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
automat...@ovirt.org has posted comments on this change.
Change subject: virt: avoid spam logs if sampling hollow VMs
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: executor: allow caller to resize TaskQueue
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
automat...@ovirt.org has posted comments on this change.
Change subject: virt: avoid spam logs with periodic false negative
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: make VmDispatcher ignore TooManyTasks
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Francesco Romani has posted comments on this change.
Change subject: migration: wait after the downtime is updated
..
Patch Set 5: Verified+1
re-verified as previously stated
--
To view, visit https://gerrit.ovirt.org/42577
T
Francesco Romani has posted comments on this change.
Change subject: migration: allow one-step downtime settings
..
Patch Set 5: Verified+1
re-verified as previously stated
--
To view, visit https://gerrit.ovirt.org/42576
To
Francesco Romani has posted comments on this change.
Change subject: migration: make downtime steps instance attributes
..
Patch Set 4: Verified+1
v3->v4 changes only commit message and rebases -> restoring score.
--
To view,
automat...@ovirt.org has posted comments on this change.
Change subject: migration: wait after the downtime is updated
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: migration: make downtime steps instance attributes
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
automat...@ovirt.org has posted comments on this change.
Change subject: migration: allow one-step downtime settings
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: migration: make downtime steps instance attributes
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/42578/3//COMMIT_MSG
Commit Message:
Line 10: cod
Dan Kenigsberg has posted comments on this change.
Change subject: migration: make downtime steps instance attributes
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/42578/3//COMMIT_MSG
Commit Message:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: sampling: omit stacktrace if no cpu stats
..
Patch Set 2: Code-Review-1
(3 comments)
nits and questions
https://gerrit.ovirt.org/#/c/42476/2//COMMIT_MSG
Francesco Romani has posted comments on this change.
Change subject: migration: make downtime steps instance attributes
..
Patch Set 3:
more additional verification proof:
Thread-83::DEBUG::2015-06-19 17:27:15,459::migration::
Francesco Romani has posted comments on this change.
Change subject: migration: wait after the downtime is updated
..
Patch Set 4: Verified+1
Works, downtime is updated immediately:
Thread-433::DEBUG::2015-06-19 17:21:02,882::
Francesco Romani has posted comments on this change.
Change subject: migration: make downtime steps instance attributes
..
Patch Set 3:
as additional verification, succesfully migrated VM.
--
To view, visit https://gerrit.ovi
Dan Kenigsberg has posted comments on this change.
Change subject: vmstats: do not catch unlikely ZeroDivisionError
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40916
To unsubscribe, visit https://g
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: more detailed stale sampling reporting
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vmstats: do not catch unlikely ZeroDivisionError
..
vmstats: do not catch unlikely ZeroDivisionError
Nowadays, the only foreseeable reason to have Zero
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: more detailed stale sampling reporting
..
Patch Set 13: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40390
To unsubscribe, visit https://
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: do not catch unlikely ZeroDivisionError
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sampling: more detailed stale sampling reporting
..
sampling: more detailed stale sampling reporting
To improve troubleshooting, report timestamps
of c
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: TypeError is unlikely with modern libvirt
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
-
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vmstats: TypeError is unlikely with modern libvirt
..
vmstats: TypeError is unlikely with modern libvirt
Modern libvirts, which we already require, mak
Dan Kenigsberg has posted comments on this change.
Change subject: vmstats: TypeError is unlikely with modern libvirt
..
Patch Set 7: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/40917/7//COMMIT_MSG
Commit Message:
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: use constants for counter bounds
..
Patch Set 5: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/24194
To unsubscribe, visit http
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: use constants for counter bounds
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/24194
To unsubscribe, visit https://gerrit.
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: use constants for counter bounds
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sampling: use constants for counter bounds
..
sampling: use constants for counter bounds
When we report cpu and network usage, we take two samples of L
automat...@ovirt.org has posted comments on this change.
Change subject: migration: fix spacing
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://ge
Dan Kenigsberg has submitted this change and it was merged.
Change subject: migration: fix spacing
..
migration: fix spacing
Change-Id: I8daf550fb1241872e2a0e5e7e8f0582402e03c04
Signed-off-by: Francesco Romani
Reviewed-on: htt
Francesco Romani has posted comments on this change.
Change subject: migration: make downtime steps instance attributes
..
Patch Set 3: Verified+1
Easy refactoring patch.
added (and verified) using tests.
--
To view, visit ht
automat...@ovirt.org has posted comments on this change.
Change subject: migration: allow one-step downtime settings
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: migration: wait after the downtime is updated
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: migration: make downtime steps instance attributes
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Piotr Kliczewski has posted comments on this change.
Change subject: events: make sure to send only one event per status
..
Patch Set 2: Verified+1
Verified by running latest engine and vdsm and stopping a vm to see that event
automat...@ovirt.org has posted comments on this change.
Change subject: events: make sure to send only one event per status
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
automat...@ovirt.org has posted comments on this change.
Change subject: events: send event explicitly after vm was started
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Piotr Kliczewski has posted comments on this change.
Change subject: events: make sure to send only one event per status
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/42579/1//COMMIT_MSG
Commit Message:
Line 7: ev
Dan Kenigsberg has posted comments on this change.
Change subject: events: make sure to send only one event per status
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/42579/1//COMMIT_MSG
Commit Message:
Line 7: even
Michal Skrivanek has posted comments on this change.
Change subject: migration: make downtime steps instance attributes
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42578
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: migration: wait after the downtime is updated
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42577
To unsubscribe, visit https://ge
Michal Skrivanek has posted comments on this change.
Change subject: migration: allow one-step downtime settings
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42576
To unsubscribe, visit https://gerr
automat...@ovirt.org has posted comments on this change.
Change subject: migration: wait after the downtime is updated
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: migration: allow one-step downtime settings
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: migration: make downtime steps instance attributes
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Dan Kenigsberg has posted comments on this change.
Change subject: events: send event explicitly after vm was started
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42580
To unsubscribe, visit https:/
Dan Kenigsberg has posted comments on this change.
Change subject: virt: use new mocking in hostdevTests
..
Patch Set 3:
(2 comments)
I want to see this patch in, but maybe it can be improved.
https://gerrit.ovirt.org/#/c/409
Dan Kenigsberg has posted comments on this change.
Change subject: virt: use new mocking in hostdevTests
..
Patch Set 3: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/40905
To unsubscribe, visit https://gerrit.ovirt
Dan Kenigsberg has posted comments on this change.
Change subject: virt: use new mocking in hostdevTests
..
Patch Set 3:
-1 mostly for visibility
--
To view, visit https://gerrit.ovirt.org/40905
To unsubscribe, visit https://
Piotr Kliczewski has posted comments on this change.
Change subject: events: send event explicitly after vm was started
..
Patch Set 1: Verified+1
Verified by using latest engine and vdsm and seeing 'PoweringUp' event being
tr
Piotr Kliczewski has posted comments on this change.
Change subject: events: make sure to send only one event per status
..
Patch Set 1: Verified+1
Verified by running latest vdsm and the engine and checking that there was
sin
Piotr Kliczewski has uploaded a new change for review.
Change subject: events: send event explicitly after vm was started
..
events: send event explicitly after vm was started
We need to make sure that we send 'PoweringUp' statu
Piotr Kliczewski has uploaded a new change for review.
Change subject: events: make sure to send only one event per status
..
events: make sure to send only one event per status
Initially we made an assumption that engine can ha
automat...@ovirt.org has posted comments on this change.
Change subject: events: send event explicitly after vm was started
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
automat...@ovirt.org has posted comments on this change.
Change subject: events: make sure to send only one event per status
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
automat...@ovirt.org has posted comments on this change.
Change subject: migration: make downtime steps instance attributes
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
automat...@ovirt.org has posted comments on this change.
Change subject: migration: allow one-step downtime settings
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has uploaded a new change for review.
Change subject: migration: make downtime steps instance attributes
..
migration: make downtime steps instance attributes
Move the DowntimeThread steps from class constant
to
automat...@ovirt.org has posted comments on this change.
Change subject: migration: wait after the downtime is updated
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Michal Skrivanek has posted comments on this change.
Change subject: migration: wait after the downtime is updated
..
Patch Set 1: Code-Review+1
fix typos in commit message please
--
To view, visit https://gerrit.ovirt.org/42
Michal Skrivanek has posted comments on this change.
Change subject: migration: allow one-step downtime settings
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42576/1/vdsm/virt/migration.py
File vdsm/virt/migration.
automat...@ovirt.org has posted comments on this change.
Change subject: migration: wait after the downtime is updated
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Francesco Romani has uploaded a new change for review.
Change subject: migration: allow one-step downtime settings
..
migration: allow one-step downtime settings
In specific environments, it may be useful
to have one-step downti
Francesco Romani has uploaded a new change for review.
Change subject: migration: wait after the downtime is updated
..
migration: wait after the downtime is updated
Current VDSM code waits before to set a new downtime value.
Th
automat...@ovirt.org has posted comments on this change.
Change subject: migration: allow one-step downtime settings
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: migration: fix spacing
..
Patch Set 2: Verified+1
trivial patch, verified with tests.
--
To view, visit https://gerrit.ovirt.org/40519
To unsubscribe, visit
Anton Marchukov has posted comments on this change.
Change subject: Fixed scratchpad hook's image permissions and virtio device name
..
Patch Set 2:
I have verified this by effectively placing the updated before_vm_start.py
sc
automat...@ovirt.org has posted comments on this change.
Change subject: Fixed scratchpad hook's image permissions and virtio device name
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Anton Marchukov has posted comments on this change.
Change subject: Fixed scratchpad hook's image permissions and virtio device name
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42573
To unsubscribe, v
Anton Marchukov has uploaded a new change for review.
Change subject: Fixed scratchpad hook's image permissions and virtio device name
..
Fixed scratchpad hook's image permissions and virtio device name
Change-Id: I4e0e2b09eddeb
automat...@ovirt.org has posted comments on this change.
Change subject: Fixed scratchpad hook's image permissions and virtio device name
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpc: log number of request during period of time
..
jsonrpc: log number of request during period of time
We want to understand how many requests we
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: log number of request during period of time
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42551
To unsubscribe, visit https
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: log number of request during period of time
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
Michal Skrivanek has posted comments on this change.
Change subject: virt: Rate limit epoll errors on untracked FDs
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42569/1/vdsm/virt/vmchannels.py
File vdsm/virt/vmchan
Piotr Kliczewski has posted comments on this change.
Change subject: sampling: return correct vcpu positioning info
..
Patch Set 1: Verified+1
After applying this patch I do not see this issue in the logs.
--
To view, visit h
Francesco Romani has posted comments on this change.
Change subject: sampling: return correct vcpu positioning info
..
Patch Set 1: Code-Review-1
I want more unit tests to make sure this won't happen again
--
To view, visit h
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: TypeError is unlikely with modern libvirt
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
automat...@ovirt.org has posted comments on this change.
Change subject: virt: avoid spam logs with periodic false negative
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: more detailed stale sampling reporting
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: executor: allow caller to resize TaskQueue
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: return correct vcpu positioning info
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: do not catch unlikely ZeroDivisionError
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: make VmDispatcher ignore TooManyTasks
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
automat...@ovirt.org has posted comments on this change.
Change subject: virt: avoid spam logs if sampling hollow VMs
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: virt: do not poll storage in migrations
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: virt: sampling: omit stacktrace if no cpu stats
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
1 - 100 of 112 matches
Mail list logo
