Dan Kenigsberg has posted comments on this change.
Change subject: Vdsm does not require tun device any more
..
Patch Set 3: Continuous-Integration+1
RuntimeError: ("Command ['/usr/sbin/brctl', 'addbr',
'test-\\xe3\\x83\\x88\\
automat...@ovirt.org has posted comments on this change.
Change subject: Vdsm does not require tun device any more
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vie
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Vdsm does not require tun device any more
..
Vdsm does not require tun device any more
For many many years 6a915816, vdsm no longer creates tap devices
Dan Kenigsberg has posted comments on this change.
Change subject: gluster:refactor: User specified backup servers option
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43003/1//COMMIT_MSG
Commit Message:
Line 6:
L
Dan Kenigsberg has posted comments on this change.
Change subject: tests: disable truncating diff in assert error messages
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42902
To unsubscribe, visit ht
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: disable truncating diff in assert error messages
..
tests: disable truncating diff in assert error messages
Set the maximum length of a diff in
automat...@ovirt.org has posted comments on this change.
Change subject: tests: disable truncating diff in assert error messages
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url foun
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sampling: hoststats: switch to SampleWindow
..
sampling: hoststats: switch to SampleWindow
HostStatsThread has its own sampling storage code,
like VmSt
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: hoststats: switch to SampleWindow
..
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Francesco Romani has posted comments on this change.
Change subject: sampling: hoststats: switch to SampleWindow
..
Patch Set 15: Verified+1
Verified using the tests added in the parent patch.
--
To view, visit https://gerrit
Francesco Romani has abandoned this change.
Change subject: vm: move device configuration in a module
..
Abandoned
too controversial
--
To view, visit https://gerrit.ovirt.org/36266
To unsubscribe, visit https://gerrit.ovirt.
automat...@ovirt.org has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org
Francesco Romani has abandoned this change.
Change subject: virt: devices: move device creation in a submodule
..
Abandoned
wrong direction
--
To view, visit https://gerrit.ovirt.org/38077
To unsubscribe, visit https://gerrit
automat...@ovirt.org has posted comments on this change.
Change subject: vm: move device configuration in a module
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/36266
T
automat...@ovirt.org has posted comments on this change.
Change subject: virt: graphdev: support headless VM
..
Patch Set 25:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: periodic: make VmDispatcher ignore TooManyTasks
..
Patch Set 9:
(3 comments)
https://gerrit.ovirt.org/#/c/41657/9//COMMIT_MSG
Commit Message:
Line 6:
Line
Yaniv Bronhaim has posted comments on this change.
Change subject: Vdsm does not require tun device any more
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42878
To unsubscribe, visit https://gerrit.ovir
automat...@ovirt.org has posted comments on this change.
Change subject: Vdsm does not require tun device any more
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Dan Kenigsberg has posted comments on this change.
Change subject: Vdsm does not require tun device any more
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42878
To unsubscribe, visit https://gerrit.o
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: vdscli: migration: fix migrationCreate
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Francesco Romani has uploaded a new change for review.
Change subject: migration: avoid stacktrace on known errors
..
migration: avoid stacktrace on known errors
In migration code, if VM.migrationCreate() fails on destination ho
automat...@ovirt.org has posted comments on this change.
Change subject: migration: avoid stacktrace on known errors
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Vdsm does not require tun device anymore
..
Vdsm does not require tun device anymore
Change-Id: Ia776923ec2d8e6a3dcbcaf9228f352be6e21ec93
Signed-off-by: Yaniv
automat...@ovirt.org has posted comments on this change.
Change subject: Vdsm does not require tun device anymore
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
automat...@ovirt.org has posted comments on this change.
Change subject: snapshot: Add VM.freeze() and VM.thaw() apis.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Nir Soffer has posted comments on this change.
Change subject: snapshot: Start the snapshot module
..
Patch Set 2:
(1 comment)
- vm code and api are added in the next patch.
- vmSnapshotTests.py is conforming to our current n
automat...@ovirt.org has posted comments on this change.
Change subject: snapshot: Start the snapshot module
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Bala.FA has posted comments on this change.
Change subject: tests: disable truncating diff in assert error messages
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42902
To unsubscribe, visit https://g
Adam Litke has posted comments on this change.
Change subject: Balloon should not work when guest agent is not present
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42968
To unsubscribe, visit https:
mooli tayer has posted comments on this change.
Change subject: tests: disable truncating diff in assert error messages
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42902
To unsubscribe, visit https
automat...@ovirt.org has posted comments on this change.
Change subject: vm: make acpiShutdown more robust
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/34879
To unsubsc
Francesco Romani has abandoned this change.
Change subject: virt: dev: implement from_xml for ControllerDevice
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/33754
To unsubscribe, visit https://gerrit.ovirt.org/settin
automat...@ovirt.org has posted comments on this change.
Change subject: virt: dev: implement from_xml for ControllerDevice
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org
Francesco Romani has abandoned this change.
Change subject: vm: make acpiShutdown more robust
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/34879
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-Messag
Francesco Romani has abandoned this change.
Change subject: virt: dev: implement from_xml for WatchdogDevice
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/33752
To unsubscribe, visit https://gerrit.ovirt.org/settings
Francesco Romani has uploaded a new change for review.
Change subject: virt: dev: implement from_xml for WatchdogDevice
..
virt: dev: implement from_xml for WatchdogDevice
Change-Id: I8ceb0f85908c99454f0c981fa4318cc1989f0f7c
Sig
Francesco Romani has uploaded a new change for review.
Change subject: virt: dev: implement from_xml for ControllerDevice
..
virt: dev: implement from_xml for ControllerDevice
Change-Id: I4cf7df0495a58c81207e680732fe0e72b8b5b04c
Francesco Romani has uploaded a new change for review.
Change subject: virt: dev: implement from_xml for SmartcardDevice
..
virt: dev: implement from_xml for SmartcardDevice
Change-Id: I395c49d1cd9af04527840a7d5aaf853d35aa122d
S
automat...@ovirt.org has posted comments on this change.
Change subject: virt: dev: implement from_xml for SmartcardDevice
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/
Francesco Romani has abandoned this change.
Change subject: virt: dev: implement from_xml for SmartcardDevice
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/33753
To unsubscribe, visit https://gerrit.ovirt.org/setting
Francesco Romani has uploaded a new change for review.
Change subject: virt: dev: implement from_xml for SoundDevice
..
virt: dev: implement from_xml for SoundDevice
Change-Id: I04ffbb857557e9f438634465c3f13ca6446393e5
Signed-of
Dan Kenigsberg has posted comments on this change.
Change subject: tests: disable truncating diff in assert error messages
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42902
To unsubscribe, visit ht
Francesco Romani has uploaded a new change for review.
Change subject: virt: dev: bootstrap from_xml method
..
virt: dev: bootstrap from_xml method
implement from_xml method, do incapsulate device
creation from xml description.
Francesco Romani has abandoned this change.
Change subject: virt: dev: bootstrap from_xml method
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/33750
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-Mes
automat...@ovirt.org has posted comments on this change.
Change subject: virt: dev: implement from_xml for SoundDevice
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/3375
automat...@ovirt.org has posted comments on this change.
Change subject: virt: dev: implement from_xml for WatchdogDevice
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/3
Francesco Romani has abandoned this change.
Change subject: virt: dev: implement from_xml for SoundDevice
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/33751
To unsubscribe, visit https://gerrit.ovirt.org/settings
G
automat...@ovirt.org has posted comments on this change.
Change subject: virt: dev: bootstrap from_xml method
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/33750
To unsu
Ido Barkan has abandoned this change.
Change subject: net: simplify _get_gateway
..
Abandoned
this incorrect
--
To view, visit https://gerrit.ovirt.org/42966
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-Mes
automat...@ovirt.org has posted comments on this change.
Change subject: net: simplify _get_gateway
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/42966
To unsubscribe, v
Dan Kenigsberg has posted comments on this change.
Change subject: net: run dhclient in its own process group.
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43005
To unsubscribe, visit https://gerrit
Dan Kenigsberg has posted comments on this change.
Change subject: net: run dhclient in its own process group.
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43005
To unsubscribe, visit https://gerrit
automat...@ovirt.org has posted comments on this change.
Change subject: net: run dhclient in its own process group.
..
Patch Set 4:
* Update tracker::#1228322::OK
* Check Bug-Url::OK
* Check Public Bug::#1228322::OK, public bu
automat...@ovirt.org has posted comments on this change.
Change subject: net: run dhclient in its own process group.
..
Patch Set 3:
* Update tracker::#1228322::OK
* Check Bug-Url::OK
* Check Public Bug::#1228322::OK, public bu
automat...@ovirt.org has posted comments on this change.
Change subject: net: run dhclient in its own process group.
..
Patch Set 2:
* Update tracker::#1228322::OK
* Check Bug-Url::OK
* Check Public Bug::#1228322::OK, public bu
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: fix testSetupNetworksAddBondWithManyVlans
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: tests: fix testSetupNetworksAddBondWithManyVlans
..
net: tests: fix testSetupNetworksAddBondWithManyVlans
testSetupNetworksAddBondWithManyVlans wa
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: fix testSetupNetworksAddBondWithManyVlans
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43030
To unsubscribe, visit http
Francesco Romani has posted comments on this change.
Change subject: hostdev: fix address type for host devices
..
Patch Set 1: Code-Review+1
seems OK as well
--
To view, visit https://gerrit.ovirt.org/43042
To unsubscribe, v
automat...@ovirt.org has posted comments on this change.
Change subject: load_needed_modules verb is not required
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
automat...@ovirt.org has posted comments on this change.
Change subject: load_needed_modules verb is not required
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Introducing vdsm preset systemd file
..
Introducing vdsm preset systemd file
http://www.freedesktop.org/software/systemd/man/systemd.preset.html
syste
automat...@ovirt.org has posted comments on this change.
Change subject: Introducing vdsm preset systemd file
..
Patch Set 5:
* Update tracker::#1094936::OK
* Check TR::#1094936::ERROR, 3.6.0 should not match .*
--
To view, v
Francesco Romani has posted comments on this change.
Change subject: hostdev: fix address type for generic devices
..
Patch Set 1: Code-Review+1
seems OK (also checked code before 155e823f)
--
To view, visit https://gerrit.ov
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: fix address type for host devices
..
hostdev: fix address type for host devices
When sending a guest address, we cannot allow empty type to be sent.
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix address type for host devices
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Dan Kenigsberg has posted comments on this change.
Change subject: Fixed scratchpad hook's image permissions and virtio device name
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42573
To unsubscribe,
automat...@ovirt.org has posted comments on this change.
Change subject: Fixed scratchpad hook's image permissions and virtio device name
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fixed scratchpad hook's image permissions and virtio device name
..
Fixed scratchpad hook's image permissions and virtio device name
Change-Id: I4e0e2b
Martin Polednik has posted comments on this change.
Change subject: hostdev: fix address type for generic devices
..
Patch Set 1: Verified+1
Address has correct type.
--
To view, visit https://gerrit.ovirt.org/43041
To unsubs
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix address type for generic devices
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: fix address type for generic devices
..
hostdev: fix address type for generic devices
Change 155e823f refactored some common elements of generic and
Dan Kenigsberg has posted comments on this change.
Change subject: load_needed_modules verb is not required
..
Patch Set 1: Code-Review-1
(2 comments)
nit
https://gerrit.ovirt.org/#/c/43040/1//COMMIT_MSG
Commit Message:
Line
Yaniv Bronhaim has uploaded a new change for review.
Change subject: load_needed_modules verb is not required
..
load_needed_modules verb is not required
Since ovirt-3.6 systemd takes care for loading required kernel modules dur
automat...@ovirt.org has posted comments on this change.
Change subject: load_needed_modules verb is not required
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
Yeela Kaplan has posted comments on this change.
Change subject: Introducing vdsm preset systemd file
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43032
To unsubscribe, visit https://gerrit.ovirt.or
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: make _getCpuCoresStats a function
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40429
To unsubscribe, visit https://gerri
Francesco Romani has posted comments on this change.
Change subject: sampling: make _getCpuCoresStats a function
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/40429/15/vdsm/virt/sampling.py
File vdsm/virt/sampling.
automat...@ovirt.org has posted comments on this change.
Change subject: Removing support in sysv and upstart
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: Removing support in sysv and upstart
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has posted comments on this change.
Change subject: tests: add HostStatsThread._getCpuCoreStats test
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41372
To unsubscribe, visit https://g
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: rename variables for clarity
..
Patch Set 9: Code-Review+1
I find hs0 hs1 so very clear... maybe it is just my physics education.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: hoststats: switch to SampleWindow
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40428
To unsubscribe, visit https://gerri
Dan Kenigsberg has posted comments on this change.
Change subject: tests: HostStatsThread: sampling window tests
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41878
To unsubscribe, visit https://gerr
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: HostStatsThread: sampling window tests
..
tests: HostStatsThread: sampling window tests
Add test to ensure that the circular buffer
for Host sam
automat...@ovirt.org has posted comments on this change.
Change subject: tests: HostStatsThread: sampling window tests
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: periodic: make VmDispatcher ignore TooManyTasks
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/41657/9//COMMIT_MSG
Commit Message:
Line 8:
Line 9:
Martin Polednik has posted comments on this change.
Change subject: virt: add logic for ppc cpu xml element
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/42736/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 366
Francesco Romani has posted comments on this change.
Change subject: periodic: make VmDispatcher ignore TooManyTasks
..
Patch Set 9: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/41657/9/vdsm/virt/periodic.py
File vds
Roy Golan has posted comments on this change.
Change subject: Balloon should not work when guest agent is not present
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42968
To unsubscribe, visit https:/
automat...@ovirt.org has posted comments on this change.
Change subject: Introducing vdsm preset systemd file
..
Patch Set 4:
* Update tracker::#1094936::OK
* Check Bug-Url::OK
* Check Public Bug::#1094936::OK, public bug
* Che
Yaniv Bronhaim has posted comments on this change.
Change subject: Introducing vdsm preset systemd file
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/43032
To unsubscribe, visit https://gerrit.ovirt.org
Dan Kenigsberg has posted comments on this change.
Change subject: virt: add logic for ppc cpu xml element
..
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/42736/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml
automat...@ovirt.org has posted comments on this change.
Change subject: tests: basic scaffolding tests for getUnderlying*
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/
Francesco Romani has abandoned this change.
Change subject: tests: basic scaffolding tests for getUnderlying*
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/38976
To unsubscribe, visit https://gerrit.ovirt.org/setting
automat...@ovirt.org has posted comments on this change.
Change subject: Fixed scratchpad hook's image permissions and virtio device name
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Dan Kenigsberg has posted comments on this change.
Change subject: virt: use new mocking in hostdevTests
..
Patch Set 4: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/40905
To unsubscribe, visit https://g
automat...@ovirt.org has posted comments on this change.
Change subject: virt: use new mocking in hostdevTests
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, v
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: use new mocking in hostdevTests
..
virt: use new mocking in hostdevTests
With unified mocking mechanism for host devices, hostdevTests can now
be
1 - 100 of 181 matches
Mail list logo
