Change in vdsm[master]: rwlock: Mark time sensitive test as stress test

2015-07-16 Thread alitke
Adam Litke has posted comments on this change. Change subject: rwlock: Mark time sensitive test as stress test .. Patch Set 2: Code-Review-1 please squash this with the previous patch. -- To view, visit

Change in vdsm[master]: concurrent: Add Barrier class

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: concurrent: Add Barrier class .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: rwlock: Add simpler RWLock

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 15: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: resourceManager: Avoid unneeded recursive locking

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: resourceManager: Avoid unneeded recursive locking .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: rwlock: Support timed acquire

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: rwlock: Support timed acquire .. Patch Set 21: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Add RWLock tests

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Add RWLock tests .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: rwlock: Support non-blocking acquire

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: rwlock: Support non-blocking acquire .. Patch Set 18: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: rwlock: Replace misc.RWLock

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: rwlock: Replace misc.RWLock .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: rwlock: Mark time sensitive test as stress test

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: rwlock: Mark time sensitive test as stress test .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found -- To view, visit

Change in vdsm[master]: rwlock: Mark time sensitive test as stress test

2015-07-16 Thread nsoffer
Nir Soffer has abandoned this change. Change subject: rwlock: Mark time sensitive test as stress test .. Abandoned Squashed into previous patch -- To view, visit https://gerrit.ovirt.org/43579 To unsubscribe, visit

Change in vdsm[master]: rwlock: Mark time sensitive test as stress test

2015-07-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: rwlock: Mark time sensitive test as stress test .. Patch Set 2: This is now part of https://gerrit.ovirt.org/42927 -- To view, visit

Change in vdsm[master]: concurrent: Add Barrier class

2015-07-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: concurrent: Add Barrier class .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/42927 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: net: only backup ifcfg files if they are not already persisted.

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: only backup ifcfg files if they are not already persisted. .. Patch Set 5: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public

Change in vdsm[ovirt-3.5]: net: only backup ifcfg files if they are not already persisted.

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: only backup ifcfg files if they are not already persisted. .. Patch Set 2: Verified-1 * Update tracker::#1203422::OK * Check Bug-Url::OK * Check

Change in vdsm[master]: vmstats: rename 'nic' function

2015-07-16 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: vmstats: rename 'nic' function .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43694 To unsubscribe, visit

Change in vdsm[master]: vdsm hooks: report hook stderr to Engine if it fails an action

2015-07-16 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vdsm hooks: report hook stderr to Engine if it fails an action .. Patch Set 20: Code-Review+1 (2 comments) looks ok, minor comments inside

Change in vdsm[master]: Add ResourceLocker

2015-07-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Add ResourceLocker .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/43554/2/vdsm/storage/resourceLocker.py File vdsm/storage/resourceLocker.py: Line 40:

Change in vdsm[master]: gluster: handle an unhandled exception in gfapi.py

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: handle an unhandled exception in gfapi.py .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.

Change in vdsm[master]: net: remove redundant validation during network deletion

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: remove redundant validation during network deletion .. Patch Set 2: * Update tracker::#1055454::OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: gluster: handle an unhandled exception in gfapi.py

2015-07-16 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: gluster: handle an unhandled exception in gfapi.py .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43670 To unsubscribe, visit

Change in vdsm[master]: gluster: handle an unhandled exception in gfapi.py

2015-07-16 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: handle an unhandled exception in gfapi.py .. gluster: handle an unhandled exception in gfapi.py This patch handles an un handled exception in

Change in vdsm[master]: vmstats: do not report empty ioTune

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: do not report empty ioTune .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vmstats: report network stats only if present

2015-07-16 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vmstats: report network stats only if present .. vmstats: report network stats only if present avoid to report empty values for network stats, as this may

Change in vdsm[master]: vm: event: simplify send_status_event

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: event: simplify send_status_event .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vm: event: emit event on setDownStatus

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: event: emit event on setDownStatus .. Patch Set 15: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vm: event: send status event on reboot

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: event: send status event on reboot .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vm: event: emit event on guest status change

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: event: emit event on guest status change .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: vm: stats: move vmstats translation code away

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: stats: move vmstats translation code away .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: vmstats: report disks stats only if present

2015-07-16 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vmstats: report disks stats only if present .. vmstats: report disks stats only if present avoid to report empty values for disks stats, as this may confuse

Change in vdsm[master]: vm: events: do not override Down status

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: events: do not override Down status .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: sampling: omit stacktrace if no cpu stats

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: virt: sampling: omit stacktrace if no cpu stats .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found -- To view, visit

Change in vdsm[master]: virt: sampling: omit stacktrace if no cpu stats

2015-07-16 Thread fromani
Francesco Romani has abandoned this change. Change subject: virt: sampling: omit stacktrace if no cpu stats .. Abandoned no longer needed -- To view, visit https://gerrit.ovirt.org/42476 To unsubscribe, visit

Change in vdsm[master]: hsm: Remove unrelevant sdCache.produce

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: hsm: Remove unrelevant sdCache.produce .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/43294 To

Change in vdsm[master]: hsm: Remove unrelevant sdCache.produce

2015-07-16 Thread mlipchuk
Maor Lipchuk has abandoned this change. Change subject: hsm: Remove unrelevant sdCache.produce .. Abandoned abandon it temporary until OVF_STORE will get forward -- To view, visit https://gerrit.ovirt.org/43294 To

Change in vdsm[master]: vdsm hooks: report hook stderr to Engine if it fails an action

2015-07-16 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: vdsm hooks: report hook stderr to Engine if it fails an action .. Patch Set 20: (1 comment) https://gerrit.ovirt.org/#/c/42592/20/vdsm/virt/migration.py File

Change in vdsm[master]: net: remove redundant validation during network deletion

2015-07-16 Thread ibarkan
Ido Barkan has uploaded a new change for review. Change subject: net: remove redundant validation during network deletion .. net: remove redundant validation during network deletion d6d7db introduce the ability to delete a

Change in vdsm[master]: net: remove redundant validation during network deletion

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: remove redundant validation during network deletion .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: net: remove redundant validation during network deletion

2015-07-16 Thread yzaspits
Yevgeny Zaspitsky has posted comments on this change. Change subject: net: remove redundant validation during network deletion .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/43710 To unsubscribe, visit

Change in vdsm[master]: vmstats: report network stats only if present

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: report network stats only if present .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: vm: event: status is an enumeration, not as tuple

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: event: status is an enumeration, not as tuple .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: vmstats: make sure values are all strings

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: make sure values are all strings .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vm: events: do NOT send 'Down' event after destroy

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: events: do NOT send 'Down' event after destroy .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: vm: event: add arguments to send_status_event

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: event: add arguments to send_status_event .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: virt: clientif: remove generic vm status event

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: virt: clientif: remove generic vm status event .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: vm: events: do not send hashes in status messages

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: events: do not send hashes in status messages .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: vm: stats: do not send empty disks/networks

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: stats: do not send empty disks/networks .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vmstats: make sure values are all strings

2015-07-16 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vmstats: make sure values are all strings .. vmstats: make sure values are all strings Until we drop support of XML-RPC, we need to make sure that possibly

Change in vdsm[master]: vmstats: do not report empty balloonInfo

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: do not report empty balloonInfo .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vm: event: emit event on domDependentInit

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: event: emit event on domDependentInit .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vmstats: avoid explicit string conversion

2015-07-16 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vmstats: avoid explicit string conversion .. vmstats: avoid explicit string conversion Now that we streamlined the reporting of disk stats, we can get rid

Change in vdsm[master]: vm: event: send status event on IO Error

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: event: send status event on IO Error .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vmstats: report disks stats only if present

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: report disks stats only if present .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vmstats: avoid explicit string conversion

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: avoid explicit string conversion .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: event: send status event on migrations

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: virt: event: send status event on migrations .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: vm: event: send status event on pause and resume

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: event: send status event on pause and resume .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: virt: migration: create full status in migration.py

2015-07-16 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: migration: create full status in migration.py .. Patch Set 5: Code-Review+1 Thanks, this is enough evidence. The flow can work, and we'll see on the

Change in vdsm[master]: tests: Create storagetestutils module

2015-07-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Create storagetestutils module .. Patch Set 3: Code-Review-1 -1 for visibility. -- To view, visit https://gerrit.ovirt.org/43547 To unsubscribe, visit

Change in vdsm[master]: spbackends: Move backend functions to spbackends

2015-07-16 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: spbackends: Move backend functions to spbackends .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/43463/1/vdsm/storage/spbackends.py File

Change in vdsm[master]: gluster: handle an unhandled exception in gfapi.py

2015-07-16 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: gluster: handle an unhandled exception in gfapi.py .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43670 To unsubscribe, visit

Change in vdsm[master]: tests: Create storagetestutils module

2015-07-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Create storagetestutils module .. Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/43547/3/tests/storagetestlib.py File tests/storagetestlib.py:

Change in vdsm[master]: net: only backup ifcfg files if they are not already persisted.

2015-07-16 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: only backup ifcfg files if they are not already persisted. .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/43684 To unsubscribe, visit

Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (net)

2015-07-16 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation (net) .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43679 To unsubscribe, visit

Change in vdsm[master]: sp: Move spm validation methods to StoragePool

2015-07-16 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: sp: Move spm validation methods to StoragePool .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/43542/1/vdsm/storage/hsm.py File

Change in vdsm[master]: net: only backup ifcfg files if they are not already persisted.

2015-07-16 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: only backup ifcfg files if they are not already persisted. .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43684 To unsubscribe,

Change in vdsm[master]: vmstats: rename 'nic' function

2015-07-16 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vmstats: rename 'nic' function .. Patch Set 1: Verified+1 verified together: 43694, 43679, 43681, 43682. Looks better now:

Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (net)

2015-07-16 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation (net) .. Patch Set 6: Verified+1 verified together: 43694, 43679, 43681, 43682. Looks better now:

Change in vdsm[master]: network: wait for a bridge to appear before disabling IPv6 o...

2015-07-16 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: network: wait for a bridge to appear before disabling IPv6 on it .. Patch Set 1: Code-Review-1 (3 comments) nits mostly. In general it looks excellent.

Change in vdsm[master]: virt: removing naming confilct in vmstats.py

2015-07-16 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: virt: removing naming confilct in vmstats.py .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43657 To unsubscribe, visit

Change in vdsm[master]: network: wait for a bridge to appear before disabling IPv6 o...

2015-07-16 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: network: wait for a bridge to appear before disabling IPv6 on it .. Patch Set 1: doesn't this solve https://bugzilla.redhat.com/show_bug.cgi?id=1240921 ?? -- To

Change in vdsm[master]: virt: migration: create full status in migration.py

2015-07-16 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: virt: migration: create full status in migration.py .. Patch Set 5: The status of the migration is checked by MigrateStatusVDSCommand. The best way is probably

Change in vdsm[master]: storage: simplify hasVolumeLeases

2015-07-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: simplify hasVolumeLeases .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/43548/3/vdsm/storage/clusterlock.py File

Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (disk)

2015-07-16 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation (disk) .. Patch Set 4: Verified+1 verified together: 43694, 43679, 43681, 43682. Looks better now:

Change in vdsm[master]: vmstats: factor disk iops stats into an helper

2015-07-16 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vmstats: factor disk iops stats into an helper .. Patch Set 4: Verified+1 verified together: 43694, 43679, 43681, 43682. Looks better now:

Change in vdsm[master]: net: only backup ifcfg files if they are not already persisted.

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: only backup ifcfg files if they are not already persisted. .. Patch Set 6: * Update tracker::#1203422::OK * Set MODIFIED::bug

Change in vdsm[master]: net: only backup ifcfg files if they are not already persisted.

2015-07-16 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: only backup ifcfg files if they are not already persisted. .. net: only backup ifcfg files if they are not already persisted. d6454e introduced

Change in vdsm[master]: spbackends: Move backend functions to spbackends

2015-07-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spbackends: Move backend functions to spbackends .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/43463/1/vdsm/storage/spbackends.py File

Change in vdsm[master]: sp: Move spm validation methods to StoragePool

2015-07-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Move spm validation methods to StoragePool .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/43542/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py:

Change in vdsm[ovirt-3.5]: net: only backup ifcfg files if they are not already persisted.

2015-07-16 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: net: only backup ifcfg files if they are not already persisted. .. net: only backup ifcfg files if they are not already persisted. 5fc7217 introduced

Change in vdsm[master]: stomp: make sure to send error message when no subscription

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: make sure to send error message when no subscription .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: tests: StompAdapter test suite

2015-07-16 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: StompAdapter test suite .. Patch Set 4: Verified+1 Verified by running local build. -- To view, visit https://gerrit.ovirt.org/43342 To unsubscribe,

Change in vdsm[master]: stomp: make sure to send error message when no subscription

2015-07-16 Thread piotr . kliczewski
Piotr Kliczewski has uploaded a new change for review. Change subject: stomp: make sure to send error message when no subscription .. stomp: make sure to send error message when no subscription When we get destination which is

Change in vdsm[master]: tests: StompAdapter test suite

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: StompAdapter test suite .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: stomp: send unsubscribed frame only if there was subscription

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: send unsubscribed frame only if there was subscription .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug

Change in vdsm[master]: tests: AsyncClient test suite

2015-07-16 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: AsyncClient test suite .. Patch Set 3: Verified+1 Verified by running local build. -- To view, visit https://gerrit.ovirt.org/43393 To unsubscribe,

Change in vdsm[master]: jsonrpc: handle timeout in callMethod

2015-07-16 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: handle timeout in callMethod .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/43167/3/lib/yajsonrpc/__init__.py File

Change in vdsm[master]: jsonrpc: handle timeout in callMethod

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: handle timeout in callMethod .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: test: customize destination for an event

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: test: customize destination for an event .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: stomp: standalone client

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: standalone client .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: hostdev: add support for hotplug

2015-07-16 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: hostdev: add support for hotplug .. Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/42661/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2026:

Change in vdsm[master]: freeze: Avoid unneeded freeze during snapshot

2015-07-16 Thread fromani
Francesco Romani has posted comments on this change. Change subject: freeze: Avoid unneeded freeze during snapshot .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43293 To unsubscribe, visit

Change in vdsm[master]: hsm: Explain why we call validateNotSPM() twice

2015-07-16 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: hsm: Explain why we call validateNotSPM() twice .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43731 To unsubscribe, visit

Change in vdsm[master]: spbackends: Move backend functions to spbackends

2015-07-16 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: spbackends: Move backend functions to spbackends .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43463 To unsubscribe, visit

Change in vdsm[master]: freeze: Avoid unneeded freeze during snapshot

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: freeze: Avoid unneeded freeze during snapshot .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. --

Change in vdsm[master]: tests: JsonRpcClient tests suite

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: JsonRpcClient tests suite .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: stomp: allow to mock monotonic_time method

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: allow to mock monotonic_time method .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: jsonrpc: ignore unknown message id

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: ignore unknown message id .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vm: events: reorganize events

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: events: reorganize events .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vmstats: report network stats only if present

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: report network stats only if present .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: vmstats: report disks stats only if present

2015-07-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: report disks stats only if present .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[ovirt-3.5]: net: only backup ifcfg files if they are not already persisted.

2015-07-16 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: only backup ifcfg files if they are not already persisted. .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/43685 To unsubscribe, visit

  1   2   3   >