Adam Litke has posted comments on this change.
Change subject: rwlock: Mark time sensitive test as stress test
..
Patch Set 2: Code-Review-1
please squash this with the previous patch.
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: resourceManager: Avoid unneeded recursive locking
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: rwlock: Support timed acquire
..
Patch Set 21:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Add RWLock tests
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: rwlock: Support non-blocking acquire
..
Patch Set 18:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: rwlock: Replace misc.RWLock
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: rwlock: Mark time sensitive test as stress test
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit
Nir Soffer has abandoned this change.
Change subject: rwlock: Mark time sensitive test as stress test
..
Abandoned
Squashed into previous patch
--
To view, visit https://gerrit.ovirt.org/43579
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: rwlock: Mark time sensitive test as stress test
..
Patch Set 2:
This is now part of https://gerrit.ovirt.org/42927
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/42927
To unsubscribe, visit https://gerrit.ovirt.org/settings
automat...@ovirt.org has posted comments on this change.
Change subject: net: only backup ifcfg files if they are not already persisted.
..
Patch Set 5:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: net: only backup ifcfg files if they are not already persisted.
..
Patch Set 2: Verified-1
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check
Marcin Mirecki has posted comments on this change.
Change subject: vmstats: rename 'nic' function
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43694
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vdsm hooks: report hook stderr to Engine if it fails an action
..
Patch Set 20: Code-Review+1
(2 comments)
looks ok, minor comments inside
Nir Soffer has posted comments on this change.
Change subject: Add ResourceLocker
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/43554/2/vdsm/storage/resourceLocker.py
File vdsm/storage/resourceLocker.py:
Line 40:
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: handle an unhandled exception in gfapi.py
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
automat...@ovirt.org has posted comments on this change.
Change subject: net: remove redundant validation during network deletion
..
Patch Set 2:
* Update tracker::#1055454::OK
* Check Bug-Url::OK
* Check Public
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: handle an unhandled exception in gfapi.py
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43670
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: handle an unhandled exception in gfapi.py
..
gluster: handle an unhandled exception in gfapi.py
This patch handles an un handled exception in
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: do not report empty ioTune
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has uploaded a new change for review.
Change subject: vmstats: report network stats only if present
..
vmstats: report network stats only if present
avoid to report empty values for network stats,
as this may
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: simplify send_status_event
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: emit event on setDownStatus
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: send status event on reboot
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: emit event on guest status change
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vm: stats: move vmstats translation code away
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Francesco Romani has uploaded a new change for review.
Change subject: vmstats: report disks stats only if present
..
vmstats: report disks stats only if present
avoid to report empty values for disks stats,
as this may confuse
automat...@ovirt.org has posted comments on this change.
Change subject: vm: events: do not override Down status
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: virt: sampling: omit stacktrace if no cpu stats
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit
Francesco Romani has abandoned this change.
Change subject: virt: sampling: omit stacktrace if no cpu stats
..
Abandoned
no longer needed
--
To view, visit https://gerrit.ovirt.org/42476
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: hsm: Remove unrelevant sdCache.produce
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/43294
To
Maor Lipchuk has abandoned this change.
Change subject: hsm: Remove unrelevant sdCache.produce
..
Abandoned
abandon it temporary until OVF_STORE will get forward
--
To view, visit https://gerrit.ovirt.org/43294
To
Marcin Mirecki has posted comments on this change.
Change subject: vdsm hooks: report hook stderr to Engine if it fails an action
..
Patch Set 20:
(1 comment)
https://gerrit.ovirt.org/#/c/42592/20/vdsm/virt/migration.py
File
Ido Barkan has uploaded a new change for review.
Change subject: net: remove redundant validation during network deletion
..
net: remove redundant validation during network deletion
d6d7db introduce the ability to delete a
automat...@ovirt.org has posted comments on this change.
Change subject: net: remove redundant validation during network deletion
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Yevgeny Zaspitsky has posted comments on this change.
Change subject: net: remove redundant validation during network deletion
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/43710
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: report network stats only if present
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: status is an enumeration, not as tuple
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: make sure values are all strings
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: events: do NOT send 'Down' event after destroy
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: add arguments to send_status_event
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: virt: clientif: remove generic vm status event
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vm: events: do not send hashes in status messages
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: vm: stats: do not send empty disks/networks
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has uploaded a new change for review.
Change subject: vmstats: make sure values are all strings
..
vmstats: make sure values are all strings
Until we drop support of XML-RPC, we need
to make sure that possibly
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: do not report empty balloonInfo
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: emit event on domDependentInit
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has uploaded a new change for review.
Change subject: vmstats: avoid explicit string conversion
..
vmstats: avoid explicit string conversion
Now that we streamlined the reporting of disk stats,
we can get rid
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: send status event on IO Error
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: report disks stats only if present
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: avoid explicit string conversion
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: virt: event: send status event on migrations
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: send status event on pause and resume
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Francesco Romani has posted comments on this change.
Change subject: virt: migration: create full status in migration.py
..
Patch Set 5: Code-Review+1
Thanks, this is enough evidence. The flow can work, and we'll see on the
Nir Soffer has posted comments on this change.
Change subject: tests: Create storagetestutils module
..
Patch Set 3: Code-Review-1
-1 for visibility.
--
To view, visit https://gerrit.ovirt.org/43547
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: spbackends: Move backend functions to spbackends
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43463/1/vdsm/storage/spbackends.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: handle an unhandled exception in gfapi.py
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43670
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Create storagetestutils module
..
Patch Set 3:
(4 comments)
https://gerrit.ovirt.org/#/c/43547/3/tests/storagetestlib.py
File tests/storagetestlib.py:
Ido Barkan has posted comments on this change.
Change subject: net: only backup ifcfg files if they are not already persisted.
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/43684
To unsubscribe, visit
Marcin Mirecki has posted comments on this change.
Change subject: vmstats: fix bulk stats misinterpretation (net)
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43679
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: sp: Move spm validation methods to StoragePool
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/43542/1/vdsm/storage/hsm.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: net: only backup ifcfg files if they are not already persisted.
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43684
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: vmstats: rename 'nic' function
..
Patch Set 1: Verified+1
verified together: 43694, 43679, 43681, 43682.
Looks better now:
Francesco Romani has posted comments on this change.
Change subject: vmstats: fix bulk stats misinterpretation (net)
..
Patch Set 6: Verified+1
verified together: 43694, 43679, 43681, 43682.
Looks better now:
Ido Barkan has posted comments on this change.
Change subject: network: wait for a bridge to appear before disabling IPv6 on it
..
Patch Set 1: Code-Review-1
(3 comments)
nits mostly. In general it looks excellent.
Dan Kenigsberg has posted comments on this change.
Change subject: virt: removing naming confilct in vmstats.py
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43657
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: network: wait for a bridge to appear before disabling IPv6 on it
..
Patch Set 1:
doesn't this solve https://bugzilla.redhat.com/show_bug.cgi?id=1240921 ??
--
To
Marcin Mirecki has posted comments on this change.
Change subject: virt: migration: create full status in migration.py
..
Patch Set 5:
The status of the migration is checked by MigrateStatusVDSCommand.
The best way is probably
Nir Soffer has posted comments on this change.
Change subject: storage: simplify hasVolumeLeases
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/43548/3/vdsm/storage/clusterlock.py
File
Francesco Romani has posted comments on this change.
Change subject: vmstats: fix bulk stats misinterpretation (disk)
..
Patch Set 4: Verified+1
verified together: 43694, 43679, 43681, 43682.
Looks better now:
Francesco Romani has posted comments on this change.
Change subject: vmstats: factor disk iops stats into an helper
..
Patch Set 4: Verified+1
verified together: 43694, 43679, 43681, 43682.
Looks better now:
automat...@ovirt.org has posted comments on this change.
Change subject: net: only backup ifcfg files if they are not already persisted.
..
Patch Set 6:
* Update tracker::#1203422::OK
* Set MODIFIED::bug
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: only backup ifcfg files if they are not already persisted.
..
net: only backup ifcfg files if they are not already persisted.
d6454e introduced
Nir Soffer has posted comments on this change.
Change subject: spbackends: Move backend functions to spbackends
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43463/1/vdsm/storage/spbackends.py
File
Nir Soffer has posted comments on this change.
Change subject: sp: Move spm validation methods to StoragePool
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43542/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: net: only backup ifcfg files if they are not already persisted.
..
net: only backup ifcfg files if they are not already persisted.
5fc7217 introduced
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: make sure to send error message when no subscription
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Piotr Kliczewski has posted comments on this change.
Change subject: tests: StompAdapter test suite
..
Patch Set 4: Verified+1
Verified by running local build.
--
To view, visit https://gerrit.ovirt.org/43342
To unsubscribe,
Piotr Kliczewski has uploaded a new change for review.
Change subject: stomp: make sure to send error message when no subscription
..
stomp: make sure to send error message when no subscription
When we get destination which is
automat...@ovirt.org has posted comments on this change.
Change subject: tests: StompAdapter test suite
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: send unsubscribed frame only if there was subscription
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Piotr Kliczewski has posted comments on this change.
Change subject: tests: AsyncClient test suite
..
Patch Set 3: Verified+1
Verified by running local build.
--
To view, visit https://gerrit.ovirt.org/43393
To unsubscribe,
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: handle timeout in callMethod
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/43167/3/lib/yajsonrpc/__init__.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: handle timeout in callMethod
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: test: customize destination for an event
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: standalone client
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has posted comments on this change.
Change subject: hostdev: add support for hotplug
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/42661/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2026:
Francesco Romani has posted comments on this change.
Change subject: freeze: Avoid unneeded freeze during snapshot
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43293
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: hsm: Explain why we call validateNotSPM() twice
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43731
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: spbackends: Move backend functions to spbackends
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43463
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: freeze: Avoid unneeded freeze during snapshot
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
automat...@ovirt.org has posted comments on this change.
Change subject: tests: JsonRpcClient tests suite
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: allow to mock monotonic_time method
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: ignore unknown message id
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: vm: events: reorganize events
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: report network stats only if present
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: report disks stats only if present
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Ido Barkan has posted comments on this change.
Change subject: net: only backup ifcfg files if they are not already persisted.
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/43685
To unsubscribe, visit
1 - 100 of 270 matches
Mail list logo