Change in vdsm[master]: arbitrary_vlan_name: Fix network deletion

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: arbitrary_vlan_name: Fix network deletion .. Patch Set 4: * Update tracker::#1119182::OK * Check Bug-Url::OK * Check Public Bug::#1119182::OK, public bug

Change in vdsm[master]: v2v: enable to use external virtio drivers for virtio

2015-07-19 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: v2v: enable to use external virtio drivers for virtio .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/42996/2/vdsm/v2v.py File vdsm/v2v.py: Line 375:

Change in vdsm[master]: v2v: handle exception on probing external VMs

2015-07-19 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: v2v: handle exception on probing external VMs .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/43259/1//COMMIT_MSG Commit Message: Line 7: v2v: handle

Change in vdsm[master]: arbitrary_vlan_name: Fix network deletion

2015-07-19 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: arbitrary_vlan_name: Fix network deletion .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/30013 To unsubscribe, visit

Change in vdsm[master]: netinfo: Drop ifcfg reading from _getNetInfo

2015-07-19 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: netinfo: Drop ifcfg reading from _getNetInfo .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/35012 To unsubscribe, visit

Change in vdsm[master]: netinfo: Drop ifcfg reading from _getNetInfo

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: Drop ifcfg reading from _getNetInfo .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: net: remove redundant validation during network deletion

2015-07-19 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: remove redundant validation during network deletion .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/43710 To unsubscribe, visit

Change in vdsm[master]: net: remove redundant validation during network deletion

2015-07-19 Thread yzaspits
Yevgeny Zaspitsky has posted comments on this change. Change subject: net: remove redundant validation during network deletion .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/43710 To unsubscribe, visit

Change in vdsm[master]: net_tc: add support for mirroring all (not just IPv4) traffic

2015-07-19 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net_tc: add support for mirroring all (not just IPv4) traffic .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/27388 To unsubscribe, visit

Change in vdsm[master]: v2v: DRAFT: new verb convertFromFile

2015-07-19 Thread shavivi
Shahar Havivi has abandoned this change. Change subject: v2v: DRAFT: new verb convertFromFile .. Abandoned -- To view, visit https://gerrit.ovirt.org/42067 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: v2v: DRAFT: new verb convertFromFile

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: DRAFT: new verb convertFromFile .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/42067 To

Change in vdsm[master]: v2v: Import VM from OVA file

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: Import VM from OVA file .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: get VM information from OVA file

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: v2v: refactor create command

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: refactor create command .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: refactor create command

2015-07-19 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: refactor create command .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/42066 To unsubscribe, visit

Change in vdsm[master]: hooks: Removed comment about EL6 kernel

2015-07-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: hooks: Removed comment about EL6 kernel .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43794 To unsubscribe, visit

Change in vdsm[master]: executor: Set worker system name

2015-07-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: executor: Set worker system name .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/43788/1//COMMIT_MSG Commit Message: Line 14: Since

Change in vdsm[master]: hooks: Removed comment about EL6 kernel

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: hooks: Removed comment about EL6 kernel .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: hooks: Removed comment about EL6 kernel

2015-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: hooks: Removed comment about EL6 kernel .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43794 To unsubscribe, visit

Change in vdsm[master]: hooks: Removed comment about EL6 kernel

2015-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks: Removed comment about EL6 kernel .. hooks: Removed comment about EL6 kernel EL6 is no longer supported for VDSM, so the comment about not

Change in vdsm[master]: executor: Fix race when putting tasks

2015-07-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: executor: Fix race when putting tasks .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43789 To unsubscribe, visit

Change in vdsm[master]: executor: Fix thread-unsafe call

2015-07-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: executor: Fix thread-unsafe call .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/43790/2//COMMIT_MSG Commit Message: Line 7:

Change in vdsm[master]: vm: stats: do not send empty disks/networks

2015-07-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: stats: do not send empty disks/networks .. Patch Set 8: Verified+1 works. Verified with current master, since bulk stats are broken (see

Change in vdsm[master]: vm: event: send status event on reboot

2015-07-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: event: send status event on reboot .. Patch Set 16: Verified-1 works, but too much: the event is sent multiple times. Will investigate why it happens

Change in vdsm[master]: v2v: enable to use external virtio drivers for virtio

2015-07-19 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: enable to use external virtio drivers for virtio .. Patch Set 2: -Verified -- To view, visit https://gerrit.ovirt.org/42996 To unsubscribe, visit

Change in vdsm[master]: vm: events: reorganize events

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: events: reorganize events .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/43538 To

Change in vdsm[master]: vm: events: reorganize events

2015-07-19 Thread fromani
Francesco Romani has abandoned this change. Change subject: vm: events: reorganize events .. Abandoned We preferred the split series in the end. -- To view, visit https://gerrit.ovirt.org/43538 To unsubscribe, visit

Change in vdsm[master]: v2v: enable to use external virtio drivers for virtio

2015-07-19 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: enable to use external virtio drivers for virtio .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/42996 To unsubscribe, visit

Change in vdsm[master]: v2v: Try to be nicer to other processes

2015-07-19 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: v2v: Try to be nicer to other processes .. v2v: Try to be nicer to other processes Under the hood, virt-v2v is running qemu-img convert. We use high nice and

Change in vdsm[master]: v2v: Try to be nicer to other processes

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: Try to be nicer to other processes .. Patch Set 1: * Update tracker::#1243935::OK * Check Bug-Url::OK * Check Public Bug::#1243935::OK, public bug *

Change in vdsm[master]: concurrent: Add Barrier class

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: concurrent: Add Barrier class .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: rwlock: Support timed acquire

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: rwlock: Support timed acquire .. Patch Set 22: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: rwlock: Add simpler RWLock

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 16: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: net: remove redundant validation during network deletion

2015-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: remove redundant validation during network deletion .. Patch Set 3: Code-Review-1 could you change testSetupNetworksReconfigureBridge so that a tap device

Change in vdsm[master]: rwlock: Add simpler RWLock

2015-07-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 16: This version adds recursive locking, since testing vdsm with old lock show that we do use this feature (for example,

Change in vdsm[master]: rwlock: Support timed acquire

2015-07-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: rwlock: Support timed acquire .. Patch Set 22: Verified+1 -- To view, visit https://gerrit.ovirt.org/42909 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: rwlock: Support non-blocking acquire

2015-07-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: rwlock: Support non-blocking acquire .. Patch Set 19: Verified+1 -- To view, visit https://gerrit.ovirt.org/42928 To unsubscribe, visit

Change in vdsm[master]: rwlock: Replace misc.RWLock

2015-07-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: rwlock: Replace misc.RWLock .. Patch Set 12: Tested on rhel 7.1: - create template from vm - create vm from template - migrating vms - live storage migration from

Change in vdsm[master]: resourceManager: Avoid unneeded recursive locking

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: resourceManager: Avoid unneeded recursive locking .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: rwlock: Replace misc.RWLock

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: rwlock: Replace misc.RWLock .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: rwlock: Add simpler RWLock

2015-07-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 16: Verified+1 -- To view, visit https://gerrit.ovirt.org/42908 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: rwlock: Support non-blocking acquire

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: rwlock: Support non-blocking acquire .. Patch Set 19: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Add RWLock tests

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Add RWLock tests .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: virt: before_vm_migrate_source hook point moved

2015-07-19 Thread mmirecki
Marcin Mirecki has uploaded a new change for review. Change subject: virt: before_vm_migrate_source hook point moved .. virt: before_vm_migrate_source hook point moved The hook before_vm_migrate_source was invoked only after

Change in vdsm[master]: virt: before_vm_migrate_source hook point moved

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: virt: before_vm_migrate_source hook point moved .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: net: remove redundant validation during network deletion

2015-07-19 Thread yzaspits
Yevgeny Zaspitsky has posted comments on this change. Change subject: net: remove redundant validation during network deletion .. Patch Set 3: -Verified -- To view, visit https://gerrit.ovirt.org/43710 To unsubscribe, visit

Change in vdsm[master]: executor: Fix race when putting tasks

2015-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: executor: Fix race when putting tasks .. Patch Set 1: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/43789 To unsubscribe, visit

Change in vdsm[master]: executor: Fix race when putting tasks

2015-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: executor: Fix race when putting tasks .. executor: Fix race when putting tasks When putting tasks into a TaskQueue, we used check the current number

Change in vdsm[master]: executor: Fix race when putting tasks

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: executor: Fix race when putting tasks .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: executor: Fix thread-unsafe call

2015-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: executor: Fix thread-unsafe call .. Patch Set 2: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/43790 To unsubscribe, visit

Change in vdsm[master]: executor: Fix thread-unsafe call

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: executor: Fix thread-unsafe call .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: executor: Fix thread-unsafe call

2015-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: executor: Fix thread-unsafe call .. executor: Fix thread-unsafe call Deques support thread-safe, appends and pops from either side of the deque, but

Change in vdsm[master]: net: remove redundant validation during network deletion

2015-07-19 Thread yzaspits
Yevgeny Zaspitsky has posted comments on this change. Change subject: net: remove redundant validation during network deletion .. Patch Set 3: Verified-1 Vdsm doesn't allow adding vlan tagging to the network that is used by

Change in vdsm[master]: v2v: Try to be nicer to other processes

2015-07-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: Try to be nicer to other processes .. Patch Set 2: This version fixes wrong parameter name. -- To view, visit https://gerrit.ovirt.org/43817 To unsubscribe,

Change in vdsm[master]: v2v: Try to be nicer to other processes

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: Try to be nicer to other processes .. Patch Set 2: * Update tracker::#1243935::OK * Check Bug-Url::OK * Check Public Bug::#1243935::OK, public bug *

Change in vdsm[master]: executor: Set worker system name

2015-07-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: executor: Set worker system name .. Patch Set 1: Tested on rhel 7.1 using htop. -- To view, visit https://gerrit.ovirt.org/43788 To unsubscribe, visit

Change in vdsm[master]: periodic: Use thread names that can be used as system thread...

2015-07-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: periodic: Use thread names that can be used as system thread names .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/43819 To unsubscribe,

Change in vdsm[master]: periodic: Use thread names that can be used as system thread...

2015-07-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: periodic: Use thread names that can be used as system thread names .. Patch Set 1: Tested on rhel 7.1 using htop. -- To view, visit

Change in vdsm[master]: executor: Set worker system name

2015-07-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: executor: Set worker system name .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/43788 To unsubscribe, visit

Change in vdsm[master]: periodic: Use thread names that can be used as system thread...

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: periodic: Use thread names that can be used as system thread names .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no

Change in vdsm[master]: periodic: Use thread names that can be used as system thread...

2015-07-19 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: periodic: Use thread names that can be used as system thread names .. periodic: Use thread names that can be used as system thread names Using new executor

Change in vdsm[master]: periodic: Use thread names that can be used as system thread...

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: periodic: Use thread names that can be used as system thread names .. Patch Set 2: * Update tracker::#1141422::OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

2015-07-19 Thread shtripat
Shubhendu Tripathi has uploaded a new change for review. Change subject: gluster: Added VDSM verb to stop gluster related processes .. gluster: Added VDSM verb to stop gluster related processes Added a verb which stops the

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: executor: Fix thread-unsafe call

2015-07-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: executor: Fix thread-unsafe call .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/43790 To unsubscribe, visit