Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/44011
to review the following change.
Change subject: fc-connect-server: Support FCP on connect server
..
fc-connect-server: Supp
automat...@ovirt.org has posted comments on this change.
Change subject: fc-connect-server: Move call to refreshStorage
..
Patch Set 1:
* Update tracker::#1242200::OK
* Check Bug-Url::OK
* Check Public Bug::#1242200::OK, public
automat...@ovirt.org has posted comments on this change.
Change subject: fc-connect-server: Support FCP on connect server
..
Patch Set 1:
* Update tracker::#1242200::OK
* Check Bug-Url::OK
* Check Public Bug::#1242200::OK, publ
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/44010
to review the following change.
Change subject: fc-connect-server: Add FcpConnection class
..
fc-connect-server: Add FcpCon
automat...@ovirt.org has posted comments on this change.
Change subject: fc-connect-server: Add FcpConnection class
..
Patch Set 1:
* Update tracker::#1242200::OK
* Check Bug-Url::OK
* Check Public Bug::#1242200::OK, public bug
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/44009
to review the following change.
Change subject: fc-connect-server: Move call to refreshStorage
..
fc-connect-server: Move c
Freddy Rolland has posted comments on this change.
Change subject: fc-connect-server: Move call to refreshStorage
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44009
To unsubscribe, visit https://gerrit
Freddy Rolland has posted comments on this change.
Change subject: fc-connect-server: Add FcpConnection class
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44010
To unsubscribe, visit https://gerrit.ovi
Freddy Rolland has posted comments on this change.
Change subject: fc-connect-server: Support FCP on connect server
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44011
To unsubscribe, visit https://gerr
Michal Skrivanek has posted comments on this change.
Change subject: Removing prefix definition for qemu-kvm-ev
..
Patch Set 1: Code-Review+1
(1 comment)
one more place
https://gerrit.ovirt.org/#/c/43993/1/vdsm.spec.in
File v
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Only filter guest agent data, only on XMLRPC
..
Patch Set 17:
(3 comments)
https://gerrit.ovirt.org/#/c/36949/17/vdsm/virt/guestagent.py
File vdsm/virt
Michal Skrivanek has posted comments on this change.
Change subject: fakevmstats: add config entry to enable/disable the hook
..
Patch Set 4: Code-Review+1
@ybronhei: AFAIK this is the only one which actually does something wit
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Only filter guest agent data, only on XMLRPC
..
Patch Set 17:
(2 comments)
@nsoffer:
I personally do not have the profiling data. It was brought to my
Ido Barkan has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 11: Code-Review-1
(4 comments)
cool.
-1 just for visibility. mostly nits.
https://gerrit.ovirt.org/#/c/42927/11/lib/vds
Yaniv Bronhaim has posted comments on this change.
Change subject: Revised the format of output from the vdsm-tool vdsm-id command.
..
Patch Set 1: Code-Review+1 Verified+1
--
To view, visit https://gerrit.ovirt.org/34583
To u
Ido Barkan has posted comments on this change.
Change subject: tests: Add RWLock tests
..
Patch Set 13:
(4 comments)
nits
https://gerrit.ovirt.org/#/c/42907/13/tests/rwlock_test.py
File tests/rwlock_test.py:
Line 48:
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
automat...@ovirt.org has posted comments on this change.
Change subject: Removing prefix definition for qemu-kvm-ev
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
automat...@ovirt.org has posted comments on this change.
Change subject: Renaming policycoreutils-python dependency for fedora 23 and
above
..
Patch Set 1:
* Update tracker::#1246626::OK
* Check Bug-Url::OK
* Check Public Bug:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Renaming policycoreutils-python dependency for fedora 23 and
above
..
Renaming policycoreutils-python dependency for fedora 23 and above
The utilities of poli
automat...@ovirt.org has posted comments on this change.
Change subject: fakevmstats: add config entry to enable/disable the hook
..
Patch Set 5:
* Update tracker::#1240298::OK
* Check Bug-Url::OK
* Check Public Bug::#1240298::
Omer Frenkel has posted comments on this change.
Change subject: virt: Change state of the agent only after heartbeat processing
..
Patch Set 1: Verified+1
verified with latest engine - up event contains guest agent data
--
T
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/42927/11/lib/vdsm/concurrent.py
File lib/vdsm/concurrent.py:
Line 57:
Li
Ido Barkan has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/42927/11/lib/vdsm/concurrent.py
File lib/vdsm/concurrent.py:
Line 73:
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Add RWLock tests
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug
automat...@ovirt.org has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 17:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
automat...@ovirt.org has posted comments on this change.
Change subject: resourceManager: Avoid unneeded recursive locking
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
automat...@ovirt.org has posted comments on this change.
Change subject: rwlock: Support non-blocking acquire
..
Patch Set 20:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: rwlock: Replace misc.RWLock
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: rwlock: Support timed acquire
..
Patch Set 23:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/42927/11/tests/concurrentTests.py
File tests/concurrentTests.py:
Line 60:
Ido Barkan has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43891
To unsubscribe, visit https://gerrit.
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/42927/11/lib/vdsm/concurrent.py
File lib/vdsm/concurrent.py:
Line 73:
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 12: Verified+1
This version improve readability and documentation.
--
To view, visit https://gerrit.ovirt.org/42927
To
Ido Barkan has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 16:
(5 comments)
https://gerrit.ovirt.org/#/c/42908/16/lib/vdsm/rwlock.py
File lib/vdsm/rwlock.py:
Line 39: lock.r
Nir Soffer has posted comments on this change.
Change subject: tests: Add RWLock tests
..
Patch Set 13:
(4 comments)
https://gerrit.ovirt.org/#/c/42907/13/tests/rwlock_test.py
File tests/rwlock_test.py:
Line 48: f
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Change state of the agent only after heartbeat processing
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43859/1//COMMIT_MSG
Commit Message:
Nir Soffer has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 16:
(5 comments)
https://gerrit.ovirt.org/#/c/42908/16/lib/vdsm/rwlock.py
File lib/vdsm/rwlock.py:
Line 39: lock.r
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Change state of the agent only after heartbeat processing
..
virt: Change state of the agent only after heartbeat processing
Until now we have be
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Change state of the agent only after heartbeat processing
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-
Dan Kenigsberg has posted comments on this change.
Change subject: virt: Change state of the agent only after heartbeat processing
..
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/43859/1//COMMIT_MSG
Comm
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
Ido Barkan has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 16:
(3 comments)
https://gerrit.ovirt.org/#/c/42908/16/lib/vdsm/rwlock.py
File lib/vdsm/rwlock.py:
Line 39: lock.r
Nir Soffer has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/42908/16/lib/vdsm/rwlock.py
File lib/vdsm/rwlock.py:
Line 135:
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: improve which ipv4 addr is reported.
..
Patch Set 8: Code-Review-1
(1 comment)
nit
https://gerrit.ovirt.org/#/c/33375/8/lib/vdsm/netlink/addr.py
File
Ido Barkan has posted comments on this change.
Change subject: rwlock: Replace misc.RWLock
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43423
To unsubscribe, visit https://gerrit.ovirt.org/settings
Dan Kenigsberg has posted comments on this change.
Change subject: net: fix
testSetupNetworksDeletesTheBridgeOnlyWhenItIsReconfigured
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/43995/3/tests/functi
Ido Barkan has posted comments on this change.
Change subject: rwlock: Support non-blocking acquire
..
Patch Set 20: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42928
To unsubscribe, visit https://gerrit.ovirt.org
Ido Barkan has posted comments on this change.
Change subject: rwlock: Support non-blocking acquire
..
Patch Set 20:
can we just drop this patch and use the next one?
--
To view, visit https://gerrit.ovirt.org/42928
To unsubs
Ido Barkan has posted comments on this change.
Change subject: rwlock: Support timed acquire
..
Patch Set 23: Code-Review+1
can we just squash this ti the former patch?
--
To view, visit https://gerrit.ovirt.org/42909
To unsu
automat...@ovirt.org has posted comments on this change.
Change subject: net: fix
testSetupNetworksDeletesTheBridgeOnlyWhenItIsReconfigured
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no b
Petr Horáček has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 8: Verified+1
Passed network functional tests with ifcfg and unified persistence without a
regression
Ido Barkan has posted comments on this change.
Change subject: net: fix
testSetupNetworksDeletesTheBridgeOnlyWhenItIsReconfigured
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/43995/3/tests/functional/networkTests.
Ido Barkan has posted comments on this change.
Change subject: net: fix
testSetupNetworksDeletesTheBridgeOnlyWhenItIsReconfigured
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/43995
To unsubscribe, vis
Ido Barkan has abandoned this change.
Change subject: More logging for missing nics.
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/41782
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: ab
automat...@ovirt.org has posted comments on this change.
Change subject: More logging for missing nics.
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/41782
To unsubscrib
Nir Soffer has posted comments on this change.
Change subject: rwlock: Support timed acquire
..
Patch Set 23:
We can squash this into the former patch. I'm keeping it separate in case Dan
prefer the simpler solution.
--
To v
automat...@ovirt.org has posted comments on this change.
Change subject: netinfo: improve which ipv4 addr is reported.
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Ido Barkan has posted comments on this change.
Change subject: netinfo: improve which ipv4 addr is reported.
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/33375/8/lib/vdsm/netlink/addr.py
File lib/vdsm/netlink/addr.
Ido Barkan has posted comments on this change.
Change subject: netinfo: improve which ipv4 addr is reported.
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/33375
To unsubscribe, visit https://gerrit.ovir
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
Ido Barkan has posted comments on this change.
Change subject: tests: Add RWLock tests
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/42907/13/tests/rwlock_test.py
File tests/rwlock_test.py:
Line 148:
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Nir Soffer has posted comments on this change.
Change subject: tests: Add RWLock tests
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/42907/13/tests/rwlock_test.py
File tests/rwlock_test.py:
Line 148:
Dan Kenigsberg has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/43891/9/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Dan Kenigsberg has uploaded a new change for review.
Change subject: remove double whitespace after commas
..
remove double whitespace after commas
Change-Id: I9e88bd78afddf6a835600e45d127e2bdbe0a0d7f
Signed-off-by: Dan Kenigsbe
automat...@ovirt.org has posted comments on this change.
Change subject: remove double whitespace after commas
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Petr Horáček has uploaded a new change for review.
Change subject: net: configurators: persist custom bond option
..
net: configurators: persist custom bond option
Until now, custom bond property was exposed only to
before_netwo
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 1: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one
Petr Horáček has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 11:
From Patchset 8:
Passed network functional tests with ifcfg and unified persistence without a
re
Dan Kenigsberg has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43891
To unsubscribe, visit https://ge
automat...@ovirt.org has posted comments on this change.
Change subject: net: bonding: validate options based on pre-dumped ones
..
Patch Set 3:
* Update tracker::#1234867::OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::O
Dan Kenigsberg has posted comments on this change.
Change subject: remove double whitespace after commas
..
Patch Set 1: Verified+1
gitpydiff is happy
--
To view, visit https://gerrit.ovirt.org/44021
To unsubscribe, visit htt
automat...@ovirt.org has posted comments on this change.
Change subject: network: allow custom bondOption
..
Patch Set 3:
* Update tracker::#1234867::OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check P
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 2: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one
Nir Soffer has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 17: Code-Review-1
Replace "wakeup" with other term so we can avoid using "wake_up".
--
To view, visit https://gerrit.ovirt
Ido Barkan has uploaded a new change for review.
Change subject: fix pep8
..
fix pep8
Change-Id: I4e0d9c4fc179825e9d14b4787e65b77dcfec59d7
Signed-off-by: Ido Barkan
---
M tests/functional/networkTests.py
1 file changed, 4 inser
automat...@ovirt.org has posted comments on this change.
Change subject: fix pep8
..
Patch Set 1: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is required for the stable br
Yaniv Bronhaim has uploaded a new change for review.
Change subject: remove redundant rhev_build_config_opt global
..
remove redundant rhev_build_config_opt global
Change-Id: Id35d43e51de308f132de13f7ed1a6aa1b445f944
Signed-off-
automat...@ovirt.org has posted comments on this change.
Change subject: remove redundant rhev_build_config_opt global
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Roman Mohr has uploaded a new change for review.
Change subject: tcTests: Fix problem of left over bridges
..
tcTests: Fix problem of left over bridges
For unknown reason the command which should shut down the bridge fails
to do
automat...@ovirt.org has posted comments on this change.
Change subject: tcTests: Fix problem of left over bridges
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Roman Mohr has posted comments on this change.
Change subject: tcTests: Fix problem of left over bridges
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44028
To unsubscribe, visit https://gerrit.ovirt.or
automat...@ovirt.org has posted comments on this change.
Change subject: Remove redundant rhev_build_config_opt global
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove redundant rhev_build_config_opt global
..
Patch Set 2: Verified+1
(1 comment)
https://gerrit.ovirt.org/#/c/44027/2/vdsm.spec.in
File vdsm.spec.in:
Line
Roman Mohr has posted comments on this change.
Change subject: tcTests: Fix problem of left over bridges
..
Patch Set 1:
To reproduce the issue, just run
while true; do ../tests/run_tests_local.sh tcTests.py ;done
The number
Dan Kenigsberg has posted comments on this change.
Change subject: tcTests: Fix problem of left over bridges
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/44028/1/tests/tcTests.py
File tests/tcTests.p
Dan Kenigsberg has submitted this change and it was merged.
Change subject: remove double whitespace after commas
..
remove double whitespace after commas
Change-Id: I9e88bd78afddf6a835600e45d127e2bdbe0a0d7f
Signed-off-by: Dan
automat...@ovirt.org has posted comments on this change.
Change subject: remove double whitespace after commas
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, v
Dan Kenigsberg has posted comments on this change.
Change subject: remove double whitespace after commas
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44021
To unsubscribe, visit https://gerrit.ovirt
Roman Mohr has posted comments on this change.
Change subject: tcTests: Fix problem of left over bridges
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/44028/1/tests/tcTests.py
File tests/tcTests.py:
Line 106:
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 3: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one
Dan Kenigsberg has posted comments on this change.
Change subject: Remove redundant rhev_build_config_opt global
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44027
To unsubscribe, visit https://gerr
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove redundant rhev_build_config_opt global
..
Remove redundant rhev_build_config_opt global
By mistake this part of code was left after
https://gerr
automat...@ovirt.org has posted comments on this change.
Change subject: Remove redundant rhev_build_config_opt global
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
automat...@ovirt.org has posted comments on this change.
Change subject: Renaming policycoreutils-python dependency for fedora 23 and
above
..
Patch Set 2:
* Update tracker::#1246626::OK
* Check Bug-Url::OK
* Check Public Bug:
automat...@ovirt.org has posted comments on this change.
Change subject: tcTests: Fix problem of left over bridges
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Dan Kenigsberg has posted comments on this change.
Change subject: Renaming policycoreutils-python dependency for fedora 23 and
above
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44019/1//COMMIT_MSG
Commit Message
1 - 100 of 182 matches
Mail list logo
