Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: Add --ca-file option
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44576
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storage: don't chmod local storage symlink
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/6/2//COMMIT_MSG
Commit Message:
Line 14:
Nir Soffer has posted comments on this change.
Change subject: storage: validate vdsm rwx permissions for file storage
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/2
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: register: Add --ca-file option
..
register: Add --ca-file option
Currently, we storage the Engine ca file in /etc/ovirt-engine/ca.pem
which is not
automat...@ovirt.org has posted comments on this change.
Change subject: register: Add --vdsm-uuid option
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 1:
OK. Let's have runtime option.
--
To view, visit https://gerrit.ovirt.org/44494
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: make sure to send error message when no subscription
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/43724/2/lib/yajsonrpc/stompreactor.py
Francesco Romani has posted comments on this change.
Change subject: vm: Improve error handling when Vm._dom is None
..
Patch Set 2: Code-Review+1
looks good, preliminar ACK
--
To view, visit https://gerrit.ovirt.org/43225
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: updating for VDSM 4.17 on Debian jessie
..
Patch Set 32: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/37737
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: sampling: Handle numa nodes with zero memory assigned
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44121
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: sampling: Handle numa nodes with zero memory assigned
..
Patch Set 4:
thanks for the updates!
--
To view, visit https://gerrit.ovirt.org/44121
To
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: allow to mock monotonic_time method
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/43745/1/lib/yajsonrpc/stomp.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: Handle numa nodes with zero memory assigned
..
Patch Set 3:
* Update tracker::#1247058::OK
* Check Bug-Url::OK
* Check Public
Roman Mohr has posted comments on this change.
Change subject: sampling: Handle numa nodes with zero memory assigned
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/44121
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: WIP: RFC: add ResourceTracker
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44543/1/vdsm/virt/utils.py
File vdsm/virt/utils.py:
Line 126: class
Francesco Romani has posted comments on this change.
Change subject: WIP: RFC: track domain availability
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/44544/1/vdsm/virt/periodic.py
File vdsm/virt/periodic.py:
Dan Kenigsberg has posted comments on this change.
Change subject: register: Add --persist-uuid
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44431/1/lib/vdsm/tool/register.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: kill Vm.isDomainReadyForCommands()
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: Handle numa nodes with zero memory assigned
..
Patch Set 4:
* Update tracker::#1247058::OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: factor out periodic operations
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: track domain availability
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: add ResourceTracker
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: ignore unknown message id
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43746/1/lib/yajsonrpc/__init__.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2:
Will fix Nir's comments
--
To view, visit https://gerrit.ovirt.org/43759
To unsubscribe, visit
Ondřej Svoboda has posted comments on this change.
Change subject: net: monitor: validate passed groups argument
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/44530/2/lib/vdsm/netlink/monitor.py
File
Francesco Romani has posted comments on this change.
Change subject: sampling: Handle numa nodes with zero memory assigned
..
Patch Set 3: Code-Review+2
(1 comment)
thanks for the updates.
Roman Mohr has posted comments on this change.
Change subject: sampling: Handle numa nodes with zero memory assigned
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/44121/2/vdsm/virt/sampling.py
File
Roman Mohr has posted comments on this change.
Change subject: sampling: Handle numa nodes with zero memory assigned
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/44121/3/tests/samplingTests.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: make VmDispatcher ignore TooManyTasks
..
Patch Set 23:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: track domain availability
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: fine-grained KeyError handling
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has uploaded a new change for review.
Change subject: WIP: RFC: track domain availability
..
WIP: RFC: track domain availability
Do not rely on isDomainReadyForCommands:
it can actually make things worse on
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: track domain availability
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/44401
To
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: executor: add ondiscard callback
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has abandoned this change.
Change subject: WIP: RFC: track domain availability
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/44401
To unsubscribe, visit https://gerrit.ovirt.org/settings
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: kill Vm.isDomainReadyForCommands()
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: add ResourceTracker
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Roman Mohr has posted comments on this change.
Change subject: sampling: Handle numa nodes with zero memory assigned
..
Patch Set 5:
Indeed. Might even go into 3.5. Cherry picked on 3.6
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: Handle numa nodes with zero memory assigned
..
Patch Set 5:
* Update tracker::#1247058::OK
* Set MODIFIED::bug 1247058#1247058IGNORE,
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: factor out periodic operations
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: executor: add ondiscard callback
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: add ResourceTracker
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: kill Vm.isDomainReadyForCommands()
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: track domain availability
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sampling: Handle numa nodes with zero memory assigned
..
sampling: Handle numa nodes with zero memory assigned
Fix zero division when a numa node has
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: Handle numa nodes with zero memory assigned
..
Patch Set 5:
I suspect this needs bacporting to 3.6
--
To view, visit https://gerrit.ovirt.org/44121
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: Handle numa nodes with zero memory assigned
..
Patch Set 1:
* Update tracker::#1247058::OK
* Check Bug-Url::OK
* Check Public
Roman Mohr has uploaded a new change for review.
Change subject: sampling: Handle numa nodes with zero memory assigned
..
sampling: Handle numa nodes with zero memory assigned
Fix zero division when a numa node has zero memory
Roman Mohr has posted comments on this change.
Change subject: sampling: Handle numa nodes with zero memory assigned
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44550
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: network: add ifcfg write hook
..
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/44552/1//COMMIT_MSG
Commit Message:
Line 11: executing
Adam Litke has uploaded a new change for review.
Change subject: storage: Add garbage indicator to BlockSDVol namedtuple
..
storage: Add garbage indicator to BlockSDVol namedtuple
Change-Id:
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move simple metadata getters and setters
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases
..
Patch Set 17:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: move newMetadata
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Introduce class structure
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has uploaded a new change for review.
Change subject: StorageDomainManifest: Move imageGarbageCollector
..
StorageDomainManifest: Move imageGarbageCollector
Change-Id: I6d608bed1a7add239aca3ffe96d9e9a118799511
Adam Litke has uploaded a new change for review.
Change subject: storage: Do not count garbage volumes as children
..
storage: Do not count garbage volumes as children
Change-Id: Ice3c70249cbc3577b239bd11d224955f2e29b211
Adam Litke has uploaded a new change for review.
Change subject: StorageDomain: Add get_manifest
..
StorageDomain: Add get_manifest
Change-Id: I4a7ebd209a77bea90b2b6f306c85a146923f15c6
Signed-off-by: Adam Litke
automat...@ovirt.org has posted comments on this change.
Change subject: sdm: Add decorators for sdm-only functions and their callers
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Adam Litke has uploaded a new change for review.
Change subject: storage: Introduce LV tag to ID garbage volumes
..
storage: Introduce LV tag to ID garbage volumes
Change-Id: I1ca42dd9cab0b2702efa46868dae5510c1eadca1
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: move validateDelete
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has uploaded a new change for review.
Change subject: fix remove: iterate while del
..
fix remove: iterate while del
Change-Id: I594c98cf54ed93d045b76df1c6faa5122277b19e
Signed-off-by: Adam Litke ali...@redhat.com
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN,
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: volume share utilities
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: sdc: Allow StorageDomainCache to cache StorageDomainManifest
objects
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN,
automat...@ovirt.org has posted comments on this change.
Change subject: clusterlock: Add reference counting
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: ImageManifest: create_image_dir
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: XXX: Insert sleep when creating block SD
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has uploaded a new change for review.
Change subject: FileStorageDomainManifest: move getVSize
..
FileStorageDomainManifest: move getVSize
An earlier patch moved getVSize only for BlockStorageDomainManifest
objects.
automat...@ovirt.org has posted comments on this change.
Change subject: register: Add --vdsm-uuid
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: ImageManifest: introduce ImageManifest class
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Factor out getAllVolumes
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Rename _share to share_to_image
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move getParentVolume
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Rename getParent to getParentId
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: storage: simplify hasVolumeLeases
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move getImageVolumes
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Introduce LV tag to ID garbage volumes
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Francesco Romani has posted comments on this change.
Change subject: WIP: RFC: track domain availability
..
Patch Set 4:
(4 comments)
https://gerrit.ovirt.org/#/c/44544/4/vdsm/virt/periodic.py
File vdsm/virt/periodic.py:
Francesco Romani has posted comments on this change.
Change subject: WIP: RFC: add ResourceTracker
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/44543/4/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Line 143:
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Rename getParentVolume* to produceParent
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: ImageManifest: move getChain
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move the getParent API
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move recheckIfLeaf into *Metadata class
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Do not count garbage volumes as children
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Adam Litke has posted comments on this change.
Change subject: FileStorageDomainManifest: move getVSize
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44564
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: move extend and extendVolume
..
Patch Set 16:
I'm splitting the intricate tests from this patch in order to speed the
inclusion of the
Adam Litke has uploaded a new change for review.
Change subject: FileVolumeMetadata: split getMetadata
..
FileVolumeMetadata: split getMetadata
Change-Id: I1d3fb61831de5b50a3e562b80bf38ef15ede254f
Signed-off-by: Adam Litke
Adam Litke has uploaded a new change for review.
Change subject: fix: validate volumemetadata objects
..
fix: validate volumemetadata objects
Change-Id: I8330bb23c8109cee472904bde63caa75d10c0240
Signed-off-by: Adam Litke
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move getInfo and getVolumeParams
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Metadata read utils
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: Move getRepoPath and other metadata
getters
..
Patch Set 17:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: move image and volume enumeration
..
Patch Set 17:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: move getVolumeSize
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: lvm: Allow multiple initial tags when creating an LV
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: metadata write utils
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: move extend and extendVolume
..
Patch Set 17:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: move prepare and teardown
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: move refreshVolume
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
1 - 100 of 146 matches
Mail list logo