Dima Kuznetsov has posted comments on this change.
Change subject: spmprotect: Switch from fencing by pid to fencing using
systemctl
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/43211/7/vdsm/storage/protect/spmpro
Piotr Kliczewski has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44894
To unsubscribe, visit https:
Piotr Kliczewski has posted comments on this change.
Change subject: oop: close ioprocesses on vdsmd stop
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit https://gerrit.ovir
Piotr Kliczewski has posted comments on this change.
Change subject: concurrent: Use new concurrent.thread() utility
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44895
To unsubscribe, visit https://
Piotr Kliczewski has posted comments on this change.
Change subject: tool: Cleanup configurators imports
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44859
To unsubscribe, visit https://gerrit.ovirt
Piotr Kliczewski has posted comments on this change.
Change subject: tests: functional - convert to run over jsonrpc
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43237
To unsubscribe, visit https:/
Piotr Kliczewski has posted comments on this change.
Change subject: tests: functional - convert to run over jsonrpc
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43237
To unsubscribe, visit https:/
automat...@ovirt.org has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Adam Litke has posted comments on this change.
Change subject: v2v: use the response module
..
Patch Set 25: Code-Review-1
Please consider taking https://gerrit.ovirt.org/#/c/44857 instead which
accomplishes the same as this p
Adam Litke has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 2:
(27 comments)
https://gerrit.ovirt.org/#/c/44857/2/tests/jobsTests.py
File tests/jobsTests.py:
Line 19:
Line 20
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/45058
to review the following change.
Change subject: Live Merge: Fix pre-extension calculation for chunked drives
..
Live Merge: F
automat...@ovirt.org has posted comments on this change.
Change subject: Live Merge: Fix pre-extension calculation for chunked drives
..
Patch Set 1:
* Update tracker::#1240360::OK
* Check Bug-Url::OK
* Check Public Bug::#12403
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 2: Code-Review-1
(27 comments)
Looks good, see inline comments.
https://gerrit.ovirt.org/#/c/44857/2/tests/jobsTest
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: move image and volume enumeration
..
Patch Set 23:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: deleteImage and deps
..
Patch Set 23:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: Move getRepoPath and other metadata
getters
..
Patch Set 23:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: move extend and extendVolume
..
Patch Set 23:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
Douglas Schilling Landgraf has posted comments on this change.
Change subject: oop: close ioprocesses on vdsmd stop
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit https://g
Fabian Deutsch has posted comments on this change.
Change subject: oop: close ioprocesses on vdsmd stop
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/45038/1/vdsm/storage/outOfProcess.py
File vdsm/stor
automat...@ovirt.org has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: move image and volume enumeration
..
Patch Set 22: Verified+1
--
To view, visit https://gerrit.ovirt.org/42269
To unsubscribe, visit https:/
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: deleteImage and deps
..
Patch Set 22: Verified+1
--
To view, visit https://gerrit.ovirt.org/42268
To unsubscribe, visit https://gerrit.ovirt
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: move extend and extendVolume
..
Patch Set 22: Verified+1
--
To view, visit https://gerrit.ovirt.org/42266
To unsubscribe, visit https://gerr
Ala Hino has posted comments on this change.
Change subject: gluster: Report glusterfs-cli package details
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/44581
To unsubscribe, visit https://gerrit.ovirt.
automat...@ovirt.org has posted comments on this change.
Change subject: virt: add VmTracker (RFC)
..
Patch Set 10:
* Update tracker::#1250839::OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
* Check Product
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: track domain availability (RFC)
..
Patch Set 11:
* Update tracker::#1250839::OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
automat...@ovirt.org has posted comments on this change.
Change subject: virt: cosmetic fixes
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url
Nir Soffer has posted comments on this change.
Change subject: multipath: Replace specific device sections with all_devs
section
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/44855
To unsubscribe, visi
Nir Soffer has posted comments on this change.
Change subject: multipath: Remove unneeded "features" configuration
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/44943
To unsubscribe, visit https://gerri
automat...@ovirt.org has posted comments on this change.
Change subject: multipath: Replace specific device sections with all_devs
section
..
Patch Set 4:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#880738::E
automat...@ovirt.org has posted comments on this change.
Change subject: multipath: Remove unneeded "features" configuration
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: Report glusterfs-cli package details
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44581
To unsubscribe, visit https://gerr
Tal Nisan has posted comments on this change.
Change subject: spmprotect: Switch from fencing by pid to fencing using
systemctl
..
Patch Set 7:
Dima, there is a comment waiting for you reply here
--
To view, visit https://ge
automat...@ovirt.org has posted comments on this change.
Change subject: virt: make virdomain.Notifying inherit from object
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
automat...@ovirt.org has posted comments on this change.
Change subject: virt: periodic: avoid NotConnectedError noise
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: virt: introduce virdomain module
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: track domain availability
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Yeela Kaplan has posted comments on this change.
Change subject: oop: close ioprocesses on vdsmd stop
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit https://gerrit.ovirt.org/s
automat...@ovirt.org has posted comments on this change.
Change subject: virt: cosmetic fixes
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: make runnable a method
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: virt: rename {Notifying,Disconnected}VirDomain
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
automat...@ovirt.org has posted comments on this change.
Change subject: virt: periodic: factor out periodic operations
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: make VmDispatcher ignore TooManyTasks
..
Patch Set 30:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Yeela Kaplan has uploaded a new change for review.
Change subject: oop: close ioprocesses on vdsmd stop
..
oop: close ioprocesses on vdsmd stop
Send SIGTERM only to main vdsm service.
All child processes will be closed as part o
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: virt: add VmTracker
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: handle known-missing stats
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: oop: close ioprocesses on vdsmd stop
..
Patch Set 1:
* Update tracker::#1189200::OK
* Check Bug-Url::OK
* Check Public Bug::#1189200::OK, public bug
* Che
Allon Mureinik has posted comments on this change.
Change subject: multipath: Use tuple for constant data
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44865
To unsubscribe, visit https://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: multipath: Keep tags sorted from newer to older
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44864
To unsubscribe, visit https://ge
Allon Mureinik has posted comments on this change.
Change subject: multiapth: Reorganize constants and improve documentation
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44863
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: multipath: Reformat old tags list
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44862
To unsubscribe, visit https://gerrit.ovirt.org
Nir Soffer has posted comments on this change.
Change subject: multipath: Remove unneeded "features" configuration
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/44943/2//COMMIT_MSG
Commit Message:
Line 21:
Line 22
Nir Soffer has posted comments on this change.
Change subject: multipath: Remove unneeded "features" configuration
..
Patch Set 2:
Needs a bug for 3.6
--
To view, visit https://gerrit.ovirt.org/44943
To unsubscribe, visit htt
Allon Mureinik has posted comments on this change.
Change subject: multipath: Remove unneeded "features" configuration
..
Patch Set 2: Code-Review+1
Please open a 3.6 bug for this so it can be backported to the stable branch.
Nir Soffer has posted comments on this change.
Change subject: makefile: Run pep8/pyflakes inside virtualenv
..
Patch Set 2:
(2 comments)
Looks ok, but this makes the makefile even worse.
I think we should evaluate doing this
automat...@ovirt.org has posted comments on this change.
Change subject: net: fix start_devices.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
Ido Barkan has uploaded a new change for review.
Change subject: net: fix start_devices.
..
net: fix start_devices.
a device named bond9.99 is a vlan device, not a bond.
Change-Id: I0b41e1d9c0910cb7a502e09f788db9f842b82ac7
Sign
automat...@ovirt.org has posted comments on this change.
Change subject: net: fix start_devices.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
Ido Barkan has uploaded a new change for review.
Change subject: net: fix start_devices.
..
net: fix start_devices.
a device named bond9.99 is a vlan device, not a bond.
Change-Id: I51ac5f38d8bf240ffa829a9f0e7f1fc6606ac553
Sign
automat...@ovirt.org has posted comments on this change.
Change subject: net: create bond properly during start_devices
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
T
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: create bond properly during start_devices
..
net: create bond properly during start_devices
This method, that is used during networks rollback, ca
Dan Kenigsberg has posted comments on this change.
Change subject: net: create bond properly during start_devices
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45028
To unsubscribe, visit https://ger
Dan Kenigsberg has posted comments on this change.
Change subject: net: create bond properly during start_devices
..
Patch Set 2: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/45028
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: create bond properly during start_devices
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/45028
To unsubscribe, visit https://gerrit.ovi
automat...@ovirt.org has posted comments on this change.
Change subject: net: create bond properly during start_devices
..
Patch Set 2: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one
Francesco Romani has posted comments on this change.
Change subject: readd back "jsonrpc: StoragePool_updateVMs"
..
Patch Set 1:
to minimize the mess:
- add Bug-Url ?
- add something like Original-Change-Id ?
--
To view, vis
Francesco Romani has posted comments on this change.
Change subject: readd back "jsonrpc: StoragePool_removeVM"
..
Patch Set 1:
to minimize the mess:
- add Bug-Url ?
- add something like Original-Change-Id ?
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Add RWLock tests
..
Patch Set 18:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://
automat...@ovirt.org has posted comments on this change.
Change subject: multipath: Use more meaningful names
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Add RWLock tests
..
tests: Add RWLock tests
Current RWLock looks too complex and has no tests. This patch fixes the
later issue, so we can safel
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: move image and volume enumeration
..
Patch Set 22:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: Move getRepoPath and other metadata
getters
..
Patch Set 22:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
Dan Kenigsberg has submitted this change and it was merged.
Change subject: multipath: Use more meaningful names
..
multipath: Use more meaningful names
Since we are in the context of the multipath module, the MPATH or
MPATH_CO
Dan Kenigsberg has posted comments on this change.
Change subject: multipath: Use more meaningful names
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44861
To unsubscribe, visit https://gerrit.ovirt.
Dan Kenigsberg has posted comments on this change.
Change subject: vm: periodic: NumaInfoMonitor doesn't need jobs
..
Patch Set 5: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/44763
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: periodic: NumaInfoMonitor doesn't need jobs
..
vm: periodic: NumaInfoMonitor doesn't need jobs
The Vm.isDomainReadyForCommands() is a borderline ha
automat...@ovirt.org has posted comments on this change.
Change subject: vm: periodic: NumaInfoMonitor doesn't need jobs
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: move extend and extendVolume
..
Patch Set 22:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: deleteImage and deps
..
Patch Set 22:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Ido Barkan has uploaded a new change for review.
Change subject: net: create bond properly during start_devices
..
net: create bond properly during start_devices
This method, that is used during networks rollback, calls ifup on
automat...@ovirt.org has posted comments on this change.
Change subject: makefile: Run pep8/pyflakes inside virtualenv
..
Patch Set 2:
* Update tracker::#1182088::OK
* Check Bug-Url::OK
* Check Public Bug::#1182088::OK, public
Dima Kuznetsov has posted comments on this change.
Change subject: makefile: Run pep8/pyflakes inside virtualenv
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44928/1/Makefile.am
File Makefile.am:
Line 121:
Line 1
automat...@ovirt.org has posted comments on this change.
Change subject: net: create bond properly during start_devices
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
T
Dan Kenigsberg has posted comments on this change.
Change subject: net: create bond properly during start_devices
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45028
To unsubscribe, visit https://ger
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: create bond properly during start_devices
..
net: create bond properly during start_devices
This method, that is used during networks rollback, ca
Dan Kenigsberg has posted comments on this change.
Change subject: net: create bond properly during start_devices
..
Patch Set 1: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/45027
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: create bond properly during start_devices
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/45027
To unsubscribe, visit https://gerrit.ovi
automat...@ovirt.org has posted comments on this change.
Change subject: net: create bond properly during start_devices
..
Patch Set 1: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one
Dan Kenigsberg has posted comments on this change.
Change subject: net: create bond properly during start_devices
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45027
To unsubscribe, visit https://ger
Ido Barkan has uploaded a new change for review.
Change subject: net: create bond properly during start_devices
..
net: create bond properly during start_devices
This method, that is used during networks rollback, calls ifup on
automat...@ovirt.org has posted comments on this change.
Change subject: net: create bond properly during start_devices
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
T
automat...@ovirt.org has posted comments on this change.
Change subject: net: create bond properly during start_devices
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: create bond properly during start_devices
..
net: create bond properly during start_devices
This method, that is used during networks rollback, ca
Dan Kenigsberg has posted comments on this change.
Change subject: net: create bond properly during start_devices
..
Patch Set 2: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/44587
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: create bond properly during start_devices
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/44587
To unsubscribe, visit https://gerrit.ovi
Ido Barkan has posted comments on this change.
Change subject: net: try restore networks harder.
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44274/3/tests/functional/networkTests.py
File tests/functi
Francesco Romani has posted comments on this change.
Change subject: makefile: Run pep8/pyflakes inside virtualenv
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44928/1/Makefile.am
File Makefile.am:
Line 121:
Line
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: tests: add requiresUnifiedPersistence decorator
..
net: tests: add requiresUnifiedPersistence decorator
So we can stop repeating
if vdsm.config.co
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: add requiresUnifiedPersistence decorator
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44307
To unsubscribe, visit https
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: add requiresUnifiedPersistence decorator
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
1 - 100 of 163 matches
Mail list logo
