Dan Kenigsberg has submitted this change and it was merged.
Change subject: concurrent: Add support for target function kwargs
..
concurrent: Add support for target function kwargs
Turns out we pass kwargs to some threads, so
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add support for target function kwargs
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
Dan Kenigsberg has posted comments on this change.
Change subject: concurrent: Add support for target function kwargs
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45470
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 3: Verified+1
No code changes. Patch split as Nir suggested. Copying verification flag from
previous patch set.
--
To view,
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: broken unsubscribe process
..
Patch Set 1: Verified+1
Verified together with jsonrpc fd leak patch and split later from it.
Verification flag copied
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 4: -Code-Review
--
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 4: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/44689/4/lib/vdsm/config.py.in
File
Piotr Kliczewski has posted comments on this change.
Change subject: json cli: use ssl when creating a socket
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/45611/1/lib/vdsm/utils.py
File
Francesco Romani has posted comments on this change.
Change subject: caps: more precise emulated machines selection
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/45257/4/tests/caps_libvirt_multiqemu.out
File
Yeela Kaplan has posted comments on this change.
Change subject: json cli: use ssl when creating a socket
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45611/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1254:
Petr Horáček has posted comments on this change.
Change subject: net: ifcfg: synchronous ifup
..
Patch Set 9: Verified+1
Functional network tests passed without a regression (except time rgression
mentioned in comming msg).
automat...@ovirt.org has posted comments on this change.
Change subject: net: synchronous ifup
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/45533
To unsubscribe, visit
Petr Horáček has abandoned this change.
Change subject: net: synchronous ifup
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/45533
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/44494/5/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1260:
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/45615/3/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 266:
Martin Polednik has posted comments on this change.
Change subject: caps: more precise emulated machines selection
..
Patch Set 8: Code-Review+1
Way easier to review!
--
To view, visit https://gerrit.ovirt.org/45257
To
Piotr Kliczewski has posted comments on this change.
Change subject: json cli: use ssl when creating a socket
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45611/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: Open vSwitch configurator
..
Patch Set 69:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Forcibly unregister fds with errors from epoll
..
Patch Set 8:
* Update tracker::#1226911::OK
* Check Bug-Url::OK
* Check Public Bug::#1226911::OK,
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 3:
(1 comment)
seems OK at first glance, deeper review later.
https://gerrit.ovirt.org/#/c/45615/3/lib/yajsonrpc/__init__.py
Petr Horáček has posted comments on this change.
Change subject: net: ifcfg: synchronous ifup
..
Patch Set 9:
+++ Warning 'Expected event was not caught within a given timeout' is logged at
least 4 times per functional
automat...@ovirt.org has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Amit Aviram has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
..
Patch Set 1:
The change is identical to the one @ master
--
To view, visit https://gerrit.ovirt.org/45627
To
Hello Nir Soffer, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/45627
to review the following change.
Change subject: vm.py: State saving in hotunplugDisk.
..
vm.py: State
Amit Aviram has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/45627
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: net: iproute2, pyroute2: implement rollback
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/45238
Petr Horáček has abandoned this change.
Change subject: net: iproute2, pyroute2: implement rollback
..
Abandoned
it's already implemented
--
To view, visit https://gerrit.ovirt.org/45238
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm.py: State saving in hotunplugDisk.
..
vm.py: State saving in hotunplugDisk.
VM's state was saved before detatching a disk in hotunplugDisk.
Saving
automat...@ovirt.org has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
automat...@ovirt.org has posted comments on this change.
Change subject: volume: fix failing metadata parsing
..
Patch Set 3:
* Update tracker::#1258835::OK
* Check Bug-Url::OK
* Check Public Bug::#1258835::OK, public bug
*
Piotr Kliczewski has uploaded a new change for review.
Change subject: stomp: broken unsubscribe process
..
stomp: broken unsubscribe process
There is a logic common for incoming and outgoing connection which
cleans the
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 3:
* Update tracker::#1256446::OK
* Check Bug-Url::OK
* Check Public Bug::#1256446::OK, public bug
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: broken unsubscribe process
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: storage: Hidden files filtered form listings of storage domains
..
Patch Set 2: Code-Review-1
See my previous comment.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: hsm: Support checkStatus param in getDeviceList
..
Patch Set 8: Code-Review-1
(4 comments)
Few minor fixes needed.
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Hidden files filtered form listings of storage domains
..
Patch Set 2:
* Update tracker::#1259279::OK
* Check Bug-Url::OK
* Check Public
Nir Soffer has posted comments on this change.
Change subject: storage: Hidden files filtered form listings of storage domains
..
Patch Set 1: Code-Review-1
Thanks for the patch, but this is not the right place to filter the
Jakub Niedermertl has posted comments on this change.
Change subject: storage: Hidden files filtered form listings of storage domains
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/45645
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: stomp: broken unsubscribe process
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45617/1/lib/yajsonrpc/stompreactor.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: hsm: Support checkStatus param in getDeviceList
..
Patch Set 9:
* Update tracker::#1217401::OK
* Check Bug-Url::OK
* Check Public Bug::#1217401::OK,
Freddy Rolland has posted comments on this change.
Change subject: hsm: Support checkStatus param in getDeviceList
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/45093
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: hsm: Support checkStatus param in getDeviceList
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/45093/8/vdsm/rpc/vdsmapi-schema.json
File
Nir Soffer has posted comments on this change.
Change subject: hsm: Support checkStatus param in getDeviceList
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45093
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: StorageDomainManifest: Move validateCreateVolumeParams
..
Patch Set 13: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43550
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: Introduce class structure
..
Patch Set 17: Code-Review-1
(1 comment)
Partial review
Ido Barkan has posted comments on this change.
Change subject: net: ifcfg: synchronous ifup
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/37366
To unsubscribe, visit
Dan Kenigsberg has uploaded a new change for review.
Change subject: Revert "network: bridge inherits DHCP unique identifier from
its DHCP-enabled port"
..
Revert "network: bridge inherits DHCP unique identifier from its
automat...@ovirt.org has posted comments on this change.
Change subject: Revert "network: bridge inherits DHCP unique identifier from
its DHCP-enabled port"
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check
Dan Kenigsberg has reverted this change.
Change subject: Revert "network: bridge inherits DHCP unique identifier from
its DHCP-enabled port"
..
Patch Set 7: Reverted
This patchset was reverted in change:
Dan Kenigsberg has uploaded a new change for review.
Change subject: Revert "network: bridge inherits DHCP unique identifier from
its DHCP-enabled port"
..
Revert "network: bridge inherits DHCP unique identifier from its
automat...@ovirt.org has posted comments on this change.
Change subject: Revert "network: bridge inherits DHCP unique identifier from
its DHCP-enabled port"
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check
Ido Barkan has posted comments on this change.
Change subject: Revert "network: bridge inherits DHCP unique identifier from
its DHCP-enabled port"
..
Patch Set 1: Code-Review+1
oh my. so when is it supported then? Can we ask
Nir Soffer has posted comments on this change.
Change subject: StorageDomainManifest: Move clusterLock into Manifest
..
Patch Set 12: Code-Review-1
(8 comments)
Generally ok, added few questions and minor cleanups.
automat...@ovirt.org has posted comments on this change.
Change subject: mount: Remove unneeded return
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: mount: Perform mount and umount in supervdsm
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: mount: Log info message when mounting or unmounting
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Nir Soffer has posted comments on this change.
Change subject: ImageManifest: introduce ImageManifest class
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43551
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: StorageDomainManifest: Move acquireVolumeMetadataSlot
..
Patch Set 4: Code-Review-1
(1 comment)
Looks ok, see question about storing tags
Nir Soffer has posted comments on this change.
Change subject: StorageDomainManifest: move refresh and refreshDirTree
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45388
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
vm: Libvirt quering after disk detach operation addition.
As stated in libvirt
Dan Kenigsberg has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 18:
As everybody is well-aware, this patch does not solve the bug, it only hides
one
automat...@ovirt.org has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 19:
* Update tracker::#1044466::OK
* Check TR::#1044466::ERROR, 3.6.0 should not
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 5: Verified+1
Fixed comments and rebased. Verified by building with and without m2c and
tested
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 7: Verified+1
Fixed comments and rebased. Verified by building with and without m2c and
tested communication
Jakub Niedermertl has posted comments on this change.
Change subject: storage: Hidden files filtered form listings of storage domains
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/45645
To unsubscribe,
Amit Aviram has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 1:
The change is identical to the one @ master
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: hsm: Support checkStatus param in getDeviceList
..
Patch Set 7: Code-Review-1
(3 comments)
Looks good except the backward incompatibility caused by the new
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 19:
Dan, this patch do solve the bug - which is possible data corruption when same
device
Ido Barkan has posted comments on this change.
Change subject: lib: Use new concurrent.thread() utility
..
Patch Set 5: Code-Review+1
reapproving after rebases
--
To view, visit https://gerrit.ovirt.org/44895
To unsubscribe,
automat...@ovirt.org has posted comments on this change.
Change subject: virt: vm with port mirroring stuck in down state
..
Patch Set 3:
* Update tracker::#1254713::OK
* Check Bug-Url::OK
* Check Public Bug::#1254713::OK,
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/45615/3/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line
Jakub Niedermertl has uploaded a new change for review.
Change subject: storage: Hidden files filtered form listings of storage domains
..
storage: Hidden files filtered form listings of storage domains
Listing of files in
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Hidden files filtered form listings of storage domains
..
Patch Set 1:
* Update tracker::#1259279::OK
* Check Bug-Url::OK
* Check Public
Hello Nir Soffer, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/45646
to review the following change.
Change subject: vm: Libvirt quering after disk detach operation addition.
automat...@ovirt.org has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 1:
* Update tracker::#1044466::OK
* Check Bug-Url::OK
* Check Public
Freddy Rolland has posted comments on this change.
Change subject: hsm: Support checkStatus param in getDeviceList
..
Patch Set 7:
(3 comments)
https://gerrit.ovirt.org/#/c/45093/7/client/vdsClient.py
File
Marcin Mirecki has posted comments on this change.
Change subject: virt: vm with port mirroring stuck in down state
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/45344/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Marcin Mirecki has posted comments on this change.
Change subject: virt: vm with port mirroring stuck in down state
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/45344
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: hsm: Support checkStatus param in getDeviceList
..
Patch Set 8:
* Update tracker::#1217401::OK
* Check Bug-Url::OK
* Check Public Bug::#1217401::OK,
Marcin Mirecki has posted comments on this change.
Change subject: virt: vm with port mirroring stuck in down state
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/45344/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Amit Aviram has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/45646
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: vm with port mirroring stuck in down state
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/45344/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/44494/5/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1255:
Martin Polednik has posted comments on this change.
Change subject: virt: Remove QEMU passthrough hack in ppc64
..
Patch Set 14: Verified+1
--
To view, visit https://gerrit.ovirt.org/33871
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 18: Code-Review+2
(1 comment)
not yet definitive fix, but looks like improvement.
automat...@ovirt.org has posted comments on this change.
Change subject: Fix string in diskunmap hook README file
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Martin Sivák has uploaded a new change for review.
Change subject: Add an empty metadata qos element to the created domain
..
Add an empty metadata qos element to the created domain
Libvirt reports an error every time VDSM
automat...@ovirt.org has posted comments on this change.
Change subject: Add an empty metadata qos element to the created domain
..
Patch Set 1:
* Update tracker::#1219903::OK
* Check Bug-Url::OK
* Check Public
Oved Ourfali has posted comments on this change.
Change subject: service: change vdsm KillMode to mixed
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Reset read time counters only on reads with data
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Oved Ourfali has posted comments on this change.
Change subject: service: change vdsm KillMode to mixed
..
Patch Set 4:
thanks for the clarification.
--
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 3: Code-Review+1
looks good, conditional[1] ack
+++
[1] I'd like to learn more about jsonrpc infra to do more meaningful
Nir Soffer has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45627
To unsubscribe, visit
Ido Barkan has uploaded a new change for review.
Change subject: net: rename sriov related code params
..
net: rename sriov related code params
This is to reflect that the oassed device name is actually a pci
address path such
Michal Skrivanek has posted comments on this change.
Change subject: virt: add logic for POWER cpu xml element
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/42736/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: virt: add logic for POWER cpu xml element
..
Patch Set 8: Code-Review+1
Dan, IIUC it is not needed for this patch, it will work just fine on any
libvirt
automat...@ovirt.org has posted comments on this change.
Change subject: net: rename sriov related code params
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Yeela Kaplan has posted comments on this change.
Change subject: service: change vdsm KillMode to mixed
..
Patch Set 4:
This patch is verified on fedora.
The mixed option is not yet backported to EL.
So this patch is waiting
1 - 100 of 138 matches
Mail list logo
