Change in vdsm[ovirt-3.6]: net: set physical functions up before using them.

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: set physical functions up before using them. .. Patch Set 1: * Update tracker::#1229691::OK * Check Bug-Url::OK * Check Public Bug::#1229691::OK, pub

Change in vdsm[ovirt-3.6]: net: set physical functions up before using them.

2015-10-07 Thread ibarkan
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/47110 to review the following change. Change subject: net: set physical functions up before using them. .. net: set physical fu

Change in vdsm[ovirt-3.6]: net: rename sriov related code params

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: rename sriov related code params .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[ovirt-3.6]: net: rename sriov related code params

2015-10-07 Thread ibarkan
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/47109 to review the following change. Change subject: net: rename sriov related code params .. net: rename sriov related code p

Change in vdsm[master]: jsonrpc: increase call timeout to allow valid response

2015-10-07 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: jsonrpc: increase call timeout to allow valid response .. Patch Set 1: Some network functional tests takes more time to return. -- To view, visit https://gerrit

Change in vdsm[master]: configurators: make disable_ipv6 permanent by using sysctl.d...

2015-10-07 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: configurators: make disable_ipv6 permanent by using sysctl.d configs .. Patch Set 4: I understand that this is WIP right? IMO, it makes sense to persist the kernel

Change in vdsm[master]: hostdev: fix pep8 line length violation

2015-10-07 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: hostdev: fix pep8 line length violation .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47083 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-10-07 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/46741/4/vdsm/network/api.py File vdsm/network/api.py: Line

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-10-07 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: netinfo: stop using getVlanID() in network.api .. netinfo: stop using getVlanID() in network.api The same information is already present in _netinfo.

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- T

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-10-07 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 6: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/46741 To unsubscribe, visit ht

Change in vdsm[master]: virt: Don't warn about unknown type for channel devices

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: virt: Don't warn about unknown type for channel devices .. Patch Set 3: * update_tracker: OK * Set MODIFIED::bug 1128881#1128881IGNORE, not oVirt

Change in vdsm[master]: virt: Don't warn about unknown type for channel devices

2015-10-07 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Don't warn about unknown type for channel devices .. virt: Don't warn about unknown type for channel devices We're currently issuing warnings in

Change in vdsm[master]: automation: Disable tests requiring tun device

2015-10-07 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: automation: Disable tests requiring tun device .. automation: Disable tests requiring tun device In commit a9e9e7bcc7a1 (tests: temporarily exclude few

Change in vdsm[master]: automation: Disable tests requiring tun device

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: automation: Disable tests requiring tun device .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- T

Change in vdsm[master]: storage: Initial size for thin provisioning disk

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Initial size for thin provisioning disk .. Patch Set 5: (4 comments) https://gerrit.ovirt.org/#/c/46417/5/client/vdsClient.py File client/vdsClient.py: L

Change in vdsm[master]: storage: Initial size for thin provisioning disk

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Initial size for thin provisioning disk .. Patch Set 5: Code-Review-1 (3 comments) Partial review https://gerrit.ovirt.org/#/c/46417/5/vdsm/storage/block

Change in vdsm[master]: rwlock: Support timed acquire

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: rwlock: Support timed acquire .. Patch Set 27: Verified+1 -- To view, visit https://gerrit.ovirt.org/42909 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: rwlock: Replace misc.RWLock

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: rwlock: Replace misc.RWLock .. Patch Set 17: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/43423/17//COMMIT_MSG Commit Message: Line 9: This patch remove

Change in vdsm[master]: rwlock: Support timed acquire

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: rwlock: Support timed acquire .. Patch Set 27: This version fix a race when waiter is granted after it timed out but before it got the lock. This race would lead t

Change in vdsm[master]: rwlock: Support non-blocking acquire

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: rwlock: Support non-blocking acquire .. Patch Set 24: Verified+1 -- To view, visit https://gerrit.ovirt.org/42928 To unsubscribe, visit https://gerrit.ovirt.org/se

Change in vdsm[master]: rwlock: Support non-blocking acquire

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: rwlock: Support non-blocking acquire .. Patch Set 24: Manual rebase, no code change. -- To view, visit https://gerrit.ovirt.org/42928 To unsubscribe, visit https:

Change in vdsm[master]: rwlock: Replace misc.RWLock

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: rwlock: Replace misc.RWLock .. Patch Set 17: Need to perform intensive flows to verify this. -- To view, visit https://gerrit.ovirt.org/43423 To unsubscribe, visi

Change in vdsm[master]: rwlock: Add simpler RWLock

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 21: Verified+1 This version refine the internal apis. Instead of wakeup(), we use grant(), since the purpose of this method

Change in vdsm[master]: rwlock: Support timed acquire

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: rwlock: Support timed acquire .. Patch Set 27: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: rwlock: Add simpler RWLock

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 21: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

Change in vdsm[master]: rwlock: Replace misc.RWLock

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: rwlock: Replace misc.RWLock .. Patch Set 17: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: resourceManager: Avoid unneeded recursive locking

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: resourceManager: Avoid unneeded recursive locking .. Patch Set 15: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, mak

Change in vdsm[master]: rwlock: Support non-blocking acquire

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: rwlock: Support non-blocking acquire .. Patch Set 24: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: automation: Enable xunit report

2015-10-07 Thread nsoffer
Nir Soffer has abandoned this change. Change subject: automation: Enable xunit report .. Abandoned Waiting until jenkins will use this file. -- To view, visit https://gerrit.ovirt.org/46640 To unsubscribe, visit https://gerri

Change in vdsm[master]: automation: Enable xunit report

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: automation: Enable xunit report .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/46640 To unsubscri

Change in vdsm[ovirt-3.5]: vm.py: State saving in hotunplugDisk.

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm.py: State saving in hotunplugDisk. .. Patch Set 3: Amit, what about the next patch fixing the missing wait for deatchDevice? -- To view, visit https://gerrit.o

Change in vdsm[ovirt-3.5]: vm.py: State saving in hotunplugDisk.

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm.py: State saving in hotunplugDisk. .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45928 To unsubscribe, visit https://gerrit.ovirt.org

Change in vdsm[master]: qemuimg: add support for convert progress

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: add support for convert progress .. Patch Set 11: Code-Review+1 (2 comments) Just minor commit message cleanup. https://gerrit.ovirt.org/#/c/33910/11//CO

Change in vdsm[master]: qemuimg: add support for convert progress

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: add support for convert progress .. Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/33910 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: utils: split out execCmd wrapping logic

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: split out execCmd wrapping logic .. Patch Set 1: Code-Review-1 (3 comments) I like this very much, but there some issues. https://gerrit.ovirt.org/#/c/4710

Change in vdsm[master]: utils: split out execCmd wrapping logic

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: split out execCmd wrapping logic .. Patch Set 1: Code-Review+1 Nice! -- To view, visit https://gerrit.ovirt.org/47107 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: vdsm-tool: Ensure that the vdsm uuid is a string

2015-10-07 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-tool: Ensure that the vdsm uuid is a string .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46970 To unsubscribe, vis

Change in vdsm[master]: register: Fix certificate validation

2015-10-07 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: register: Fix certificate validation .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/46981/1/lib/vdsm/tool/register.py File lib/vdsm/tool/

Change in vdsm[master]: register: Leave the logging to the vdsm-tool

2015-10-07 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: register: Leave the logging to the vdsm-tool .. Patch Set 1: I believe the vdsm already provides too much data but Dan is the man to decide. -- To

Change in vdsm[master]: register: Drop CA path redundancies

2015-10-07 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: register: Drop CA path redundancies .. Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/46980 To unsubscribe, visit https://ge

Change in vdsm[master]: register: Simplify setting defaults

2015-10-07 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: register: Simplify setting defaults .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46979 To unsubscribe, visit https://ge

Change in vdsm[master]: register: Drop CA path redundancies

2015-10-07 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: register: Drop CA path redundancies .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/46980/1/lib/vdsm/tool/register.py File lib/vdsm/tool/r

Change in vdsm[master]: utils: split out execCmd wrapping logic

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: utils: split out execCmd wrapping logic .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: qemuimg: add support for convert progress

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: qemuimg: add support for convert progress .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure h

Change in vdsm[master]: utils: split out execCmd wrapping logic

2015-10-07 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: utils: split out execCmd wrapping logic .. utils: split out execCmd wrapping logic The execCmd utility contains fairly intricate logic which wraps a given command

Change in vdsm[master]: qemuimg: add support for convert progress

2015-10-07 Thread alitke
Adam Litke has posted comments on this change. Change subject: qemuimg: add support for convert progress .. Patch Set 9: (4 comments) https://gerrit.ovirt.org/#/c/33910/9/vdsm/storage/image.py File vdsm/storage/image.py: Line

Change in vdsm[ovirt-3.5]: vdsm-tool: Do not panic with sanlock empty groups

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vdsm-tool: Do not panic with sanlock empty groups .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least

Change in vdsm[ovirt-3.5]: vdsm-tool: Do not panic with sanlock empty groups

2015-10-07 Thread nsoffer
Hello Germano Veit Michel, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/47105 to review the following change. Change subject: vdsm-tool: Do not panic with sanlock empty groups .

Change in vdsm[ovirt-3.6]: vdsm-tool: Do not panic with sanlock empty groups

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vdsm-tool: Do not panic with sanlock empty groups .. Patch Set 1: Verified+1 Verified on master, trivial change. -- To view, visit https://gerrit.ovirt.org/47104

Change in vdsm[ovirt-3.6]: vdsm-tool: Do not panic with sanlock empty groups

2015-10-07 Thread nsoffer
Hello Germano Veit Michel, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/47104 to review the following change. Change subject: vdsm-tool: Do not panic with sanlock empty groups .

Change in vdsm[ovirt-3.6]: vdsm-tool: Do not panic with sanlock empty groups

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vdsm-tool: Do not panic with sanlock empty groups .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: net: tests: additional tests for host QOS

2015-10-07 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: net: tests: additional tests for host QOS .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44699 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: net: qos: change top qos api

2015-10-07 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: net: qos: change top qos api .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45526 To unsubscribe, visit https://gerrit.ovirt.org/sett

Change in vdsm[master]: move _kill_and_rm_pid to utils

2015-10-07 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: move _kill_and_rm_pid to utils .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45527 To unsubscribe, visit https://gerrit.ovirt.org/se

Change in vdsm[master]: automation: Enable xunit report

2015-10-07 Thread dcaroest
David Caro has posted comments on this change. Change subject: automation: Enable xunit report .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/46640/4/automation/build-artifacts.sh File automation/build-artifacts.sh:

Change in vdsm[master]: automation: Enable xunit report

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: automation: Enable xunit report .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/46640/4/automation/build-artifacts.sh File automation/build-artifacts.sh:

Change in vdsm[master]: vdsm: introduce cpuinfo module

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: introduce cpuinfo module .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: automation: Enable xunit report

2015-10-07 Thread dcaroest
David Caro has posted comments on this change. Change subject: automation: Enable xunit report .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/46640/4/automation/build-artifacts.sh File automation/build-artifacts.sh:

Change in vdsm[master]: automation: Enable xunit report

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: automation: Enable xunit report .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/46640/4/automation/build-artifacts.sh File automation/build-artifacts.sh:

Change in vdsm[master]: migration: Add incoming migration semaphore

2015-10-07 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add incoming migration semaphore .. Patch Set 8: (4 comments) https://gerrit.ovirt.org/#/c/45954/8//COMMIT_MSG Commit Message: Line 7: migration: Add

Change in vdsm[master]: migration: Add incoming migration semaphore

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration: Add incoming migration semaphore .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: Add retry logic for incoming limit

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration: Add retry logic for incoming limit .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: vm: small cleanup of _completeIncomingMigration()

2015-10-07 Thread mbetak
Martin Betak has uploaded a new change for review. Change subject: vm: small cleanup of _completeIncomingMigration() .. vm: small cleanup of _completeIncomingMigration() Extracted the check for recovery completion into separate

Change in vdsm[master]: utils: Add @throttle decorator

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: utils: Add @throttle decorator .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: automation: Disable tests requiring tun device

2015-10-07 Thread dcaroest
David Caro has posted comments on this change. Change subject: automation: Disable tests requiring tun device .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46641 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: utils: Add @throttle decorator

2015-10-07 Thread mbetak
Martin Betak has uploaded a new change for review. Change subject: utils: Add @throttle decorator .. utils: Add @throttle decorator Added decorator for API methods that need to limit their maximum number of concurrent operations

Change in vdsm[master]: vm: small cleanup of _completeIncomingMigration()

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: small cleanup of _completeIncomingMigration() .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: atomation: Remove commented code

2015-10-07 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: atomation: Remove commented code .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/46639 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: atomation: Remove commented code

2015-10-07 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: atomation: Remove commented code .. atomation: Remove commented code We don't keep commented code in vdsm. Change-Id: I3a3bf8c82ce38afe064a0941e7e9af5

Change in vdsm[master]: automation: No need to disbale stress tests

2015-10-07 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: automation: No need to disbale stress tests .. automation: No need to disbale stress tests Stress tests and slow tests are disabled by default. Also,

Change in vdsm[master]: automation: No need to disbale stress tests

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: automation: No need to disbale stress tests .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To v

Change in vdsm[master]: automation: No need to disbale stress tests

2015-10-07 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: automation: No need to disbale stress tests .. Patch Set 2: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/46638 To unsubscr

Change in vdsm[master]: atomation: Remove commented code

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: atomation: Remove commented code .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: automation: No need to disbale stress tests

2015-10-07 Thread dcaroest
David Caro has posted comments on this change. Change subject: automation: No need to disbale stress tests .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46638 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: atomation: Remove commented code

2015-10-07 Thread dcaroest
David Caro has posted comments on this change. Change subject: atomation: Remove commented code .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46639 To unsubscribe, visit https://gerrit.ovirt.org/sett

Change in vdsm[master]: automation: Keep xunit report

2015-10-07 Thread dcaroest
David Caro has posted comments on this change. Change subject: automation: Keep xunit report .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/46643/3/automation/build-artifacts.sh File automation/build-artifacts.sh: L

Change in vdsm[master]: automation: Enable xunit report

2015-10-07 Thread dcaroest
David Caro has posted comments on this change. Change subject: automation: Enable xunit report .. Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/46640/4/automation/build-artifacts.sh File automation/build-

Change in vdsm[master]: hostdev: fix pep8 line length violation

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: hostdev: fix pep8 line length violation .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: hostdev: fix pep8 line length violation

2015-10-07 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: hostdev: fix pep8 line length violation .. Patch Set 1: Verified+1 82->79 chars -- To view, visit https://gerrit.ovirt.org/47083 To unsubscribe, visit https:

Change in vdsm[master]: hostdev: fix pep8 line length violation

2015-10-07 Thread mpolednik
Martin Polednik has uploaded a new change for review. Change subject: hostdev: fix pep8 line length violation .. hostdev: fix pep8 line length violation Change-Id: I493bb143e1ebdeb53821bf6ea8ca6cc6e7185aa0 Signed-off-by: Martin

Change in vdsm[master]: spec: Require newer kernel version on EL

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Require newer kernel version on EL .. Patch Set 1: CI error is expected - package not available on centos yet. -- To view, visit https://gerrit.ovirt.org/47

Change in vdsm[master]: storage: Initial size for thin provisioning disk

2015-10-07 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Initial size for thin provisioning disk .. Patch Set 4: (18 comments) https://gerrit.ovirt.org/#/c/46417/4/tests/blockVolumeTests.py File tests/blockV

Change in vdsm[master]: storage: Initial size for thin provisioning disk

2015-10-07 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Initial size for thin provisioning disk .. Patch Set 3: (17 comments) https://gerrit.ovirt.org/#/c/46417/3//COMMIT_MSG Commit Message: Line 6: Line

Change in vdsm[master]: storage: Initial size for thin provisioning disk

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: storage: Initial size for thin provisioning disk .. Patch Set 5: * Update tracker::#1221603::OK * Check Bug-Url::OK * Check Public Bug::#1221603::OK, publ

Change in vdsm[master]: move _kill_and_rm_pid to utils

2015-10-07 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: move _kill_and_rm_pid to utils .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45527 To unsubscribe, visit https://gerrit.ovirt.org/sett

Change in vdsm[master]: hooks: ovs: start every log with 'OVS: '

2015-10-07 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: start every log with 'OVS: ' .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/46906/4/vdsm_hooks/ovs/ovs_utils.py File vdsm_hooks/ovs/ovs_uti

Change in vdsm[master]: configurators: make disable_ipv6 permanent by using sysctl.d...

2015-10-07 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: configurators: make disable_ipv6 permanent by using sysctl.d configs .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/46985/4//COMMIT_MSG Commit Message

Change in vdsm[master]: spec: Require newer kernel version on EL

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Require newer kernel version on EL .. Patch Set 1: CI failures not related, seems that loop device issues are not fixed yet. -- To view, visit https://gerri

Change in vdsm[master]: spec: Require newer kernel version on Fedora

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Require newer kernel version on Fedora .. Patch Set 5: CI failures not related, seems that loop device issues are not fixed yet. -- To view, visit https://g

Change in vdsm[master]: spec: Require newer kernel version on Fedora

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Require newer kernel version on Fedora .. Patch Set 5: Verified+1 Tested on Fedora 22 - vdsm pull newer kernel. -- To view, visit https://gerrit.ovirt.org/4

Change in vdsm[master]: networkTests: normalize strings (to unicode) through json magic

2015-10-07 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: networkTests: normalize strings (to unicode) through json magic .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45201 To unsubscribe, visi

Change in vdsm[master]: spec: Require newer kernel version on EL

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Require newer kernel version on EL .. Patch Set 1: Code-Review-1 Verified+1 Verfied on EL 7.1. -1 because the package is not availble yet in CentOS. -- To

Change in vdsm[master]: netinfo: simplify getNetworksAndVlansForIface

2015-10-07 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: netinfo: simplify getNetworksAndVlansForIface .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/46765/2/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line

Change in vdsm[master]: netinfo: rework reporting of DHCPv4/6 on network devices

2015-10-07 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: netinfo: rework reporting of DHCPv4/6 on network devices .. Patch Set 6: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/46430/6/lib/vdsm/netinfo.py File l

Change in vdsm[master]: spec: Require newer kernel version on EL

2015-10-07 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: spec: Require newer kernel version on EL .. spec: Require newer kernel version on EL iSCSI default replacement_timeout is 120 seconds, resulting in too slow iSCSI

Change in vdsm[master]: spec: Require newer kernel version on EL

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: spec: Require newer kernel version on EL .. Patch Set 1: * Update tracker::#980139::OK * Check Bug-Url::OK * Check Public Bug::#980139::OK, public bug * C

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: spec: Require newer kernel version on Fedora

2015-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Require newer kernel version on Fedora .. Patch Set 5: This version separate the Fedora fix from EL fix. -- To view, visit https://gerrit.ovirt.org/44851 To

Change in vdsm[master]: spec: Require newer kernel version on Fedora

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: spec: Require newer kernel version on Fedora .. Patch Set 5: * Update tracker::#1253790::OK * Check Bug-Url::OK * Check Public Bug::#1253790::OK, public b

  1   2   >