Yaniv Bronhaim has posted comments on this change.
Change subject: tests: functional - convert to run over jsonrpc
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45789
To unsubscribe, visit https://g
Dan Kenigsberg has posted comments on this change.
Change subject: config: Resolve crash when IPv6 disabled in kernel
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/47978/1/vdsm/network/configurators/if
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Introduce schema parsing tests
..
tests: Introduce schema parsing tests
We currently have some tests that test the schema tokenizer but we don't
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Introduce schema parsing tests
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, v
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Introduce schema parsing tests
..
Patch Set 3: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/45464
To unsubscribe, visit https
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: HostSample always gets current cpus
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/42035/16/vdsm/virt/sampling.py
File vdsm/virt/sampling.
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: support iperf3 for performance tests
..
Patch Set 21: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/46448/21/tests/nettestlib.py
File test
Martin Polednik has posted comments on this change.
Change subject: lib: utils: consolidate Error class in one place
..
Patch Set 1: Code-Review+1
(2 comments)
A little concern regarding importing Error directly to module's na
Martin Polednik has posted comments on this change.
Change subject: lib: grub2 module
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/47946/1/lib/vdsm/grub2.py
File lib/vdsm/grub2.py:
Line 143: if not val:
Li
automat...@ovirt.org has posted comments on this change.
Change subject: lib: grub2 module
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
automat...@ovirt.org has posted comments on this change.
Change subject: lib: grub2 module
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
automat...@ovirt.org has posted comments on this change.
Change subject: config: Resolve crash when IPv6 disabled in kernel
..
Patch Set 1:
* Update tracker::#1277204::OK
* Check Bug-Url::OK
* Check Public Bug::#1277204::OK, pu
Yeela Kaplan has posted comments on this change.
Change subject: jsonrpc cli: allow client to return compatible results
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/47923
To unsubscribe, visit https://
Yeela Kaplan has posted comments on this change.
Change subject: tests: functional - convert to run over jsonrpc
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/45789
To unsubscribe, visit https://gerrit
Yeela Kaplan has posted comments on this change.
Change subject: jsonrpc cli: Allow setting timeout for long operations
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/47922
To unsubscribe, visit https://
Roman Mohr has posted comments on this change.
Change subject: monitor: Add udev monitor
..
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/47729/7/lib/vdsm/udev/monitor.py
File lib/vdsm/udev/monitor.py:
Line 34: m
Yeela Kaplan has uploaded a new change for review.
Change subject: init: compatible comment on upgrade
..
init: compatible comment on upgrade
Make comments compatible on upgrade from 4.16
and 4.10.
Change-Id: Ib9f86251ea9c4dc21
automat...@ovirt.org has posted comments on this change.
Change subject: init: compatible comment on upgrade
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Add initial FakeLVM tests and fix errors
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Add FakeLVM LV properties tests
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
automat...@ovirt.org has posted comments on this change.
Change subject: tests: FakeLVM add support for activateLVs
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
automat...@ovirt.org has posted comments on this change.
Change subject: tests: FakeLVM support initialTag when creating LV
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
automat...@ovirt.org has posted comments on this change.
Change subject: tests: FakeLVM test command failure
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Streamline fake blockSD creation
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: tests: FakeLVM create inactive LV
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Add FakeLVM PV properties tests
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
automat...@ovirt.org has posted comments on this change.
Change subject: tests: FakeLVM add lvPath test
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Adam Litke has posted comments on this change.
Change subject: tests: Add initial FakeLVM tests and fix errors
..
Patch Set 2:
(10 comments)
https://gerrit.ovirt.org/#/c/47857/2/tests/storagefakelib.py
File tests/storagefakeli
Francesco Romani has posted comments on this change.
Change subject: lib: grub2 module
..
Patch Set 1:
(8 comments)
initial review, mostly minor things.
To be able to do a meaningful review, I miss to see how this is going to
Dan Kenigsberg has posted comments on this change.
Change subject: Having logrotate configuration to rotate coredump directory as
root user
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/47833/1//COMMIT_MSG
Commit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: replace import for persist/unpersist
..
Patch Set 1: Verified+1
Backported only.
--
To view, visit https://gerrit.ovirt.org/47968
To unsubs
automat...@ovirt.org has posted comments on this change.
Change subject: utils: replace import for persist/unpersist
..
Patch Set 1:
* Update tracker::#1274063::OK
* Check Bug-Url::OK
* Check Public Bug::#1274063::OK, public bu
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: utils: replace import for persist/unpersist
..
utils: replace import for persist/unpersist
Use the new ovirt-node Config class for persist/unpersis
automat...@ovirt.org has posted comments on this change.
Change subject: WIP
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a val
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: add fake virt-v2v process for testing without virt-v2v
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url f
Francesco Romani has posted comments on this change.
Change subject: sampling: remove HostStatsThread.get()
..
Patch Set 16: Verified+1
verified running patched VDSM that vds stats are still collected and reported
(checked usi
Shahar Havivi has posted comments on this change.
Change subject: v2v: add fake virt-v2v process for testing without virt-v2v
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/47738/2/tests/fake-virt-v2v.py
File tests/f
Francesco Romani has posted comments on this change.
Change subject: sampling: HostSample always gets current cpus
..
Patch Set 16: Verified+1
verified running patche VDSM. Host stats are still collected and reported
(verified
Francesco Romani has posted comments on this change.
Change subject: periodic: document missing VmDispatcher argument
..
Patch Set 1: Verified+1
trivial change. Verified running patched VDSM. No error spotted on the logs.
--
Francesco Romani has posted comments on this change.
Change subject: sampling: rename attributes for clarity
..
Patch Set 2: Verified+1
trivial change. Verified running patched VDSM. No error spotted on the logs.
--
To view,
Yaniv Bronhaim has posted comments on this change.
Change subject: Having logrotate configuration to rotate coredump directory as
root user
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/47833
To unsubs
Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/api.py
File vdsm/g
automat...@ovirt.org has posted comments on this change.
Change subject: lib: sparsify: use common Error class
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: use the response module
..
Patch Set 36:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has uploaded a new change for review.
Change subject: lib: sparsify: use common Error class
..
lib: sparsify: use common Error class
the virtsparsify module used a slightly variant
of the now-common Error class.
Francesco Romani has uploaded a new change for review.
Change subject: lib: utils: consolidate Error class in one place
..
lib: utils: consolidate Error class in one place
Few utilities code have a duplicate Error exception, tha
automat...@ovirt.org has posted comments on this change.
Change subject: lib: utils: consolidate Error class in one place
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Martin Polednik has posted comments on this change.
Change subject: lib: grub2 module
..
Patch Set 1:
(2 comments)
Why do you see grub2-* as too low level?
https://gerrit.ovirt.org/#/c/47946/1/lib/vdsm/grub2.py
File lib/vdsm/
Ramesh N has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/api.py
File vdsm/gluster/api
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: fix brick devices are created with incorrect data
alignment
..
Patch Set 1:
* Update tracker::#1270792::OK
* Check Bug-Url::OK
* Check Public Bu
automat...@ovirt.org has posted comments on this change.
Change subject: tests: functional - convert to run over jsonrpc
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Timothy Asir has uploaded a new change for review.
Change subject: gluster: fix brick devices are created with incorrect data
alignment
..
gluster: fix brick devices are created with incorrect data alignment
Removed make partit
Yeela Kaplan has posted comments on this change.
Change subject: tests: functional - convert to run over jsonrpc
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/45789/10/tests/functional/utils.py
File tests/functiona
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
init: configure multipath on upgrade from ovirt-3.5
multipath configurator was added to vdsm-too
automat...@ovirt.org has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 2:
* Update tracker::#1276736::OK
* Set MODIFIED::bug 1276736#1276736IGNORE, not
Yaniv Bronhaim has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 1: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/47957
To unsubscribe, v
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: ovs: add script name to log
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
init: configure multipath on upgrade from ovirt-3.5
multipath configurator was added to vdsm-too
automat...@ovirt.org has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 2:
* Update tracker::#1276736::OK
* Set MODIFIED::bug 1276736#1276736IGNORE, not
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: ovs: use six.iteritems and six.itervalues
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Yaniv Bronhaim has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/47957
To unsubscribe, visit https:
Yaniv Bronhaim has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/47956
To unsubscribe, visit https:
automat...@ovirt.org has posted comments on this change.
Change subject: hook: after_network_setup_fail
..
Patch Set 19:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
automat...@ovirt.org has posted comments on this change.
Change subject: net: ovs: better rollback
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
Yeela Kaplan has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 1: Verified+1
Same as master.
Builds successfully.
--
To view, visit https://gerrit.ovirt.org/4
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: ovs: start every log with 'OVS: '
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/46906
To
Petr Horáček has abandoned this change.
Change subject: hooks: ovs: start every log with 'OVS: '
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/46906
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-Mes
Francesco Romani has posted comments on this change.
Change subject: migration: added support for convergance schedule
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/46940/4/vdsm/virt/migration.py
File vdsm/virt/mig
Yeela Kaplan has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 1: Verified+1
Same as master.
Builds successfully.
--
To view, visit https://gerrit.ovirt.org/4
Dan Kenigsberg has submitted this change and it was merged.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
init: configure multipath on upgrade from ovirt-3.5
multipath configurator was added to vdsm-too
automat...@ovirt.org has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 3:
* Update tracker::#1276736::OK
* Set MODIFIED::bug 1276736#1276736IGNORE, not
Ido Barkan has posted comments on this change.
Change subject: net: fake sriov device hook
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/47847
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ge
automat...@ovirt.org has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 1:
* Update tracker::#1276736::OK
* Check Bug-Url::OK
* Check Public Bug::#1276736::OK, p
Yeela Kaplan has uploaded a new change for review.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
init: configure multipath on upgrade from ovirt-3.5
multipath configurator was added to vdsm-tool
in ovirt
automat...@ovirt.org has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 1:
* Update tracker::#1276736::OK
* Check Bug-Url::OK
* Check Public Bug::#1276736::OK, p
Yeela Kaplan has uploaded a new change for review.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
init: configure multipath on upgrade from ovirt-3.5
multipath configurator was added to vdsm-tool
in ovirt
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: functional - convert to run over jsonrpc
..
Patch Set 10: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/45789/10/tests/functional/utils.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc cli: allow client to return compatible results
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47923
To unsubscribe, visit htt
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc cli: Allow setting timeout for long operations
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47922
To unsubscribe, visit htt
Yeela Kaplan has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/47941
To unsubscribe, visit https://ger
Yaniv Bronhaim has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 2: Code-Review+1
I was wrong - force is not required in multipath specifically thanks to the
c
Dan Kenigsberg has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/47941
To unsubscribe, visit https:
automat...@ovirt.org has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 2:
* Update tracker::#1276736::OK
* Check Bug-Url::OK
* Check Public Bug::#1276736::OK, p
Yeela Kaplan has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/47941/1/init/vdsmd_init_common.sh.in
File init/vdsm
Yeela Kaplan has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/47941/1/init/vdsmd_init_common.sh.in
File init/vdsmd
Francesco Romani has posted comments on this change.
Change subject: lib: grub2 module
..
Patch Set 1: Code-Review-1
(3 comments)
-1 for visibility
I started reviewing, and gave initial comments, than realized that here we ar
Tomas Jelinek has posted comments on this change.
Change subject: migration: added support for convergance schedule
..
Patch Set 4:
(10 comments)
https://gerrit.ovirt.org/#/c/46940/4/vdsm/virt/migration.py
File vdsm/virt/migra
Yaniv Bronhaim has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/47941/1/init/vdsmd_init_common.sh.in
File init/vds
Yaniv Bronhaim has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/47941/1/init/vdsmd_init_common.sh.in
File init/vds
Dan Kenigsberg has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/47941/1/init/vdsmd_init_common.sh.in
File init/vd
automat...@ovirt.org has posted comments on this change.
Change subject: utils: replace import for persist/unpersist
..
Patch Set 3:
* Update tracker::#1274063::OK
* Set MODIFIED::bug 1274063#1274063IGNORE, not oVirt pr
Dan Kenigsberg has posted comments on this change.
Change subject: utils: replace import for persist/unpersist
..
Patch Set 2: Code-Review+2
Trusting Fabian.
--
To view, visit https://gerrit.ovirt.org/47829
To unsubscribe, vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: replace import for persist/unpersist
..
utils: replace import for persist/unpersist
Use the new ovirt-node Config class for persist/unpersist co
Yaniv Bronhaim has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 1: Code-Review-1
(2 comments)
second ...
https://gerrit.ovirt.org/#/c/47941/1/init/vdsmd_init
Fabian Deutsch has posted comments on this change.
Change subject: utils: replace import for persist/unpersist
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47829
To unsubscribe, visit https://gerrit
automat...@ovirt.org has posted comments on this change.
Change subject: lib: grub2 module
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: hoststats: use custom logger
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: hoststats: remove unneeded attribute
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: hoststats: don't inherit from thread
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: HostStatsThread as periodic operation
..
Patch Set 30:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
1 - 100 of 130 matches
Mail list logo