automat...@ovirt.org has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 4:
* #1277879::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#127787
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: zombiereaper is not removed on vdsm upgrade
..
spec: zombiereaper is not removed on vdsm upgrade
Change-Id: I039ca8102ed910f9be890e3b7fff5375a010
Dan Kenigsberg has posted comments on this change.
Change subject: spec: zombiereaper is not removed on vdsm upgrade
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48240
To unsubscribe, visit https://
automat...@ovirt.org has posted comments on this change.
Change subject: spec: zombiereaper is not removed on vdsm upgrade
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
automat...@ovirt.org has posted comments on this change.
Change subject: build: Use make for generating the test certificates
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build: Use make for generating the test certificates
..
build: Use make for generating the test certificates
It is easier to use make for creating file
Dan Kenigsberg has posted comments on this change.
Change subject: build: Use make for generating the test certificates
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48226
To unsubscribe, visit https
Shahar Havivi has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/48129/3/vdsm/v2v.py
File vdsm/v2v.py:
Lin
Francesco Romani has posted comments on this change.
Change subject: lib: executor: make possible to name work tasks
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/48191/5/lib/vdsm/executor.py
File lib/vdsm/executor.
Nir Soffer has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 8: -Code-Review
(1 comment)
https://gerrit.ovirt.org/#/c/48051/8/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
L
Dan Kenigsberg has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/48051/8/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 19:
Dan Kenigsberg has posted comments on this change.
Change subject: mkimage: lib: add and use umaskset helper
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/48133/2/vdsm/mkimage.py
File vdsm/mkimage.py:
Line 123:
Nir Soffer has posted comments on this change.
Change subject: lib: executor: make possible to name work tasks
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/48191/5/lib/vdsm/executor.py
File lib/vdsm/executor.py:
L
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: use {name} instead of explicit vdsm
..
spec: use {name} instead of explicit vdsm
Change-Id: Ic91ac5dddc595f87b23c04071f3c2e0e66b1f738
Signed-off-
Dan Kenigsberg has posted comments on this change.
Change subject: spec: use {name} instead of explicit vdsm
..
Patch Set 1: Code-Review+2 Continuous-Integration+1
unrelated CI failure
--
To view, visit https://gerrit.ovirt.o
automat...@ovirt.org has posted comments on this change.
Change subject: spec: use {name} instead of explicit vdsm
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vie
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 4:
@Oved, Piotr: not sure about CI jobs state. Worst case scenario, I will run
tests locally like I did d
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: fix semaphore misusing
..
Patch Set 1:
* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
* Check P
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48348
to review the following change.
Change subject: sampling: fix semaphore misusing
..
sampling: fix semaphore misusing
We
Milan Zamazal has posted comments on this change.
Change subject: periodic: more cautious return to fast path
..
Patch Set 2: Code-Review-1
(6 comments)
Looks like a good idea to me. -1 just due to the typos.
https://gerrit.o
Ondřej Svoboda has posted comments on this change.
Change subject: bonding defaults: for validation, we need to be aware of all
options
..
Patch Set 1: Verified+1
testSetupNetworksAddDelBondedNetwork passed. I also modified it
Tomas Jelinek has posted comments on this change.
Change subject: migration: added support for convergance schedule
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46940/4/vdsm/virt/migration.py
File vdsm/virt/migrati
automat...@ovirt.org has posted comments on this change.
Change subject: migration: added support for convergance schedule
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: migration: Added support for setting the convergenceSchedule
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Francesco Romani has posted comments on this change.
Change subject: lib: executor: make possible to name work tasks
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/48191/5/lib/vdsm/executor.py
File lib/vdsm/executor
Tomas Jelinek has posted comments on this change.
Change subject: migration added migrateChangeParams verb
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/46934/7/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-sch
Dan Kenigsberg has posted comments on this change.
Change subject: mkimage: lib: add and use umaskset helper
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/48133/2/lib/vdsm/constants.py.in
File lib/vdsm/constants.py
Tomas Jelinek has posted comments on this change.
Change subject: migration: Add support for max migration bandwidth setting
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/46846/8/vdsm/rpc/vdsmapi-schema.json
File v
automat...@ovirt.org has posted comments on this change.
Change subject: migration: Add support for max migration bandwidth setting
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
automat...@ovirt.org has posted comments on this change.
Change subject: migration: added support for convergance schedule
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: migration added migrateChangeParams verb
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
automat...@ovirt.org has posted comments on this change.
Change subject: migration: Added support for setting the convergenceSchedule
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Francesco Romani has posted comments on this change.
Change subject: mkimage: lib: add and use umaskset helper
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/48133/2/vdsm/umaskset
File vdsm/umaskset:
L
Nir Soffer has posted comments on this change.
Change subject: lib: executor: make possible to name work tasks
..
Patch Set 5: Code-Review-1
(2 comments)
Should work, but I'm not fan of adding stuff to Worker, when the callabl
Dan Kenigsberg has posted comments on this change.
Change subject: daemon: enable cpu affinity by default
..
Patch Set 1:
We need to make sure that running Vdsm on a a single-CPU (virtual) host is not
commonplace.
Please test
Dan Kenigsberg has submitted this change and it was merged.
Change subject: remove redundant tabs from vdsmd init script
..
remove redundant tabs from vdsmd init script
Change-Id: I8c09fb78b14bf2184c69f01bed34333d9fc43eed
Signe
Dan Kenigsberg has posted comments on this change.
Change subject: remove redundant tabs from vdsmd init script
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48233
To unsubscribe, visit https://gerri
automat...@ovirt.org has posted comments on this change.
Change subject: remove redundant tabs from vdsmd init script
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: periodic: use name for the work sent to executor
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48193
To unsubscribe, visit https://g
Dan Kenigsberg has posted comments on this change.
Change subject: lib: executor: make possible to name work tasks
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48191
To unsubscribe, visit https://ge
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: fix semaphore misusing
..
Patch Set 3:
* #1250839::Update tracker: OK
* Set MODIFIED::bug 1250839#1250839IGNORE, not oVirt prod but vdsm
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: fix semaphore misusing
..
Patch Set 2: Continuous-Integration+1
Copying CI from PS1
--
To view, visit https://gerrit.ovirt.org/48332
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sampling: fix semaphore misusing
..
sampling: fix semaphore misusing
We should release the internal _sampling semaphore only
if we acquired it succesfu
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: fix semaphore misusing
..
Patch Set 2: Code-Review+2
omg
--
To view, visit https://gerrit.ovirt.org/48332
To unsubscribe, visit https://gerrit.ovirt
automat...@ovirt.org has posted comments on this change.
Change subject: vmchannel: performance enhancment. changing thread name
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovir
Jenkins CI RO has abandoned this change.
Change subject: vmchannel: performance enhancment. changing thread name
..
Abandoned
Abandoned due to no activity - please restore if still relevant
--
To view, visit https://gerrit.ov
Jenkins CI RO has posted comments on this change.
Change subject: vmchannel: performance enhancment. changing thread name
..
Patch Set 1:
Abandoned due to no activity - please restore if still relevant
--
To view, visit https
Ondřej Svoboda has posted comments on this change.
Change subject: bonding defaults: for validation, we need to be aware of all
options
..
Patch Set 5:
For the record, "mode=1 primary=em1" options DO work. I must have forgotte
Francesco Romani has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/48129/3/vdsm/v2v.py
File vdsm/v2v.py:
Francesco Romani has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 3: Code-Review-1
sorry I missed one thing
--
To view, visit https://gerrit.ovirt.or
automat...@ovirt.org has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 2:
* #1279555::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279555::OK, public bug
* Check Product
Ondřej Svoboda has uploaded a new change for review.
Change subject: bonding defaults: for validation, we need to be aware of all
options
..
bonding defaults: for validation, we need to be aware of all options
In the commit b01
automat...@ovirt.org has posted comments on this change.
Change subject: bonding defaults: for validation, we need to be aware of all
options
..
Patch Set 1:
* #1262496::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bu
Francesco Romani has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 2: Verified+1
verified together: 48191, 48193, 48192, 48333
verified with 48332 using steps provided in
Francesco Romani has posted comments on this change.
Change subject: lib: executor: pack items in a Task tuple
..
Patch Set 5: Verified+1
verified together: 48191, 48193, 48192, 48333
verified with 48332 using steps provided in
Francesco Romani has posted comments on this change.
Change subject: periodic: use name for the work sent to executor
..
Patch Set 5: Verified+1
verified together: 48191, 48193, 48192, 48333
verified with 48332 using steps prov
Francesco Romani has posted comments on this change.
Change subject: lib: executor: make possible to name work tasks
..
Patch Set 5: Verified+1
verified together: 48191, 48193, 48192, 48333
verified with 48332 using steps provi
Francesco Romani has posted comments on this change.
Change subject: sampling: fix semaphore misusing
..
Patch Set 2: Verified+1
verified with the steps as per https://bugzilla.redhat.com/1250839
--
To view, visit https://ger
Shahar Havivi has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 3:
sure
ova needs tests as well...
--
To view, visit https://gerrit.ovirt.org/48129
To
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 4:
I asked CI team offline to take a look why none of the jobs were triggered.
--
To view, visit https:/
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 4:
@Francesco - so should we merge it without CI?
Or, is it in the works?
--
To view, visit https://gerrit.o
Dan Kenigsberg has posted comments on this change.
Change subject: bonding defaults: for validation, we need to be aware of all
options
..
Patch Set 4: Code-Review+2
Copying score
--
To view, visit https://gerrit.ovirt.org/4
Dan Kenigsberg has submitted this change and it was merged.
Change subject: bonding defaults: for validation, we need to be aware of all
options
..
bonding defaults: for validation, we need to be aware of all options
In the co
automat...@ovirt.org has posted comments on this change.
Change subject: bonding defaults: for validation, we need to be aware of all
options
..
Patch Set 5:
* #1262496::Update tracker: OK
* Set MODIFIED::bug 1262496#12624
Ala Hino has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/48308/2/tests/storageServerTests.py
File tests/storage
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 4:
* #1278880::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1278880::OK,
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, vis
automat...@ovirt.org has posted comments on this change.
Change subject: lib: executor: make possible to name work tasks
..
Patch Set 5:
* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, publi
automat...@ovirt.org has posted comments on this change.
Change subject: lib: executor: pack items in a Task tuple
..
Patch Set 5:
* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: use name for the work sent to executor
..
Patch Set 5:
* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, publ
automat...@ovirt.org has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 2:
* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: fix semaphore misusing
..
Patch Set 2:
* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
* Check P
Bala.FA has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https:
automat...@ovirt.org has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
automat...@ovirt.org has posted comments on this change.
Change subject: lib: executor: pack items in a Task tuple
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: fix semaphore misusing
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: lib: executor: make possible to name work tasks
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Francesco Romani has uploaded a new change for review.
Change subject: sampling: fix semaphore misusing
..
sampling: fix semaphore misusing
We should release the internal _sampling semaphore only
if we acquired it succesfully.
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: use name for the work sent to executor
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Francesco Romani has uploaded a new change for review.
Change subject: lib: executor: log pool status on discard
..
lib: executor: log pool status on discard
Log the pool size and content when a worker is discarded,
to make trou
automat...@ovirt.org has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug ur
Francesco Romani has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 3: Code-Review+2
(1 comment)
please plan some tests for this patch. It is fine if yo
Francesco Romani has posted comments on this change.
Change subject: host stats: Add cpusStatus to vdsStats
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/46270/7/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-sc
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 12: Code-Review+1
thanks for the updates! At first glance looks fine now, will have another
Ramesh N has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 4: Code-Review+2
raising score after BZ was added
--
To view, visit https://gerrit.ovirt.org/48293
To un
Francesco Romani has posted comments on this change.
Change subject: scheduler: use single instance
..
Patch Set 2: Code-Review+2
raising score after BZ was added
--
To view, visit https://gerrit.ovirt.org/48287
To unsubscrib
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 4:
@Oved, it seems that 3.6 was not added to the stable branch set, that should be
the reason why CI jobs
David Caro has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/48268/9/automation/lago-control.sh
File aut
Ramesh N has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 6:
(1 comment)
I changed the schema to follow the approach used in volumeSnapshotConfigSet.
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
automat...@ovirt.org has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Milan Zamazal has posted comments on this change.
Change subject: gitignore: Missing autogenerated files added
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48328
To unsubscribe, visit https://gerrit.ov
automat...@ovirt.org has posted comments on this change.
Change subject: gitignore: Missing autogenerated files added
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 12:
* #1264003::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1264003::OK,
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 6: Code-Review-1
Please follow approach as it is used in volumeSnapshotConfigSet.
--
Bala.FA has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/43821/6/vdsm/gluster/exception.py
Fi
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/9/tests/hoststatsTests.py
File tests/hoststatsT
Shahar Havivi has posted comments on this change.
Change subject: v2v: add fake virt-v2v process for testing without virt-v2v
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/47738
To unsubscribe, visit ht
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 9:
(6 comments)
https://gerrit.ovirt.org/#/c/46269/9/tests/hoststatsTests.py
File tests/hoststats
101 - 200 of 202 matches
Mail list logo
