Change in vdsm[master]: lib: executor: pack items in a Task tuple

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: lib: executor: pack items in a Task tuple .. Patch Set 5: * #1250839::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1250839::OK, public bug

Change in vdsm[master]: periodic: use name for the work sent to executor

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: periodic: use name for the work sent to executor .. Patch Set 5: * #1250839::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1250839::OK,

Change in vdsm[master]: lib: executor: log pool status on discard

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: lib: executor: log pool status on discard .. Patch Set 2: * #1250839::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1250839::OK, public bug

Change in vdsm[master]: sampling: fix semaphore misusing

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: fix semaphore misusing .. Patch Set 2: * #1250839::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1250839::OK, public bug * Check

Change in vdsm[master]: lib: executor: make possible to name work tasks

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: lib: executor: make possible to name work tasks .. Patch Set 5: * #1250839::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1250839::OK,

Change in vdsm[master]: bonding defaults: for validation, we need to be aware of all...

2015-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: bonding defaults: for validation, we need to be aware of all options .. Patch Set 4: Code-Review+2 Copying score -- To view, visit

Change in vdsm[master]: bonding defaults: for validation, we need to be aware of all...

2015-11-10 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: bonding defaults: for validation, we need to be aware of all options .. bonding defaults: for validation, we need to be aware of all options In the

Change in vdsm[master]: bonding defaults: for validation, we need to be aware of all...

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: bonding defaults: for validation, we need to be aware of all options .. Patch Set 5: * #1262496::Update tracker: OK * Set MODIFIED::bug

Change in vdsm[ovirt-3.6]: jsonrpc: executor based thread factory

2015-11-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 4: I asked CI team offline to take a look why none of the jobs were triggered. -- To view, visit

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

2015-11-10 Thread rnachimu
Ramesh N has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/43821 To unsubscribe, visit

Change in vdsm[master]: sampling: fix semaphore misusing

2015-11-10 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: sampling: fix semaphore misusing .. sampling: fix semaphore misusing We should release the internal _sampling semaphore only if we acquired it succesfully.

Change in vdsm[master]: lib: executor: make possible to name work tasks

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: lib: executor: make possible to name work tasks .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

2015-11-10 Thread barumuga
Bala.FA has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43821 To unsubscribe, visit

Change in vdsm[master]: lib: executor: log pool status on discard

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: lib: executor: log pool status on discard .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: lib: executor: pack items in a Task tuple

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: lib: executor: pack items in a Task tuple .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sampling: fix semaphore misusing

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: fix semaphore misusing .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: lib: executor: log pool status on discard

2015-11-10 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: lib: executor: log pool status on discard .. lib: executor: log pool status on discard Log the pool size and content when a worker is discarded, to make

Change in vdsm[master]: periodic: use name for the work sent to executor

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: periodic: use name for the work sent to executor .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[ovirt-3.6]: jsonrpc: executor based thread factory

2015-11-10 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 4: @Francesco - so should we merge it without CI? Or, is it in the works? -- To view, visit

Change in vdsm[master]: sampling: fix semaphore misusing

2015-11-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: sampling: fix semaphore misusing .. Patch Set 2: Verified+1 verified with the steps as per https://bugzilla.redhat.com/1250839 -- To view, visit

Change in vdsm[master]: v2v: add fake virt-v2v process for testing without virt-v2v

2015-11-10 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: add fake virt-v2v process for testing without virt-v2v .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/47738 To unsubscribe, visit

Change in vdsm[master]: gitignore: Missing autogenerated files added

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gitignore: Missing autogenerated files added .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: host stats: Collect stats from online cpu cores only

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 12: * #1264003::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: lib: executor: make possible to name work tasks

2015-11-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: executor: make possible to name work tasks .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/48191/5/lib/vdsm/executor.py File

Change in vdsm[master]: migration: Added support for setting the convergenceSchedule

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration: Added support for setting the convergenceSchedule .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: migration: added support for convergance schedule

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration: added support for convergance schedule .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: migration: added support for convergance schedule

2015-11-10 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: migration: added support for convergance schedule .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/46940/4/vdsm/virt/migration.py File

Change in vdsm[master]: spec: use {name} instead of explicit vdsm

2015-11-10 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: use {name} instead of explicit vdsm .. spec: use {name} instead of explicit vdsm Change-Id: Ic91ac5dddc595f87b23c04071f3c2e0e66b1f738

Change in vdsm[master]: spec: use {name} instead of explicit vdsm

2015-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: spec: use {name} instead of explicit vdsm .. Patch Set 1: Code-Review+2 Continuous-Integration+1 unrelated CI failure -- To view, visit

Change in vdsm[master]: spec: use {name} instead of explicit vdsm

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: spec: use {name} instead of explicit vdsm .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: lib: executor: make possible to name work tasks

2015-11-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: executor: make possible to name work tasks .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/48191/5/lib/vdsm/executor.py File lib/vdsm/executor.py:

Change in vdsm[master]: mkimage: lib: add and use umaskset helper

2015-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: mkimage: lib: add and use umaskset helper .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/48133/2/vdsm/mkimage.py File vdsm/mkimage.py: Line 123:

Change in vdsm[master]: vdsm.conf: Add drop-in dir

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 2: * #1279555::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279555::OK, public bug * Check

Change in vdsm[master]: v2v: ova should support zip and extracted directory formats

2015-11-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: ova should support zip and extracted directory formats .. Patch Set 3: Code-Review-1 sorry I missed one thing -- To view, visit

Change in vdsm[master]: v2v: ova should support zip and extracted directory formats

2015-11-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: ova should support zip and extracted directory formats .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/48129/3/vdsm/v2v.py File vdsm/v2v.py:

Change in vdsm[master]: vmchannel: performance enhancment. changing thread name

2015-11-10 Thread Jenkins CI RO
Jenkins CI RO has abandoned this change. Change subject: vmchannel: performance enhancment. changing thread name .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: vmchannel: performance enhancment. changing thread name

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vmchannel: performance enhancment. changing thread name .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit

Change in vdsm[master]: vmchannel: performance enhancment. changing thread name

2015-11-10 Thread Jenkins CI RO
Jenkins CI RO has posted comments on this change. Change subject: vmchannel: performance enhancment. changing thread name .. Patch Set 1: Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: sampling: fix semaphore misusing

2015-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: sampling: fix semaphore misusing .. Patch Set 2: Code-Review+2 omg -- To view, visit https://gerrit.ovirt.org/48332 To unsubscribe, visit

Change in vdsm[master]: sampling: fix semaphore misusing

2015-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: sampling: fix semaphore misusing .. Patch Set 2: Continuous-Integration+1 Copying CI from PS1 -- To view, visit https://gerrit.ovirt.org/48332 To

Change in vdsm[master]: sampling: fix semaphore misusing

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: fix semaphore misusing .. Patch Set 3: * #1250839::Update tracker: OK * Set MODIFIED::bug 1250839#1250839IGNORE, not oVirt prod but

Change in vdsm[master]: sampling: fix semaphore misusing

2015-11-10 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: sampling: fix semaphore misusing .. sampling: fix semaphore misusing We should release the internal _sampling semaphore only if we acquired it

Change in vdsm[master]: remove redundant tabs from vdsmd init script

2015-11-10 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: remove redundant tabs from vdsmd init script .. remove redundant tabs from vdsmd init script Change-Id: I8c09fb78b14bf2184c69f01bed34333d9fc43eed

Change in vdsm[master]: remove redundant tabs from vdsmd init script

2015-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: remove redundant tabs from vdsmd init script .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48233 To unsubscribe, visit

Change in vdsm[master]: remove redundant tabs from vdsmd init script

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: remove redundant tabs from vdsmd init script .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: migration added migrateChangeParams verb

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration added migrateChangeParams verb .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: Added support for setting the convergenceSchedule

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration: Added support for setting the convergenceSchedule .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: mkimage: lib: add and use umaskset helper

2015-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: mkimage: lib: add and use umaskset helper .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/48133/2/lib/vdsm/constants.py.in File

Change in vdsm[master]: migration: Add support for max migration bandwidth setting

2015-11-10 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: migration: Add support for max migration bandwidth setting .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/46846/8/vdsm/rpc/vdsmapi-schema.json File

Change in vdsm[master]: lib: executor: log pool status on discard

2015-11-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: executor: log pool status on discard .. Patch Set 2: Verified+1 verified together: 48191, 48193, 48192, 48333 verified with 48332 using steps provided

Change in vdsm[ovirt-3.6]: bonding defaults: for validation, we need to be aware of all...

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: bonding defaults: for validation, we need to be aware of all options .. Patch Set 1: * #1262496::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: lib: executor: make possible to name work tasks

2015-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: lib: executor: make possible to name work tasks .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48191 To unsubscribe, visit

Change in vdsm[master]: lib: executor: make possible to name work tasks

2015-11-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: executor: make possible to name work tasks .. Patch Set 5: Code-Review-1 (2 comments) Should work, but I'm not fan of adding stuff to Worker, when the

Change in vdsm[master]: migration: Add support for max migration bandwidth setting

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration: Add support for max migration bandwidth setting .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: migration: added support for convergance schedule

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration: added support for convergance schedule .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: lib: executor: pack items in a Task tuple

2015-11-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: executor: pack items in a Task tuple .. Patch Set 5: Verified+1 verified together: 48191, 48193, 48192, 48333 verified with 48332 using steps provided

Change in vdsm[master]: lib: executor: make possible to name work tasks

2015-11-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: executor: make possible to name work tasks .. Patch Set 5: Verified+1 verified together: 48191, 48193, 48192, 48333 verified with 48332 using steps

Change in vdsm[master]: periodic: use name for the work sent to executor

2015-11-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: periodic: use name for the work sent to executor .. Patch Set 5: Verified+1 verified together: 48191, 48193, 48192, 48333 verified with 48332 using steps

Change in vdsm[ovirt-3.6]: bonding defaults: for validation, we need to be aware of all...

2015-11-10 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: bonding defaults: for validation, we need to be aware of all options .. bonding defaults: for validation, we need to be aware of all options In the commit

Change in vdsm[master]: bonding defaults: for validation, we need to be aware of all...

2015-11-10 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: bonding defaults: for validation, we need to be aware of all options .. Patch Set 5: For the record, "mode=1 primary=em1" options DO work. I must have

Change in vdsm[master]: periodic: use name for the work sent to executor

2015-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: periodic: use name for the work sent to executor .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48193 To unsubscribe, visit

Change in vdsm[master]: daemon: enable cpu affinity by default

2015-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: daemon: enable cpu affinity by default .. Patch Set 1: We need to make sure that running Vdsm on a a single-CPU (virtual) host is not commonplace. Please

Change in vdsm[master]: mkimage: lib: add and use umaskset helper

2015-11-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: mkimage: lib: add and use umaskset helper .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/48133/2/vdsm/umaskset File vdsm/umaskset:

Change in vdsm[master]: migration added migrateChangeParams verb

2015-11-10 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: migration added migrateChangeParams verb .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/46934/7/vdsm/rpc/vdsmapi-schema.json File

Change in vdsm[master]: clusterlock: Remove unneeded workaround

2015-11-10 Thread ishaby
Idan Shaby has posted comments on this change. Change subject: clusterlock: Remove unneeded workaround .. Patch Set 4: Sure: I had an environment of three hosts. I blocked the outgoing packets from one of the hosts (id=3) to

Change in vdsm[ovirt-3.6]: v2v: ova should support zip and extracted directory formats

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: ova should support zip and extracted directory formats .. Patch Set 1: * #1277879::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[ovirt-3.6]: v2v: ova should support zip and extracted directory formats

2015-11-10 Thread shavivi
Shahar Havivi has uploaded a new change for review. Change subject: v2v: ova should support zip and extracted directory formats .. v2v: ova should support zip and extracted directory formats Change-Id:

Change in vdsm[master]: clusterlock: Remove unneeded workaround

2015-11-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clusterlock: Remove unneeded workaround .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/31162 To unsubscribe, visit

Change in vdsm[master]: clusterlock: Remove unneeded workaround

2015-11-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clusterlock: Remove unneeded workaround .. Patch Set 4: Thanks Idan! -- To view, visit https://gerrit.ovirt.org/31162 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: v2v: ova should support zip and extracted directory formats

2015-11-10 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: ova should support zip and extracted directory formats .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/48402 To unsubscribe, visit

Change in vdsm[master]: Adding functional tests to check-patch

2015-11-10 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Adding functional tests to check-patch .. Patch Set 2: Verified-1 we can abandon this try - we continue with https://gerrit.ovirt.org/#/c/48268/ -- To view,

Change in vdsm[master]: clusterlock: Remove unneeded workaround

2015-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: clusterlock: Remove unneeded workaround .. Patch Set 4: Continuous-Integration+1 unrelated failure 17:26:54 Last metadata expiration check performed 0:00:02

Change in vdsm[ovirt-3.5]: netinfo: rework reporting of DHCPv4/6 on network devices

2015-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: rework reporting of DHCPv4/6 on network devices .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/48399/1//COMMIT_MSG Commit

Change in vdsm[master]: net: tests: test network's iface

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: tests: test network's iface .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time

2015-11-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpcvdscli: improve functional network tests duration time .. Patch Set 1: Verified-1 After testing both invocation it seems that there is still place for

Change in vdsm[ovirt-3.6]: bonding defaults: for validation, we need to be aware of all...

2015-11-10 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: bonding defaults: for validation, we need to be aware of all options .. Patch Set 1: Verified+1 testSetupNetworksAddDelBondedNetwork passed. I also modified

Change in vdsm[master]: periodic: more cautious return to fast path

2015-11-10 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: periodic: more cautious return to fast path .. Patch Set 2: Code-Review-1 (6 comments) Looks like a good idea to me. -1 just due to the typos.

Change in vdsm[ovirt-3.6]: sampling: fix semaphore misusing

2015-11-10 Thread fromani
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/48348 to review the following change. Change subject: sampling: fix semaphore misusing .. sampling: fix semaphore misusing We

Change in vdsm[ovirt-3.6]: sampling: fix semaphore misusing

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: fix semaphore misusing .. Patch Set 1: * #1250839::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1250839::OK, public bug * Check

Change in vdsm[ovirt-3.6]: jsonrpc: executor based thread factory

2015-11-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 4: @Oved, Piotr: not sure about CI jobs state. Worst case scenario, I will run tests locally like I did

Change in vdsm[master]: Adding python3 run for nosetests

2015-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Adding python3 run for nosetests .. Patch Set 8: (3 comments) https://gerrit.ovirt.org/#/c/48051/8/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 19:

Change in vdsm[master]: Adding python3 run for nosetests

2015-11-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Adding python3 run for nosetests .. Patch Set 8: -Code-Review (1 comment) https://gerrit.ovirt.org/#/c/48051/8/lib/vdsm/config.py.in File lib/vdsm/config.py.in:

Change in vdsm[master]: net: ifup ignores invalid gateway settings

2015-11-10 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: net: ifup ignores invalid gateway settings .. net: ifup ignores invalid gateway settings When we try to set address and gateway on different subnets, ifup just

Change in vdsm[master]: net: ifup ignores invalid gateway settings

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: ifup ignores invalid gateway settings .. Patch Set 1: * #1270688::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1270688::OK, public

Change in vdsm[master]: net: tests: test if network's iface

2015-11-10 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: net: tests: test if network's iface .. net: tests: test if network's iface Change-Id: If45fb63247b5e5b21721a23d8781a4ed80e58932 Signed-off-by: Petr Horáček

Change in vdsm[master]: net: tests: test if network's iface

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: tests: test if network's iface .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: lib: executor: make possible to name work tasks

2015-11-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: executor: make possible to name work tasks .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/48191/5/lib/vdsm/executor.py File

Change in vdsm[master]: build: Use make for generating the test certificates

2015-11-10 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: build: Use make for generating the test certificates .. build: Use make for generating the test certificates It is easier to use make for creating

Change in vdsm[master]: build: Use make for generating the test certificates

2015-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: build: Use make for generating the test certificates .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48226 To unsubscribe, visit

Change in vdsm[master]: v2v: ova should support zip and extracted directory formats

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: ova should support zip and extracted directory formats .. Patch Set 5: * #1277879::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: gluster: Set mount path based on gluster volume info

2015-11-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Set mount path based on gluster volume info .. Patch Set 4: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/48308/4/tests/storageServerTests.py

Change in vdsm[master]: v2v: ova should support zip and extracted directory formats

2015-11-10 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: ova should support zip and extracted directory formats .. Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/48129/3/vdsm/v2v.py File vdsm/v2v.py:

Change in vdsm[master]: spec: zombiereaper is not removed on vdsm upgrade

2015-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: spec: zombiereaper is not removed on vdsm upgrade .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48240 To unsubscribe, visit

Change in vdsm[master]: spec: zombiereaper is not removed on vdsm upgrade

2015-11-10 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: zombiereaper is not removed on vdsm upgrade .. spec: zombiereaper is not removed on vdsm upgrade Change-Id:

Change in vdsm[master]: spec: zombiereaper is not removed on vdsm upgrade

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: spec: zombiereaper is not removed on vdsm upgrade .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.

Change in vdsm[master]: build: Use make for generating the test certificates

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: build: Use make for generating the test certificates .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.

Change in vdsm[master]: v2v: ova should support zip and extracted directory formats

2015-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: ova should support zip and extracted directory formats .. Patch Set 4: * #1277879::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: v2v: ova should support zip and extracted directory formats

2015-11-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: ova should support zip and extracted directory formats .. Patch Set 4: Code-Review-1 (1 comment) one question inside, -1 for visibility.

Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time

2015-11-10 Thread piotr . kliczewski
Piotr Kliczewski has uploaded a new change for review. Change subject: jsonrpcvdscli: improve functional network tests duration time .. jsonrpcvdscli: improve functional network tests duration time The tests were creating new

Change in vdsm[master]: v2v: ova should support zip and extracted directory formats

2015-11-10 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: ova should support zip and extracted directory formats .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/48129/4/vdsm/v2v.py File vdsm/v2v.py:

<    1   2   3   >