automat...@ovirt.org has posted comments on this change.
Change subject: lib: executor: pack items in a Task tuple
..
Patch Set 5:
* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: use name for the work sent to executor
..
Patch Set 5:
* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK,
automat...@ovirt.org has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 2:
* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: fix semaphore misusing
..
Patch Set 2:
* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: lib: executor: make possible to name work tasks
..
Patch Set 5:
* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK,
Dan Kenigsberg has posted comments on this change.
Change subject: bonding defaults: for validation, we need to be aware of all
options
..
Patch Set 4: Code-Review+2
Copying score
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: bonding defaults: for validation, we need to be aware of all
options
..
bonding defaults: for validation, we need to be aware of all options
In the
automat...@ovirt.org has posted comments on this change.
Change subject: bonding defaults: for validation, we need to be aware of all
options
..
Patch Set 5:
* #1262496::Update tracker: OK
* Set MODIFIED::bug
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 4:
I asked CI team offline to take a look why none of the jobs were triggered.
--
To view, visit
Ramesh N has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit
Francesco Romani has uploaded a new change for review.
Change subject: sampling: fix semaphore misusing
..
sampling: fix semaphore misusing
We should release the internal _sampling semaphore only
if we acquired it succesfully.
automat...@ovirt.org has posted comments on this change.
Change subject: lib: executor: make possible to name work tasks
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Bala.FA has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: lib: executor: pack items in a Task tuple
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: fix semaphore misusing
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has uploaded a new change for review.
Change subject: lib: executor: log pool status on discard
..
lib: executor: log pool status on discard
Log the pool size and content when a worker is discarded,
to make
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: use name for the work sent to executor
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 4:
@Francesco - so should we merge it without CI?
Or, is it in the works?
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: sampling: fix semaphore misusing
..
Patch Set 2: Verified+1
verified with the steps as per https://bugzilla.redhat.com/1250839
--
To view, visit
Shahar Havivi has posted comments on this change.
Change subject: v2v: add fake virt-v2v process for testing without virt-v2v
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/47738
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: gitignore: Missing autogenerated files added
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 12:
* #1264003::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Francesco Romani has posted comments on this change.
Change subject: lib: executor: make possible to name work tasks
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/48191/5/lib/vdsm/executor.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: migration: Added support for setting the convergenceSchedule
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: migration: added support for convergance schedule
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Tomas Jelinek has posted comments on this change.
Change subject: migration: added support for convergance schedule
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46940/4/vdsm/virt/migration.py
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: use {name} instead of explicit vdsm
..
spec: use {name} instead of explicit vdsm
Change-Id: Ic91ac5dddc595f87b23c04071f3c2e0e66b1f738
Dan Kenigsberg has posted comments on this change.
Change subject: spec: use {name} instead of explicit vdsm
..
Patch Set 1: Code-Review+2 Continuous-Integration+1
unrelated CI failure
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: spec: use {name} instead of explicit vdsm
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Nir Soffer has posted comments on this change.
Change subject: lib: executor: make possible to name work tasks
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/48191/5/lib/vdsm/executor.py
File lib/vdsm/executor.py:
Dan Kenigsberg has posted comments on this change.
Change subject: mkimage: lib: add and use umaskset helper
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/48133/2/vdsm/mkimage.py
File vdsm/mkimage.py:
Line 123:
automat...@ovirt.org has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 2:
* #1279555::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279555::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 3: Code-Review-1
sorry I missed one thing
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/48129/3/vdsm/v2v.py
File vdsm/v2v.py:
Jenkins CI RO has abandoned this change.
Change subject: vmchannel: performance enhancment. changing thread name
..
Abandoned
Abandoned due to no activity - please restore if still relevant
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: vmchannel: performance enhancment. changing thread name
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit
Jenkins CI RO has posted comments on this change.
Change subject: vmchannel: performance enhancment. changing thread name
..
Patch Set 1:
Abandoned due to no activity - please restore if still relevant
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: fix semaphore misusing
..
Patch Set 2: Code-Review+2
omg
--
To view, visit https://gerrit.ovirt.org/48332
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: fix semaphore misusing
..
Patch Set 2: Continuous-Integration+1
Copying CI from PS1
--
To view, visit https://gerrit.ovirt.org/48332
To
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: fix semaphore misusing
..
Patch Set 3:
* #1250839::Update tracker: OK
* Set MODIFIED::bug 1250839#1250839IGNORE, not oVirt prod but
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sampling: fix semaphore misusing
..
sampling: fix semaphore misusing
We should release the internal _sampling semaphore only
if we acquired it
Dan Kenigsberg has submitted this change and it was merged.
Change subject: remove redundant tabs from vdsmd init script
..
remove redundant tabs from vdsmd init script
Change-Id: I8c09fb78b14bf2184c69f01bed34333d9fc43eed
Dan Kenigsberg has posted comments on this change.
Change subject: remove redundant tabs from vdsmd init script
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48233
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: remove redundant tabs from vdsmd init script
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
automat...@ovirt.org has posted comments on this change.
Change subject: migration added migrateChangeParams verb
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: migration: Added support for setting the convergenceSchedule
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Dan Kenigsberg has posted comments on this change.
Change subject: mkimage: lib: add and use umaskset helper
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/48133/2/lib/vdsm/constants.py.in
File
Tomas Jelinek has posted comments on this change.
Change subject: migration: Add support for max migration bandwidth setting
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/46846/8/vdsm/rpc/vdsmapi-schema.json
File
Francesco Romani has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 2: Verified+1
verified together: 48191, 48193, 48192, 48333
verified with 48332 using steps provided
automat...@ovirt.org has posted comments on this change.
Change subject: bonding defaults: for validation, we need to be aware of all
options
..
Patch Set 1:
* #1262496::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Dan Kenigsberg has posted comments on this change.
Change subject: lib: executor: make possible to name work tasks
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48191
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: lib: executor: make possible to name work tasks
..
Patch Set 5: Code-Review-1
(2 comments)
Should work, but I'm not fan of adding stuff to Worker, when the
automat...@ovirt.org has posted comments on this change.
Change subject: migration: Add support for max migration bandwidth setting
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: migration: added support for convergance schedule
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Francesco Romani has posted comments on this change.
Change subject: lib: executor: pack items in a Task tuple
..
Patch Set 5: Verified+1
verified together: 48191, 48193, 48192, 48333
verified with 48332 using steps provided
Francesco Romani has posted comments on this change.
Change subject: lib: executor: make possible to name work tasks
..
Patch Set 5: Verified+1
verified together: 48191, 48193, 48192, 48333
verified with 48332 using steps
Francesco Romani has posted comments on this change.
Change subject: periodic: use name for the work sent to executor
..
Patch Set 5: Verified+1
verified together: 48191, 48193, 48192, 48333
verified with 48332 using steps
Ondřej Svoboda has uploaded a new change for review.
Change subject: bonding defaults: for validation, we need to be aware of all
options
..
bonding defaults: for validation, we need to be aware of all options
In the commit
Ondřej Svoboda has posted comments on this change.
Change subject: bonding defaults: for validation, we need to be aware of all
options
..
Patch Set 5:
For the record, "mode=1 primary=em1" options DO work. I must have
Dan Kenigsberg has posted comments on this change.
Change subject: periodic: use name for the work sent to executor
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48193
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: daemon: enable cpu affinity by default
..
Patch Set 1:
We need to make sure that running Vdsm on a a single-CPU (virtual) host is not
commonplace.
Please
Francesco Romani has posted comments on this change.
Change subject: mkimage: lib: add and use umaskset helper
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/48133/2/vdsm/umaskset
File vdsm/umaskset:
Tomas Jelinek has posted comments on this change.
Change subject: migration added migrateChangeParams verb
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/46934/7/vdsm/rpc/vdsmapi-schema.json
File
Idan Shaby has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 4:
Sure:
I had an environment of three hosts.
I blocked the outgoing packets from one of the hosts (id=3) to
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 1:
* #1277879::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: ova should support zip and extracted directory formats
..
v2v: ova should support zip and extracted directory formats
Change-Id:
Nir Soffer has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/31162
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 4:
Thanks Idan!
--
To view, visit https://gerrit.ovirt.org/31162
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48402
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding functional tests to check-patch
..
Patch Set 2: Verified-1
we can abandon this try - we continue with https://gerrit.ovirt.org/#/c/48268/
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 4: Continuous-Integration+1
unrelated failure
17:26:54 Last metadata expiration check performed 0:00:02
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: rework reporting of DHCPv4/6 on network devices
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/48399/1//COMMIT_MSG
Commit
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: test network's iface
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: improve functional network tests duration time
..
Patch Set 1: Verified-1
After testing both invocation it seems that there is still place for
Ondřej Svoboda has posted comments on this change.
Change subject: bonding defaults: for validation, we need to be aware of all
options
..
Patch Set 1: Verified+1
testSetupNetworksAddDelBondedNetwork passed. I also modified
Milan Zamazal has posted comments on this change.
Change subject: periodic: more cautious return to fast path
..
Patch Set 2: Code-Review-1
(6 comments)
Looks like a good idea to me. -1 just due to the typos.
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48348
to review the following change.
Change subject: sampling: fix semaphore misusing
..
sampling: fix semaphore misusing
We
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: fix semaphore misusing
..
Patch Set 1:
* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 4:
@Oved, Piotr: not sure about CI jobs state. Worst case scenario, I will run
tests locally like I did
Dan Kenigsberg has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/48051/8/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 19:
Nir Soffer has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 8: -Code-Review
(1 comment)
https://gerrit.ovirt.org/#/c/48051/8/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Petr Horáček has uploaded a new change for review.
Change subject: net: ifup ignores invalid gateway settings
..
net: ifup ignores invalid gateway settings
When we try to set address and gateway on different subnets, ifup
just
automat...@ovirt.org has posted comments on this change.
Change subject: net: ifup ignores invalid gateway settings
..
Patch Set 1:
* #1270688::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270688::OK, public
Petr Horáček has uploaded a new change for review.
Change subject: net: tests: test if network's iface
..
net: tests: test if network's iface
Change-Id: If45fb63247b5e5b21721a23d8781a4ed80e58932
Signed-off-by: Petr Horáček
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: test if network's iface
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: lib: executor: make possible to name work tasks
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/48191/5/lib/vdsm/executor.py
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build: Use make for generating the test certificates
..
build: Use make for generating the test certificates
It is easier to use make for creating
Dan Kenigsberg has posted comments on this change.
Change subject: build: Use make for generating the test certificates
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48226
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 5:
* #1277879::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Nir Soffer has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 4: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/48308/4/tests/storageServerTests.py
Shahar Havivi has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/48129/3/vdsm/v2v.py
File vdsm/v2v.py:
Dan Kenigsberg has posted comments on this change.
Change subject: spec: zombiereaper is not removed on vdsm upgrade
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48240
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: zombiereaper is not removed on vdsm upgrade
..
spec: zombiereaper is not removed on vdsm upgrade
Change-Id:
automat...@ovirt.org has posted comments on this change.
Change subject: spec: zombiereaper is not removed on vdsm upgrade
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
automat...@ovirt.org has posted comments on this change.
Change subject: build: Use make for generating the test certificates
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 4:
* #1277879::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Francesco Romani has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 4: Code-Review-1
(1 comment)
one question inside, -1 for visibility.
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonrpcvdscli: improve functional network tests duration time
..
jsonrpcvdscli: improve functional network tests duration time
The tests were creating new
Shahar Havivi has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/48129/4/vdsm/v2v.py
File vdsm/v2v.py:
101 - 200 of 202 matches
Mail list logo