Change in vdsm[master]: vm: snapshot - use r+ to open vm conf file

Nir Soffer has posted comments on this change. Change subject: vm: snapshot - use r+ to open vm conf file .. Patch Set 6: Waiting for Dan -- To view, visit https://gerrit.ovirt.org/48776 To unsubscribe, visit

Change in vdsm[master]: vm: snapshot - use r+ to open vm conf file

Nir Soffer has posted comments on this change. Change subject: vm: snapshot - use r+ to open vm conf file .. Patch Set 6: Daniel, can you verify? -- To view, visit https://gerrit.ovirt.org/48776 To unsubscribe, visit

Change in vdsm[master]: tests: Test both ssl and m2c

gerrit-hooks has posted comments on this change. Change subject: tests: Test both ssl and m2c .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: stomp: Drain pending bytes from SSLConnection

gerrit-hooks has posted comments on this change. Change subject: stomp: Drain pending bytes from SSLConnection .. Patch Set 3: * #1274670::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1274670::OK, public bug *

Change in vdsm[master]: stomp: Drain pending bytes from SSLConnection

Piotr Kliczewski has posted comments on this change. Change subject: stomp: Drain pending bytes from SSLConnection .. Patch Set 3: Code-Review+2 Verified+1 Rebase only. Copying verification flag and score from previous patch

Change in vdsm[master]: tests: Test both ssl and m2c

Piotr Kliczewski has posted comments on this change. Change subject: tests: Test both ssl and m2c .. Patch Set 2: Code-Review-1 still integration tests need fixing but stompTests are running OK. -1 for visibility -- To

Change in vdsm[master]: tests: Test both ssl and m2c

Piotr Kliczewski has posted comments on this change. Change subject: tests: Test both ssl and m2c .. Patch Set 2: Interesting my pyflakes did not complain about it. Will fix the build as well. -- To view, visit

Change in vdsm[master]: daemon: autodisable cpu affinity on singlecore

Francesco Romani has posted comments on this change. Change subject: daemon: autodisable cpu affinity on singlecore .. Patch Set 4: (4 comments) https://gerrit.ovirt.org/#/c/48619/4//COMMIT_MSG Commit Message: Line 3:

Change in vdsm[master]: daemon: autodisable cpu affinity on singlecore

gerrit-hooks has posted comments on this change. Change subject: daemon: autodisable cpu affinity on singlecore .. Patch Set 5: * #1279431::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279431::OK, public bug *

Change in vdsm[master]: host stats: Collect stats from online cpu cores only

Roman Mohr has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 12: Verified+1 Verified by: 1) vdsClient -s 0 getVdsStats shows all cpu cores 2) disable cpu

Change in vdsm[master]: net: ovs: remove initial nic ip, dont touch unchanged networks

Petr Horáček has posted comments on this change. Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks .. Patch Set 12: Verified+1 Passed functional networkTestsOVS.py without a regression -- To

Change in vdsm[master]: hooks: ovs: better rollback

Petr Horáček has posted comments on this change. Change subject: hooks: ovs: better rollback .. Patch Set 17: Verified+1 Passed without a regression. Connectivity check is working. -- To view, visit

Change in vdsm[master]: hooks: ovs: better rollback

gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: better rollback .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: hooks: ovs: better rollback

Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks: ovs: better rollback .. hooks: ovs: better rollback Until now, OVS hook was not able to rollback after failed setup of non-OVS networks. Now

Change in vdsm[master]: tests: v2v: add test for commit f8127d8

Francesco Romani has posted comments on this change. Change subject: tests: v2v: add test for commit f8127d8 .. Patch Set 7: Verified+1 simplified -- To view, visit https://gerrit.ovirt.org/47367 To unsubscribe, visit

Change in vdsm[master]: tests: v2v: add test for commit f8127d8

Francesco Romani has posted comments on this change. Change subject: tests: v2v: add test for commit f8127d8 .. Patch Set 7: ..and re-verified running the tests (actually checked they do the right thing, not just blindly

Change in vdsm[master]: ifcfg: remove files properly on the node

gerrit-hooks has posted comments on this change. Change subject: ifcfg: remove files properly on the node .. Patch Set 1: * #1283628::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283628::OK, public bug * Check

Change in vdsm[master]: ifcfg: remove files properly on the node

Dan Kenigsberg has uploaded a new change for review. Change subject: ifcfg: remove files properly on the node .. ifcfg: remove files properly on the node Since change-id I02ae28c345 we are always persisting ifcfg files on the

Change in vdsm[master]: daemon: autodisable cpu affinity on singlecore

Petr Horáček has posted comments on this change. Change subject: daemon: autodisable cpu affinity on singlecore .. Patch Set 4: Verified+1 Code-Review+1 Fixed: Command ['/usr/bin/taskset', '--all-tasks', '--pid',

Change in vdsm[master]: hooks: ovs: pass ip configuration as a namedtuple

Petr Horáček has posted comments on this change. Change subject: hooks: ovs: pass ip configuration as a namedtuple .. Patch Set 1: Verified+1 Passed functional networkTestsOVS.py without a regression -- To view, visit

Change in vdsm[master]: tests: v2v: add test for commit f8127d8

Francesco Romani has posted comments on this change. Change subject: tests: v2v: add test for commit f8127d8 .. Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/47367/6/tests/v2vTests.py File

Change in vdsm[master]: tests: v2v: add test for commit f8127d8

gerrit-hooks has posted comments on this change. Change subject: tests: v2v: add test for commit f8127d8 .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: hooks: ovs: better rollback

Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: better rollback .. Patch Set 17: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/46907 To unsubscribe, visit

Change in vdsm[master]: stomp: Drain pending bytes from SSLConnection

Milan Zamazal has posted comments on this change. Change subject: stomp: Drain pending bytes from SSLConnection .. Patch Set 2: Verified+1 I verified that it fixes https://bugzilla.redhat.com/1274670 for me: - I downloaded the

Change in vdsm[master]: net: break netinfo-netconfpersistence dependency

Ido Barkan has uploaded a new change for review. Change subject: net: break netinfo-netconfpersistence dependency .. net: break netinfo-netconfpersistence dependency netinfo module is currently depend on netconfpersistence

Change in vdsm[master]: stomp: slow data read when connected from localhost

Nir Soffer has posted comments on this change. Change subject: stomp: slow data read when connected from localhost .. Patch Set 2: If we go with https://gerrit.ovirt.org/48803, we can abandon this one, right? -- To view,

Change in vdsm[master]: net: break netinfo-netconfpersistence dependency

gerrit-hooks has posted comments on this change. Change subject: net: break netinfo-netconfpersistence dependency .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vm: Support for non-ascii vm name

Piotr Kliczewski has posted comments on this change. Change subject: vm: Support for non-ascii vm name .. Patch Set 1: Code-Review+1 Based on conversation with Nir we want to have it in to as workaround and fix the engine to

Change in vdsm[master]: wip

gerrit-hooks has posted comments on this change. Change subject: wip .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.

Change in vdsm[master]: vm: Support for non-ascii vm name

Francesco Romani has posted comments on this change. Change subject: vm: Support for non-ascii vm name .. Patch Set 1: Code-Review-1 I like this patch, but I'm concerned about possible Engine breakage. I think it should work,

Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file

gerrit-hooks has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file

Arik Hadas has uploaded a new change for review. Change subject: virt: hibernation - use r+ to open vm conf file .. virt: hibernation - use r+ to open vm conf file Complementary part of Ic6799e07898155fd4a630bfaf4151ea9ccdcee49

Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file

Nir Soffer has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 1: Code-Review+1 Thanks Arik! Would add the same comment above the open call like in Daniel patch?

Change in vdsm[master]: wip

Ido Barkan has uploaded a new change for review. Change subject: wip .. wip Change-Id: I8804521b42d44a699fbfa2733415c60a10015a3b Signed-off-by: Ido Barkan --- M lib/vdsm/kernelconfig.py M

Change in vdsm[master]: build: Cleanup conditionals in the build system

Nir Soffer has posted comments on this change. Change subject: build: Cleanup conditionals in the build system .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/48446/11/configure.ac File configure.ac: Line 52: ,

Change in vdsm[master]: vm: Support for non-ascii vm name

Francesco Romani has posted comments on this change. Change subject: vm: Support for non-ascii vm name .. Patch Set 1: Added Arik ans Shmuel based on my previous comment, so they are aware of this change. -- To view, visit

Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file

gerrit-hooks has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file

Arik Hadas has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Done -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit

Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file

Nir Soffer has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Code-Review+2 Waiting for Francesco review. -- To view, visit https://gerrit.ovirt.org/48826 To

Change in vdsm[master]: vdsm.conf: Add drop-in dir

Fabian Deutsch has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 2: (1 comment) Right, I'm also fine with that. Let me push aa patch with a more generic function which illustrates

Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file

Arik Hadas has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit

Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file

Francesco Romani has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Code-Review+2 Right, I missed (for completely silly reasons) to point out to check and fix

Change in vdsm[master]: net: ovs: remove initial nic ip, dont touch unchanged networks

Petr Horáček has posted comments on this change. Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks .. Patch Set 11: (2 comments)

Change in vdsm[master]: vdsm.conf: Add drop-in dir

Fabian Deutsch has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/48317/3/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 454: Line

Change in vdsm[master]: stomp: slow data read when connected from localhost

Piotr Kliczewski has posted comments on this change. Change subject: stomp: slow data read when connected from localhost .. Patch Set 2: Yes. Once the other patch is merged I will abandon this one. -- To view, visit

Change in vdsm[master]: vdsm.conf: Add drop-in dir

gerrit-hooks has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 3: * #1279555::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279555::OK, public bug * Check

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

Francesco Romani has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 2: Marcin, please address comments from Nir. In followup patches, we can make

Change in vdsm[master]: hooks: ovs: pass ip configuration as a namedtuple

gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: pass ip configuration as a namedtuple .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: net: ovs: remove initial nic ip, dont touch unchanged networks

gerrit-hooks has posted comments on this change. Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: hooks: ovs: pass ip configuration as a namedtuple

Petr Horáček has uploaded a new change for review. Change subject: hooks: ovs: pass ip configuration as a namedtuple .. hooks: ovs: pass ip configuration as a namedtuple Signed-off-by: Petr Horáček

Change in vdsm[master]: proposal for bz 1282239

gerrit-hooks has posted comments on this change. Change subject: proposal for bz 1282239 .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: proposal for bz 1282239

Arik Hadas has uploaded a new change for review. Change subject: proposal for bz 1282239 .. proposal for bz 1282239 Change-Id: Idace47c18673e250f3f612a20a15ae5c62565082 Signed-off-by: Arik Hadas --- M

<    1   2