Adam Litke has posted comments on this change.
Change subject: XXX: Add _getDeletedImagePath until patch merged
..
Patch Set 2: Code-Review-2
--
To view, visit https://gerrit.ovirt.org/50218
To unsubscribe, visit https://gerri
Adam Litke has posted comments on this change.
Change subject: XXX: All outstanding VolumeMetadata changes squashed
..
Patch Set 1: Code-Review-2
--
To view, visit https://gerrit.ovirt.org/50362
To unsubscribe, visit https://g
Adam Litke has abandoned this change.
Change subject: sdm: Create the storage/sdm directory
..
Abandoned
Already merged.
--
To view, visit https://gerrit.ovirt.org/50219
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: sdm: Create the storage/sdm directory
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/50219
To unsubscribe
gerrit-hooks has posted comments on this change.
Change subject: XXX: All outstanding VolumeMetadata changes squashed
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storagefakelib: Add FakeResourceManager
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
gerrit-hooks has posted comments on this change.
Change subject: XXX: Add _getDeletedImagePath until patch merged
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
Adam Litke has uploaded a new change for review.
Change subject: XXX: All outstanding VolumeMetadata changes squashed
..
XXX: All outstanding VolumeMetadata changes squashed
Change-Id: I5db8bb8bdf405b8760ecbe103dcbb1a1907ca1db
S
gerrit-hooks has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: storage: add get_volume_artifacts_class to the domain manifest
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: fileVolume: refactor _putMetadata to support volume artifacts
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: fileVolume: define file extension for volume artifacts metadata
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
gerrit-hooks has posted comments on this change.
Change subject: jobs: Add error property
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: jobs: Only report progress if set
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: sdm: add create_volume_container API stub
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Adam Litke has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 1:
(17 comments)
https://gerrit.ovirt.org/#/c/50221/1/tests/sdm_verbs_test.py
File tests/sdm_verbs_test.py:
Line 38:
Adam Litke has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 2:
(7 comments)
https://gerrit.ovirt.org/#/c/50221/2/vdsm/storage/sdm/api/create_volume.py
File vdsm/storage/sdm/api/create
Adam Litke has uploaded a new change for review.
Change subject: jobs: Only report progress if set
..
jobs: Only report progress if set
Not all Jobs have deterministic progress and some jobs will complete so
quickly that progres
gerrit-hooks has posted comments on this change.
Change subject: jobs: Only report progress if set
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: jobs: Add error property
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Adam Litke has uploaded a new change for review.
Change subject: jobs: Add error property
..
jobs: Add error property
When a Job encounters an error, there should be a standardized way for
that error to be stored so that code wo
Adam Litke has posted comments on this change.
Change subject: sdm: add create_volume_container API stub
..
Patch Set 2:
(7 comments)
https://gerrit.ovirt.org/#/c/50220/2/client/vdsClient.py
File client/vdsClient.py:
Line 106
Douglas Schilling Landgraf has posted comments on this change.
Change subject: service: change vdsm KillMode to mixed
..
Patch Set 6:
if this patch is not needed anymore, please abandon.
--
To view, visit https://gerrit.ovirt
Nir Soffer has posted comments on this change.
Change subject: vdsm standard CI arrangement
..
Patch Set 26: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/setting
gerrit-hooks has posted comments on this change.
Change subject: vdsm standard CI arrangement
..
Patch Set 26:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
Nir Soffer has posted comments on this change.
Change subject: deleting references due to memory leaks in the following
modules. adding GC thread every 30sec to vdsm
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/4
Nir Soffer has posted comments on this change.
Change subject: deleting references due to memory leaks in the following
modules. adding GC thread every 30sec to vdsm
..
Patch Set 4:
(4 comments)
There is no chance that someth
Nir Soffer has posted comments on this change.
Change subject: clean refrences inorder to save memory.
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/49346/1/vdsm/storage/misc.py
File vdsm/storage/misc.py:
Line 220:
Nir Soffer has posted comments on this change.
Change subject: deleting references due to memory leaks in the following
modules. adding GC thread every 30sec to vdsm
..
Patch Set 4: Code-Review-2
Please provide information sug
Nir Soffer has posted comments on this change.
Change subject: clean refrences inorder to save memory.
..
Patch Set 1: Code-Review-2
- This path is full of unrelated changes
- We don't have any tests
- We don't have any reason
Nir Soffer has posted comments on this change.
Change subject: schema: Fix asserts that had side effect
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/34362
To unsubscribe, visit https://gerrit.ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: schema: Fix asserts that had side effect
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Nir Soffer has posted comments on this change.
Change subject: sdm: add create_volume_container API stub
..
Patch Set 2: Code-Review-1
(7 comments)
Mostly great, need little fix in api.
https://gerrit.ovirt.org/#/c/50220/2/cl
Francesco Romani has posted comments on this change.
Change subject: Add an empty metadata qos element to the created domain
..
Patch Set 3:
seems fine now. Waiting until monday because 50341, otherwise fine.
--
To view, visi
Francesco Romani has posted comments on this change.
Change subject: Add an empty metadata qos element to the created domain
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Handle empty QoS section with no cpu limit information
..
Patch Set 2:
seems fine, and solves the issue seen on 49655. Waiting until monday if Martin
wants t
Francesco Romani has posted comments on this change.
Change subject: Handle empty QoS section with no cpu limit information
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/50341
To unsubscribe, visit http
Adam Litke has posted comments on this change.
Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44045/7/vdsm/storage/volume.
gerrit-hooks has posted comments on this change.
Change subject: migration: add 'transferring' property
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
gerrit-hooks has posted comments on this change.
Change subject: migration: don't mess up with _status fields
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: do not use status after getStat()
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: vm: report "MigrationSource" only if transferring
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: migration: make status field private
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: migration: rename method
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: virt: enhance migration.SourceThread.stop()
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: return copy of internal status
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: migration: track and report abort reason
..
Patch Set 8:
* #1154397::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1154397::OK, public bug
* Check P
Nir Soffer has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/50221/2/vdsm/storage/sdm/api/create_volume.py
File vdsm/storage/sdm/api/create
Francesco Romani has posted comments on this change.
Change subject: Handle empty QoS section with no cpu limit information
..
Patch Set 2: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/50341
To unsubscri
Francesco Romani has posted comments on this change.
Change subject: Handle empty QoS section with no cpu limit information
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50341
To unsubscribe, visit h
Nir Soffer has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 2: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/50221/2/vdsm/storage/sdm/api/sdm_job.py
File vdsm/storage/sdm/ap
Jenkins CI has posted comments on this change.
Change subject: Handle empty QoS section with no cpu limit information
..
Patch Set 2: Continuous-Integration-1
Propagate review hook: Continuous Integration value inherited from p
Martin Betak has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 5: Code-Review+1
(1 comment)
Nice job! I really like the simplification over the previous implementations.
https://gerri
gerrit-hooks has posted comments on this change.
Change subject: Handle empty QoS section with no cpu limit information
..
Patch Set 2: Verified-1
* #1289007::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1289007:
Martin Sivák has uploaded a new change for review.
Change subject: Handle empty QoS section with no cpu limit information
..
Handle empty QoS section with no cpu limit information
The 3.5 stats collecting code expected the cpu l
gerrit-hooks has posted comments on this change.
Change subject: Handle empty QoS section with no cpu limit information
..
Patch Set 1: Verified-1
* #1219903::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1219903:
Jenkins CI has posted comments on this change.
Change subject: migration: rename method
..
Patch Set 2: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 1
--
To view, visit htt
gerrit-hooks has posted comments on this change.
Change subject: migration: add 'transferring' property
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
gerrit-hooks has posted comments on this change.
Change subject: migration: rename method
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: vm: report "MigrationSource" only if transferring
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: migration: track and report abort reason
..
Patch Set 7:
* #1154397::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1154397::OK, public bug
* Check P
Nir Soffer has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 10: Code-Review+1
Waiting for Francesco approval.
--
To view, visit https://gerrit.ovirt.org/48860
To unsubs
gerrit-hooks has posted comments on this change.
Change subject: storagefakelib: Add FakeResourceManager
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Adam Litke has uploaded a new change for review.
Change subject: storage: add get_volume_artifacts_class to the domain manifest
..
storage: add get_volume_artifacts_class to the domain manifest
When working with a domain manifes
gerrit-hooks has posted comments on this change.
Change subject: sdm: add create_volume_container API stub
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: storage: add get_volume_artifacts_class to the domain manifest
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Adam Litke has uploaded a new change for review.
Change subject: storagefakelib: Add FakeResourceManager
..
storagefakelib: Add FakeResourceManager
Change-Id: I0302b48d984ce7eb8ce2326ab4bb033430c032f9
Signed-off-by: Adam Litke
gerrit-hooks has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Nir Soffer has posted comments on this change.
Change subject: storage: add a context manager for the domainLock
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50272
To unsubscribe, visit https://gerr
Nir Soffer has posted comments on this change.
Change subject: storage: add a context manager for the domainLock
..
Patch Set 3: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/50272
To unsubscribe, visit h
gerrit-hooks has posted comments on this change.
Change subject: storage: add a context manager for the domainLock
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vie
Nir Soffer has submitted this change and it was merged.
Change subject: storage: add a context manager for the domainLock
..
storage: add a context manager for the domainLock
Change-Id: Id7b831d4fe5a67f6998f31978f2399fdebdb3ceb
gerrit-hooks has posted comments on this change.
Change subject: vm: report "MigrationSource" only if transferring
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: migration: rename method
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Francesco Romani has uploaded a new change for review.
Change subject: migration: rename method
..
migration: rename method
TODO
Change-Id: I9f8558f85c3a9824e0fd7884fe7beed2b239f591
Signed-off-by: Francesco Romani
---
M vdsm/v
Francesco Romani has uploaded a new change for review.
Change subject: vm: report "MigrationSource" only if transferring
..
vm: report "MigrationSource" only if transferring
When a Vm failed to migrate for whatever reason,
the r
Francesco Romani has uploaded a new change for review.
Change subject: migration: add 'transferring' property
..
migration: add 'transferring' property
Add 'transferring' property to migration.SourceThread,
to let the client cod
gerrit-hooks has posted comments on this change.
Change subject: migration: add 'transferring' property
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Adam Litke has posted comments on this change.
Change subject: storage: add a context manager for the domainLock
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/50272
To unsubscribe, visit https://gerrit.
Adam Litke has posted comments on this change.
Change subject: storage: add a context manager for the domainLock
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/50272/2/tests/manifest_tests.py
File tests/manifest_tes
gerrit-hooks has posted comments on this change.
Change subject: storage: add a context manager for the domainLock
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 5: Verified+1
tested the unthrottled path using patched VDSM running (and migrating) vms.
Tested the other paths usin
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 5:
Martin, please share your thoughts!
--
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https:
Nir Soffer has posted comments on this change.
Change subject: storage: add a context manager for the domainLock
..
Patch Set 2: Code-Review+1
(2 comments)
Looks good, but we can simplify the failing test even more.
https://g
Francesco Romani has posted comments on this change.
Change subject: Add an empty metadata qos element to the created domain
..
Patch Set 3:
caused by appendMetadata - we need a try/except IndexError in sampling.py in
_sampleC
Francesco Romani has posted comments on this change.
Change subject: Add an empty metadata qos element to the created domain
..
Patch Set 3: Code-Review-1
sorry for late noticing: smoke test revelead a bug
Thread-77::ERROR::20
Francesco Romani has posted comments on this change.
Change subject: Add an empty metadata qos element to the created domain
..
Patch Set 3: Continuous-Integration+1
jenkins failure unrelated
--
To view, visit https://gerrit.
Francesco Romani has posted comments on this change.
Change subject: Add an empty metadata qos element to the created domain
..
Patch Set 3:
...sorry, I misread 3.5 for 3.6. Will recheck the tests and merge
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: Add an empty metadata qos element to the created domain
..
Patch Set 3:
will check test failure, it should be bogus. Will be merged after the 3.6.1
branch cr
Adam Litke has posted comments on this change.
Change subject: storage: add a context manager for the domainLock
..
Patch Set 2: Verified+1
Verified with unit tests as before.
--
To view, visit https://gerrit.ovirt.org/50272
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 10: Verified+1
Verified by suspending and resuming a VM with and without qemu-guest-agent
running and chec
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 9:
(5 comments)
https://gerrit.ovirt.org/#/c/48860/9/tests/vmTests.py
File tests/vmTests.py:
Line 1564:
gerrit-hooks has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 10:
* #1156194::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1156194::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: packaging: updating for VDSM 4.17.4 on Debian jessie
..
Patch Set 35:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/3773
Simone Tiraboschi has abandoned this change.
Change subject: packaging: updating for VDSM 4.17.4 on Debian jessie
..
Abandoned
Moved to https://gerrit.ovirt.org/49257
--
To view, visit https://gerrit.ovirt.org/37737
To unsubs
Adam Litke has posted comments on this change.
Change subject: schema: Fix asserts that had side effect
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/34362
To unsubscribe, visit https://gerrit.ovirt.
Adam Litke has restored this change.
Change subject: tests: Add a live merge functional test
..
Restored
--
To view, visit https://gerrit.ovirt.org/29824
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageT
1 - 100 of 151 matches
Mail list logo