Change in vdsm[master]: sp: improve domainStateChange event handling

Liron Aravot has posted comments on this change. Change subject: sp: improve domainStateChange event handling .. Patch Set 3: Code-Review-1 (1 comment) -1 till my question is answered. https://gerrit.ovirt.org/#/c/51393/3/vds

Change in vdsm[master]: sp: improve domainStateChange event handling

Nir Soffer has posted comments on this change. Change subject: sp: improve domainStateChange event handling .. Patch Set 3: Flows that should be verified: - Create new storage pool - connectStoragePool - disconnectStoragePool -

Change in vdsm[master]: sp: improve domainStateChange event handling

Nir Soffer has posted comments on this change. Change subject: sp: improve domainStateChange event handling .. Patch Set 3: Code-Review+1 (8 comments) Looks good, but we need more reviews. Waiting for reviews from Adam and Lir

Change in vdsm[master]: sp: update domain links on state change

Idan Shaby has posted comments on this change. Change subject: sp: update domain links on state change .. Patch Set 3: (2 comments) Please also review https://gerrit.ovirt.org/#/c/51393/ . https://gerrit.ovirt.org/#/c/27334/3

Change in vdsm[master]: Move dsaversion under vdsm-python package

Edward Haas has posted comments on this change. Change subject: Move dsaversion under vdsm-python package .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51381 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: sp: improve domainStateChange event handling

gerrit-hooks has posted comments on this change. Change subject: sp: improve domainStateChange event handling .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

Nir Soffer has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 1: (7 comments) https://gerrit.ovirt.org/#/c/51407/1/lib/vdsm/utils.py File

Change in vdsm[master]: Move dsaversion under vdsm-python package

Nir Soffer has posted comments on this change. Change subject: Move dsaversion under vdsm-python package .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51381 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: guestagent: Speed up xml character filtering

Nir Soffer has posted comments on this change. Change subject: guestagent: Speed up xml character filtering .. Patch Set 5: Verified+1 Changes: - fix the valid unicode test, values above 0x must use \U instead of \u - \U00

Change in vdsm[master]: tests: Improve object filtering tests

gerrit-hooks has posted comments on this change. Change subject: tests: Improve object filtering tests .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: guestagent: Simplify and modernize object filtering

gerrit-hooks has posted comments on this change. Change subject: guestagent: Simplify and modernize object filtering .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: guestagent: Speed up xml character filtering

gerrit-hooks has posted comments on this change. Change subject: guestagent: Speed up xml character filtering .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: Move dsaversion under vdsm-python package

gerrit-hooks has posted comments on this change. Change subject: Move dsaversion under vdsm-python package .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: Move dsaversion under vdsm-python package

Yaniv Bronhaim has posted comments on this change. Change subject: Move dsaversion under vdsm-python package .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/51381 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

Yaniv Bronhaim has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 1: errr need to fix some tests -- To view, visit https://gerrit.ovirt.

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

Yaniv Bronhaim has uploaded a new change for review. Change subject: Introducing context manager to terminate async processes on internal fail .. Introducing context manager to terminate async processes on internal fail part of

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

gerrit-hooks has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bu

Change in vdsm[master]: cpuinfo: add predicates for x86 and ppc platform detection

Nir Soffer has posted comments on this change. Change subject: cpuinfo: add predicates for x86 and ppc platform detection .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/50894/2/vdsm/caps.py File vdsm/ca

Change in vdsm[master]: Move dsaversion under vdsm-python package

Nir Soffer has posted comments on this change. Change subject: Move dsaversion under vdsm-python package .. Patch Set 1: Code-Review-1 (4 comments) https://gerrit.ovirt.org/#/c/51381/1/lib/vdsm/dsaversion.py.in File lib/vdsm/d

Change in vdsm[master]: VolumeMetadata: Add getParentVolume

Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Add getParentVolume .. Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/44042/13/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 55

Change in vdsm[master]: storage: add get_volume_artifacts_class to the domain manifest

Nir Soffer has posted comments on this change. Change subject: storage: add get_volume_artifacts_class to the domain manifest .. Patch Set 9: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/50339/9//COMMIT_MSG Commit M

Change in vdsm[master]: sdm: Add create_volume job

Nir Soffer has posted comments on this change. Change subject: sdm: Add create_volume job .. Patch Set 10: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/50221/10/vdsm/storage/sdm/api/base.py File vdsm/storage/sdm/api/

Change in vdsm[master]: storagefakelib: Add FakeResourceManager

gerrit-hooks has posted comments on this change. Change subject: storagefakelib: Add FakeResourceManager .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: storagefakelib: Add FakeResourceManager

Nir Soffer has submitted this change and it was merged. Change subject: storagefakelib: Add FakeResourceManager .. storagefakelib: Add FakeResourceManager A fake ResourceManager is needed for testing the sdm verbs. The fake ob

Change in vdsm[master]: fileSD: Make _getDeletedImagePath public

gerrit-hooks has posted comments on this change. Change subject: fileSD: Make _getDeletedImagePath public .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: fileSD: Make _getDeletedImagePath public

Nir Soffer has posted comments on this change. Change subject: fileSD: Make _getDeletedImagePath public .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50218 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: fileSD: Make _getDeletedImagePath public

Nir Soffer has submitted this change and it was merged. Change subject: fileSD: Make _getDeletedImagePath public .. fileSD: Make _getDeletedImagePath public _getDeletedImagePath is useful to the upcoming FileVolumeArtifacts cla

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

Nir Soffer has posted comments on this change. Change subject: storage: Split newMetadata into makeMetadata and createMetadata .. Patch Set 15: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/44045/15/vdsm/storage/volum

Change in vdsm[master]: sdm: add SDM.create_volume API stub

Nir Soffer has posted comments on this change. Change subject: sdm: add SDM.create_volume API stub .. Patch Set 10: Code-Review-1 (4 comments) https://gerrit.ovirt.org/#/c/50220/10/client/vdsClient.py File client/vdsClient.py:

Change in vdsm[master]: storage: Move VOLUME_PERMISSIONS to storage constants

Nir Soffer has submitted this change and it was merged. Change subject: storage: Move VOLUME_PERMISSIONS to storage constants .. storage: Move VOLUME_PERMISSIONS to storage constants VOLUME_PERMISSIONS will be needed by the vol

Change in vdsm[master]: storage: Move VOLUME_PERMISSIONS to storage constants

gerrit-hooks has posted comments on this change. Change subject: storage: Move VOLUME_PERMISSIONS to storage constants .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: storage constants: Move LEASE_FILEEXT

Nir Soffer has posted comments on this change. Change subject: storage constants: Move LEASE_FILEEXT .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/50841/3/vdsm/storage/fileSD.py File vdsm/storage/fileS

Change in vdsm[master]: fileVolumeManifest: Make lease and meta path getters public

Nir Soffer has posted comments on this change. Change subject: fileVolumeManifest: Make lease and meta path getters public .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51036 To unsubscribe, visit ht

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

Adam Litke has posted comments on this change. Change subject: storage: Split newMetadata into makeMetadata and createMetadata .. Patch Set 15: Verified+1 Verified with 'make check' and by doing LSM+Live Merge. -- To view, vi

Change in vdsm[master]: fileSD: Make _getDeletedImagePath public

Adam Litke has posted comments on this change. Change subject: fileSD: Make _getDeletedImagePath public .. Patch Set 9: Verified+1 Verified with 'make check' and by doing LSM+Live Merge. -- To view, visit https://gerrit.ovirt

Change in vdsm[master]: storage: add get_volume_artifacts_class to the domain manifest

Adam Litke has posted comments on this change. Change subject: storage: add get_volume_artifacts_class to the domain manifest .. Patch Set 9: Verified+1 Verified with 'make check' and by doing LSM+Live Merge. -- To view, visi

Change in vdsm[master]: storage: Move VOLUME_PERMISSIONS to storage constants

Adam Litke has posted comments on this change. Change subject: storage: Move VOLUME_PERMISSIONS to storage constants .. Patch Set 6: Verified+1 Verified with 'make check' and by doing LSM+Live Merge. -- To view, visit https:/

Change in vdsm[master]: storage: Move VOLUME_PERMISSIONS to storage constants

Adam Litke has posted comments on this change. Change subject: storage: Move VOLUME_PERMISSIONS to storage constants .. Patch Set 6: Verified with 'make check' and by doing LSM+Live Merge. -- To view, visit https://gerrit.ovi

Change in vdsm[master]: sdm: add SDM.create_volume API stub

Adam Litke has posted comments on this change. Change subject: sdm: add SDM.create_volume API stub .. Patch Set 10: Verified+1 Verified with 'make check' and by doing LSM+Live Merge. -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: storagefakelib: Add FakeResourceManager

Adam Litke has posted comments on this change. Change subject: storagefakelib: Add FakeResourceManager .. Patch Set 9: Verified+1 Verified with 'make check' and by doing LSM+Live Merge. -- To view, visit https://gerrit.ovirt.

Change in vdsm[master]: storage constants: Move LEASE_FILEEXT

Adam Litke has posted comments on this change. Change subject: storage constants: Move LEASE_FILEEXT .. Patch Set 3: Verified+1 Verified with 'make check' and by doing LSM+Live Merge. -- To view, visit https://gerrit.ovirt.or

Change in vdsm[master]: sdm: Add create_volume job

Adam Litke has posted comments on this change. Change subject: sdm: Add create_volume job .. Patch Set 10: Verified+1 Verified with 'make check' and by doing LSM+Live Merge. -- To view, visit https://gerrit.ovirt.org/50221 To

Change in vdsm[master]: fileVolumeManifest: Make lease and meta path getters public

Adam Litke has posted comments on this change. Change subject: fileVolumeManifest: Make lease and meta path getters public .. Patch Set 2: Verified+1 Verified with 'make check' and by doing LSM+Live Merge. -- To view, visit h

Change in vdsm[master]: Introduce VolumeArtifacts

Adam Litke has posted comments on this change. Change subject: Introduce VolumeArtifacts .. Patch Set 15: Verified+1 Verified with 'make check' and by doing LSM+Live Merge. -- To view, visit https://gerrit.ovirt.org/48097 To

Change in vdsm[master]: storage: Add _getDeletedImagePath until patch merged

Adam Litke has abandoned this change. Change subject: storage: Add _getDeletedImagePath until patch merged .. Abandoned -- To view, visit https://gerrit.ovirt.org/50049 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: XXX: All outstanding VolumeMetadata changes squashed

Adam Litke has abandoned this change. Change subject: XXX: All outstanding VolumeMetadata changes squashed .. Abandoned -- To view, visit https://gerrit.ovirt.org/50362 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: XXX: All outstanding VolumeMetadata changes squashed

gerrit-hooks has posted comments on this change. Change subject: XXX: All outstanding VolumeMetadata changes squashed .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/50362

Change in vdsm[master]: storage: Add _getDeletedImagePath until patch merged

gerrit-hooks has posted comments on this change. Change subject: storage: Add _getDeletedImagePath until patch merged .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/50049

Change in vdsm[master]: fileSD: Make _getDeletedImagePath public

Adam Litke has posted comments on this change. Change subject: fileSD: Make _getDeletedImagePath public .. Patch Set 9: -Code-Review This patch now makes _getDeletedImagePath public -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: storage: add get_volume_artifacts_class to the domain manifest

gerrit-hooks has posted comments on this change. Change subject: storage: add get_volume_artifacts_class to the domain manifest .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: storage: Move VOLUME_PERMISSIONS to storage constants

gerrit-hooks has posted comments on this change. Change subject: storage: Move VOLUME_PERMISSIONS to storage constants .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: sdm: Add create_volume job

gerrit-hooks has posted comments on this change. Change subject: sdm: Add create_volume job .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: fileSD: Make _getDeletedImagePath public

gerrit-hooks has posted comments on this change. Change subject: fileSD: Make _getDeletedImagePath public .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: storage constants: Move LEASE_FILEEXT

gerrit-hooks has posted comments on this change. Change subject: storage constants: Move LEASE_FILEEXT .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

gerrit-hooks has posted comments on this change. Change subject: storage: Split newMetadata into makeMetadata and createMetadata .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url foun

Change in vdsm[master]: Introduce VolumeArtifacts

gerrit-hooks has posted comments on this change. Change subject: Introduce VolumeArtifacts .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: fileVolumeManifest: Make lease and meta path getters public

gerrit-hooks has posted comments on this change. Change subject: fileVolumeManifest: Make lease and meta path getters public .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, ma

Change in vdsm[master]: storagefakelib: Add FakeResourceManager

gerrit-hooks has posted comments on this change. Change subject: storagefakelib: Add FakeResourceManager .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header match

Change in vdsm[master]: sdm: add SDM.create_volume API stub

gerrit-hooks has posted comments on this change. Change subject: sdm: add SDM.create_volume API stub .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: sdm: add SDM.create_volume API stub

Adam Litke has posted comments on this change. Change subject: sdm: add SDM.create_volume API stub .. Patch Set 9: (3 comments) https://gerrit.ovirt.org/#/c/50220/9/client/vdsClient.py File client/vdsClient.py: Line 208:

Change in vdsm[master]: Introduce VolumeArtifacts

Adam Litke has posted comments on this change. Change subject: Introduce VolumeArtifacts .. Patch Set 14: (12 comments) https://gerrit.ovirt.org/#/c/48097/14/vdsm/storage/sdm/volume_artifacts.py File vdsm/storage/sdm/volume_ar

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

Adam Litke has posted comments on this change. Change subject: storage: Split newMetadata into makeMetadata and createMetadata .. Patch Set 14: (2 comments) https://gerrit.ovirt.org/#/c/44045/14/vdsm/storage/volume.py File vds

Change in vdsm[master]: Added Python 3 support for sslTests.py

gerrit-hooks has posted comments on this change. Change subject: Added Python 3 support for sslTests.py .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: VolumeMetadata: Add getParentVolume

Adam Litke has posted comments on this change. Change subject: VolumeMetadata: Add getParentVolume .. Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/44042/13/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 55

Change in vdsm[master]: guestagent: Simplify and modernize object filtering

Nir Soffer has posted comments on this change. Change subject: guestagent: Simplify and modernize object filtering .. Patch Set 3: Continuous-Integration+1 Loop devices issue again -- To view, visit https://gerrit.ovirt.org/5

Change in vdsm[master]: testlib: use arch from lib

Francesco Romani has posted comments on this change. Change subject: testlib: use arch from lib .. Patch Set 4: Code-Review-1 (1 comment) please check the inline comment. https://gerrit.ovirt.org/#/c/49973/4/tests/testlib.py

Change in vdsm[master]: nettestlib: add ppc64le TUNSETIFF value

Francesco Romani has posted comments on this change. Change subject: nettestlib: add ppc64le TUNSETIFF value .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46955 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: nettestlib: use cpuarch module

Francesco Romani has posted comments on this change. Change subject: nettestlib: use cpuarch module .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49992 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: caps: use cpuarch module

Francesco Romani has posted comments on this change. Change subject: caps: use cpuarch module .. Patch Set 3: Code-Review+1 Instant +2 if these changes can be owned by virt (caps.py is either shared or infra IIRC) -- To view

Change in vdsm[master]: guestagent: Speed up xml character filtering

Nir Soffer has posted comments on this change. Change subject: guestagent: Speed up xml character filtering .. Patch Set 4: Continuous-Integration+1 CI failures not related (jsonrpc timeout) -- To view, visit https://gerrit.o

Change in vdsm[master]: tests: Separate tests using permutations

Nir Soffer has posted comments on this change. Change subject: tests: Separate tests using permutations .. Patch Set 4: Continuous-Integration+1 CI failures not related (loop device issues again) -- To view, visit https://ger

Change in vdsm[master]: caps/lib: move CPU architecture details to lib/cpuarch

Francesco Romani has posted comments on this change. Change subject: caps/lib: move CPU architecture details to lib/cpuarch .. Patch Set 4: Code-Review-1 (3 comments) amazing work, and nice improvements. Looks fine, but it see

Change in vdsm[master]: cpuinfo: use is_ppc predicate when parsing cpu_map.xml

Francesco Romani has posted comments on this change. Change subject: cpuinfo: use is_ppc predicate when parsing cpu_map.xml .. Patch Set 1: Code-Review-1 (1 comment) looks good, but the BZ needs to be filled or dropped https:

Change in vdsm[master]: cpuinfo: add predicates for x86 and ppc platform detection

Francesco Romani has posted comments on this change. Change subject: cpuinfo: add predicates for x86 and ppc platform detection .. Patch Set 2: Code-Review+2 I take ownership of the changes in caps.py and supervdsmServer (reaso

Change in vdsm[master]: cpuinfo: add predicates for x86 and ppc platform detection

Francesco Romani has posted comments on this change. Change subject: cpuinfo: add predicates for x86 and ppc platform detection .. Patch Set 2: yes, it seems the split was done in 51382 -- To view, visit https://gerrit.ovirt.

Change in vdsm[master]: guestagent: Speed up xml character filtering

Nir Soffer has posted comments on this change. Change subject: guestagent: Speed up xml character filtering .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/50945 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: cpuinfo: use is_ppc predicate when parsing cpu_map.xml

Francesco Romani has posted comments on this change. Change subject: cpuinfo: use is_ppc predicate when parsing cpu_map.xml .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51382 To unsubscribe, visit h

Change in vdsm[master]: cpuinfo: add predicates for x86 and ppc platform detection

Francesco Romani has posted comments on this change. Change subject: cpuinfo: add predicates for x86 and ppc platform detection .. Patch Set 2: Code-Review+1 looks ok. Nir asked to split changes in behaviour and refactoring, I

Change in vdsm[master]: tests: Separate tests using permutations

gerrit-hooks has posted comments on this change. Change subject: tests: Separate tests using permutations .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: tests: Improve object filtering tests

gerrit-hooks has posted comments on this change. Change subject: tests: Improve object filtering tests .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: guestagent: Simplify and modernize object filtering

gerrit-hooks has posted comments on this change. Change subject: guestagent: Simplify and modernize object filtering .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: guestagent: Speed up xml character filtering

gerrit-hooks has posted comments on this change. Change subject: guestagent: Speed up xml character filtering .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Add filtering xml timing test

gerrit-hooks has posted comments on this change. Change subject: tests: Add filtering xml timing test .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: guestagent: Speed up xml character filtering

Nir Soffer has posted comments on this change. Change subject: guestagent: Speed up xml character filtering .. Patch Set 3: (3 comments) Yaniv, I don't think we should care about "discouraged" characters. If we find that our

Change in vdsm[master]: jobs: Add Job.__repr__ for easier debugging

gerrit-hooks has posted comments on this change. Change subject: jobs: Add Job.__repr__ for easier debugging .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, vis

Change in vdsm[master]: jobs: Add Job.__repr__ for easier debugging

Nir Soffer has submitted this change and it was merged. Change subject: jobs: Add Job.__repr__ for easier debugging .. jobs: Add Job.__repr__ for easier debugging Every object should have __repr__ to make it easy to have more d

Change in vdsm[master]: jobs: Add Job.__repr__ for easier debugging

Nir Soffer has posted comments on this change. Change subject: jobs: Add Job.__repr__ for easier debugging .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/51217/4/tests/jobsTests.py File tests/jobsTests.py: Line 216:

Change in vdsm[master]: jobs: Add Job.__repr__ for easier debugging

Francesco Romani has posted comments on this change. Change subject: jobs: Add Job.__repr__ for easier debugging .. Patch Set 4: Code-Review+1 (2 comments) overall looks good, I'm not 100% sold but not enough to stop this patc

Change in vdsm[master]: jobs: Replace validation method with a property

Nir Soffer has submitted this change and it was merged. Change subject: jobs: Replace validation method with a property .. jobs: Replace validation method with a property Replace Job.validate_not_active() with an Job.active pro

Change in vdsm[master]: jobs: Replace validation method with a property

gerrit-hooks has posted comments on this change. Change subject: jobs: Replace validation method with a property .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: jobs: Take lock once when deleting a job

Nir Soffer has submitted this change and it was merged. Change subject: jobs: Take lock once when deleting a job .. jobs: Take lock once when deleting a job Previous we use get() for checking if a job exists before deleting it,

Change in vdsm[master]: jobs: Take lock once when deleting a job

gerrit-hooks has posted comments on this change. Change subject: jobs: Take lock once when deleting a job .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: jobs: Replace validation method with a property

Francesco Romani has posted comments on this change. Change subject: jobs: Replace validation method with a property .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51216 To unsubscribe, visit https://

Change in vdsm[master]: jobs: Take lock once when deleting a job

Francesco Romani has posted comments on this change. Change subject: jobs: Take lock once when deleting a job .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51215 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: VolumeMetadata: Add getParentVolume

Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Add getParentVolume .. Patch Set 13: -Continuous-Integration -- To view, visit https://gerrit.ovirt.org/44042 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

Francesco Romani has posted comments on this change. Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts .. Patch Set 10: Code-Review-1 (4 comments) -1 for visibility, comments inside. The biggest issu

Change in vdsm[master]: v2v: extract specific classes for libvirt and ova

Francesco Romani has posted comments on this change. Change subject: v2v: extract specific classes for libvirt and ova .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49951 To unsubscribe, visit https

Change in vdsm[master]: VolumeMetadata: Add getParentVolume

Jenkins CI has posted comments on this change. Change subject: VolumeMetadata: Add getParentVolume .. Patch Set 13: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 12 -- To vi

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

Francesco Romani has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 23: Code-Review-1 (1 comment) Looks fine except for one point: please avoid raising strings as exception. S

Change in vdsm[master]: VolumeMetadata: Add getParentVolume

Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Add getParentVolume .. Patch Set 13: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/44042/13/vdsm/storage/volume.py File vdsm/storage/volum

  1   2   3   >