Change in vdsm[master]: kill and report asyncProc if fails on first write to stdin

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: kill and report asyncProc if fails on first write to stdin .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, mak

Change in vdsm[master]: kill and report asyncProc if fails on first write to stdin

2016-01-12 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: kill and report asyncProc if fails on first write to stdin .. kill and report asyncProc if fails on first write to stdin Change-Id: I57b68742ce1dcae1d9fdad020b

Change in vdsm[master]: split to commandsTests.py - only execCmd tests

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: split to commandsTests.py - only execCmd tests .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: split to commandsTests.py - only execCmd tests

2016-01-12 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: split to commandsTests.py - only execCmd tests .. split to commandsTests.py - only execCmd tests Change-Id: I3d4fafb105607f2a768ae80f74cdea131b2d3dc7 Signed-of

Change in vdsm[master]: split to commandsTests.py - only execCmd tests

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: split to commandsTests.py - only execCmd tests .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

2016-01-12 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/51508/4/vdsm/virt/guestagent.py File vdsm/virt/guestag

Change in vdsm[master]: conflib: Introduce the conflib library

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: conflib: Introduce the conflib library .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/40960/5/lib/vdsm/conflib.py File lib/vdsm/conflib.py: Line 129:

Change in vdsm[master]: supervdsm: use cpuarch

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: supervdsm: use cpuarch .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' a

Change in vdsm[master]: testlib: use arch from lib

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: testlib: use arch from lib .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/51407/6//COMMIT_MSG Commit Mes

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/51407/5/lib/vdsm/commands.py F

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

2016-01-12 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/51407/5/lib/vdsm/commands.

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bu

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

2016-01-12 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: exception: Gather exceptions in vdsm.exception .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48868 To unsubscribe, visit https://ger

Change in vdsm[master]: tests: Fix loop device leak in mount tests

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Fix loop device leak in mount tests .. Patch Set 1: But note that this may still fail, the udevadm.settle call is not good enough. I will work on a better w

Change in vdsm[master]: tests: Fix loop device leak in mount tests

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Fix loop device leak in mount tests .. Patch Set 1: Verified+1 Verified by running the mount tests 100 times per run, see https://gerrit.ovirt.org/51748 --

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 32: (1 comment) https://gerrit.ovirt.org/#/c/48672/32/tests/v2vTests.py File tests/v2vTests.py: Line 317:

Change in vdsm[master]: v2v: tests: new testing class: MockVirConnectTests

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: tests: new testing class: MockVirConnectTests .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/51704/2/tests/v2vTests.py File tests/v2vTests.py: Lin

Change in vdsm[master]: v2v: tests: new testing class: MockVirConnectTests

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: tests: new testing class: MockVirConnectTests .. Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/51704/2/tests/v2vTests.py File tests/v2vTests.py: Lin

Change in vdsm[master]: v2v: tests: refactor v2vTests

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: tests: refactor v2vTests .. Patch Set 1: Code-Review+1 Waiting for Francesco ack. -- To view, visit https://gerrit.ovirt.org/51703 To unsubscribe, visit htt

Change in vdsm[master]: v2v: tests: rename vmid to UUID to match Libvirts domain pro...

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: tests: rename vmid to UUID to match Libvirts domain property .. Patch Set 2: Continuous-Integration+1 CI failures not relevant (loop mount tests acting up aga

Change in vdsm[master]: v2v: tests: rename vmid to UUID to match Libvirts domain pro...

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: tests: rename vmid to UUID to match Libvirts domain property .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url f

Change in vdsm[master]: v2v: tests: rename vmid to UUID to match Libvirts domain pro...

2016-01-12 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: v2v: tests: rename vmid to UUID to match Libvirts domain property .. v2v: tests: rename vmid to UUID to match Libvirts domain property Change-Id: I41abb2b

Change in vdsm[master]: v2v: tests: rename vmid to UUID to match Libvirts domain pro...

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: tests: rename vmid to UUID to match Libvirts domain property .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51616 To unsubscribe, v

Change in vdsm[master]: storage: Introduction to imagetickets.py

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Introduction to imagetickets.py .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/50014/8/vdsm/storage/imagetickets.py File vdsm/storage/imageticke

Change in vdsm[master]: tests: Improve object filtering tests

2016-01-12 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: tests: Improve object filtering tests .. tests: Improve object filtering tests The tests were not checking handling of all types and handling of nested str

Change in vdsm[master]: tests: Improve object filtering tests

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Improve object filtering tests .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit htt

Change in vdsm[master]: storage: Introduction to imagetickets.py

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Introduction to imagetickets.py .. Patch Set 8: (21 comments) Much nicer now https://gerrit.ovirt.org/#/c/50014/8/client/vdsClient.py File client/vdsClie

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 5: (7 comments) https://gerrit.ovirt.org/#/c/51407/5//COMMIT_MSG Commit Mes

Change in vdsm[master]: health: Introduce Vdsm health monitoring

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: health: Introduce Vdsm health monitoring .. Patch Set 1: Michal, we can switch this on and of in runtime, but I prefer to start with something very simple. -- To

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bu

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 10: Code-Review-1 -Verified -- To view, visit https://gerrit.ovirt.org/48871 To unsubscribe, visit ht

Change in vdsm[master]: net: Cleanup translateNetOptionsToNew

2016-01-12 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Cleanup translateNetOptionsToNew .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51749 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[master]: net: Cleanup translateNetOptionsToNew

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Cleanup translateNetOptionsToNew .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: net: Cleanup translateNetOptionsToNew

2016-01-12 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: Cleanup translateNetOptionsToNew .. net: Cleanup translateNetOptionsToNew translateNetOptionsToNew is no longer needed. (and is located in the wrong place an

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

2016-01-12 Thread Jenkins CI
Jenkins CI has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 4: Continuous-Integration-1 Propagate review hook: Continuous Integration va

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

2016-01-12 Thread Jenkins CI
Jenkins CI has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 4: Continuous-Integration+1 Propagate review hook: Continuous Integration va

Change in vdsm[master]: py3 test improving

2016-01-12 Thread Jenkins CI
Jenkins CI has posted comments on this change. Change subject: py3 test improving .. Patch Set 3: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit https://g

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: exception: Gather exceptions in vdsm.exception .. Patch Set 7: This version rebase over master after commands patch was merged. Need to test again to make sure not

Change in vdsm[master]: operstate: use python3-friendly io.open()

2016-01-12 Thread edwardh
Edward Haas has posted comments on this change. Change subject: operstate: use python3-friendly io.open() .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/51736/1/tests/netinfoTests.py File tests/netinfoT

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: exception: Gather exceptions in vdsm.exception .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: gluster: Add gluster exception tests

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: Add gluster exception tests .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: exception: Make VdsmException reusable

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: exception: Make VdsmException reusable .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: exception: Inherit from VdsmException

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: exception: Inherit from VdsmException .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 9: Verified-1 Unfinished, do not merge. -- To view, visit https://gerrit.ovirt.org/48871 To unsubscr

Change in vdsm[master]: virt: Don't create on non-x86 architectures

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Don't create on non-x86 architectures .. Patch Set 3: Code-Review+1 (1 comment) Looks good, waiting for Francesco ack. https://gerrit.ovirt.org/#/c/51648/3

Change in vdsm[master]: virt: Don't create on non-x86 architectures

2016-01-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: virt: Don't create on non-x86 architectures .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51648 To unsubscribe, visit https://gerri

Change in vdsm[master]: tests: Stress test the loop leak fix

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Stress test the loop leak fix .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Stress test the loop leak fix

2016-01-12 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: tests: Stress test the loop leak fix .. tests: Stress test the loop leak fix Use permutations for running the fixed tests 100 times for each run. Change-Id: If5da

Change in vdsm[master]: virt: Don't create on non-x86 architectures

2016-01-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: virt: Don't create on non-x86 architectures .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51648/3//COMMIT_MSG Commit Message: Line 8: Line 9: We

Change in vdsm[master]: lib: avoid circular references due to wrapping

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: avoid circular references due to wrapping .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/51630/2/lib/vdsm/libvirtconnection.py File lib/vdsm/libvirt

Change in vdsm[master]: virt: Don't create on non-x86 architectures

2016-01-12 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Don't create on non-x86 architectures .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/51648/2/tests/vmTests.py File tests/vmTests.py: Line 303

Change in vdsm[master]: virt: Don't create on non-x86 architectures

2016-01-12 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Don't create on non-x86 architectures .. Patch Set 3: Test duplication resolved + rebase. -- To view, visit https://gerrit.ovirt.org/51648 To unsubscrib

Change in vdsm[master]: virt: Don't create on non-x86 architectures

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Don't create on non-x86 architectures .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: register: Leave the logging to the vdsm-tool

2016-01-12 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: register: Leave the logging to the vdsm-tool .. Patch Set 2: Dan's call. -- To view, visit https://gerrit.ovirt.org/46978 To unsubscribe, visit ht

Change in vdsm[master]: register: Leave the logging to the vdsm-tool

2016-01-12 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: register: Leave the logging to the vdsm-tool .. Patch Set 2: looks like that our QE already has been looking to /var/log/vdsm/register.log, probabl

Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

2016-01-12 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 9: Removed gal because his account email is no longer correct - And just causing spamming

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bu

Change in vdsm[master]: net tests: Wait for bond dev state up

2016-01-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net tests: Wait for bond dev state up .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51698 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: net tests: Wait for bond dev state up

2016-01-12 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net tests: Wait for bond dev state up .. net tests: Wait for bond dev state up Several functional tests that involved bond devices, checked that change

Change in vdsm[master]: net tests: Wait for bond dev state up

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net tests: Wait for bond dev state up .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit htt

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bu

Change in vdsm[master]: lib: avoid circular references due to wrapping

2016-01-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: avoid circular references due to wrapping .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/51630/2/lib/vdsm/libvirtconnection.py File lib/vdsm/

Change in vdsm[master]: sp: improve domainStateChange event handling

2016-01-12 Thread laravot
Liron Aravot has posted comments on this change. Change subject: sp: improve domainStateChange event handling .. Patch Set 6: -Code-Review -- To view, visit https://gerrit.ovirt.org/51393 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

2016-01-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: exception: Gather exceptions in vdsm.exception .. Patch Set 6: Continuous-Integration+1 CI failures are spurious. -- To view, visit https://gerrit.ovirt.org/4

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bu

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

2016-01-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: exception: Gather exceptions in vdsm.exception .. Patch Set 6: Code-Review-1 utils.py. doh. -- To view, visit https://gerrit.ovirt.org/48868 To unsubscribe, v

Change in vdsm[master]: storage: Introduction to imagetickets.py

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Introduction to imagetickets.py .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: py3 test improving

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: py3 test improving .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and i

Change in vdsm[master]: py3 test improving

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: py3 test improving .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and i

Change in vdsm[master]: storage: Introduction to imagetickets.py

2016-01-12 Thread aaviram
Amit Aviram has abandoned this change. Change subject: storage: Introduction to imagetickets.py .. Abandoned Patch was duplicated. -- To view, visit https://gerrit.ovirt.org/51710 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: storage: Introduction to imagetickets.py

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Introduction to imagetickets.py .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/51710 To unsubscr

Change in vdsm[master]: storage: Introduction to imagetickets.py

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Introduction to imagetickets.py .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

2016-01-12 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48871 To unsubscribe, visit https:/

Change in vdsm[master]: exception: Inherit from VdsmException

2016-01-12 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: exception: Inherit from VdsmException .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48869 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: exception: Make VdsmException reusable

2016-01-12 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: exception: Make VdsmException reusable .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48875 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: gluster: Add gluster exception tests

2016-01-12 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: gluster: Add gluster exception tests .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51565 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: py3 test improving

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: py3 test improving .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and i

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

2016-01-12 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: exception: Gather exceptions in vdsm.exception .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48868 To unsubscribe, visit https://g

Change in vdsm[master]: vm: extract cleanupRecoveryFile() helper

2016-01-12 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: extract cleanupRecoveryFile() helper .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51386 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: health: Introduce Vdsm health monitoring

2016-01-12 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: health: Introduce Vdsm health monitoring .. Patch Set 1: ah ok, you used DEBUG_LEAK. then not "hours":) could it be turned on/off in runtime? same as we want

Change in vdsm[master]: health: Introduce Vdsm health monitoring

2016-01-12 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: health: Introduce Vdsm health monitoring .. Patch Set 1: nice. though...for long running debugging I'd go with 1h interval or perhaps even more hours instead

Change in vdsm[master]: operstate: use python3-friendly io.open()

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: operstate: use python3-friendly io.open() .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: operstate: use python3-friendly io.open()

2016-01-12 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: operstate: use python3-friendly io.open() .. operstate: use python3-friendly io.open() netinfoTests is not yet passing under Python 3 due to its import of exec

Change in vdsm[master]: virt: safer handling of migration parameters

2016-01-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 2: Verified+1 v2 just changed the commit message (and rebased), hence restore +2 -- To view, visit

Change in vdsm[master]: migration: use context manager for semaphore

2016-01-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: use context manager for semaphore .. Patch Set 2: Verified+1 v2 changes only the commit message, here's the restored score -- To view, visit http

Change in vdsm[master]: caps: use cpuarch module

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: caps: use cpuarch module .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: nettestlib: add ppc64le TUNSETIFF value

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: nettestlib: add ppc64le TUNSETIFF value .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: nettestlib: use cpuarch module

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: nettestlib: use cpuarch module .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U

Change in vdsm[master]: caps/lib: move CPU architecture details to lib/cpuarch

2016-01-12 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: caps/lib: move CPU architecture details to lib/cpuarch .. Patch Set 9: Verified+1 rebased and re-ran the testing environment to make sure it's fine -- To vie

Change in vdsm[master]: caps/lib: move CPU architecture details to lib/cpuarch

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: caps/lib: move CPU architecture details to lib/cpuarch .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

2016-01-12 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/51521/8/vdsm/virt/vmchannels.py File vdsm/vir

Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

2016-01-12 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51521 To unsubscribe, visit h

Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/51521/8/vdsm/virt/vmchannels.py File vdsm/virt/vmch

Change in vdsm[master]: caps/lib: move CPU architecture details to lib/cpuarch

2016-01-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: caps/lib: move CPU architecture details to lib/cpuarch .. Patch Set 8: Code-Review-1 some silly rebase needed -- To view, visit https://gerrit.ovirt.org/49972

Change in vdsm[master]: cpuinfo: use is_ppc predicate when parsing cpu_map.xml

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: cpuinfo: use is_ppc predicate when parsing cpu_map.xml .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- T

Change in vdsm[master]: cpuinfo: use is_ppc predicate when parsing cpu_map.xml

2016-01-12 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: cpuinfo: use is_ppc predicate when parsing cpu_map.xml .. cpuinfo: use is_ppc predicate when parsing cpu_map.xml The CPU_MAP.xml uses base platform nam

Change in vdsm[master]: tests: Fix loop device leak in mount tests

2016-01-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Fix loop device leak in mount tests .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/51614/1//COMMIT_MSG Commit Message: Line 12:

Change in vdsm[master]: tests: Fix loop device leak in mount tests

2016-01-12 Thread edwardh
Edward Haas has posted comments on this change. Change subject: tests: Fix loop device leak in mount tests .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51614 To unsubscribe, visit https://gerrit.ovi

  1   2   >