Change in vdsm[master]: utils: add weakmethod helper

Milan Zamazal has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/51865/4//COMMIT_MSG Commit Message: Line 13: an ... a ... Line 14:

Change in vdsm[master]: lib: use weakmethod to break reference cycles

Milan Zamazal has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/51630/8//COMMIT_MSG Commit Message: Line 28: friandly

Change in vdsm[master]: tests: extend coverage for vmstats.disks()

Milan Zamazal has posted comments on this change. Change subject: tests: extend coverage for vmstats.disks() .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51854 To unsubscribe, visit

Change in vdsm[master]: utils: add weakmethod helper

Nir Soffer has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/51865/4/tests/utilsTests.py File tests/utilsTests.py: Line 1009:

Change in vdsm[master]: utils: add weakmethod helper

Nir Soffer has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 7: (5 comments) https://gerrit.ovirt.org/#/c/51865/7/tests/utilsTests.py File tests/utilsTests.py: Line 993:

Change in vdsm[ovirt-3.5]: virt: Correct epoll unregistration usage in vmchannels

gerrit-hooks has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 7: * #1297414::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1297414::OK,

Change in vdsm[ovirt-3.5]: virt: Set cloexec flag on channel sockets

gerrit-hooks has posted comments on this change. Change subject: virt: Set cloexec flag on channel sockets .. Patch Set 5: Verified-1 * #1297414::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1297414::OK, public

Change in vdsm[master]: utils: add weakmethod helper

Francesco Romani has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/51865/4/tests/utilsTests.py File tests/utilsTests.py: Line 1009:

Change in vdsm[master]: virt: stats: make _disk_iops_bytes more robust

gerrit-hooks has posted comments on this change. Change subject: virt: stats: make _disk_iops_bytes more robust .. Patch Set 8: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug *

Change in vdsm[master]: tests: improve vmstats.disks coverage

gerrit-hooks has posted comments on this change. Change subject: tests: improve vmstats.disks coverage .. Patch Set 7: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug * Check

Change in vdsm[master]: tests: extend coverage for vmstats.disks()

Francesco Romani has posted comments on this change. Change subject: tests: extend coverage for vmstats.disks() .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/51854/2//COMMIT_MSG Commit Message: Line 11: argoments

Change in vdsm[master]: virt: stats: make disk_rate more robust

gerrit-hooks has posted comments on this change. Change subject: virt: stats: make disk_rate more robust .. Patch Set 11: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug * Check

Change in vdsm[master]: virt: stats: make compute_latency more robust

gerrit-hooks has posted comments on this change. Change subject: virt: stats: make compute_latency more robust .. Patch Set 8: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug *

Change in vdsm[ovirt-3.6]: virt: Set cloexec flag on channel sockets

Francesco Romani has posted comments on this change. Change subject: virt: Set cloexec flag on channel sockets .. Patch Set 1: Code-Review+2 raising score. Please verify on-branch. -- To view, visit

Change in vdsm[master]: lib: use weakmethod to break reference cycles

Francesco Romani has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/51630/8/lib/vdsm/libvirtconnection.py File

Change in vdsm[master]: utils: add weakmethod helper

gerrit-hooks has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 6: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check Public Bug::WARN,

Change in vdsm[master]: lib: apply weakmethod also to virConnect objects

Francesco Romani has uploaded a new change for review. Change subject: lib: apply weakmethod also to virConnect objects .. lib: apply weakmethod also to virConnect objects There is no evidence we leak virConnect objects, and

Change in vdsm[master]: lib: apply weakmethod also to virConnect objects

gerrit-hooks has posted comments on this change. Change subject: lib: apply weakmethod also to virConnect objects .. Patch Set 1: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug *

Change in vdsm[master]: lib: use weakmethod to break reference cycles

gerrit-hooks has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 9: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check

Change in vdsm[ovirt-3.5]: virt: Set cloexec flag on channel sockets

Francesco Romani has posted comments on this change. Change subject: virt: Set cloexec flag on channel sockets .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/51878/4/vdsm/virt/guestagent.py File

Change in vdsm[ovirt-3.6]: virt: Set cloexec flag on channel sockets

Vinzenz Feenstra has posted comments on this change. Change subject: virt: Set cloexec flag on channel sockets .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51877 To unsubscribe, visit

Change in vdsm[master]: tests: extend coverage for vmstats.disks()

Dan Kenigsberg has posted comments on this change. Change subject: tests: extend coverage for vmstats.disks() .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51854 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: virt: Set cloexec flag on channel sockets

Nir Soffer has posted comments on this change. Change subject: virt: Set cloexec flag on channel sockets .. Patch Set 4: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/51878/4/vdsm/virt/guestagent.py File

Change in vdsm[master]: utils: add weakmethod helper

Francesco Romani has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/51865/4//COMMIT_MSG Commit Message: Line 14: cycular > ... circular

Change in vdsm[master]: utils: add weakmethod helper

Francesco Romani has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 5: Code-Review-1 (2 comments) missing docstring, will add in the next upload.

Change in vdsm[master]: hooks: ovs: enable auto-attach mapping

Petr Horáček has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py File

Change in vdsm[master]: utils: add weakmethod helper

gerrit-hooks has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 7: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check Public Bug::WARN,

Change in vdsm[master]: lib: apply weakmethod also to virConnect objects

gerrit-hooks has posted comments on this change. Change subject: lib: apply weakmethod also to virConnect objects .. Patch Set 2: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug *

Change in vdsm[master]: lib: use weakmethod to break reference cycles

gerrit-hooks has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 10: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check

Change in vdsm[master]: virt: stats: make disk_rate more robust

Francesco Romani has posted comments on this change. Change subject: virt: stats: make disk_rate more robust .. Patch Set 11: Verified+1 verified together: 48493 50593 50594 verified the happy path running vms and checking

Change in vdsm[master]: virt: stats: make _disk_iops_bytes more robust

Francesco Romani has posted comments on this change. Change subject: virt: stats: make _disk_iops_bytes more robust .. Patch Set 8: Verified+1 verified together: 48493 50593 50594 verified the happy path running vms and

Change in vdsm[master]: tests: improve vmstats.disks coverage

Francesco Romani has posted comments on this change. Change subject: tests: improve vmstats.disks coverage .. Patch Set 7: Verified+1 verified running the tests themselves. -- To view, visit https://gerrit.ovirt.org/50598 To

Change in vdsm[master]: tests: extend coverage for vmstats.disks()

gerrit-hooks has posted comments on this change. Change subject: tests: extend coverage for vmstats.disks() .. Patch Set 3: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug *

Change in vdsm[master]: tests: extend coverage for vmstats.disks()

Francesco Romani has posted comments on this change. Change subject: tests: extend coverage for vmstats.disks() .. Patch Set 3: Verified+1 verified running the tests themselves. -- To view, visit

Change in vdsm[master]: lib: use weakmethod to break reference cycles

Nir Soffer has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 10: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/51630/10/lib/vdsm/libvirtconnection.py File

Change in vdsm[ovirt-3.5]: virt: Set cloexec flag on channel sockets

Nir Soffer has posted comments on this change. Change subject: virt: Set cloexec flag on channel sockets .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51878 To unsubscribe, visit

Change in vdsm[master]: lib: use weakmethod to break reference cycles

gerrit-hooks has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 8: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check

Change in vdsm[master]: utils: add weakmethod helper

gerrit-hooks has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 5: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check Public Bug::WARN,

Change in vdsm[master]: health: Introduce Vdsm health monitoring

Michal Skrivanek has posted comments on this change. Change subject: health: Introduce Vdsm health monitoring .. Patch Set 3: Code-Review+1 sure, better than nothing -- To view, visit https://gerrit.ovirt.org/51708 To

Change in vdsm[ovirt-3.6]: virt: Set cloexec flag on channel sockets

Vinzenz Feenstra has posted comments on this change. Change subject: virt: Set cloexec flag on channel sockets .. Patch Set 1: on it -- To view, visit https://gerrit.ovirt.org/51877 To unsubscribe, visit

Change in vdsm[master]: tests: improve vmstats.disks coverage

Dan Kenigsberg has posted comments on this change. Change subject: tests: improve vmstats.disks coverage .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50598 To unsubscribe, visit

Change in vdsm[master]: tests: extend coverage for vmstats.disks()

gerrit-hooks has posted comments on this change. Change subject: tests: extend coverage for vmstats.disks() .. Patch Set 4: * #1281337::Update tracker: OK * Set MODIFIED::bug 1281337#1281337IGNORE, not all related

Change in vdsm[master]: tests: extend coverage for vmstats.disks()

Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: extend coverage for vmstats.disks() .. tests: extend coverage for vmstats.disks() This patch extends the test coverage for vmstats.disks() -

Change in vdsm[master]: tests: improve vmstats.disks coverage

Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: improve vmstats.disks coverage .. tests: improve vmstats.disks coverage vmstats.disks() must be robust in presence of various missing diks

Change in vdsm[master]: tests: improve vmstats.disks coverage

gerrit-hooks has posted comments on this change. Change subject: tests: improve vmstats.disks coverage .. Patch Set 8: * #1281337::Update tracker: OK * Set MODIFIED::bug 1281337#1281337IGNORE, not all related patches

Change in vdsm[master]: virt: stats: make compute_latency more robust

Francesco Romani has posted comments on this change. Change subject: virt: stats: make compute_latency more robust .. Patch Set 8: verified together: 48493 50593 50594 verified the happy path running vms and checking vdsClient

Change in vdsm[master]: network setup validator

gerrit-hooks has posted comments on this change. Change subject: network setup validator .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: hooks: ovs: enable auto-attach mapping

Marcin Mirecki has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py File

Change in vdsm[master]: health: Introduce Vdsm health monitoring

Nir Soffer has posted comments on this change. Change subject: health: Introduce Vdsm health monitoring .. Patch Set 3: Code-Review-1 Need to remove gc.DEBUG_SAVEALL, saving all the unreachable objects is not useful for

Change in vdsm[master]: lib: use weakmethod to break reference cycles

Francesco Romani has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/51630/10/lib/vdsm/libvirtconnection.py File

Change in vdsm[master]: misc: Fix RWLock leak due to reference cycle

Nir Soffer has posted comments on this change. Change subject: misc: Fix RWLock leak due to reference cycle .. Patch Set 2: -Verified Need to test again with gc.set_debug(0) -- To view, visit https://gerrit.ovirt.org/51868

Change in vdsm[master]: utils: add weakmethod helper

gerrit-hooks has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 8: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check Public Bug::WARN,

Change in vdsm[master]: lib: apply weakmethod also to virConnect objects

Francesco Romani has abandoned this change. Change subject: lib: apply weakmethod also to virConnect objects .. Abandoned squashed in parent patch. -- To view, visit https://gerrit.ovirt.org/51885 To unsubscribe, visit

Change in vdsm[master]: lib: apply weakmethod also to virConnect objects

gerrit-hooks has posted comments on this change. Change subject: lib: apply weakmethod also to virConnect objects .. Patch Set 2: * update_tracker: OK -- To view, visit https://gerrit.ovirt.org/51885 To unsubscribe, visit

Change in vdsm[master]: lib: use weakmethod to break reference cycles

gerrit-hooks has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 11: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check

Change in vdsm[master]: utils: add weakmethod helper

Francesco Romani has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/51865/8/tests/utilsTests.py File tests/utilsTests.py: Line 1004:

Change in vdsm[master]: lib: use weakmethod to break reference cycles

Nir Soffer has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 11: Code-Review+2 Verified+1 Tested on rhel 7 with https://gerrit.ovirt.org/51708. See

Change in vdsm[master]: misc: Fix RWLock leak due to reference cycle

gerrit-hooks has posted comments on this change. Change subject: misc: Fix RWLock leak due to reference cycle .. Patch Set 2: * #1269424::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/51868 To unsubscribe,

Change in vdsm[ovirt-3.6]: virt: Correct epoll unregistration usage in vmchannels

Francesco Romani has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 2: Code-Review+2 re-raising score -- To view, visit https://gerrit.ovirt.org/51840 To

Change in vdsm[ovirt-3.5]: virt: Set cloexec flag on channel sockets

Francesco Romani has posted comments on this change. Change subject: virt: Set cloexec flag on channel sockets .. Patch Set 5: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/51878/5/vdsm/virt/guestagent.py File

Change in vdsm[ovirt-3.6]: virt: Correct epoll unregistration usage in vmchannels

Francesco Romani has submitted this change and it was merged. Change subject: virt: Correct epoll unregistration usage in vmchannels .. virt: Correct epoll unregistration usage in vmchannels Previously we have been

Change in vdsm[ovirt-3.6]: virt: Set cloexec flag on channel sockets

gerrit-hooks has posted comments on this change. Change subject: virt: Set cloexec flag on channel sockets .. Patch Set 2: * #1226911::Update tracker: OK * Set MODIFIED::bug 1226911#1226911IGNORE, not oVirt

Change in vdsm[ovirt-3.6]: virt: Set cloexec flag on channel sockets

Francesco Romani has submitted this change and it was merged. Change subject: virt: Set cloexec flag on channel sockets .. virt: Set cloexec flag on channel sockets To counter act potential leakage of open handles, this patch

Change in vdsm[master]: kill and report asyncProc if fails on first write to stdin

Piotr Kliczewski has posted comments on this change. Change subject: kill and report asyncProc if fails on first write to stdin .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/51763/2//COMMIT_MSG Commit Message:

Change in vdsm[master]: lib: use weakmethod to break reference cycles

Piotr Kliczewski has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51630 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: virt: Set cloexec flag on channel sockets

Francesco Romani has posted comments on this change. Change subject: virt: Set cloexec flag on channel sockets .. Patch Set 5: Looks fine, let's see what jenkins thinks -- To view, visit https://gerrit.ovirt.org/51878 To

Change in vdsm[master]: storage: Fix

Adam Litke has uploaded a new change for review. Change subject: storage: Fix .. storage: Fix In commit a816cd3d (which was part of the SDM Volume refactoring work) we moved some functions related to volume leases into the

Change in vdsm[master]: storage: Fix

gerrit-hooks has posted comments on this change. Change subject: storage: Fix .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a

Change in vdsm[master]: virt: stats: make disk_rate more robust

Francesco Romani has posted comments on this change. Change subject: virt: stats: make disk_rate more robust .. Patch Set 11: additional verification performed migrating VMs while continuosly requesti getAllVmStats. No

Change in vdsm[master]: virt: stats: make compute_latency more robust

Francesco Romani has posted comments on this change. Change subject: virt: stats: make compute_latency more robust .. Patch Set 8: additional verification performed migrating VMs while continuosly requesti getAllVmStats. No

Change in vdsm[master]: virt: stats: make _disk_iops_bytes more robust

Francesco Romani has posted comments on this change. Change subject: virt: stats: make _disk_iops_bytes more robust .. Patch Set 8: additional verification performed migrating VMs while continuosly requesti getAllVmStats. No

Change in vdsm[master]: lib: use weakmethod to break reference cycles

Milan Zamazal has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51630 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: virt: Correct epoll unregistration usage in vmchannels

gerrit-hooks has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 3: * #1226911::Update tracker: OK * Set MODIFIED::bug 1226911#1226911IGNORE, not

Change in vdsm[ovirt-3.5]: virt: Set cloexec flag on channel sockets

Francesco Romani has posted comments on this change. Change subject: virt: Set cloexec flag on channel sockets .. Patch Set 5: Rerun-Hooks: all -- To view, visit https://gerrit.ovirt.org/51878 To unsubscribe, visit

Change in vdsm[master]: misc: Fix RWLock leak due to reference cycle

Piotr Kliczewski has posted comments on this change. Change subject: misc: Fix RWLock leak due to reference cycle .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51868 To unsubscribe, visit

Change in vdsm[master]: hooks: ovs: enable auto-attach mapping

Petr Horáček has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py File

Change in vdsm[master]: hooks: ovs: enable auto-attach mapping

Marcin Mirecki has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 1: Code-Review+1 -Verified -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit

Change in vdsm[master]: hooks: ovs: enable auto-attach mapping

Marcin Mirecki has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit

Change in vdsm[master]: health: Introduce Vdsm health monitoring

gerrit-hooks has posted comments on this change. Change subject: health: Introduce Vdsm health monitoring .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: utils: add weakmethod helper

Nir Soffer has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 8: Verified+1 Tested together with https://gerrit.ovirt.org/51708. -- To view, visit https://gerrit.ovirt.org/51865 To

Change in vdsm[ovirt-3.5]: virt: Set cloexec flag on channel sockets

Vinzenz Feenstra has posted comments on this change. Change subject: virt: Set cloexec flag on channel sockets .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/51878 To unsubscribe, visit

Change in vdsm[master]: health: Introduce Vdsm health monitoring

Nir Soffer has posted comments on this change. Change subject: health: Introduce Vdsm health monitoring .. Patch Set 4: Verified+1 This remove the unneeded gc.DEBUG_SAVEALL option and refine the code. For example logs see

Change in vdsm[ovirt-3.5]: virt: Correct epoll unregistration usage in vmchannels

gerrit-hooks has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 7: -Verified * #1297414::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[ovirt-3.5]: virt: Set cloexec flag on channel sockets

gerrit-hooks has posted comments on this change. Change subject: virt: Set cloexec flag on channel sockets .. Patch Set 5: -Verified * #1297414::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1297414::OK, public

Change in vdsm[ovirt-3.5]: virt: Correct epoll unregistration usage in vmchannels

Francesco Romani has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 7: Rerun-Hooks: all -- To view, visit https://gerrit.ovirt.org/51841 To unsubscribe,

Change in vdsm[master]: misc: Fix RWLock leak due to reference cycle

Nir Soffer has abandoned this change. Change subject: misc: Fix RWLock leak due to reference cycle .. Abandoned Not needed, this leak exist only when running with gc.DEBUG_SAVEALL, because RWLock has a reference cycle.

Change in vdsm[master]: utils: add weakmethod helper

Francesco Romani has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 7: (5 comments) https://gerrit.ovirt.org/#/c/51865/7/tests/utilsTests.py File tests/utilsTests.py: Line 993:

Change in vdsm[master]: utils: add weakmethod helper

Nir Soffer has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/51865/8/tests/utilsTests.py File tests/utilsTests.py: Line 1004: Line

Change in vdsm[master]: virt: stats: make compute_latency more robust

Francesco Romani has posted comments on this change. Change subject: virt: stats: make compute_latency more robust .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/50593 To unsubscribe, visit

Change in vdsm[master]: utils: add weakmethod helper

Nir Soffer has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/51865/8/tests/utilsTests.py File tests/utilsTests.py: Line 1043:

Change in vdsm[master]: sp: update domain links on state change

Nir Soffer has posted comments on this change. Change subject: sp: update domain links on state change .. Patch Set 7: Liron, can you review this again? -- To view, visit https://gerrit.ovirt.org/51393 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: virt: Set cloexec flag on channel sockets

Vinzenz Feenstra has posted comments on this change. Change subject: virt: Set cloexec flag on channel sockets .. Patch Set 5: Jenkins thinks this: (With one unrelated error) Jenkins CI 2:39 PM ↩ Patch Set 5:

Change in vdsm[ovirt-3.5]: virt: Set cloexec flag on channel sockets

Francesco Romani has posted comments on this change. Change subject: virt: Set cloexec flag on channel sockets .. Patch Set 5: Continuous-Integration+1 jenkins failure unrelated (bond woes again). Everything else looks ok. --

Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

gerrit-hooks has posted comments on this change. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. Patch Set 5: * #1295428::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1295428::OK, public bug

Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

Nir Soffer has posted comments on this change. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. Patch Set 5: Code-Review+1 I agree that this patch is good enough compared with the previous code, and we make

Change in vdsm[master]: utils: add weakmethod helper

Nir Soffer has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 9: Code-Review+1 (2 comments) Looks good, can be little simpler, see the comments in the tests.

Change in vdsm[master]: net: Use VLAN ID as integer across VDSM

gerrit-hooks has posted comments on this change. Change subject: net: Use VLAN ID as integer across VDSM .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: Use VLAN ID as integer across VDSM

Edward Haas has posted comments on this change. Change subject: net: Use VLAN ID as integer across VDSM .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/51802/1/lib/vdsm/netconfpersistence.py File

Change in vdsm[master]: net: Use VLAN ID as integer across VDSM

Edward Haas has posted comments on this change. Change subject: net: Use VLAN ID as integer across VDSM .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/51802 To unsubscribe, visit

Change in vdsm[master]: split to commands_tests.py - only execCmd tests

Nir Soffer has posted comments on this change. Change subject: split to commands_tests.py - only execCmd tests .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/51762/2/tests/Makefile.am File tests/Makefile.am: Line

  1   2   >