Edward Haas has posted comments on this change.
Change subject: net: Fixing old netinfo access
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/53011
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: net: Fixing old netinfo access
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
Edward Haas has uploaded a new change for review.
Change subject: net: Fixing old netinfo access
..
net: Fixing old netinfo access
netinfo has been split into individual modules some time ago, this patch
fixes some leftovers tha
Edward Haas has posted comments on this change.
Change subject: net: Clean netinfo.__init__ and migrate to cache
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.
gerrit-hooks has posted comments on this change.
Change subject: net: Clean netinfo.__init__ and migrate to cache
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
Edward Haas has posted comments on this change.
Change subject: net: Clean netinfo.__init__ and migrate to cache
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.
Edward Haas has uploaded a new change for review.
Change subject: net: Clean netinfo.__init__ and migrate to cache
..
net: Clean netinfo.__init__ and migrate to cache
When stand alone modules under the netinfo package are being
gerrit-hooks has posted comments on this change.
Change subject: net: Clean netinfo.__init__ and migrate to cache
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 45:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
gerrit-hooks has posted comments on this change.
Change subject: virt: Use XML API in more VM devices
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: virt: Use XML API in Vm._correctDiskVolumes
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
Martin Betak has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/52980
To unsubscribe, visit https://gerrit.ovirt.org/settings
Martin Polednik has posted comments on this change.
Change subject: hooks: Remove dead code from before_vm_migrate_destination
..
Patch Set 2: Code-Review+1
I don't think we need to keep this for further reference with git hist
Martin Polednik has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52980
To unsubscribe, visit https://gerrit.ovirt.org/se
Milan Zamazal has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52980
To unsubscribe, visit https://gerrit.ovirt.org/sett
gerrit-hooks has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
Martin Betak has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 2:
split the hook part as per mpolednik's request
--
To view, visit https://gerrit.ovirt.org/52980
To unsubscribe, vi
gerrit-hooks has posted comments on this change.
Change subject: hooks: Remove dead code from before_vm_migrate_destination
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Remove unreachable code
..
vdsm: Remove unreachable code
Change-Id: Ie84749d01a735bc8177c7d16fb0612636f547004
Signed-off-by: Martin Betak
---
M lib/vdsm/u
gerrit-hooks has posted comments on this change.
Change subject: hooks: Remove dead code from before_vm_migrate_destination
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Martin Betak has uploaded a new change for review.
Change subject: hooks: Remove dead code from before_vm_migrate_destination
..
hooks: Remove dead code from before_vm_migrate_destination
Change-Id: Ibc853b33ee7470581c1dae4ad408
gerrit-hooks has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
Martin Polednik has posted comments on this change.
Change subject: hostdev: fix detection for ppc64le
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/50525
To unsubscribe, visit https://gerrit.ovirt.org/
gerrit-hooks has posted comments on this change.
Change subject: virt: Switch from minidom to etree in vmxml.XML
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: virt: Make DomainDescriptor use new XML API
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
gerrit-hooks has posted comments on this change.
Change subject: virt: Use XML API in some simpler VM devices
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: Use XML API in VM._getUnderlyingDeviceAddress
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Make VM._correctGraphicsConfiguration use DomainDescriptor
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url foun
gerrit-hooks has posted comments on this change.
Change subject: virt: XML helper for virt introduced
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 1: Code-Review-1
split the hook from other modifications, would love to see both in
--
To view, visit https://gerr
gerrit-hooks has posted comments on this change.
Change subject: WIP DONTMERGE: migrationLimit retry
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: Apply storage QoS on running VM
..
Patch Set 4:
* #1201482::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1201482::OK, public bug
* Check Product::#
gerrit-hooks has posted comments on this change.
Change subject: setupNetworks: moving nics between bonds
..
Patch Set 11:
* #1269175::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1269175::OK, public bug
* Check
Dan Kenigsberg has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 5:
(3 comments)
https://gerrit.ovirt.org/#/c/51763/5/lib/vdsm/commands.py
File lib/vdsm
Dan Kenigsberg has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 5: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/51763
To unsubscribe, visit
Edward Haas has uploaded a new change for review.
Change subject: net: Canonize dhcpv6 on API input
..
net: Canonize dhcpv6 on API input
IPv6 dhcp is enabled by default, therefore, if the key is missing
from the network setup re
gerrit-hooks has posted comments on this change.
Change subject: net: Canonize dhcpv6 on API input
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
Dan Kenigsberg has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52646
To unsubscribe, visit https://ge
Dan Kenigsberg has posted comments on this change.
Change subject: [wip] Dynamic load of supervdsm_api funcs
..
Patch Set 4:
(4 comments)
https://gerrit.ovirt.org/#/c/52875/4/tests/functional/supervdsmFuncTests.py
File tests/f
gerrit-hooks has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 44:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
gerrit-hooks has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 43:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
gerrit-hooks has posted comments on this change.
Change subject: Apply storage QoS on running VM
..
Patch Set 3:
* #1201482::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1201482::OK, public bug
* Check Product::#
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 1:
jenkins failure not related to this change.
--
To view, visit https://gerrit.ovirt.o
gerrit-hooks has posted comments on this change.
Change subject: untested: notify Engine when host connectivity changes
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
T
Dan Kenigsberg has submitted this change and it was merged.
Change subject: untested: notify Engine when host connectivity changes
..
untested: notify Engine when host connectivity changes
Change-Id: I4e2df34c95709a3e201e984909
Milan Zamazal has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 1: Code-Review-1
(1 comment)
Good idea, just an objection about modifying the hook.
https://gerrit.ovirt.org/#/c/529
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 1: Verified+1
Verified using latest engine and checking that hook error properly propagat
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: moving hook error to exception module
..
Patch Set 1: Verified+1
Verified using latest engine and checking that hook error properly propagates
to the
gerrit-hooks has posted comments on this change.
Change subject: hooks: moving hook error to exception module
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url i
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Make VdsmException reusable
..
Patch Set 1: Verified+1
Verified using latest engine and checking that hook error properly propagates
to the engine
Hello Nir Soffer, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/52982
to review the following change.
Change subject: exception: Make VdsmException reusable
..
exception: Make V
gerrit-hooks has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 1:
* #1295778::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1295778::OK, publi
gerrit-hooks has posted comments on this change.
Change subject: exception: Make VdsmException reusable
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is requ
Piotr Kliczewski has uploaded a new change for review.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
hooks: make sure to handle vdsm exception in the bridge
We need to make sure to handle hook errors
Piotr Kliczewski has uploaded a new change for review.
Change subject: hooks: moving hook error to exception module
..
hooks: moving hook error to exception module
Required-For: https://bugzilla.redhat.com/1295778
Change-Id: I9
gerrit-hooks has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 42:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
gerrit-hooks has posted comments on this change.
Change subject: WIP - io qos can be changed on running vm
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Martin Betak has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/52980/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 294
Line 295
Line
gerrit-hooks has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Remove unreachable code
..
vdsm: Remove unreachable code
Change-Id: I919ca97f7b1077be2415287a43b9a9372e1fa593
Signed-off-by: Martin Betak
---
M lib/vdsm/u
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: fix tests (waitForState and vdsProxy)
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: two networks cannot share one tag
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: enable auto-attach mapping
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
gerrit-hooks has posted comments on this change.
Change subject: test jenkins job
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/52965
To unsubscribe, visit https://gerri
Petr Horáček has abandoned this change.
Change subject: test jenkins job
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/52965
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit
gerrit-hooks has posted comments on this change.
Change subject: hostdev: fix detection for ppc64le
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
Petr Horáček has uploaded a new change for review.
Change subject: test jenkins job
..
test jenkins job
Change-Id: If71f2eaea3a06d1e62664b6c61915a6669d155d0
Signed-off-by: Petr Horáček
---
M vdsm/network/api.py
1 file changed,
gerrit-hooks has posted comments on this change.
Change subject: test jenkins job
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is required for the stable br
gerrit-hooks has posted comments on this change.
Change subject: hooks: moving hook error to exception module
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: moving hook error to exception module
..
hooks: moving hook error to exception module
Change-Id: I920a7ecff2f5e0b604f8c13dce2e59bdeef30056
Sign
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
hooks: make sure to handle vdsm exception in the bridge
We need to make sure to handle hook
gerrit-hooks has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 8:
* #1295778::Update tracker: OK
* Set MODIFIED::bug 1295778#1295778IGNORE, not all
Shahar Havivi has posted comments on this change.
Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
..
Patch Set 16: Verified+1
--
To view, visit https://gerrit.ovirt.org/49505
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: network: ovs configurator A
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: network: ovs configurator
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: hostdev: fix detection for ppc64le
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
Martin Polednik has posted comments on this change.
Change subject: virt: migration: initialize SourceThread._destServer on __init__
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52897
To unsubscribe
Martin Polednik has posted comments on this change.
Change subject: vmstats: remove useless short stacktrace
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/52894/3//COMMIT_MSG
Commit Message:
Line 6:
Martin Polednik has posted comments on this change.
Change subject: periodic: ignore known-benign libvirt errors
..
Patch Set 5: Code-Review-1
(2 comments)
I don't know what libvirt.VIR_ERR_OPERATION_UNSUPPORTED means in this
Piotr Kliczewski has posted comments on this change.
Change subject: untested: notify Engine when host connectivity changes
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit h
Martin Mucha has posted comments on this change.
Change subject: untested: notify Engine when host connectivity changes
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit https
Martin Polednik has posted comments on this change.
Change subject: periodic: silence useless log
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/52895/3/vdsm/virt/periodic.py
File vdsm/virt/periodic.py:
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 16:
> Also tested it on ppc and it is definitely somewhat better than
> before, consider that +0.
86 matches
Mail list logo