Edward Haas has posted comments on this change.
Change subject: net: api: destroyOnMasterRemoval has stable value
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53701
To unsubscribe, visit https://ger
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53714/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Nir Soffer has posted comments on this change.
Change subject: localFsSD: Use the right manifest.
..
Patch Set 3:
Amit, can you backport to 3.6?
--
To view, visit https://gerrit.ovirt.org/53688
To unsubscribe, visit https://g
gerrit-hooks has posted comments on this change.
Change subject: localFsSD: Use the right manifest.
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https:
Nir Soffer has submitted this change and it was merged.
Change subject: localFsSD: Use the right manifest.
..
localFsSD: Use the right manifest.
Local storage domain should use its own manifest instead of the
inherited one from
Adam Litke has posted comments on this change.
Change subject: localFsSD: Use the right manifest.
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53688
To unsubscribe, visit https://gerrit.ovirt.org/se
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53714/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: net: api: destroyOnMasterRemoval has stable value
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53701
To unsubscribe, visit https://
Dan Kenigsberg has posted comments on this change.
Change subject: net: api: don't check for bond slaves twice
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/53700/2/lib/vdsm/network/api.py
File lib/vdsm/network/api.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: api: mark functions as private
..
net: api: mark functions as private
network/api.py functions clientSeen() and assertBridgeClean()
are used only
Dan Kenigsberg has posted comments on this change.
Change subject: net: api: mark functions as private
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53657
To unsubscribe, visit https://gerrit.ovirt.o
gerrit-hooks has posted comments on this change.
Change subject: net: api: mark functions as private
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https
Dan Kenigsberg has posted comments on this change.
Change subject: net: api: drop isolatedCommand handling
..
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/53481/7/tests/configNetworkTests.py
File tests/c
Dan Kenigsberg has posted comments on this change.
Change subject: net: api: drop isolatedCommand handling
..
Patch Set 7: Continuous-Integration+1
Unrelated failure
ERROR: test_echo(4096, False) (stompTests.StompTests)
--
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: api: remove bonding handling from _addNetwork
..
net: api: remove bonding handling from _addNetwork
_addNetwork is not an API verb anymore. setupN
gerrit-hooks has posted comments on this change.
Change subject: net: api: remove bonding handling from _addNetwork
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To v
Dan Kenigsberg has posted comments on this change.
Change subject: net: api: remove bonding handling from _addNetwork
..
Patch Set 14: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/53475
To unsubscribe, v
Dan Kenigsberg has posted comments on this change.
Change subject: net: api: remove bonding handling from _addNetwork
..
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53475
To unsubscribe, visit https:
gerrit-hooks has posted comments on this change.
Change subject: net: api: remove bonding handling from _addNetwork
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: schema: remove unused types
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonrpc: provide more info when method not found
..
jsonrpc: provide more info when method not found
When there was no method to be invoked we returned gener
gerrit-hooks has posted comments on this change.
Change subject: schema: inconsistency fixes
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: bridge: obtain method
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
an
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 11:
I checked and current yaml implementation do not support splitting files when
alias/anchor is used in the file. We
Martin Polednik has posted comments on this change.
Change subject: tests: use new proxy method for virt functional tests
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/53528
To unsubscribe, visit https:
Petr Horáček has posted comments on this change.
Change subject: net: api: refactoring of bondings removal
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/53695/9/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Dan Kenigsberg has uploaded a new change for review.
Change subject: [WIP] net tests: make functional tests run again with
persistence=ifcfg
..
[WIP] net tests: make functional tests run again with persistence=ifcfg
We have mul
gerrit-hooks has posted comments on this change.
Change subject: [WIP] net tests: make functional tests run again with
persistence=ifcfg
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Petr Horáček has posted comments on this change.
Change subject: net: api: refactoring of bondings removal
..
Patch Set 9: Verified+1
Passed functional/networkTests.py without a regression.
--
To view, visit https://gerrit.ov
Martin Betak has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit http
Martin Betak has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit https://gerrit.ovir
gerrit-hooks has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
gerrit-hooks has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
Petr Horáček has posted comments on this change.
Change subject: net: api: destroyOnMasterRemoval has stable value
..
Patch Set 2: Verified+1
Passed functional/networkTests.py without a regression.
--
To view, visit https://
gerrit-hooks has posted comments on this change.
Change subject: net: api: refactoring of bondings removal
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Petr Horáček has posted comments on this change.
Change subject: tests: Move network tests to its own folder
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/53704/1/tests/network/__init__.py
File tests/
Piotr Kliczewski has posted comments on this change.
Change subject: m2c: use custom certificate validation function
..
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/53398/1/lib/vdsm/m2cutils.py
File lib/vdsm/m2cutils
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/52864/11/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:
Line 6928:
gerrit-hooks has posted comments on this change.
Change subject: net: api: refactoring of bondings removal
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: net: api: destroyOnMasterRemoval has stable value
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Edward Haas has posted comments on this change.
Change subject: net: Apply Host QoS changes on the fly
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/53548
To unsubscribe, visit https://gerrit.ovirt.org/
Petr Horáček has posted comments on this change.
Change subject: net: api: don't check for bond slaves twice
..
Patch Set 2: Verified+1
Passed functional/networkTests.py without a regression
--
To view, visit https://gerrit.o
Petr Horáček has posted comments on this change.
Change subject: m2c: use custom certificate validation function
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/53398/1/lib/vdsm/m2cutils.py
File lib/vdsm/m2cutils.py:
Petr Horáček has posted comments on this change.
Change subject: m2c: use custom certificate validation function
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/53398/1/lib/vdsm/m2cutils.py
File lib/vdsm
Edward Haas has posted comments on this change.
Change subject: net: also disable IPv6 on bridges not using it, after unified
restoration
..
Patch Set 5:
Could you please explain in the message why is this needed?
And why doin
Edward Haas has posted comments on this change.
Change subject: tests: Move network tests to its own folder
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/53704
To unsubscribe, visit https://gerrit.ovirt
Edward Haas has uploaded a new change for review.
Change subject: tests: Move network tests to its own folder
..
tests: Move network tests to its own folder
Network tests (from tests/) have been moved to tests/network/ and their
gerrit-hooks has posted comments on this change.
Change subject: tests: Move network tests to its own folder
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: ovs: support hot-plugged vnics
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52347
To unsubscribe, visit https://gerrit.ovirt
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: support hot-plugged vnics
..
Patch Set 4:
* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867FAILED, illegal change from ON_QA
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: ovs: support hot-plugged vnics
..
hooks: ovs: support hot-plugged vnics
To support hot-plugged vnics, we have to place our before_device_create
gerrit-hooks has posted comments on this change.
Change subject: net: api: don't check for bond slaves twice
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: ovs: support hot-plugged vnics
..
hooks: ovs: support hot-plugged vnics
To support hot-plugged vnics, we have to place our before_device_create
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: ovs: support hot-plugged vnics
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52348
To unsubscribe, visit https://gerrit.ovirt
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: support hot-plugged vnics
..
Patch Set 5:
* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related patches ar
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: support hot-plugged vnics
..
Patch Set 3: Verified+1
With this build, it is possible to add a new nic to running VM, VM is then able
to ping its host
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: support hot-plugged vnics
..
Patch Set 4: Verified+1
With this build, it is possible to add a new nic to running VM, VM is then able
to ping its host
gerrit-hooks has posted comments on this change.
Change subject: Live Merge: Skip initial extension when base is raw
..
Patch Set 6:
* #1308626::Update tracker: OK
* Set MODIFIED::bug 1308626#1308626IGNORE, not oVirt cl
Francesco Romani has submitted this change and it was merged.
Change subject: Live Merge: Skip initial extension when base is raw
..
Live Merge: Skip initial extension when base is raw
When starting a live merge we pre-extend t
Piotr Kliczewski has posted comments on this change.
Change subject: schema: remove unused types
..
Patch Set 2:
Francesco any news?
--
To view, visit https://gerrit.ovirt.org/53521
To unsubscribe, visit https://gerrit.ovirt.
Piotr Kliczewski has posted comments on this change.
Change subject: schema: inconsistency fixes
..
Patch Set 3:
Nir any news?
--
To view, visit https://gerrit.ovirt.org/53460
To unsubscribe, visit https://gerrit.ovirt.org/se
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Skip initial extension when base is raw
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53110
To unsubscribe, visit http
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: support hot-plugged vnics
..
Patch Set 3: Verified-1
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: support hot-plugged vnics
..
Patch Set 4:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Prod
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: support hot-plugged vnics
..
Patch Set 3:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Prod
Irit Goihman has posted comments on this change.
Change subject: vdsm: added decorator to host uuid function
..
Patch Set 1:
> you should use the same Change-Id as your previous patch (
> I42b725075a14bb090e9dd0aa429fffe537ccf
Edward Haas has posted comments on this change.
Change subject: net: api: remove bonding handling from _addNetwork
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53475
To unsubscribe, visit https://g
gerrit-hooks has posted comments on this change.
Change subject: net: api: remove bonding handling from _addNetwork
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: support hot-plugged vnics
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Prod
gerrit-hooks has posted comments on this change.
Change subject: net: Adding network api module to supervdsm
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vis
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Adding network api module to supervdsm
..
net: Adding network api module to supervdsm
Change-Id: I75197754b9c64ccc1a58632802ba0cc8d99c9eb9
Signed-
gerrit-hooks has posted comments on this change.
Change subject: net: api: refactoring of bondings removal
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: net: api: refactoring of bondings removal
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 3:
* #1295778::Update tracker: OK
* Set MODIFIED::bug 1295778#1295778OK
--
To view,
Francesco Romani has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 2: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/53696
To unsubscr
gerrit-hooks has posted comments on this change.
Change subject: net: api: refactoring of bondings removal
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Francesco Romani has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 2:
run CI scripts manually on local environment:
http://www.ovirt.org/CI/Build_and_test_
Francesco Romani has submitted this change and it was merged.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
hooks: make sure to handle vdsm exception in the bridge
We need to make sure to handle hoo
Jenkins CI has posted comments on this change.
Change subject: net: api: refactoring of bondings removal
..
Patch Set 4: Continuous-Integration-1
Propagate review hook: Continuous Integration value inherited from patch 3
--
T
gerrit-hooks has posted comments on this change.
Change subject: net: api: refactoring of bondings removal
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: bond removal
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a va
Francesco Romani has submitted this change and it was merged.
Change subject: hooks: moving hook error to exception module
..
hooks: moving hook error to exception module
Required-For: https://bugzilla.redhat.com/1295778
Chang
gerrit-hooks has posted comments on this change.
Change subject: hooks: moving hook error to exception module
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vi
Francesco Romani has posted comments on this change.
Change subject: hooks: moving hook error to exception module
..
Patch Set 1:
run CI scripts manually on local chroots:
http://www.ovirt.org/CI/Build_and_test_standards#Testi
Francesco Romani has posted comments on this change.
Change subject: hooks: moving hook error to exception module
..
Patch Set 1: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/53699
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: tests: use new proxy method for virt functional tests
..
Patch Set 1: Code-Review+1
Thanks, let's make functional tests working again!
--
To view, visit https:
Petr Horáček has posted comments on this change.
Change subject: net: api: destroyOnMasterRemoval has stable value
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53701/1/lib/vdsm/network/api.py
File lib/vdsm/network/
gerrit-hooks has posted comments on this change.
Change subject: net: api: destroyOnMasterRemoval has stable value
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Petr Horáček has uploaded a new change for review.
Change subject: net: api: destroyOnMasterRemoval has stable value
..
net: api: destroyOnMasterRemoval has stable value
We don't have to check if 'remove' in attrs, it has been a
gerrit-hooks has posted comments on this change.
Change subject: net: api: don't check for bond slaves twice
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
gerrit-hooks has posted comments on this change.
Change subject: bond removal
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a va
Petr Horáček has uploaded a new change for review.
Change subject: net: api: don't check for bond slaves twice
..
net: api: don't check for bond slaves twice
We already check if bonds have slaves in _validateNetworkSetup(),
ther
Francesco Romani has submitted this change and it was merged.
Change subject: exception: Make VdsmException reusable
..
exception: Make VdsmException reusable
VdsmException was initializing code and message to default values if
gerrit-hooks has posted comments on this change.
Change subject: exception: Make VdsmException reusable
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit ht
Francesco Romani has posted comments on this change.
Change subject: exception: Make VdsmException reusable
..
Patch Set 1:
run CI scripts manually:
http://www.ovirt.org/CI/Build_and_test_standards#Testing_the_scripts_locally
Francesco Romani has posted comments on this change.
Change subject: exception: Make VdsmException reusable
..
Patch Set 1: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/53698
To unsubscribe, visit https:
Petr Horáček has posted comments on this change.
Change subject: net: also disable IPv6 on bridges not using it, after unified
restoration
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53683
To unsu
gerrit-hooks has posted comments on this change.
Change subject: net: also disable IPv6 on bridges not using it, after unified
restoration
..
Patch Set 5:
* #1219363::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::
1 - 100 of 183 matches
Mail list logo