Change in vdsm[master]: net: also disable IPv6 on bridges not using it, after unifie...

Edward Haas has posted comments on this change. Change subject: net: also disable IPv6 on bridges not using it, after unified restoration .. Patch Set 6: (1 comment)

Change in vdsm[master]: net tests: make functional tests run again with persistence=...

gerrit-hooks has posted comments on this change. Change subject: net tests: make functional tests run again with persistence=ifcfg .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: net tests: make functional tests run again with persistence=...

Edward Haas has posted comments on this change. Change subject: net tests: make functional tests run again with persistence=ifcfg .. Patch Set 3: Code-Review-1 (1 comment)

Change in vdsm[ovirt-3.6]: net: api: use running config only with unified persistence

Hello Petr Horáček, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/53763 to review the following change. Change subject: net: api: use running config only with unified persistence .. net: api:

Change in vdsm[ovirt-3.6]: net: api: use running config only with unified persistence

gerrit-hooks has posted comments on this change. Change subject: net: api: use running config only with unified persistence .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At

Change in vdsm[master]: adding StorageDomain.removeVmData()

Jenkins CI RO has posted comments on this change. Change subject: adding StorageDomain.removeVmData() .. Patch Set 4: Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: adding StorageDomain.getStoredVmsInfo

Jenkins CI RO has posted comments on this change. Change subject: adding StorageDomain.getStoredVmsInfo .. Patch Set 9: Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: tcTests: Fix problem of left over bridges

Jenkins CI RO has posted comments on this change. Change subject: tcTests: Fix problem of left over bridges .. Patch Set 2: Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: RWLock: Add non-blocking acquire

Jenkins CI RO has posted comments on this change. Change subject: RWLock: Add non-blocking acquire .. Patch Set 4: Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: adding StorageDomain.activateHsm()

Jenkins CI RO has posted comments on this change. Change subject: adding StorageDomain.activateHsm() .. Patch Set 4: Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: adding StorageDomain.getStoredVmsInfo

gerrit-hooks has posted comments on this change. Change subject: adding StorageDomain.getStoredVmsInfo .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/42129 To

Change in vdsm[master]: virt: enable libgfapi with snapshot support

gerrit-hooks has posted comments on this change. Change subject: virt: enable libgfapi with snapshot support .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/33768 To

Change in vdsm[master]: hostdev: add reattach method to HostDevice

gerrit-hooks has posted comments on this change. Change subject: hostdev: add reattach method to HostDevice .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/43774 To

Change in vdsm[master]: adding StorageDomain.updateVmData()

Jenkins CI RO has posted comments on this change. Change subject: adding StorageDomain.updateVmData() .. Patch Set 5: Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: tcTests: Fix problem of left over bridges

gerrit-hooks has posted comments on this change. Change subject: tcTests: Fix problem of left over bridges .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/44028 To

Change in vdsm[master]: hostdev: add support for hotunplug

Jenkins CI RO has posted comments on this change. Change subject: hostdev: add support for hotunplug .. Patch Set 2: Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: Add ResourceLocker

Jenkins CI RO has posted comments on this change. Change subject: Add ResourceLocker .. Patch Set 3: Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/43554 To

Change in vdsm[master]: adding StorageDomain.getStoredVmsInfo

Jenkins CI RO has abandoned this change. Change subject: adding StorageDomain.getStoredVmsInfo .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/42129 To

Change in vdsm[master]: virt: enable libgfapi with snapshot support

Jenkins CI RO has abandoned this change. Change subject: virt: enable libgfapi with snapshot support .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: tcTests: Fix problem of left over bridges

Jenkins CI RO has abandoned this change. Change subject: tcTests: Fix problem of left over bridges .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/44028

Change in vdsm[master]: virt: Send event after shutdown or reboot initiation

gerrit-hooks has posted comments on this change. Change subject: virt: Send event after shutdown or reboot initiation .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit

Change in vdsm[master]: StorageDomainManifest: introduce produceVolumeMetadata

gerrit-hooks has posted comments on this change. Change subject: StorageDomainManifest: introduce produceVolumeMetadata .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit

Change in vdsm[master]: Add ResourceLocker

gerrit-hooks has posted comments on this change. Change subject: Add ResourceLocker .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/43554 To unsubscribe, visit

Change in vdsm[master]: hostdev: add reattach method to HostDevice

Jenkins CI RO has posted comments on this change. Change subject: hostdev: add reattach method to HostDevice .. Patch Set 1: Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: [WIP]ABRT integration

Jenkins CI RO has posted comments on this change. Change subject: [WIP]ABRT integration .. Patch Set 1: Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/44287 To

Change in vdsm[master]: virt: Send event after shutdown or reboot initiation

Jenkins CI RO has abandoned this change. Change subject: virt: Send event after shutdown or reboot initiation .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: [WIP]configurators: move configurator functions into conf_utils

Jenkins CI RO has abandoned this change. Change subject: [WIP]configurators: move configurator functions into conf_utils .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: StorageDomainManifest: introduce produceVolumeMetadata

Jenkins CI RO has abandoned this change. Change subject: StorageDomainManifest: introduce produceVolumeMetadata .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: RWLock: Add non-blocking acquire

Jenkins CI RO has abandoned this change. Change subject: RWLock: Add non-blocking acquire .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/42773 To

Change in vdsm[master]: hostdev: add reattach method to HostDevice

Jenkins CI RO has abandoned this change. Change subject: hostdev: add reattach method to HostDevice .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: [WIP]configurators: move configurator functions into conf_utils

gerrit-hooks has posted comments on this change. Change subject: [WIP]configurators: move configurator functions into conf_utils .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit

Change in vdsm[master]: adding the StorageDomain.upgradeVersion verb

Jenkins CI RO has posted comments on this change. Change subject: adding the StorageDomain.upgradeVersion verb .. Patch Set 7: Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: Add ResourceLocker

Jenkins CI RO has abandoned this change. Change subject: Add ResourceLocker .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/43554 To unsubscribe, visit

Change in vdsm[master]: virt: Send event after shutdown or reboot initiation

Jenkins CI RO has posted comments on this change. Change subject: virt: Send event after shutdown or reboot initiation .. Patch Set 1: Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: virt: enable libgfapi with snapshot support

Jenkins CI RO has posted comments on this change. Change subject: virt: enable libgfapi with snapshot support .. Patch Set 4: Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: [WIP]configurators: move configurator functions into conf_utils

Jenkins CI RO has posted comments on this change. Change subject: [WIP]configurators: move configurator functions into conf_utils .. Patch Set 1: Abandoned due to no activity - please restore if still relevant -- To view,

Change in vdsm[master]: RWLock: Add non-blocking acquire

gerrit-hooks has posted comments on this change. Change subject: RWLock: Add non-blocking acquire .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/42773 To unsubscribe,

Change in vdsm[master]: StorageDomainManifest: introduce produceVolumeMetadata

Jenkins CI RO has posted comments on this change. Change subject: StorageDomainManifest: introduce produceVolumeMetadata .. Patch Set 3: Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: [WIP]ABRT integration

gerrit-hooks has posted comments on this change. Change subject: [WIP]ABRT integration .. Patch Set 1: * #917062::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/44287 To unsubscribe, visit

Change in vdsm[master]: [WIP]ABRT integration

Jenkins CI RO has abandoned this change. Change subject: [WIP]ABRT integration .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/44287 To unsubscribe,

Change in vdsm[master]: net: api: remove _delNonVdsmNetwork

Edward Haas has posted comments on this change. Change subject: net: api: remove _delNonVdsmNetwork .. Patch Set 1: Are you sure? What about del from _delBrokenNetwork? -- To view, visit https://gerrit.ovirt.org/53761 To

Change in vdsm[master]: net: api: move netinfo update and save one call

Edward Haas has posted comments on this change. Change subject: net: api: move netinfo update and save one call .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/53760/1/lib/vdsm/network/api.py File

Change in vdsm[master]: net: api: rename _add_missing_networks -> _net_setup

Edward Haas has posted comments on this change. Change subject: net: api: rename _add_missing_networks -> _net_setup .. Patch Set 1: setup usually imply also edit and delete in addition to add. I would suggest '_net_add' --

Change in vdsm[master]: net: api: return networks to connectivity check from setup

Edward Haas has posted comments on this change. Change subject: net: api: return networks to connectivity check from setup .. Patch Set 2: Code-Review-1 (2 comments)

Change in vdsm[master]: tests: Move network tests to its own folder

Edward Haas has posted comments on this change. Change subject: tests: Move network tests to its own folder .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/53704/1/tests/Makefile.am File tests/Makefile.am: Line 83:

Change in vdsm[master]: tests: Move network tests to its own folder

Edward Haas has posted comments on this change. Change subject: tests: Move network tests to its own folder .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/53704/1/tests/network/__init__.py File

Change in vdsm[master]: tests: Move network tests to its own folder

gerrit-hooks has posted comments on this change. Change subject: tests: Move network tests to its own folder .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: Kill and report asyncProc if fails on first write to stdin

Nir Soffer has posted comments on this change. Change subject: Kill and report asyncProc if fails on first write to stdin .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/51763/6/tests/commands_test.py File

Change in vdsm[master]: tests: Move network tests to its own folder

Nir Soffer has posted comments on this change. Change subject: tests: Move network tests to its own folder .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/53704/1/tests/Makefile.am File tests/Makefile.am: Line 83:

Change in vdsm[master]: net: Removing cfg entry from get capabilities

Edward Haas has posted comments on this change. Change subject: net: Removing cfg entry from get capabilities .. Patch Set 2: Seems it is used in ovirt-hosted-engine-setup. (https://gerrit.ovirt.org/#/c/53428) We should

Change in vdsm[master]: vm: Make run() return status

Dan Kenigsberg has posted comments on this change. Change subject: vm: Make run() return status .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53745 To unsubscribe, visit

Change in vdsm[master]: net: api: move netinfo update and save one call

Dan Kenigsberg has posted comments on this change. Change subject: net: api: move netinfo update and save one call .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/53760/1/lib/vdsm/network/api.py File

Change in vdsm[master]: net: api: rename _add_missing_networks -> _net_setup

Dan Kenigsberg has posted comments on this change. Change subject: net: api: rename _add_missing_networks -> _net_setup .. Patch Set 1: Code-Review-1 net_setup is a highly-overloaded name (the verb is setupNetworks, we have

Change in vdsm[master]: net: api: drop isolatedCommand handling

Dan Kenigsberg has submitted this change and it was merged. Change subject: net: api: drop isolatedCommand handling .. net: api: drop isolatedCommand handling Since addNetwork and delNetwork API were dropped, we don't need

Change in vdsm[master]: net: api: drop isolatedCommand handling

Dan Kenigsberg has posted comments on this change. Change subject: net: api: drop isolatedCommand handling .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53481 To unsubscribe, visit

Change in vdsm[master]: net: api: drop isolatedCommand handling

gerrit-hooks has posted comments on this change. Change subject: net: api: drop isolatedCommand handling .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: net: Removing cfg entry from get capabilities

Dan Kenigsberg has posted comments on this change. Change subject: net: Removing cfg entry from get capabilities .. Patch Set 2: Code-Review-1 $ git grep "\bcfg\b" shows that it should be removed from schema, networkTests.py,

Change in vdsm[master]: move alignmentScan.py to lib

Dan Kenigsberg has posted comments on this change. Change subject: move alignmentScan.py to lib .. Patch Set 2: Code-Review-1 Import execCmd from vdsm.command Traceback (most recent call last): File

Change in vdsm[master]: net: also disable IPv6 on bridges not using it, after unifie...

Dan Kenigsberg has posted comments on this change. Change subject: net: also disable IPv6 on bridges not using it, after unified restoration .. Patch Set 6: Code-Review-1 (1 comment) a nit

Change in vdsm[master]: ifcfg: import netinfo modules' members directly

Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: import netinfo modules' members directly .. Patch Set 1: Code-Review-1 (1 comment)

Change in vdsm[master]: vm: destroy: try harder destroying a Vm

Dan Kenigsberg has posted comments on this change. Change subject: vm: destroy: try harder destroying a Vm .. Patch Set 1: Code-Review-1 (1 comment) I prefer being more prudent and killing the VM only after we are sure we