Francesco Romani has posted comments on this change.
Change subject: netinfo: dns: more robust parsing of resolv.conf
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/54558/2/tests/network/netinfo_test.py
File
gerrit-hooks has posted comments on this change.
Change subject: machinetype: document public functions
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: netinfo: dns: more robust parsing of resolv.conf
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: enable more tests on py3
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has uploaded a new change for review.
Change subject: tests: enable more tests on py3
..
tests: enable more tests on py3
Change-Id: I91de6407b5d08901d719c73effb251d101b3866f
Signed-off-by: Francesco Romani
Francesco Romani has uploaded a new change for review.
Change subject: lib: py3: add compat shim for StringIO
..
lib: py3: add compat shim for StringIO
We use the StringIO class (e.g. commands.py),
but this class was moved
gerrit-hooks has posted comments on this change.
Change subject: lib: py3: add compat shim for StringIO
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has posted comments on this change.
Change subject: net: IP address hostport split tool
..
Patch Set 4:
Nir, the storage "vertical" can (and does) give services to other verticals
(mount.Mount is an example).
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Make Vm.devMapFromDevSpecMap() private
..
virt: Make Vm.devMapFromDevSpecMap() private
There is currently no reason to expose the method outside
gerrit-hooks has posted comments on this change.
Change subject: virt: Make Vm.devMapFromDevSpecMap() private
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: api: replace custom logger with logging
..
net: api: replace custom logger with logging
We use one log file for all supervdsm logs, there is no
Dan Kenigsberg has posted comments on this change.
Change subject: net: api: replace custom logger with logging
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54350
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: api: replace custom logger with logging
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Unbreak imagetickets_test
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54571
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Unbreak imagetickets_test
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Unbreak imagetickets_test
..
tests: Unbreak imagetickets_test
imagetickets_test passed locally and on jenkins, but failed after
rebasing on
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
virt: Make Vm.devSpecMapFromConf() private
There is currently no reason to expose the method outside Vm.
gerrit-hooks has posted comments on this change.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: api: remove unused methods
..
Patch Set 4: Code-Review-1
why are you removing the storage tests instead of fixing them? it certainly
does not belong to this
gerrit-hooks has posted comments on this change.
Change subject: debian: add supervdsm_api
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: debian: add supervdsm_api
..
debian: add supervdsm_api
Whole supervdsm_api package was missing in debian installation
according to the debian
Dan Kenigsberg has posted comments on this change.
Change subject: debian: add supervdsm_api
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54466
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Don't use Vm device configuration in clientIF
..
virt: Don't use Vm device configuration in clientIF
clientIF retrieves device configuration
gerrit-hooks has posted comments on this change.
Change subject: virt: Don't use Vm device configuration in clientIF
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Nir Soffer has posted comments on this change.
Change subject: virt: Use PEP8 identifiers in vmxml.device_address
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54511/1/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Nir Soffer has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53615
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: virt: Make Vm.devMapFromDevSpecMap() private
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53484
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53483
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: virt: Don't use Vm device configuration in clientIF
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53482
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Unbreak imagetickets_test
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: tests: Unbreak imagetickets_test after
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/54571
To unsubscribe, visit
Nir Soffer has uploaded a new change for review.
Change subject: tests: Unbreak imagetickets_test after
..
tests: Unbreak imagetickets_test after
imagetickets_test passed locally and on jenkins, but failed after
rebasing on
gerrit-hooks has posted comments on this change.
Change subject: tests: Unbreak imagetickets_test after
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 13: Code-Review+2 Verified+1
Tests still pass
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: imagetickets: add tests
..
imagetickets: add tests
Adding tests to the new imagetickets module.
Change-Id: I2728851a91529ec35501f423d9a798af961fb82a
Nir Soffer has posted comments on this change.
Change subject: json: use forzenset for filtered methods
..
Patch Set 5:
Waiting for another review
--
To view, visit https://gerrit.ovirt.org/54160
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 1:
Looks good, but we are not handling yet errors in execCmd - we had few patches
for this, but they
Nir Soffer has posted comments on this change.
Change subject: tests: refactor manifest_tests fake env setup
..
Patch Set 2: Code-Review-1
(1 comment)
Looks good, one question
Nir Soffer has posted comments on this change.
Change subject: storagetests: initial FakeEnv support
..
Patch Set 1: Code-Review-1
(1 comment)
Looks good, minor style issue.
Nir Soffer has posted comments on this change.
Change subject: FakeLVM: Add invalidateVG stub
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54566
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: incorporate pool id in file domain path
..
Patch Set 1: Code-Review-1
(1 comment)
Looks good, imports can be nicer.
Nir Soffer has posted comments on this change.
Change subject: storage: Cleanup usage of DMDK_POOLS
..
Patch Set 1: Code-Review-1
(2 comments)
Looks good, lets rebase on master and import from new shiny lib/vdsm/storage
Nir Soffer has posted comments on this change.
Change subject: tests: rename manifest_tests.py
..
Patch Set 1: Code-Review-1
(1 comment)
Looks good, suggested rename.
https://gerrit.ovirt.org/#/c/54563/1/tests/Makefile.am
Petr Horáček has posted comments on this change.
Change subject: net: api: keep names and quotes consistent
..
Patch Set 9:
for some reason this breaks some tests...
for instance testDhcpReplaceNicWithBridge fails with
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: re-enable IPv6 before device configuration, or disable
afterwards
..
Patch Set 5: Verified+1
All functional tests passed, including
gerrit-hooks has posted comments on this change.
Change subject: repoplot: Add LVM commands graph
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: repoplot: Add LVM commands graph
..
repoplot: Add LVM commands graph
Parse and display LVM commands runtime. Domain monitors are running LVM
commands
gerrit-hooks has posted comments on this change.
Change subject: tests: incorporate pool id in file domain path
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has posted comments on this change.
Change subject: repoplot: Add LVM commands graph
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54080
To unsubscribe, visit
Adam Litke has uploaded a new change for review.
Change subject: tests: rename manifest_tests.py
..
tests: rename manifest_tests.py
We now have multiple kinds of manifests: StorageDomainManifest,
ImageManifest, and
Adam Litke has uploaded a new change for review.
Change subject: storagetests: Create metadata storage area for block domains
..
storagetests: Create metadata storage area for block domains
In order for our fake block storage
gerrit-hooks has posted comments on this change.
Change subject: FakeLVM: Add invalidateVG stub
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has uploaded a new change for review.
Change subject: tests: incorporate pool id in file domain path
..
tests: incorporate pool id in file domain path
In real environments, an image 'A' in a file domain would appear
Adam Litke has uploaded a new change for review.
Change subject: storagetests: initial FakeEnv support
..
storagetests: initial FakeEnv support
Many storage tests rely on a mocked storage environment in order to test
the
Adam Litke has uploaded a new change for review.
Change subject: storagetests: Rename make_blocksd
..
storagetests: Rename make_blocksd
Over time make_blocksd has evolved to work more like
make_filesd_manifest. Now that it
gerrit-hooks has posted comments on this change.
Change subject: storagetests: Add create_block_volume
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storagetests: Rename make_blocksd
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storagetests: initial FakeEnv support
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has uploaded a new change for review.
Change subject: storagetests: Add create_block_volume
..
storagetests: Add create_block_volume
Add a utility function to create a fake block volume. We must make sure
the LV is
gerrit-hooks has posted comments on this change.
Change subject: storagetests: Create metadata storage area for block domains
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: tests: rename manifest_tests.py
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Cleanup usage of DMDK_POOLS
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has uploaded a new change for review.
Change subject: storage: Cleanup usage of DMDK_POOLS
..
storage: Cleanup usage of DMDK_POOLS
Storage Domains have a metadata key called DMDK_POOLS. Volumes also use
this
Adam Litke has uploaded a new change for review.
Change subject: FakeLVM: Add invalidateVG stub
..
FakeLVM: Add invalidateVG stub
Real code expects to call lvm.invalidateVG in cases where our cache
needs to be invalidated and
gerrit-hooks has posted comments on this change.
Change subject: tests: refactor manifest_tests fake env setup
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: ifcfg: re-enable IPv6 before device configuration, or disable
afterwards
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
Adam Litke has posted comments on this change.
Change subject: tests: refactor manifest_tests fake env setup
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/50273/1/tests/manifest_tests.py
File
Ondřej Svoboda has posted comments on this change.
Change subject: net: api: replace custom logger with logging
..
Patch Set 5: Code-Review+1
The failing test is handled by https://gerrit.ovirt.org/#/c/54555/
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: net: api: replace custom logger with logging
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Edward Haas has posted comments on this change.
Change subject: netinfo: dns: more robust parsing of resolv.conf
..
Patch Set 2: -Code-Review
(1 comment)
https://gerrit.ovirt.org/#/c/54558/2/tests/network/netinfo_test.py
File
Edward Haas has posted comments on this change.
Change subject: netinfo: dns: more robust parsing of resolv.conf
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54558
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: netinfo: dns: more robust parsing of resolv.conf
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/54558/2/tests/network/netinfo_test.py
File
Edward Haas has posted comments on this change.
Change subject: net: api: keep names and quotes consistent
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54351
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net: api: replace custom logger with logging
..
Patch Set 4: Code-Review+1
The mentioned failures in the functional tests are unrelated.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: schema: add Rng and Tpm device to the device list
..
Patch Set 7:
I am working on a fix and should push a patch soon.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: ifcfg: re-enable IPv6 before device configuration, or disable
afterwards
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
Nir Soffer has submitted this change and it was merged.
Change subject: storage: Move storage_exception module to lib
..
storage: Move storage_exception module to lib
Moving vdsm/storage/storage_exception.py to
gerrit-hooks has posted comments on this change.
Change subject: storage: Move storage_exception module to lib
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: tests: refactor manifest_tests fake env setup
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/50273/1/tests/manifest_tests.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Move storage_exception module to lib
..
Patch Set 9: Verified+1
Trivial rebase in storageServer.py, copying verification.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: netinfo: dns: more robust parsing of resolv.conf
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Petr Horáček has posted comments on this change.
Change subject: net: api: replace custom logger with logging
..
Patch Set 4: Verified+1
Passed network tests without a regression.
test_drop_initial_bond_slaves_ip_config is
Nir Soffer has posted comments on this change.
Change subject: storage: Move storage_exception module to lib
..
Patch Set 9: Code-Review+2
This version is a rebase on master, and fix conflict with latest changes in
gerrit-hooks has posted comments on this change.
Change subject: storage: Move storage_exception module to lib
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: netinfo: dns: more robust parsing of resolv.conf
..
Patch Set 1: Code-Review-1 Verified+1
V+1:verified using the new tests
-1 because the output of the tests
Francesco Romani has uploaded a new change for review.
Change subject: netinfo: dns: more robust parsing of resolv.conf
..
netinfo: dns: more robust parsing of resolv.conf
The current code which parses /etc/resolv.conf is not
gerrit-hooks has posted comments on this change.
Change subject: netinfo: dns: more robust parsing of resolv.conf
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: moving protocoldetector under lib
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: moving protocoldetector under lib
..
moving protocoldetector under lib
Change-Id: Ifc63b5a23278a2b05897662848e625fcdd9ee0bb
Signed-off-by: Yaniv
Dan Kenigsberg has submitted this change and it was merged.
Change subject: machinetype: reorganize and rename private functions
..
machinetype: reorganize and rename private functions
This patch renames the private function
gerrit-hooks has posted comments on this change.
Change subject: machinetype: reorganize and rename private functions
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: remove unused sendKeys verb
..
vm: remove unused sendKeys verb
Change-Id: I709610a43cdf58464147ed6c7167d93558e29451
Signed-off-by: pkliczewski
gerrit-hooks has posted comments on this change.
Change subject: vm: remove unused sendKeys verb
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: remove not used monitorCommand
..
Patch Set 1: Code-Review+2
monitorCommand is doing
return errCode['noimpl']
since ovirt-3.0 (at least). It's time to
Dan Kenigsberg has posted comments on this change.
Change subject: vm: remove unused sendKeys verb
..
Patch Set 1: Code-Review+2
This was only seldom used by QE. It can go now.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: storage: Move storage_exception module to lib
..
Patch Set 8: Code-Review-1
please rebase on top of https://gerrit.ovirt.org/#/c/53785/
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: schema: add Rng and Tpm device to the device list
..
Patch Set 7:
This error is not related, I reported it yesterday in devel.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: Removing 'link' scoped addresses from the ip address list
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54211
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Removing 'link' scoped addresses from the ip address list
..
net: Removing 'link' scoped addresses from the ip address list
This method should
1 - 100 of 279 matches
Mail list logo
