Edward Haas has posted comments on this change.
Change subject: hooks: Add fcoe hook
..
Patch Set 16: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/55029/16/vdsm_hooks/fcoe/Makefile.am
File
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Run unit tests using travis-ci and docker
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54856
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Run unit tests using travis-ci and docker
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Run unit tests using travis-ci and docker
..
tests: Run unit tests using travis-ci and docker
Integrate with travis ci to run unit tests with
Michal Skrivanek has posted comments on this change.
Change subject: migrations: change migration parameters
..
Patch Set 2: Code-Review-1
Didn't we talk about 54?;) it's an increase from 768Mbps to 864Mbps, but that
should
gerrit-hooks has posted comments on this change.
Change subject: tests: Run unit tests using travis-ci and docker
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Run unit tests using travis-ci and docker
..
Patch Set 6: Code-Review-1
what the.. rebase?
/usr/bin/pep8 --exclude="${exclude}" --filename '*.py' . \
gerrit-hooks has posted comments on this change.
Change subject: FakeLVM: support single LV and array in activateLVs
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has uploaded a new change for review.
Change subject: tests: Use VG tags to store fake block domain md
..
tests: Use VG tags to store fake block domain md
Block storage domain metadata can either be stored in VG tags
Adam Litke has uploaded a new change for review.
Change subject: FakeLVM: Add changeVGTags support
..
FakeLVM: Add changeVGTags support
changeVGTags support is needed to properly emulate tag-based block
storage domain metadata.
gerrit-hooks has posted comments on this change.
Change subject: tests: Use VG tags to store fake block domain md
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: FakeLVM: Add changeLVTags
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: FakeLVM: Add changeVGTags support
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Create fake block volume metadata
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has uploaded a new change for review.
Change subject: tests: Create fake block volume metadata
..
tests: Create fake block volume metadata
When creating fake block volumes, create the volume metadata in the fake
Adam Litke has posted comments on this change.
Change subject: lvm: Allow multiple initial tags when creating an LV
..
Patch Set 8: Verified+1
(2 comments)
Created block volumes on storage.
gerrit-hooks has posted comments on this change.
Change subject: lvm: Allow multiple initial tags when creating an LV
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: storage: Move mount module to vdsm storage lib.
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: lvm: Allow multiple initial tags when creating an LV
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Francesco Romani has posted comments on this change.
Change subject: vm: conf: proper locking in status()
..
Patch Set 2:
there is a big evil lurking here: Vm.lastStatus is a property, and its
getter/setter use a lock. There
gerrit-hooks has posted comments on this change.
Change subject: lvm: Allow multiple initial tags when creating an LV
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Francesco Romani has posted comments on this change.
Change subject: caps: disable rng if no packages are reported
..
Patch Set 1: Code-Review-1
I don't _want_ to, but backward compatibility could be a harsh tyrant :)
Will
Dan Kenigsberg has posted comments on this change.
Change subject: storage: Move mount module to vdsm storage lib.
..
Patch Set 10:
please rebase on top of master (or at least https://gerrit.ovirt.org/55423 )
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: hooks:checkips: add checkips hook
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#994170::ERROR, private bug
* Check Public
Dan Kenigsberg has posted comments on this change.
Change subject: caps: disable rng if no packages are reported
..
Patch Set 1: Code-Review-1
do we really want to restore this awkward behaviour? why?
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: Add fcoe hook
..
Patch Set 16: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/55029/16/vdsm_hooks/fcoe/fcoe_before_network_setup.py
File
gerrit-hooks has posted comments on this change.
Change subject: hooks:checkips: add checkips hook
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#994170::ERROR, private bug
* Check Public
Artyom Lukianov has uploaded a new change for review.
Change subject: hooks:checkips: add checkips hook
..
hooks:checkips: add checkips hook
Give possibilty to check connectivity between host and given addresses.
Update network
Francesco Romani has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 18:
(2 comments)
https://gerrit.ovirt.org/#/c/53304/18/lib/vdsm/virt/utils.py
File
Martin Betak has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/53304/18/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Edward Haas has posted comments on this change.
Change subject: tests: Run unit tests using travis-ci and docker
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/54856
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Run unit tests using travis-ci and docker
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: agent: Guest agent reply capability support
..
Patch Set 6: Code-Review-1
(2 comments)
looks ok, -1 only for visibility of the comments.
Martin Betak has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/53304/18/lib/vdsm/virt/utils.py
File
Martin Betak has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/53304/18/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
gerrit-hooks has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Francesco Romani has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 1:
will try to move elsewhere
--
To view, visit https://gerrit.ovirt.org/55647
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Francesco Romani has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/53304/18/lib/vdsm/virt/utils.py
File
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/53304/18/tests/vmUtilsTests.py
File
Francesco Romani has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 19:
added Piotr because of the schema changes
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23: Code-Review-1
(1 comment)
few comments accumulated, I think a resubmit is needed :\
-1 for
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix a bad value in KSM test
..
Patch Set 1: Code-Review+1
looks alright to me. just run the test to verify that it indeed works because
it doesn't run
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Francesco Romani has posted comments on this change.
Change subject: vm: conf: proper locking in migration path
..
Patch Set 2:
jenkins failure seems irrelevant:
00:15:17.641
Dan Kenigsberg has submitted this change and it was merged.
Change subject: caps: drop dead code
..
caps: drop dead code
We don't support RHEL6 anymore, and we depend anyway
on libvirt >= 1.2.1x so we don't need this code
gerrit-hooks has posted comments on this change.
Change subject: caps: drop dead code
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: automation: build and install vdsm only after spec or makefile
change
..
Patch Set 2:
please explain your motivation in the commit message
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: hooks:checkips: add checkips hook
..
Patch Set 14:
* update_tracker: OK
* Set MODIFIED::bug 994170#994170IGNORE, not oVirt classification but
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks:checkips: add checkips hook
..
hooks:checkips: add checkips hook
Give possibilty to check connectivity between host and given addresses.
Update
Dan Kenigsberg has posted comments on this change.
Change subject: hooks:checkips: add checkips hook
..
Patch Set 13: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54102
To unsubscribe, visit
Martin Sivák has uploaded a new change for review.
Change subject: Fix a bad value in KSM test
..
Fix a bad value in KSM test
The merge across nodes allows only 0,1,2,3 values.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: Fix a bad value in KSM test
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: caps: drop dead code
..
Patch Set 1:
works as expected on CentOS 7.x
--
To view, visit https://gerrit.ovirt.org/55683
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: caps: drop dead code
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55683
To unsubscribe, visit https://gerrit.ovirt.org/settings
Francesco Romani has posted comments on this change.
Change subject: vm: conf: proper locking in migration path
..
Patch Set 2: Verified+1
verified doing migrations back and forth using a couple of VMs.
Please note that I
Francesco Romani has uploaded a new change for review.
Change subject: caps: disable rng if no packages are reported
..
caps: disable rng if no packages are reported
Vdsm used to not report rngSource if it could not detect
the
gerrit-hooks has posted comments on this change.
Change subject: caps: disable rng if no packages are reported
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23: -Code-Review
(1 comment)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File
Petr Horáček has posted comments on this change.
Change subject: net: native ovs [7]: configure basic ovs nets and bonds
..
Patch Set 5:
(1 comment)
Tomas Jelinek has posted comments on this change.
Change subject: migrations: change migration parameters
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/55676/1//COMMIT_MSG
Commit Message:
PS1, Line 10:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(2 comments)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Francesco Romani has posted comments on this change.
Change subject: migrations: change migration parameters
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55676
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: migrations: change migration parameters
..
Patch Set 2:
* #1323952::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1323952::OK, public bug
* Check
Edward Haas has posted comments on this change.
Change subject: net: native ovs [7]: configure basic ovs nets and bonds
..
Patch Set 5:
(1 comment)
Francesco Romani has posted comments on this change.
Change subject: agent: Introduction of first_connect event
..
Patch Set 3: Code-Review-1
(1 comment)
question inside, -1 for visibility
Francesco Romani has posted comments on this change.
Change subject: virt: Introduction of the GuestAgentEvents class
..
Patch Set 5: Code-Review-1
(1 comment)
the concept is fine, but this implementation could cause GC
Francesco Romani has posted comments on this change.
Change subject: virt: Pass effective guest agent API version during migration
..
Patch Set 3: Code-Review+1
(1 comment)
partial ACK: looks good, possible simplification
Francesco Romani has posted comments on this change.
Change subject: virt: Add new guest agent API function for lifecycle-events
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51780
To unsubscribe,
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(2 comments)
https://gerrit.ovirt.org/#/c/52799/23/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Francesco Romani has posted comments on this change.
Change subject: migrations: change migration parameters
..
Patch Set 1: Code-Review+1
(3 comments)
besides typos in the commit message, looks good to me, hence partial ACK
gerrit-hooks has posted comments on this change.
Change subject: storage: Move mount module to vdsm storage lib.
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: Fix configfile to use unicode which allows to add toolTests to
python3 check
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN,
Tomas Jelinek has posted comments on this change.
Change subject: migrations: change migration parameters
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55676
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: storage: Move mount module to vdsm storage lib.
..
Patch Set 9:
(6 comments)
https://gerrit.ovirt.org/#/c/55292/9/lib/vdsm/storage/Makefile.am
File
gerrit-hooks has posted comments on this change.
Change subject: automation: build and install vdsm only after spec or makefile
change
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Yaniv Bronhaim has posted comments on this change.
Change subject: storage: Move mount module to vdsm storage lib.
..
Patch Set 9: Code-Review-1
please reply to nir's comments
--
To view, visit https://gerrit.ovirt.org/55292
Dan Kenigsberg has posted comments on this change.
Change subject: vm: serialize destroy() and creation
..
Patch Set 4: -Code-Review
thought about the down side - we cannot abort a VM while it is stuck on
preparePath.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: vm: conf: proper locking in setNumberOfCpus()
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54910
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Vm: conf: proper locking in the creation path
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54909
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: conf: proper locking in onDisconnect()
..
Patch Set 2: Code-Review-1
make sense to me, will move to the end of the series
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: conf: proper locking in onDisconnect()
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/54908/2/vdsm/virt/vm.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: vm: conf: proper locking in onConnect()
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54907
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: conf: proper locking in status()
..
Patch Set 2: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/54906/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Dan Kenigsberg has posted comments on this change.
Change subject: vm: conf: proper locking in migration path
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54905
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: caps: drop dead code
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55683
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: vm: conf: proper locking in migration path
..
Patch Set 2:
* #1318550::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1318550::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: vm: conf: proper locking in onConnect()
..
Patch Set 2:
* #1318550::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1318550::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: vm: conf: proper locking in onDisconnect()
..
Patch Set 2:
* #1318550::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1318550::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: Vm: conf: proper locking in the creation path
..
Patch Set 2:
* #1318550::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1318550::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: vm: conf: proper locking in setNumberOfCpus()
..
Patch Set 2:
* #1318550::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1318550::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: vm: conf: proper locking in status()
..
Patch Set 2:
* #1318550::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1318550::OK, public bug
* Check
Francesco Romani has uploaded a new change for review.
Change subject: caps: drop dead code
..
caps: drop dead code
We don't support RHEL6 anymore, and we depend anyway
on libvirt >= 1.2.1x so we don't need this code anymore.
gerrit-hooks has posted comments on this change.
Change subject: caps: drop dead code
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Dan Kenigsberg has posted comments on this change.
Change subject: vm: serialize destroy() and creation
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55150
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: use proper threading.Event()s
..
Patch Set 7:
* #912390::Update tracker: OK
* Set MODIFIED::bug 912390#912390IGNORE, not all related patches are
1 - 100 of 132 matches
Mail list logo