Change in vdsm[master]: hooks: Add fcoe hook

2016-04-05 Thread edwardh
Edward Haas has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 16: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/55029/16/vdsm_hooks/fcoe/Makefile.am File

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

2016-04-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54856 To unsubscribe, visit

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

2016-04-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Run unit tests using travis-ci and docker .. tests: Run unit tests using travis-ci and docker Integrate with travis ci to run unit tests with

Change in vdsm[master]: migrations: change migration parameters

2016-04-05 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: migrations: change migration parameters .. Patch Set 2: Code-Review-1 Didn't we talk about 54?;) it's an increase from 768Mbps to 864Mbps, but that should

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

2016-04-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 6: Code-Review-1 what the.. rebase? /usr/bin/pep8 --exclude="${exclude}" --filename '*.py' . \

Change in vdsm[master]: FakeLVM: support single LV and array in activateLVs

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: FakeLVM: support single LV and array in activateLVs .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Use VG tags to store fake block domain md

2016-04-05 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: tests: Use VG tags to store fake block domain md .. tests: Use VG tags to store fake block domain md Block storage domain metadata can either be stored in VG tags

Change in vdsm[master]: FakeLVM: Add changeVGTags support

2016-04-05 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: FakeLVM: Add changeVGTags support .. FakeLVM: Add changeVGTags support changeVGTags support is needed to properly emulate tag-based block storage domain metadata.

Change in vdsm[master]: tests: Use VG tags to store fake block domain md

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Use VG tags to store fake block domain md .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: FakeLVM: Add changeLVTags

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: FakeLVM: Add changeLVTags .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: FakeLVM: Add changeVGTags support

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: FakeLVM: Add changeVGTags support .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Create fake block volume metadata

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Create fake block volume metadata .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Create fake block volume metadata

2016-04-05 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: tests: Create fake block volume metadata .. tests: Create fake block volume metadata When creating fake block volumes, create the volume metadata in the fake

Change in vdsm[master]: lvm: Allow multiple initial tags when creating an LV

2016-04-05 Thread alitke
Adam Litke has posted comments on this change. Change subject: lvm: Allow multiple initial tags when creating an LV .. Patch Set 8: Verified+1 (2 comments) Created block volumes on storage.

Change in vdsm[master]: lvm: Allow multiple initial tags when creating an LV

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lvm: Allow multiple initial tags when creating an LV .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: storage: Move mount module to vdsm storage lib.

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Move mount module to vdsm storage lib. .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: lvm: Allow multiple initial tags when creating an LV

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lvm: Allow multiple initial tags when creating an LV .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: vm: conf: proper locking in status()

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: conf: proper locking in status() .. Patch Set 2: there is a big evil lurking here: Vm.lastStatus is a property, and its getter/setter use a lock. There

Change in vdsm[master]: lvm: Allow multiple initial tags when creating an LV

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lvm: Allow multiple initial tags when creating an LV .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: caps: disable rng if no packages are reported

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: caps: disable rng if no packages are reported .. Patch Set 1: Code-Review-1 I don't _want_ to, but backward compatibility could be a harsh tyrant :) Will

Change in vdsm[master]: storage: Move mount module to vdsm storage lib.

2016-04-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: storage: Move mount module to vdsm storage lib. .. Patch Set 10: please rebase on top of master (or at least https://gerrit.ovirt.org/55423 ) -- To view,

Change in vdsm[ovirt-3.6.3]: hooks:checkips: add checkips hook

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks:checkips: add checkips hook .. Patch Set 2: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#994170::ERROR, private bug * Check Public

Change in vdsm[master]: caps: disable rng if no packages are reported

2016-04-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: caps: disable rng if no packages are reported .. Patch Set 1: Code-Review-1 do we really want to restore this awkward behaviour? why? -- To view, visit

Change in vdsm[master]: hooks: Add fcoe hook

2016-04-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 16: Code-Review-1 (4 comments) https://gerrit.ovirt.org/#/c/55029/16/vdsm_hooks/fcoe/fcoe_before_network_setup.py File

Change in vdsm[ovirt-3.6.3]: hooks:checkips: add checkips hook

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks:checkips: add checkips hook .. Patch Set 1: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#994170::ERROR, private bug * Check Public

Change in vdsm[ovirt-3.6.3]: hooks:checkips: add checkips hook

2016-04-05 Thread alukiano
Artyom Lukianov has uploaded a new change for review. Change subject: hooks:checkips: add checkips hook .. hooks:checkips: add checkips hook Give possibilty to check connectivity between host and given addresses. Update network

Change in vdsm[master]: migration: Add DynamicThrottling semaphores

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: Add DynamicThrottling semaphores .. Patch Set 18: (2 comments) https://gerrit.ovirt.org/#/c/53304/18/lib/vdsm/virt/utils.py File

Change in vdsm[master]: migration: Add DynamicThrottling semaphores

2016-04-05 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add DynamicThrottling semaphores .. Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/53304/18/tests/vmUtilsTests.py File tests/vmUtilsTests.py:

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

2016-04-05 Thread edwardh
Edward Haas has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/54856 To unsubscribe, visit

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: agent: Guest agent reply capability support

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: agent: Guest agent reply capability support .. Patch Set 6: Code-Review-1 (2 comments) looks ok, -1 only for visibility of the comments.

Change in vdsm[master]: migration: Add DynamicThrottling semaphores

2016-04-05 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add DynamicThrottling semaphores .. Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/53304/18/lib/vdsm/virt/utils.py File

Change in vdsm[master]: migration: Add DynamicThrottling semaphores

2016-04-05 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add DynamicThrottling semaphores .. Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/53304/18/tests/vmUtilsTests.py File tests/vmUtilsTests.py:

Change in vdsm[master]: migration: Add DynamicThrottling semaphores

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: Add DynamicThrottling semaphores .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: Add retry on full capacity

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: Add retry on full capacity .. Patch Set 25: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: Enable lazy setting of incoming/outgoing limits

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: Enable lazy setting of incoming/outgoing limits .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: virt: utils: add is_kvm helper

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: utils: add is_kvm helper .. Patch Set 1: will try to move elsewhere -- To view, visit https://gerrit.ovirt.org/55647 To unsubscribe, visit

Change in vdsm[master]: migration: Add retry on full capacity

2016-04-05 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: migration: Add retry on full capacity .. Patch Set 23: (1 comment) https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py File vdsm/virt/migration.py:

Change in vdsm[master]: migration: Add DynamicThrottling semaphores

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: Add DynamicThrottling semaphores .. Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/53304/18/lib/vdsm/virt/utils.py File

Change in vdsm[master]: migration: Add retry on full capacity

2016-04-05 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add retry on full capacity .. Patch Set 23: (1 comment) https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py File vdsm/virt/migration.py:

Change in vdsm[master]: migration: Add retry on full capacity

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: Add retry on full capacity .. Patch Set 24: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: Add DynamicThrottling semaphores

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: Add DynamicThrottling semaphores .. Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/53304/18/tests/vmUtilsTests.py File

Change in vdsm[master]: migration: Enable lazy setting of incoming/outgoing limits

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: Enable lazy setting of incoming/outgoing limits .. Patch Set 19: added Piotr because of the schema changes -- To view, visit

Change in vdsm[master]: migration: Add retry on full capacity

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: Add retry on full capacity .. Patch Set 23: Code-Review-1 (1 comment) few comments accumulated, I think a resubmit is needed :\ -1 for

Change in vdsm[master]: Fix a bad value in KSM test

2016-04-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Fix a bad value in KSM test .. Patch Set 1: Code-Review+1 looks alright to me. just run the test to verify that it indeed works because it doesn't run

Change in vdsm[master]: migration: Add retry on full capacity

2016-04-05 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add retry on full capacity .. Patch Set 23: (1 comment) https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py File vdsm/virt/migration.py:

Change in vdsm[master]: vm: conf: proper locking in migration path

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: conf: proper locking in migration path .. Patch Set 2: jenkins failure seems irrelevant: 00:15:17.641

Change in vdsm[master]: caps: drop dead code

2016-04-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: caps: drop dead code .. caps: drop dead code We don't support RHEL6 anymore, and we depend anyway on libvirt >= 1.2.1x so we don't need this code

Change in vdsm[master]: caps: drop dead code

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: caps: drop dead code .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: automation: build and install vdsm only after spec or makefi...

2016-04-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: automation: build and install vdsm only after spec or makefile change .. Patch Set 2: please explain your motivation in the commit message -- To view, visit

Change in vdsm[master]: hooks:checkips: add checkips hook

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks:checkips: add checkips hook .. Patch Set 14: * update_tracker: OK * Set MODIFIED::bug 994170#994170IGNORE, not oVirt classification but -- To

Change in vdsm[master]: hooks:checkips: add checkips hook

2016-04-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks:checkips: add checkips hook .. hooks:checkips: add checkips hook Give possibilty to check connectivity between host and given addresses. Update

Change in vdsm[master]: hooks:checkips: add checkips hook

2016-04-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: hooks:checkips: add checkips hook .. Patch Set 13: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54102 To unsubscribe, visit

Change in vdsm[master]: Fix a bad value in KSM test

2016-04-05 Thread msivak
Martin Sivák has uploaded a new change for review. Change subject: Fix a bad value in KSM test .. Fix a bad value in KSM test The merge across nodes allows only 0,1,2,3 values. Change-Id:

Change in vdsm[master]: Fix a bad value in KSM test

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Fix a bad value in KSM test .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: caps: drop dead code

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: caps: drop dead code .. Patch Set 1: works as expected on CentOS 7.x -- To view, visit https://gerrit.ovirt.org/55683 To unsubscribe, visit

Change in vdsm[master]: caps: drop dead code

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: caps: drop dead code .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/55683 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: vm: conf: proper locking in migration path

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: conf: proper locking in migration path .. Patch Set 2: Verified+1 verified doing migrations back and forth using a couple of VMs. Please note that I

Change in vdsm[master]: caps: disable rng if no packages are reported

2016-04-05 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: caps: disable rng if no packages are reported .. caps: disable rng if no packages are reported Vdsm used to not report rngSource if it could not detect the

Change in vdsm[master]: caps: disable rng if no packages are reported

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: caps: disable rng if no packages are reported .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: Add retry on full capacity

2016-04-05 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: migration: Add retry on full capacity .. Patch Set 23: -Code-Review (1 comment) https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py File

Change in vdsm[master]: net: native ovs [7]: configure basic ovs nets and bonds

2016-04-05 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs [7]: configure basic ovs nets and bonds .. Patch Set 5: (1 comment)

Change in vdsm[master]: migrations: change migration parameters

2016-04-05 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: migrations: change migration parameters .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/55676/1//COMMIT_MSG Commit Message: PS1, Line 10:

Change in vdsm[master]: migration: Add retry on full capacity

2016-04-05 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add retry on full capacity .. Patch Set 23: (2 comments) https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py File vdsm/virt/migration.py:

Change in vdsm[master]: migrations: change migration parameters

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migrations: change migration parameters .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55676 To unsubscribe, visit

Change in vdsm[master]: migrations: change migration parameters

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migrations: change migration parameters .. Patch Set 2: * #1323952::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1323952::OK, public bug * Check

Change in vdsm[master]: net: native ovs [7]: configure basic ovs nets and bonds

2016-04-05 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: native ovs [7]: configure basic ovs nets and bonds .. Patch Set 5: (1 comment)

Change in vdsm[master]: agent: Introduction of first_connect event

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: agent: Introduction of first_connect event .. Patch Set 3: Code-Review-1 (1 comment) question inside, -1 for visibility

Change in vdsm[master]: virt: Introduction of the GuestAgentEvents class

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Introduction of the GuestAgentEvents class .. Patch Set 5: Code-Review-1 (1 comment) the concept is fine, but this implementation could cause GC

Change in vdsm[master]: virt: Pass effective guest agent API version during migration

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Pass effective guest agent API version during migration .. Patch Set 3: Code-Review+1 (1 comment) partial ACK: looks good, possible simplification

Change in vdsm[master]: virt: Add new guest agent API function for lifecycle-events

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Add new guest agent API function for lifecycle-events .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51780 To unsubscribe,

Change in vdsm[master]: migration: Add retry on full capacity

2016-04-05 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add retry on full capacity .. Patch Set 23: (2 comments) https://gerrit.ovirt.org/#/c/52799/23/lib/vdsm/config.py.in File lib/vdsm/config.py.in:

Change in vdsm[master]: migrations: change migration parameters

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migrations: change migration parameters .. Patch Set 1: Code-Review+1 (3 comments) besides typos in the commit message, looks good to me, hence partial ACK

Change in vdsm[master]: storage: Move mount module to vdsm storage lib.

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Move mount module to vdsm storage lib. .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Fix configfile to use unicode which allows to add toolTests ...

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Fix configfile to use unicode which allows to add toolTests to python3 check .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN,

Change in vdsm[master]: migrations: change migration parameters

2016-04-05 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: migrations: change migration parameters .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/55676 To unsubscribe, visit

Change in vdsm[master]: storage: Move mount module to vdsm storage lib.

2016-04-05 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: storage: Move mount module to vdsm storage lib. .. Patch Set 9: (6 comments) https://gerrit.ovirt.org/#/c/55292/9/lib/vdsm/storage/Makefile.am File

Change in vdsm[master]: automation: build and install vdsm only after spec or makefi...

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: automation: build and install vdsm only after spec or makefile change .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug

Change in vdsm[master]: storage: Move mount module to vdsm storage lib.

2016-04-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: storage: Move mount module to vdsm storage lib. .. Patch Set 9: Code-Review-1 please reply to nir's comments -- To view, visit https://gerrit.ovirt.org/55292

Change in vdsm[master]: vm: serialize destroy() and creation

2016-04-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: serialize destroy() and creation .. Patch Set 4: -Code-Review thought about the down side - we cannot abort a VM while it is stuck on preparePath. -- To

Change in vdsm[master]: vm: conf: proper locking in setNumberOfCpus()

2016-04-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: conf: proper locking in setNumberOfCpus() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54910 To unsubscribe, visit

Change in vdsm[master]: Vm: conf: proper locking in the creation path

2016-04-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Vm: conf: proper locking in the creation path .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54909 To unsubscribe, visit

Change in vdsm[master]: vm: conf: proper locking in onDisconnect()

2016-04-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: conf: proper locking in onDisconnect() .. Patch Set 2: Code-Review-1 make sense to me, will move to the end of the series -- To view, visit

Change in vdsm[master]: vm: conf: proper locking in onDisconnect()

2016-04-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: conf: proper locking in onDisconnect() .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/54908/2/vdsm/virt/vm.py File

Change in vdsm[master]: vm: conf: proper locking in onConnect()

2016-04-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: conf: proper locking in onConnect() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54907 To unsubscribe, visit

Change in vdsm[master]: vm: conf: proper locking in status()

2016-04-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: conf: proper locking in status() .. Patch Set 2: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/54906/2/vdsm/virt/vm.py File vdsm/virt/vm.py:

Change in vdsm[master]: vm: conf: proper locking in migration path

2016-04-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: conf: proper locking in migration path .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54905 To unsubscribe, visit

Change in vdsm[master]: caps: drop dead code

2016-04-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: caps: drop dead code .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55683 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: vm: conf: proper locking in migration path

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: conf: proper locking in migration path .. Patch Set 2: * #1318550::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1318550::OK, public bug *

Change in vdsm[master]: vm: conf: proper locking in onConnect()

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: conf: proper locking in onConnect() .. Patch Set 2: * #1318550::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1318550::OK, public bug * Check

Change in vdsm[master]: vm: conf: proper locking in onDisconnect()

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: conf: proper locking in onDisconnect() .. Patch Set 2: * #1318550::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1318550::OK, public bug *

Change in vdsm[master]: Vm: conf: proper locking in the creation path

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Vm: conf: proper locking in the creation path .. Patch Set 2: * #1318550::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1318550::OK, public bug *

Change in vdsm[master]: vm: conf: proper locking in setNumberOfCpus()

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: conf: proper locking in setNumberOfCpus() .. Patch Set 2: * #1318550::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1318550::OK, public bug *

Change in vdsm[master]: vm: conf: proper locking in status()

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: conf: proper locking in status() .. Patch Set 2: * #1318550::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1318550::OK, public bug * Check

Change in vdsm[master]: caps: drop dead code

2016-04-05 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: caps: drop dead code .. caps: drop dead code We don't support RHEL6 anymore, and we depend anyway on libvirt >= 1.2.1x so we don't need this code anymore.

Change in vdsm[master]: caps: drop dead code

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: caps: drop dead code .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: vm: serialize destroy() and creation

2016-04-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: serialize destroy() and creation .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55150 To unsubscribe, visit

Change in vdsm[master]: vm: use proper threading.Event()s

2016-04-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: use proper threading.Event()s .. Patch Set 7: * #912390::Update tracker: OK * Set MODIFIED::bug 912390#912390IGNORE, not all related patches are

  1   2   >