Petr Horáček has posted comments on this change.
Change subject: net: native ovs: introduce constants module
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/56451/7/lib/vdsm/network/ovs/constants.py
File
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: ovs network setup
..
Patch Set 10:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Petr Horáček has posted comments on this change.
Change subject: net: native ovs: introduce constants module
..
Patch Set 7: Code-Review-1
i should add 'ovs' here too
--
To view, visit https://gerrit.ovirt.org/56451
To
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: ovs bonding setup
..
Patch Set 5:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: ovs network setup
..
Patch Set 9:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Petr Horáček has posted comments on this change.
Change subject: net: native ovs: ovs network setup
..
Patch Set 8: -Verified
--
To view, visit https://gerrit.ovirt.org/56353
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: ovs bonding setup
..
Patch Set 4:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Edward Haas has posted comments on this change.
Change subject: net: native ovs: reserve ovsbr0 network name
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/56452/5/tests/network/ovs_test.py
File
Edward Haas has posted comments on this change.
Change subject: net: native ovs: reserve ovsbr0 network name
..
Patch Set 5: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/56452
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net: native ovs: introduce constants module
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/56451/7/lib/vdsm/network/ovs/constants.py
File
Edward Haas has posted comments on this change.
Change subject: net: native ovs: check for bond existence
..
Patch Set 4:
(2 comments)
Just some nits
https://gerrit.ovirt.org/#/c/56461/4//COMMIT_MSG
Commit Message:
PS4,
Edward Haas has posted comments on this change.
Change subject: net: native ovs: check for nic existence
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/56448/6/lib/vdsm/network/ovs/validator.py
File
Edward Haas has posted comments on this change.
Change subject: net: add Transaction() to netconfpersistence
..
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56149
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net: native ovs: check for nic existence
..
Patch Set 6:
(2 comments)
Small nit
https://gerrit.ovirt.org/#/c/56448/6/lib/vdsm/network/ovs/validator.py
File
Nir Soffer has posted comments on this change.
Change subject: Refactor metadata operations
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/52671/6/vdsm/storage/volume.py
File vdsm/storage/volume.py:
Line 223:
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: Add from_lines factory method
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52672
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Refactor metadata operations
..
Patch Set 6: Code-Review+1
Waiting for another review.
--
To view, visit https://gerrit.ovirt.org/52671
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: ovs bonding setup
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Edward Haas has posted comments on this change.
Change subject: net: native ovs: ovsnettestlib.py
..
Patch Set 9: Code-Review-1
(2 comments)
Some nits
https://gerrit.ovirt.org/#/c/56391/8/tests/network/ovs_driver_test.py
Petr Horáček has posted comments on this change.
Change subject: net: native ovs: ovs network setup
..
Patch Set 8: Verified+1
Passed ovs_test.py and manual setupNetworks API testing.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: reserve ovsbr0 network name
..
Patch Set 5:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: introduce constants module
..
Patch Set 7:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: check for nic existence
..
Patch Set 6:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: check for bond existence
..
Patch Set 4:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: ovs network setup
..
Patch Set 8:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: ovsnettestlib.py
..
Patch Set 9:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Add from_lines factory method
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: Refactor metadata operations
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
gerrit-hooks has posted comments on this change.
Change subject: storage: Filter incomplete volumes from volume queries
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: rwlock: Replace misc.RWLock
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vm: Add error logging in diskReplicateFinish
..
Patch Set 3:
* #1325791::Update tracker: OK
* Set MODIFIED::bug 1325791#1325791FAILED, illegal change
Nir Soffer has posted comments on this change.
Change subject: vm: Add error logging in diskReplicateFinish
..
Patch Set 2:
The original problem cannot be reproduced with engine 3.6.4. I verified the
logs by faking various
Nir Soffer has submitted this change and it was merged.
Change subject: vm: Add error logging in diskReplicateFinish
..
vm: Add error logging in diskReplicateFinish
On failures of diskReplicateFinish we had mostly no logs,
Nir Soffer has posted comments on this change.
Change subject: vm: Add error logging in diskReplicateFinish
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/55939
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: drop unused blkid external binary
..
Patch Set 1: Code-Review+1
:. missed that
--
To view, visit https://gerrit.ovirt.org/56478
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: v2v: add support for importing kvm based vms from libvirt
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56459/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Nir Soffer has posted comments on this change.
Change subject: kvm@ovirt: tool for streaming images from libvirt
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55797/2/helpers/kvm2ovirt
File helpers/kvm2ovirt:
Line
Nir Soffer has posted comments on this change.
Change subject: v2v: add support for importing kvm based vms from libvirt
..
Patch Set 1: Code-Review+1
(3 comments)
Nice, needs some minor fixes.
Nir Soffer has posted comments on this change.
Change subject: build: Remove pep8 and pyflakes requirement
..
Patch Set 3: -Continuous-Integration
--
To view, visit https://gerrit.ovirt.org/56152
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: Add from_lines factory method
..
Patch Set 5: Code-Review+2
Looks good, waiting for previous patch.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: Refactor metadata operations
..
Patch Set 5: Code-Review-1
Please check all comments
--
To view, visit https://gerrit.ovirt.org/52671
To unsubscribe, visit
Dan Kenigsberg has uploaded a new change for review.
Change subject: drop unused blkid external binary
..
drop unused blkid external binary
commit ac0efac98 should have removed these definitions.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: drop unused blkid external binary
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: storage: Filter incomplete volumes from volume queries
..
Patch Set 6:
Adam, can you verify?
--
To view, visit https://gerrit.ovirt.org/56086
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: tests: Add test_missing_tags for block storage
..
Patch Set 5: Verified+1
Tests pass, so this is verified.
--
To view, visit https://gerrit.ovirt.org/56171
To
gerrit-hooks has posted comments on this change.
Change subject: tests: Add test_missing_tags for block storage
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Add test_missing_tags for block storage
..
tests: Add test_missing_tags for block storage
Add a simple test that verifies that volumes with missing
Nir Soffer has posted comments on this change.
Change subject: build: Remove pep8 and pyflakes requirement
..
Patch Set 3: Continuous-Integration+1
CI succeeded, but for some reason did not update gerrit yet.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: automation: Run make check over el7 in automation CI
..
Patch Set 6: Code-Review+1
Waiting from Piotr/Dan ack.
--
To view, visit https://gerrit.ovirt.org/56122
Yaniv Bronhaim has posted comments on this change.
Change subject: automation: Run make check over el7 in automation CI
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/56122
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Remove pep8 and pyflakes requirement
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/56152
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: automation: Run make check over el7 in automation CI
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: build: Remove pep8 and pyflakes requirement
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: Removing generationID from clientIF
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Removing generationID from clientIF
..
Removing generationID from clientIF
Seems like this verb is not in use for a long time. Originally it was
added to
gerrit-hooks has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: HACK: virt: override vm type from custom property
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hook: add imagerepo feed containers
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: containers: always add emulator to XML
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has uploaded a new change for review.
Change subject: cmdutils: enhance systemd_run
..
cmdutils: enhance systemd_run
Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a
TODO: explain
Signed-off-by: Francesco
gerrit-hooks has posted comments on this change.
Change subject: WIP: vm: skip domDependentInit for containers
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: containers: optional container support
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: tests: Add test_missing_tags for block storage
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56171
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Refactor metadata operations
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/52671/4/tests/storage_volume_metadata_test.py
File
gerrit-hooks has posted comments on this change.
Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
gerrit-hooks has posted comments on this change.
Change subject: tests: Add test_missing_tags for block storage
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: Refactor metadata operations
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Filter incomplete volumes from volume queries
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Adam Litke has posted comments on this change.
Change subject: VolumeMetadata: Add from_lines factory method
..
Patch Set 4:
(12 comments)
https://gerrit.ovirt.org/#/c/52672/3//COMMIT_MSG
Commit Message:
Line 8:
Line 9: Add
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Add from_lines factory method
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Petr Horáček has abandoned this change.
Change subject: net: native ovs [7]: configure basic ovs nets and bonds
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/55307
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [7]: configure basic ovs nets and bonds
..
Patch Set 6:
* #1195208::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/55307
To
Milan Zamazal has posted comments on this change.
Change subject: vm: rename event for clarity
..
Patch Set 1: Code-Review+1
Good idea.
--
To view, visit https://gerrit.ovirt.org/56466
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: FakeLVM: Always create lv file
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: tests: FakeLVM: Always create lv file
..
tests: FakeLVM: Always create lv file
When creating Fake LVs always create a regular file at lvm.lvPath(...)
of
Nir Soffer has posted comments on this change.
Change subject: kvm@ovirt: tool for streaming images from libvirt
..
Patch Set 2:
(5 comments)
https://gerrit.ovirt.org/#/c/55797/2/helpers/kvm2ovirt
File helpers/kvm2ovirt:
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: ovsnettestlib.py
..
Patch Set 8:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Petr Horáček has posted comments on this change.
Change subject: net: native ovs: ovsnettestlib.py
..
Patch Set 8: Verified+1
Passed ovs_driver_test.py
--
To view, visit https://gerrit.ovirt.org/56391
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: net: native ovs: ovs network setup
..
Patch Set 7:
this should be rebased on top of consts patch
--
To view, visit https://gerrit.ovirt.org/56353
To
gerrit-hooks has posted comments on this change.
Change subject: net: add Transaction() to netconfpersistence
..
Patch Set 15:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: ovs network setup
..
Patch Set 7:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Petr Horáček has posted comments on this change.
Change subject: net: native ovs: ovs network setup
..
Patch Set 6: Verified+1
Passed ovs_test.py and manual setupNetworks API testing.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: ovs network setup
..
Patch Set 6:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: vm: handle destroy request while starting up
..
Patch Set 5:
Piotr, good points, but turns out that I was heading in the wrong direction, so
I stripped away
Nir Soffer has posted comments on this change.
Change subject: storage: fix spec normalization when mounting
..
Patch Set 9:
(7 comments)
https://gerrit.ovirt.org/#/c/55182/9/lib/vdsm/storage/fileUtils.py
File
Petr Horáček has posted comments on this change.
Change subject: net: native ovs: ovsnettestlib.py
..
Patch Set 7: Verified+1
Passed ovs_driver_test.py
--
To view, visit https://gerrit.ovirt.org/56391
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: rename event for clarity
..
Patch Set 1: Verified+1
trivial rename-only patch, verified using tests.
--
To view, visit https://gerrit.ovirt.org/56466
gerrit-hooks has posted comments on this change.
Change subject: vm: serialize destroy() and creation
..
Patch Set 4:
* #912390::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/55150
To unsubscribe, visit
Francesco Romani has abandoned this change.
Change subject: vm: serialize destroy() and creation
..
Abandoned
wrong approach
--
To view, visit https://gerrit.ovirt.org/55150
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: rename event for clarity
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vm: handle destroy request while starting up
..
Patch Set 5:
* #912390::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#912390::OK, public bug
*
Francesco Romani has uploaded a new change for review.
Change subject: vm: rename event for clarity
..
vm: rename event for clarity
Vm._destroyed actually means that Vdsm received a request
to destroy a Vm which is not yet
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: ovsnettestlib.py
..
Patch Set 7:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: storage: fix spec normalization when mounting
..
Patch Set 9:
(3 comments)
Please fix getStorageDomainsList - missing spec normalization before
transforming
Adam Litke has posted comments on this change.
Change subject: Refactor metadata operations
..
Patch Set 4:
(5 comments)
https://gerrit.ovirt.org/#/c/52671/4/tests/storage_volume_metadata_test.py
File
1 - 100 of 186 matches
Mail list logo