Change in vdsm[master]: net: native ovs: introduce constants module

2016-04-21 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/56451/7/lib/vdsm/network/ovs/constants.py File

Change in vdsm[master]: net: native ovs: ovs network setup

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs network setup .. Patch Set 10: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: introduce constants module

2016-04-21 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 7: Code-Review-1 i should add 'ovs' here too -- To view, visit https://gerrit.ovirt.org/56451 To

Change in vdsm[master]: net: native ovs: ovs bonding setup

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs bonding setup .. Patch Set 5: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: ovs network setup

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs network setup .. Patch Set 9: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: ovs network setup

2016-04-21 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: ovs network setup .. Patch Set 8: -Verified -- To view, visit https://gerrit.ovirt.org/56353 To unsubscribe, visit

Change in vdsm[master]: net: native ovs: ovs bonding setup

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs bonding setup .. Patch Set 4: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

2016-04-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/56452/5/tests/network/ovs_test.py File

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

2016-04-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 5: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/56452 To unsubscribe, visit

Change in vdsm[master]: net: native ovs: introduce constants module

2016-04-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/56451/7/lib/vdsm/network/ovs/constants.py File

Change in vdsm[master]: net: native ovs: check for bond existence

2016-04-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 4: (2 comments) Just some nits https://gerrit.ovirt.org/#/c/56461/4//COMMIT_MSG Commit Message: PS4,

Change in vdsm[master]: net: native ovs: check for nic existence

2016-04-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/56448/6/lib/vdsm/network/ovs/validator.py File

Change in vdsm[master]: net: add Transaction() to netconfpersistence

2016-04-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: add Transaction() to netconfpersistence .. Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56149 To unsubscribe, visit

Change in vdsm[master]: net: native ovs: check for nic existence

2016-04-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 6: (2 comments) Small nit https://gerrit.ovirt.org/#/c/56448/6/lib/vdsm/network/ovs/validator.py File

Change in vdsm[master]: Refactor metadata operations

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Refactor metadata operations .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/52671/6/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 223:

Change in vdsm[master]: VolumeMetadata: Add from_lines factory method

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Add from_lines factory method .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/52672 To unsubscribe, visit

Change in vdsm[master]: Refactor metadata operations

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Refactor metadata operations .. Patch Set 6: Code-Review+1 Waiting for another review. -- To view, visit https://gerrit.ovirt.org/52671 To unsubscribe, visit

Change in vdsm[master]: net: native ovs: ovs bonding setup

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs bonding setup .. Patch Set 3: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

2016-04-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 9: Code-Review-1 (2 comments) Some nits https://gerrit.ovirt.org/#/c/56391/8/tests/network/ovs_driver_test.py

Change in vdsm[master]: net: native ovs: ovs network setup

2016-04-21 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: ovs network setup .. Patch Set 8: Verified+1 Passed ovs_test.py and manual setupNetworks API testing. -- To view, visit

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 5: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: native ovs: introduce constants module

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 7: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: native ovs: check for nic existence

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 6: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: check for bond existence

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 4: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: ovs network setup

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs network setup .. Patch Set 8: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 9: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: VolumeMetadata: Add from_lines factory method

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Add from_lines factory method .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Refactor metadata operations

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Refactor metadata operations .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: storage: Filter incomplete volumes from volume queries

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Filter incomplete volumes from volume queries .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: rwlock: Replace misc.RWLock

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: rwlock: Replace misc.RWLock .. Patch Set 25: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vm: Add error logging in diskReplicateFinish

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: Add error logging in diskReplicateFinish .. Patch Set 3: * #1325791::Update tracker: OK * Set MODIFIED::bug 1325791#1325791FAILED, illegal change

Change in vdsm[master]: vm: Add error logging in diskReplicateFinish

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Add error logging in diskReplicateFinish .. Patch Set 2: The original problem cannot be reproduced with engine 3.6.4. I verified the logs by faking various

Change in vdsm[master]: vm: Add error logging in diskReplicateFinish

2016-04-21 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: vm: Add error logging in diskReplicateFinish .. vm: Add error logging in diskReplicateFinish On failures of diskReplicateFinish we had mostly no logs,

Change in vdsm[master]: vm: Add error logging in diskReplicateFinish

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Add error logging in diskReplicateFinish .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/55939 To unsubscribe, visit

Change in vdsm[master]: drop unused blkid external binary

2016-04-21 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: drop unused blkid external binary .. Patch Set 1: Code-Review+1 :. missed that -- To view, visit https://gerrit.ovirt.org/56478 To unsubscribe, visit

Change in vdsm[master]: v2v: add support for importing kvm based vms from libvirt

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: add support for importing kvm based vms from libvirt .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56459/1/lib/vdsm/v2v.py File lib/vdsm/v2v.py:

Change in vdsm[master]: kvm@ovirt: tool for streaming images from libvirt

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: kvm@ovirt: tool for streaming images from libvirt .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/55797/2/helpers/kvm2ovirt File helpers/kvm2ovirt: Line

Change in vdsm[master]: v2v: add support for importing kvm based vms from libvirt

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: add support for importing kvm based vms from libvirt .. Patch Set 1: Code-Review+1 (3 comments) Nice, needs some minor fixes.

Change in vdsm[master]: build: Remove pep8 and pyflakes requirement

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: build: Remove pep8 and pyflakes requirement .. Patch Set 3: -Continuous-Integration -- To view, visit https://gerrit.ovirt.org/56152 To unsubscribe, visit

Change in vdsm[master]: VolumeMetadata: Add from_lines factory method

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Add from_lines factory method .. Patch Set 5: Code-Review+2 Looks good, waiting for previous patch. -- To view, visit

Change in vdsm[master]: Refactor metadata operations

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Refactor metadata operations .. Patch Set 5: Code-Review-1 Please check all comments -- To view, visit https://gerrit.ovirt.org/52671 To unsubscribe, visit

Change in vdsm[master]: drop unused blkid external binary

2016-04-21 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: drop unused blkid external binary .. drop unused blkid external binary commit ac0efac98 should have removed these definitions. Change-Id:

Change in vdsm[master]: drop unused blkid external binary

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: drop unused blkid external binary .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: storage: Filter incomplete volumes from volume queries

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Filter incomplete volumes from volume queries .. Patch Set 6: Adam, can you verify? -- To view, visit https://gerrit.ovirt.org/56086 To unsubscribe,

Change in vdsm[master]: tests: Add test_missing_tags for block storage

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add test_missing_tags for block storage .. Patch Set 5: Verified+1 Tests pass, so this is verified. -- To view, visit https://gerrit.ovirt.org/56171 To

Change in vdsm[master]: tests: Add test_missing_tags for block storage

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add test_missing_tags for block storage .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: tests: Add test_missing_tags for block storage

2016-04-21 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: tests: Add test_missing_tags for block storage .. tests: Add test_missing_tags for block storage Add a simple test that verifies that volumes with missing

Change in vdsm[master]: build: Remove pep8 and pyflakes requirement

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: build: Remove pep8 and pyflakes requirement .. Patch Set 3: Continuous-Integration+1 CI succeeded, but for some reason did not update gerrit yet. -- To view,

Change in vdsm[master]: automation: Run make check over el7 in automation CI

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: automation: Run make check over el7 in automation CI .. Patch Set 6: Code-Review+1 Waiting from Piotr/Dan ack. -- To view, visit https://gerrit.ovirt.org/56122

Change in vdsm[master]: automation: Run make check over el7 in automation CI

2016-04-21 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: automation: Run make check over el7 in automation CI .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/56122 To unsubscribe, visit

Change in vdsm[master]: build: Remove pep8 and pyflakes requirement

2016-04-21 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: build: Remove pep8 and pyflakes requirement .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/56152 To unsubscribe, visit

Change in vdsm[master]: automation: Run make check over el7 in automation CI

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: automation: Run make check over el7 in automation CI .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: build: Remove pep8 and pyflakes requirement

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: build: Remove pep8 and pyflakes requirement .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: Removing generationID from clientIF

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Removing generationID from clientIF .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: Removing generationID from clientIF

2016-04-21 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: Removing generationID from clientIF .. Removing generationID from clientIF Seems like this verb is not in use for a long time. Originally it was added to

Change in vdsm[master]: cmdutils: enhance systemd_run

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: cmdutils: enhance systemd_run .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: HACK: virt: override vm type from custom property

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: HACK: virt: override vm type from custom property .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: hook: add imagerepo feed containers

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hook: add imagerepo feed containers .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: virt: utils: add is_kvm helper

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: utils: add is_kvm helper .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: containers: always add emulator to XML

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: containers: always add emulator to XML .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: cmdutils: enhance systemd_run

2016-04-21 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: cmdutils: enhance systemd_run .. cmdutils: enhance systemd_run Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a TODO: explain Signed-off-by: Francesco

Change in vdsm[master]: WIP: vm: skip domDependentInit for containers

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: WIP: vm: skip domDependentInit for containers .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: containers: optional container support

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: containers: optional container support .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: network: supervdsm: configure container networks

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: network: supervdsm: configure container networks .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Add test_missing_tags for block storage

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add test_missing_tags for block storage .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56171 To unsubscribe, visit

Change in vdsm[master]: Refactor metadata operations

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Refactor metadata operations .. Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/52671/4/tests/storage_volume_metadata_test.py File

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: tests: Add test_missing_tags for block storage

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add test_missing_tags for block storage .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Refactor metadata operations

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Refactor metadata operations .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: storage: Filter incomplete volumes from volume queries

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Filter incomplete volumes from volume queries .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: VolumeMetadata: Add from_lines factory method

2016-04-21 Thread alitke
Adam Litke has posted comments on this change. Change subject: VolumeMetadata: Add from_lines factory method .. Patch Set 4: (12 comments) https://gerrit.ovirt.org/#/c/52672/3//COMMIT_MSG Commit Message: Line 8: Line 9: Add

Change in vdsm[master]: VolumeMetadata: Add from_lines factory method

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Add from_lines factory method .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: native ovs [7]: configure basic ovs nets and bonds

2016-04-21 Thread phoracek
Petr Horáček has abandoned this change. Change subject: net: native ovs [7]: configure basic ovs nets and bonds .. Abandoned -- To view, visit https://gerrit.ovirt.org/55307 To unsubscribe, visit

Change in vdsm[master]: net: native ovs [7]: configure basic ovs nets and bonds

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs [7]: configure basic ovs nets and bonds .. Patch Set 6: * #1195208::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/55307 To

Change in vdsm[master]: vm: rename event for clarity

2016-04-21 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: rename event for clarity .. Patch Set 1: Code-Review+1 Good idea. -- To view, visit https://gerrit.ovirt.org/56466 To unsubscribe, visit

Change in vdsm[master]: tests: FakeLVM: Always create lv file

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: FakeLVM: Always create lv file .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: tests: FakeLVM: Always create lv file

2016-04-21 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: tests: FakeLVM: Always create lv file .. tests: FakeLVM: Always create lv file When creating Fake LVs always create a regular file at lvm.lvPath(...) of

Change in vdsm[master]: kvm@ovirt: tool for streaming images from libvirt

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: kvm@ovirt: tool for streaming images from libvirt .. Patch Set 2: (5 comments) https://gerrit.ovirt.org/#/c/55797/2/helpers/kvm2ovirt File helpers/kvm2ovirt:

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 8: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

2016-04-21 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 8: Verified+1 Passed ovs_driver_test.py -- To view, visit https://gerrit.ovirt.org/56391 To unsubscribe, visit

Change in vdsm[master]: net: native ovs: ovs network setup

2016-04-21 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: ovs network setup .. Patch Set 7: this should be rebased on top of consts patch -- To view, visit https://gerrit.ovirt.org/56353 To

Change in vdsm[master]: net: add Transaction() to netconfpersistence

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: add Transaction() to netconfpersistence .. Patch Set 15: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: native ovs: ovs network setup

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs network setup .. Patch Set 7: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: ovs network setup

2016-04-21 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: ovs network setup .. Patch Set 6: Verified+1 Passed ovs_test.py and manual setupNetworks API testing. -- To view, visit

Change in vdsm[master]: net: native ovs: ovs network setup

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs network setup .. Patch Set 6: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: vm: handle destroy request while starting up

2016-04-21 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: handle destroy request while starting up .. Patch Set 5: Piotr, good points, but turns out that I was heading in the wrong direction, so I stripped away

Change in vdsm[master]: storage: fix spec normalization when mounting

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: fix spec normalization when mounting .. Patch Set 9: (7 comments) https://gerrit.ovirt.org/#/c/55182/9/lib/vdsm/storage/fileUtils.py File

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

2016-04-21 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 7: Verified+1 Passed ovs_driver_test.py -- To view, visit https://gerrit.ovirt.org/56391 To unsubscribe, visit

Change in vdsm[master]: vm: rename event for clarity

2016-04-21 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: rename event for clarity .. Patch Set 1: Verified+1 trivial rename-only patch, verified using tests. -- To view, visit https://gerrit.ovirt.org/56466

Change in vdsm[master]: vm: serialize destroy() and creation

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: serialize destroy() and creation .. Patch Set 4: * #912390::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/55150 To unsubscribe, visit

Change in vdsm[master]: vm: serialize destroy() and creation

2016-04-21 Thread fromani
Francesco Romani has abandoned this change. Change subject: vm: serialize destroy() and creation .. Abandoned wrong approach -- To view, visit https://gerrit.ovirt.org/55150 To unsubscribe, visit

Change in vdsm[master]: vm: rename event for clarity

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: rename event for clarity .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vm: handle destroy request while starting up

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: handle destroy request while starting up .. Patch Set 5: * #912390::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#912390::OK, public bug *

Change in vdsm[master]: vm: rename event for clarity

2016-04-21 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vm: rename event for clarity .. vm: rename event for clarity Vm._destroyed actually means that Vdsm received a request to destroy a Vm which is not yet

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

2016-04-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 7: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: storage: fix spec normalization when mounting

2016-04-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: fix spec normalization when mounting .. Patch Set 9: (3 comments) Please fix getStorageDomainsList - missing spec normalization before transforming

Change in vdsm[master]: Refactor metadata operations

2016-04-21 Thread alitke
Adam Litke has posted comments on this change. Change subject: Refactor metadata operations .. Patch Set 4: (5 comments) https://gerrit.ovirt.org/#/c/52671/4/tests/storage_volume_metadata_test.py File

  1   2   >