Nir Soffer has posted comments on this change.
Change subject: hsm: Use manifest in verify_untrusted_volume
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60059
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: automation: Increase timeout for make check
..
Patch Set 1: Verified+1
Tested with next patch and locally.
--
To view, visit https://gerrit.ovirt.org/60051
To
Adam Litke has uploaded a new change for review.
Change subject: hsm: Use manifest in verify_untrusted_volume
..
hsm: Use manifest in verify_untrusted_volume
New users of storage objects should generally use the new *Manifest
Adam Litke has uploaded a new change for review.
Change subject: tests: Add tests for verify_untrusted_volume
..
tests: Add tests for verify_untrusted_volume
Add some tests to check that verify_untrusted_volume works as
Edward Haas has posted comments on this change.
Change subject: test: Introduce mock module for testing
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/59797
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: migration: fix typo
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60037
To unsubscribe, visit https://gerrit.ovirt.org/settings
Edward Haas has posted comments on this change.
Change subject: ovs: flush IP config from attached ifaces
..
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/59958/4/lib/vdsm/network/netswitch.py
File
Adam Litke has posted comments on this change.
Change subject: automation: Increase timeout for make check
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60051
To unsubscribe, visit
Simone Tiraboschi has uploaded a new change for review.
Change subject: jsonrpcvdscli: add additional verbs
..
jsonrpcvdscli: add additional verbs
Add additional verbs required by the hosted-engine upgrade flow.
Change-Id:
Nir Soffer has uploaded a new change for review.
Change subject: automation: Increase timeout for make check
..
automation: Increase timeout for make check
CI slaves are sometimes very slow. Increase the timeout to 600 seconds
Francesco Romani has submitted this change and it was merged.
Change subject: logging: Introduce throttledlog
..
logging: Introduce throttledlog
In some situations, we want to log interesting information. A natural
place to
Francesco Romani has submitted this change and it was merged.
Change subject: rpc: Use Suppressed class instead of logging workarounds
..
rpc: Use Suppressed class instead of logging workarounds
We have got logging workarounds
Francesco Romani has posted comments on this change.
Change subject: migration: fix typo
..
Patch Set 2: Verified+1
verified migrating a VM with the patch mentioned in the previous comment,
forcing (bogus) detection of
Francesco Romani has posted comments on this change.
Change subject: migration: fix typo
..
Patch Set 2:
exercised the fix with this patch:
--- /home/fromani/migration.py 2016-06-30 18:57:09.926887247 +0200
+++
Nir Soffer has submitted this change and it was merged.
Change subject: vm: Refine needsDriveMonitoring docstring
..
vm: Refine needsDriveMonitoring docstring
Change-Id: I84f3500f16caff2a71e8772179a0f30249747729
Signed-off-by:
Francesco Romani has submitted this change and it was merged.
Change subject: rpc: Log calls of API methods with possibly large results
..
rpc: Log calls of API methods with possibly large results
We can prevent some API
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: openstack hook should wait a while for nic activation
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60035
To unsubscribe,
Petr Horáček has posted comments on this change.
Change subject: ovs: flush IP config from attached ifaces
..
Patch Set 5:
(3 comments)
https://gerrit.ovirt.org/#/c/59958/4/lib/vdsm/network/netswitch.py
File
Francesco Romani has submitted this change and it was merged.
Change subject: rpc: Lower logging priority just for getAllVmStats
..
rpc: Lower logging priority just for getAllVmStats
Currently, we effectively disable logging
Milan Zamazal has posted comments on this change.
Change subject: migration: fix typo
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60037/1/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 610:
Milan Zamazal has posted comments on this change.
Change subject: migration: fix typo
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/60037
To unsubscribe, visit https://gerrit.ovirt.org/settings
Francesco Romani has posted comments on this change.
Change subject: migration: downtime: add tunable for back compat
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/59467/13/vdsm/virt/migration.py
File
Milan Zamazal has posted comments on this change.
Change subject: migration: fix typo
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60037
To unsubscribe, visit https://gerrit.ovirt.org/settings
Francesco Romani has uploaded a new change for review.
Change subject: migration: fix typo
..
migration: fix typo
This typo sneaked in during the review of commit 1e7d561
Change-Id: I421a7ba0d0ffedc2a90a79aab37712fabbddebca
Marcin Mirecki has posted comments on this change.
Change subject: hooks: openstack hook should wait a while for nic activation
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60035
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: migration: downtime: add tunable for back compat
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/59467/13/vdsm/virt/migration.py
File
Francesco Romani has posted comments on this change.
Change subject: hooks: openstack hook should wait a while for nic activation
..
Patch Set 1: Code-Review+1
seems ok, deeper review later.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vdscli: Replace the default '::' host with hostname
..
Patch Set 1:
true test failure
FAIL: testNoArguments (vdsClientTests.CannonizeHostPortTest)
Hello Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60035
to review the following change.
Change subject: hooks: openstack hook should wait a while for nic activation
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ovs: rollback transaction
..
ovs: rollback transaction
Use netconfpersistence.Transaction() to trigger rollback after failed
OVS network setup.
Dan Kenigsberg has posted comments on this change.
Change subject: ovs: rollback transaction
..
Patch Set 10: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/59904
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net ifcfg: fix bond rollback
..
net ifcfg: fix bond rollback
When setupNetworks(NET, BOND) fails on NET configuration, BOND ifcfg
file is removed, but
Dan Kenigsberg has posted comments on this change.
Change subject: net ifcfg: fix bond rollback
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59940
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Print backtrace and terminate stuck tests
..
tests: Print backtrace and terminate stuck tests
If the test runner does not complete after a
Edward Haas has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49173
To unsubscribe, visit
Nir Soffer has submitted this change and it was merged.
Change subject: qemuimg: Report qcow2 compat version
..
qemuimg: Report qcow2 compat version
The verification code for image upload wants to validate that a volume's
Milan Zamazal has posted comments on this change.
Change subject: API: doc: reformat docstring for consistency
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59875
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 9: Code-Review+1
I love this patch
--
To view, visit https://gerrit.ovirt.org/49173
To
Francesco Romani has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 9:
let's check what happens if one uses:
vdsClient -s 0 create /dev/null
Milan Zamazal has posted comments on this change.
Change subject: API: allow setLogLevel to tune a specific logger
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59874
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: net ifcfg: fix bond rollback
..
Patch Set 2:
It's tested in the following patch, together with ovs switch.
--
To view, visit https://gerrit.ovirt.org/59940
To
Dan Kenigsberg has posted comments on this change.
Change subject: tests: add mocking in deviceTests
..
Patch Set 2: Code-Review+2
raising scores
--
To view, visit https://gerrit.ovirt.org/59876
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: add mocking in deviceTests
..
tests: add mocking in deviceTests
add mocking to make sure not to query libvirt in this flow.
We don't actually
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 3:
Main changes:
* storing logs in /var/log/vdsm/import instead of /var/run/vdsm/v2v because
/var/run is
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Add info about the number of run tasks in executor workers
..
virt: Add info about the number of run tasks in executor workers
Change-Id:
Martin Polednik has posted comments on this change.
Change subject: API: logging: move setLogLevel code into logUtils
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59872
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpc: expose Volume.setDescription as setVolumeDescription
..
jsonrpc: expose Volume.setDescription as setVolumeDescription
Change-Id:
Milan Zamazal has abandoned this change.
Change subject: rpc: Log calls of API methods with possibly large results
..
Abandoned
Unmerged part of an aborted backport series, replaced with another series.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: API: streamline and make setLogLevel correct
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59873
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: API: logging: move setLogLevel code into logUtils
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59872
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: API: doc: reformat docstring for consistency
..
Patch Set 2: Verified+1
docstring-only change, 'make check' pass.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: API: allow setLogLevel to tune a specific logger
..
Patch Set 2: Verified+1
verified together: 59872 59873 59874 59875
tried changing logger levels (virt,
Francesco Romani has posted comments on this change.
Change subject: API: streamline and make setLogLevel correct
..
Patch Set 2: Verified+1
verified together: 59872 59873 59874 59875
tried changing logger levels (virt,
Francesco Romani has posted comments on this change.
Change subject: API: logging: move setLogLevel code into logUtils
..
Patch Set 2: Verified+1
verified together: 59872 59873 59874 59875
tried changing logger levels (virt,
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log also error codes of RPC calls
..
Patch Set 4: Verified+1
Verified that the error codes are logged as expected.
--
To view, visit
Edward Haas has posted comments on this change.
Change subject: ovs: flush IP config from attached ifaces
..
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/59958/4/lib/vdsm/network/netswitch.py
File
Nir Soffer has posted comments on this change.
Change subject: yml: return type fixes for Host.hostdevListByCaps
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59703/1/tests/vdsmapi_test.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.spmStart
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59704/1/tests/vdsmapi_test.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.hostdevListByCaps
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59703/1/tests/vdsmapi_test.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.connect
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59702/1/tests/vdsmapi_test.py
File
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Introduce supports_compat helper
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/59410/7/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 48:
Francesco Romani has posted comments on this change.
Change subject: rpc: Use Suppressed class instead of logging workarounds
..
Patch Set 3:
a previous revierer gave his +2 without much care, it seems :)
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: rpc: Use Suppressed class instead of logging workarounds
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59994
To unsubscribe,
Nir Soffer has submitted this change and it was merged.
Change subject: qemuimg: Use --output json for 'check' and 'info'
..
qemuimg: Use --output json for 'check' and 'info'
We now depend on qemu-2.3.0 or later which can
Nir Soffer has submitted this change and it was merged.
Change subject: tests: storage and gluster exception tests pass py3
..
tests: storage and gluster exception tests pass py3
changed types.TypeType (which is deprecated in
Nir Soffer has submitted this change and it was merged.
Change subject: tests: converted main.py to a test module
..
tests: converted main.py to a test module
main.py is now a test module and has been splitted to
a new test
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Print backtrace and terminate stuck tests
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/58212
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add slow tests for testing new tracebacks
..
Patch Set 4: Verified-1
This *should* fail if the previous patch is correct.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Print backtrace and terminate stuck tests
..
Patch Set 8: Verified+1
Tested that the watcher process is terminated by the shell (I think it get
SIGHUP when
Nir Soffer has posted comments on this change.
Change subject: tests: Print backtrace and terminate stuck tests
..
Patch Set 8:
Tested locally with next patch:
TIMEOUT=10 ./run_tests_local.sh testlibTests.py
We get a
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log RPC call summary on info level
..
Patch Set 4: Verified+1
Verified that RPC calls are logged as expected.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 4: Verified+1
Verified that expected getAllVmStats info is logged at expected interval.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.connectStorageServer
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/59701/1/lib/api/vdsm-api.yml
File
Edward Haas has uploaded a new change for review.
Change subject: vdscli: Replace the default '::' host with hostname
..
vdscli: Replace the default '::' host with hostname
vdscli may fail to connect to the VDSM server when
Milan Zamazal has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/57754/16/tests/executorTests.py
File
Milan Zamazal has posted comments on this change.
Change subject: logging: Introduce throttledlog
..
Patch Set 3: Verified+1
Verified by running tests.
--
To view, visit https://gerrit.ovirt.org/59995
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: rpc: Use Suppressed class instead of logging workarounds
..
Patch Set 3: Verified+1
Verified that (suppressed) is still logged as getAllVmStats response and
Irit Goihman has posted comments on this change.
Change subject: tests: converted main.py to a test module
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/59975
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: virt net: Support VM migration on OVS based networks
..
Patch Set 10:
(3 comments)
https://gerrit.ovirt.org/#/c/59645/10/vdsm/virt/Makefile.am
File
Nir Soffer has submitted this change and it was merged.
Change subject: client: use representation object
..
client: use representation object
Now we group information about how we fetch arg information from
vdsm api. Fixed
Nir Soffer has posted comments on this change.
Change subject: client: use representation object
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59827
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Print backtrace and terminate stuck tests
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/58212
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: recovery error passed as response
..
Patch Set 2: Continuous-Integration+1
we have CI+1 score on patchset 1, not sure why it is not propagated.
--
Francesco Romani has submitted this change and it was merged.
Change subject: jsonrpc: recovery error passed as response
..
jsonrpc: recovery error passed as response
When we notice that vdsm is in recovery mode we return
Milan Zamazal has posted comments on this change.
Change subject: rpc: Use Suppressed class instead of logging workarounds
..
Patch Set 3:
Small bugs in master patches are dangerous... The mistakenly removed line
returned.
Francesco Romani has abandoned this change.
Change subject: jsonrpc: Fix log level overriding of some methods
..
Abandoned
Milan provided better patches.
--
To view, visit https://gerrit.ovirt.org/58797
To unsubscribe, visit
Francesco Romani has abandoned this change.
Change subject: json: use forzenset for filtered methods
..
Abandoned
Milan provided better patches.
--
To view, visit https://gerrit.ovirt.org/58796
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: migration: downtime: update step delay computation
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59221
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: migration: downtime: start thread after 1st iter
..
migration: downtime: start thread after 1st iter
This patch makes the migration.DowntimeThread
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: Pass config_network_test on py3
..
Patch Set 4: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/59860
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: migration: downtime: add tunable for back compat
..
migration: downtime: add tunable for back compat
In order to fix rhbz#1339521 and to improve the
Francesco Romani has submitted this change and it was merged.
Change subject: migration: downtime: update step delay computation
..
migration: downtime: update step delay computation
This patch changes the way the wait for
Francesco Romani has posted comments on this change.
Change subject: migration: downtime: start thread after 1st iter
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59220
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: migration: downtime: add tunable for back compat
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59467
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: migration: track qemu iterations
..
migration: track qemu iterations
this patch adds accounting for the QEMU iteration during the migrations.
A
Francesco Romani has submitted this change and it was merged.
Change subject: migration: downtime: handle steps=1
..
migration: downtime: handle steps=1
The migration.DowntimeThread() computes the sequence of values
of the
Francesco Romani has posted comments on this change.
Change subject: migration: track qemu iterations
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59219
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: Pass config_network_test on py3
..
net tests: Pass config_network_test on py3
ported relevant code to python3 in order that
Francesco Romani has posted comments on this change.
Change subject: migration: wait for monitor thread before to exit
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59217
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: migration: make MonitorThread own DowntimeThread
..
migration: make MonitorThread own DowntimeThread
A future patch wants to tune the legacy
1 - 100 of 248 matches
Mail list logo
