gerrit-hooks has posted comments on this change.
Change subject: Revert "virt net: Change graphics type from network to address"
..
Patch Set 2:
* #1195208::Update tracker: OK
* Set MODIFIED::bug 1195208#1195208FAILED,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Revert "virt net: Change graphics type from network to address"
..
Revert "virt net: Change graphics type from network to address"
This reverts commit
Petr Horáček has posted comments on this change.
Change subject: ovs: acquire external ifaces
..
Patch Set 25:
(2 comments)
https://gerrit.ovirt.org/#/c/60404/25/tests/network/ovs_switch_test.py
File tests/network/ovs_switch_t
Petr Horáček has posted comments on this change.
Change subject: ovs: ovs_net2bridge fails when ovs service is down
..
Patch Set 2:
So then we should drop it from netinfo too?
--
To view, visit https://gerrit.ovirt.org/61241
Nir Soffer has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 20: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/57754/20/tests/executorTests.py
File tests/e
gerrit-hooks has posted comments on this change.
Change subject: log: Use INFO log level as default
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
Nir Soffer has posted comments on this change.
Change subject: log: Use INFO log level as default
..
Patch Set 2:
Rebase, update new logger added since the original patch.
--
To view, visit https://gerrit.ovirt.org/32504
To u
gerrit-hooks has posted comments on this change.
Change subject: virt net: Change graphics type from network to address
..
Patch Set 1: Verified-1
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208:
Hello Petr Horáček, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/61262
to review the following change.
Change subject: virt net: Change graphics type from network to address
..
Nir Soffer has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/60533/4/README.logging
File README.logging:
Line 25: The ba
Dan Kenigsberg has posted comments on this change.
Change subject: Revert "virt net: Change graphics type from network to address"
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/61259
To un
gerrit-hooks has posted comments on this change.
Change subject: storage: Unify stoage logger name
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
Nir Soffer has uploaded a new change for review.
Change subject: storage: Unify stoage logger name
..
storage: Unify stoage logger name
We had both "Storage" and "storage" loggers, but configuration was only
for "Storage". Unify
gerrit-hooks has posted comments on this change.
Change subject: Revert "virt net: Change graphics type from network to address"
..
Patch Set 1: Verified-1
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::
Edward Haas has uploaded a new change for review.
Change subject: Revert "virt net: Change graphics type from network to address"
..
Revert "virt net: Change graphics type from network to address"
This reverts commit 13603192ab2
Nir Soffer has posted comments on this change.
Change subject: Adding report_stats to virt.stats
..
Patch Set 8:
Yaniv, can you reply to the questions in
https://gerrit.ovirt.org/#/c/59066/8/lib/vdsm/virt/vmstats.py?
--
To v
Nir Soffer has posted comments on this change.
Change subject: sdm: Wire up when_finished callback
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/61255/1/vdsm/storage/sdm/api/base.py
File vdsm/storage/s
Edward Haas has posted comments on this change.
Change subject: ovs: rollback acquired ifaces after failure
..
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/61088/7/lib/vdsm/network/ifacquire.py
File lib/
Nir Soffer has posted comments on this change.
Change subject: jobs: Add when_finished callback and wire up Job.abort
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/61254/1/lib/vdsm/jobs.py
File lib/vds
Nir Soffer has posted comments on this change.
Change subject: Pass the Scheduler instance to HSM
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/61253/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Li
Edward Haas has posted comments on this change.
Change subject: ovs: acquire external ifaces
..
Patch Set 26: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/60404/25/tests/network/ovs_switch_test.py
File tests/network
Edward Haas has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/60974/5/tests/network/acquire_ifaces_test.py
File tests/network/acquire_ifa
gerrit-hooks has posted comments on this change.
Change subject: sdm: Autoclear sdm jobs when finished
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: jobs: Add when_finished callback and wire up Job.abort
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
gerrit-hooks has posted comments on this change.
Change subject: sdm: Wire up when_finished callback
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: Pass the Scheduler instance to HSM
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
gerrit-hooks has posted comments on this change.
Change subject: tests: Move TestingJob to sdmtestlib
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has uploaded a new change for review.
Change subject: jobs: Add when_finished callback and wire up Job.abort
..
jobs: Add when_finished callback and wire up Job.abort
Add a callback mechanism that will be triggered wh
Adam Litke has uploaded a new change for review.
Change subject: Pass the Scheduler instance to HSM
..
Pass the Scheduler instance to HSM
In preparation for auto-cleared Jobs, pass the Scheduler instance created at
vdsm startup
Adam Litke has uploaded a new change for review.
Change subject: sdm: Autoclear sdm jobs when finished
..
sdm: Autoclear sdm jobs when finished
The engine uses the Host.getJobs API to query the status of SDM jobs it has
run. In
Adam Litke has uploaded a new change for review.
Change subject: sdm: Wire up when_finished callback
..
sdm: Wire up when_finished callback
Change-Id: I8db3abc6e57a4a06b90ea1c7bb4186b0b936a152
Signed-off-by: Adam Litke
---
M te
Adam Litke has uploaded a new change for review.
Change subject: tests: Move TestingJob to sdmtestlib
..
tests: Move TestingJob to sdmtestlib
The TestingJob currently used in storage_sdm_api_test.py is needed for testing
Job han
Edward Haas has posted comments on this change.
Change subject: ovs: ovs_net2bridge fails when ovs service is down
..
Patch Set 2: Code-Review-1
There was an agreement that OVS service must be running on this VDSM version.
If w
Edward Haas has posted comments on this change.
Change subject: net systemd: Require openvswitch.service
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61239
To unsubscribe, visit https://gerrit.ovirt
Francesco Romani has abandoned this change.
Change subject: vmxml: move namespace declaration
..
Abandoned
made obsolete by updated https://gerrit.ovirt.org/#/c/60481/15
--
To view, visit https://gerrit.ovirt.org/57381
To uns
gerrit-hooks has posted comments on this change.
Change subject: vmxml: move namespace declaration
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/57381
To unsubscribe, v
gerrit-hooks has posted comments on this change.
Change subject: vm: reorder operations in _domDependentInit
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 36:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: **WIP** tool: reconfigure containers networks
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: network: filter out 'veth' devices.
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 28:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 43:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
gerrit-hooks has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
Francesco Romani has posted comments on this change.
Change subject: vm: reorder operations in _domDependentInit
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/59817/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS5, Line
gerrit-hooks has posted comments on this change.
Change subject: **WIP** tool: reconfigure containers networks
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has abandoned this change.
Change subject: vm: split guest agent init from domDependentInit
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/59816
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 42:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
Francesco Romani has abandoned this change.
Change subject: vm: split device init from domDependentInit
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/59814
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ger
gerrit-hooks has posted comments on this change.
Change subject: vm: split guest agent init from domDependentInit
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/59816
To
gerrit-hooks has posted comments on this change.
Change subject: vm: split device init from domDependentInit
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/59814
To unsu
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 23:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 35:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 27:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
gerrit-hooks has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 23:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: network: filter out 'veth' devices.
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
Francesco Romani has posted comments on this change.
Change subject: vm: reorder operations in _domDependentInit
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/59817/18/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 16
Francesco Romani has posted comments on this change.
Change subject: vm: split guest agent init from domDependentInit
..
Patch Set 18: Code-Review-2
Let's do like this:
1. improve Vm.domDependentInit() separately:
https://gerr
Francesco Romani has posted comments on this change.
Change subject: vm: split device init from domDependentInit
..
Patch Set 18: Code-Review-2
the plan changed as follows:
1. improve Vm.domDependentInit in a separate series
2.
Francesco Romani has posted comments on this change.
Change subject: vm: split device init from domDependentInit
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/59814/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS5, Line
gerrit-hooks has posted comments on this change.
Change subject: contrib: jsonrpc: add example script to run a VM
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: vm: add methods to get/set transient status
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
gerrit-hooks has posted comments on this change.
Change subject: vm: use monotonic_time() for transient status
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vm: always set transient_status with its timestamp
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Francesco Romani has uploaded a new change for review.
Change subject: vm: rename Vm._guestEvent
..
vm: rename Vm._guestEvent
The _guestEvent field of Vm class is misleading.
It does not track a "guest event", but rather sets a
gerrit-hooks has posted comments on this change.
Change subject: vm: rename Vm._guestEvent
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: vm: legacy rng devices fix not needed anymore
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vm: move device initialization together
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Francesco Romani has uploaded a new change for review.
Change subject: vm: legacy rng devices fix not needed anymore
..
vm: legacy rng devices fix not needed anymore
We introduced this fix to deal with upgrades from Vdsm
4.16.z,
Francesco Romani has uploaded a new change for review.
Change subject: vm: move device initialization together
..
vm: move device initialization together
It was scatthered around in Vm._domDependentInit for no good reason
No int
Adam Litke has posted comments on this change.
Change subject: osutils: Start the osutils module
..
Patch Set 4: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/61142/4/tests/osutils_test.py
File tests/osutils_test.py:
Adam Litke has posted comments on this change.
Change subject: testlib: Use osutils.close_fd to avoid fd leaks
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61216
To unsubscribe, visit https://gerrit
Adam Litke has posted comments on this change.
Change subject: osutils: Move NoIntrCall to osutils.uninterruptible
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61153
To unsubscribe, visit https://ge
Adam Litke has posted comments on this change.
Change subject: clusterlock: Support for multiple leases
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60422
To unsubscribe, visit https://gerrit.ovirt.
gerrit-hooks has posted comments on this change.
Change subject: ovs: ovs_net2bridge fails when ovs service is down
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
Adam Litke has posted comments on this change.
Change subject: clusterlock: Raise if lock is used improperly
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60424
To unsubscribe, visit https://gerrit.o
Jenkins CI has posted comments on this change.
Change subject: net systemd: Require openvswitch.service
..
Patch Set 2: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 1
--
To
gerrit-hooks has posted comments on this change.
Change subject: net systemd: Require openvswitch.service
..
Patch Set 2: -Verified
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
gerrit-hooks has posted comments on this change.
Change subject: net func tests: drop ovs/legacy permutation
..
Patch Set 1: Verified-1
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public
gerrit-hooks has posted comments on this change.
Change subject: ovs: ovs_net2bridge fails when ovs service is down
..
Patch Set 1: Verified-1
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK,
Petr Horáček has uploaded a new change for review.
Change subject: ovs: ovs_net2bridge fails when ovs service is down
..
ovs: ovs_net2bridge fails when ovs service is down
Calling ovs_net2bridge() when openvswitch service is not
Petr Horáček has uploaded a new change for review.
Change subject: ovs: ovs_net2bridge fails when ovs service is down
..
ovs: ovs_net2bridge fails when ovs service is down
Calling ovs_net2bridge() when openvswitch service is not
gerrit-hooks has posted comments on this change.
Change subject: ovs: ovs_net2bridge fails when ovs service is down
..
Patch Set 1:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
gerrit-hooks has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60533/2/README.logging
File README.logging:
PS2, Line
Adam Litke has posted comments on this change.
Change subject: clusterlock: Fix double close on EINTR
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60539
To unsubscribe, visit https://gerrit.ovirt.or
gerrit-hooks has posted comments on this change.
Change subject: net systemd: Require openvswitch.service
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is re
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has posted comments on this change.
Change subject: osutils: Start the osutils module
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/61142/4/tests/osutils_test.py
File tests/osutils_test.py:
Line 27: from
Petr Horáček has uploaded a new change for review.
Change subject: net func tests: drop ovs/legacy permutation
..
net func tests: drop ovs/legacy permutation
OVS tests are now covered in new functional tests
tests/network/func_*
Hello Dan Kenigsberg, Edward Haas,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/61239
to review the following change.
Change subject: net systemd: Require openvswitch.service
..
net systemd: Req
gerrit-hooks has posted comments on this change.
Change subject: vm: api: move vm status check into migrate()
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 3: Verified+1
copied score.
--
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit
1 - 100 of 129 matches
Mail list logo