Edward Haas has posted comments on this change.

Change subject: net: introduce acquire module
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/60974/5/tests/network/acquire_ifaces_test.py
File tests/network/acquire_ifaces_test.py:

Line 90
Line 91
Line 92
Line 93
Line 94
> I'm not sure, i tried that but got this:
Have you specified what readlines() returns?
m_open.readlines.return_value = NIC_IFCFG.format(NIC_NAME).split()


-- 
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Edward Haas <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]

Reply via email to