Nir Soffer has posted comments on this change.
Change subject: storage: Sortable ResourceManager lock namespaces
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/61436/1/tests/storage_guarded_test.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Move IMAGE_NAMESPACE and VOLUME_NAMESPACE to
constants.py
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/61434/1//COMMIT_MSG
Commit Message:
Nir Soffer has posted comments on this change.
Change subject: storage: Sortable ResourceManager lock namespaces
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/61436/1/lib/vdsm/storage/constants.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 1:
(8 comments)
Nice! I'll continue tomorrow.
https://gerrit.ovirt.org/#/c/61435/1/lib/vdsm/storage/guarded.py
Nir Soffer has posted comments on this change.
Change subject: Log which client called a verb
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/61367/1/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: Draft for showing client address in rpc logs
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: Sortable ResourceManager lock namespaces
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has uploaded a new change for review.
Change subject: storage: Move IMAGE_NAMESPACE and VOLUME_NAMESPACE to
constants.py
..
storage: Move IMAGE_NAMESPACE and VOLUME_NAMESPACE to constants.py
Change-Id:
Adam Litke has uploaded a new change for review.
Change subject: storage: Introduce guarded utilities
..
storage: Introduce guarded utilities
Throughout the storage code we have implicit locking rules which we follow in
order
Adam Litke has uploaded a new change for review.
Change subject: storage: Sortable ResourceManager lock namespaces
..
storage: Sortable ResourceManager lock namespaces
In order to simplify correct locking order, change the
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Move IMAGE_NAMESPACE and VOLUME_NAMESPACE to
constants.py
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Edward Haas has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 4:
I also do not understand why this needs to be resolved by us at this system
level.
NM is not able to work
Edward Haas has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 4:
It's not kernel related as far as I understand.
modprobe.d is used to setup aliases and default arguments to
gerrit-hooks has posted comments on this change.
Change subject: Adding report_stats to virt.stats
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: Adding report_stats to virt.stats
..
Adding report_stats to virt.stats
This vmstats function sends metrics to external metrics collector.
It parses last
gerrit-hooks has posted comments on this change.
Change subject: sampling: micro-optimization
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 6:
* #1357798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1357798::OK, public bug
* Check
Jenkins CI has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 5: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 4
--
To
gerrit-hooks has posted comments on this change.
Change subject: virt: sampling: add empty() method to StatsSample
..
Patch Set 2:
* #1357798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1357798::OK, public bug
gerrit-hooks has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 4:
* #1357798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1357798::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 5:
* #1357798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1357798::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: sampling: micro-optimization
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: virt: sampling: add empty() method to StatsSample
..
Patch Set 1:
* #1357798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1357798::OK, public bug
Francesco Romani has uploaded a new change for review.
Change subject: virt: sampling: add empty() method to StatsSample
..
virt: sampling: add empty() method to StatsSample
kill the EMPTY_SAMPLE constant.
we always need to
gerrit-hooks has posted comments on this change.
Change subject: sampling: micro-optimization
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Petr Horáček has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 4:
Works on my CentOS. So it is a kernel bug?
--
To view, visit https://gerrit.ovirt.org/61396
To
Edward Haas has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 4: Verified-1
Does not work on my Centos7 VM.
It seems that the modprobe.d conf is loaded after the kernel
Piotr Kliczewski has posted comments on this change.
Change subject: log: Use INFO log level as default
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/32504
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: automation: fix check-merged.sh
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Irit Goihman has uploaded a new change for review.
Change subject: automation: fix check-merged.sh
..
automation: fix check-merged.sh
after moving to fc24 check-merged job started to fail.
This patch fixes broken dependencies
Edward Haas has posted comments on this change.
Change subject: ifcfg: write current DNS information to a management network's
ifcfg file
..
Patch Set 4:
(4 comments)
gerrit-hooks has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Jenkins CI has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 4: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 1
--
To
gerrit-hooks has posted comments on this change.
Change subject: packaging: spec: drop default defattr
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 4:
* #1356635::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356635::OK, public bug
* Check
Petr Horáček has uploaded a new change for review.
Change subject: modprobe: set bonding max_bonds to 0
..
modprobe: set bonding max_bonds to 0
|
|
\ /
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: write current DNS information to a management network's
ifcfg file
..
Patch Set 4:
(6 comments)
gerrit-hooks has posted comments on this change.
Change subject: Revert "NetworkManager: configure to monitor ifcfg/connection
files"
..
Patch Set 5:
* #1326798::Update tracker: OK
* Check Bug-Url::OK
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 3:
* #1356635::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356635::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 2:
* #1356635::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356635::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/61310/3/lib/vdsm/virt/sampling.py
File
Petr Horáček has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 1:
Meh, nevermind, it failed to load bonding module...
--
To view, visit https://gerrit.ovirt.org/61396
To
Nir Soffer has posted comments on this change.
Change subject: Adding report_stats to virt.stats
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/59066/14/lib/vdsm/virt/vmstats.py
File lib/vdsm/virt/vmstats.py:
Line
Petr Horáček has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 1:
Thanks for the review.
However, we found that we can pass options while loading modules. New file is
not
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Remove python 3 test run
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61189
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding report_stats to virt.stats
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/59066/14/lib/vdsm/virt/vmstats.py
File lib/vdsm/virt/vmstats.py:
Nir Soffer has posted comments on this change.
Change subject: Adding report_stats to virt.stats
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/59066/14/lib/vdsm/virt/vmstats.py
File lib/vdsm/virt/vmstats.py:
Line
Francesco Romani has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 1: Code-Review-1
+1 for the name suggestion
I strongly agree with Martin about finding a better way to ship
Martin Polednik has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 1:
Even better filename would be vdsm-bonding-modprobe.conf.
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 1: Code-Review-1
Two concerns:
First, the name "modprobe.conf" later renamed to "vdsm.conf" is bad. It is
gerrit-hooks has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 1:
* #1356635::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356635::OK, public bug
* Check
Yaniv Bronhaim has posted comments on this change.
Change subject: Send vm info report each sampling interval from VMBulkSampler
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/59523/11/lib/vdsm/virt/sampling.py
gerrit-hooks has posted comments on this change.
Change subject: hostdev: move parent processing to device processor
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
gerrit-hooks has posted comments on this change.
Change subject: hostdev: move productinfo processing to device processor
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: move parent processing to device processor
..
hostdev: move parent processing to device processor
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: hostdev: move physfn processing to device processor
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: move productinfo processing to device processor
..
hostdev: move productinfo processing to device processor
Change-Id:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: move physfn processing to device processor
..
hostdev: move physfn processing to device processor
Change-Id:
Francesco Romani has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: api: move vm status check into migrate()
..
Patch Set 8: Verified+1
changes in the tests only, verification still holds.
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: compat: py3: capture output of CPopen.communicate
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/61393/2/lib/vdsm/compat.py
File lib/vdsm/compat.py:
gerrit-hooks has posted comments on this change.
Change subject: vm: api: move vm status check into migrate()
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: vm: api: move vm status check into migrate()
..
Patch Set 7:
(3 comments)
https://gerrit.ovirt.org/#/c/60608/7/tests/vmMigrationTests.py
File
gerrit-hooks has posted comments on this change.
Change subject: compat: py3: capture output of CPopen.communicate
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Fabian Deutsch has posted comments on this change.
Change subject: Revert "NetworkManager: configure to monitor ifcfg/connection
files"
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59260
To
Dan Kenigsberg has uploaded a new change for review.
Change subject: compat: py3: capture output of CPopen.communicate
..
compat: py3: capture output of CPopen.communicate
To allow better coverage of python3 testing, we use
gerrit-hooks has posted comments on this change.
Change subject: compat: py3: capture output of CPopen.communicate
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Edward Haas has posted comments on this change.
Change subject: ifcfg: write current DNS information to a management network's
ifcfg file
..
Patch Set 4: Code-Review-1
(5 comments)
Francesco Romani has posted comments on this change.
Change subject: vm: api: move vm status check into migrate()
..
Patch Set 7: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/60608
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: micro-optimization
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/61311/4//COMMIT_MSG
Commit Message:
Line 4: Commit: Francesco
Dan Kenigsberg has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/61310/3/lib/vdsm/virt/sampling.py
File
Francesco Romani has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/61310/3/lib/vdsm/virt/sampling.py
File
gerrit-hooks has posted comments on this change.
Change subject: tests: sampling: add FakeClock helper
..
Patch Set 3:
* #1357798::Update tracker: OK
* Set MODIFIED::bug 1357798#1357798IGNORE, not all related patches
Dan Kenigsberg has posted comments on this change.
Change subject: tests: sampling: add FakeClock helper
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61309
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: sampling: add FakeClock helper
..
tests: sampling: add FakeClock helper
Add a more robust FakeClock implementation, to be used
in a upcoming
gerrit-hooks has posted comments on this change.
Change subject: vm: reorder operations in _domDependentInit
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: vm: reorder operations in _domDependentInit
..
Patch Set 20: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59817
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: reorder operations in _domDependentInit
..
vm: reorder operations in _domDependentInit
There is no real dependency, so we move up
the
gerrit-hooks has posted comments on this change.
Change subject: Revert "NetworkManager: configure to monitor ifcfg/connection
files"
..
Patch Set 4:
* #1326798::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Francesco Romani has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 4: Code-Review-1
(score changed for visibility, I still want this patch very much)
Looks like tests
Dan Kenigsberg has posted comments on this change.
Change subject: build: Remove python 3 test run
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61189
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vdscli: Replace the default '::' host with hostname
..
Patch Set 4:
* #1350883::Update tracker: OK
* Set MODIFIED::bug 1350883#1350883OK
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdscli: Replace the default '::' host with hostname
..
vdscli: Replace the default '::' host with hostname
vdscli may fail to connect to the VDSM
gerrit-hooks has posted comments on this change.
Change subject: fix vdscli: Replace the default '::' host with hostname
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
Dan Kenigsberg has posted comments on this change.
Change subject: vdscli: Replace the default '::' host with hostname
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61363
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vdscli test: Minor pythonic changes in _assertValidAddress
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61386
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: fix vdscli: Replace the default '::' host with hostname
..
fix vdscli: Replace the default '::' host with hostname
Fixing the tests for cases where
Dan Kenigsberg has posted comments on this change.
Change subject: fix vdscli: Replace the default '::' host with hostname
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61381
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vdscli test: Minor pythonic changes in _assertValidAddress
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61386
To unsubscribe,
Edward Haas has posted comments on this change.
Change subject: vdscli test: Minor pythonic changes in _assertValidAddress
..
Patch Set 1: Verified+1
n
--
To view, visit https://gerrit.ovirt.org/61386
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vdscli test: Minor pythonic changes in _assertValidAddress
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Edward Haas has uploaded a new change for review.
Change subject: vdscli test: Minor pythonic changes in _assertValidAddress
..
vdscli test: Minor pythonic changes in _assertValidAddress
Change-Id:
Edward Haas has posted comments on this change.
Change subject: fix vdscli: Replace the default '::' host with hostname
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/61381/1/tests/vdsClientTests.py
File
Edward Haas has posted comments on this change.
Change subject: vdscli: Replace the default '::' host with hostname
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/61363
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vdscli: Replace the default '::' host with hostname
..
Patch Set 3:
* #1350883::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350883::OK, public
gerrit-hooks has posted comments on this change.
Change subject: network: a legacy bridge now reads its NIC's original
nameservers
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: vdscli: Replace the default '::' host with hostname
..
Patch Set 2:
* #1350883::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350883::OK, public
Ondřej Svoboda has abandoned this change.
Change subject: network: a legacy bridge now reads its NIC's original
nameservers
..
Abandoned
Superseded by https://gerrit.ovirt.org/61184/
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: packaging: spec: drop default defattr
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
1 - 100 of 195 matches
Mail list logo
