gerrit-hooks has posted comments on this change.
Change subject: hooks: Relocate hooking (api) module under lib
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/55544
To un
Edward Haas has abandoned this change.
Change subject: hooks: Relocate hooking (api) module under lib
..
Abandoned
There is no agreement on exposing hooking in this way.
--
To view, visit https://gerrit.ovirt.org/55544
To uns
Edward Haas has posted comments on this change.
Change subject: vdsm: removing txRate and rxRate from code
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59544
To unsubscribe, visit https://gerrit.ovi
Edward Haas has posted comments on this change.
Change subject: virt net: Interface default driver name set to 'vhost'
..
Patch Set 1: Verified+1
Based on Meni Yakove test which was originally performed on the 4.0 branch.
--
Edward Haas has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/61482/13/tests/utilsTests.py
File tests/utilsTests.py:
Line 1060: self
Edward Haas has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 13: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/61482/12/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 953:
Edward Haas has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 31: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/60404/31/tests/network/func_static_ip_test.py
File tests/network/func
Petr Horáček has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 13: Verified+1
(1 comment)
Passed utilsTests.py
https://gerrit.ovirt.org/#/c/61482/12/lib/vdsm/utils.py
File lib/vdsm/util
gerrit-hooks has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 13:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#119520
gerrit-hooks has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: Send metrics info only if metrics enabled to avoid parsing logic
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url foun
gerrit-hooks has posted comments on this change.
Change subject: Rename reports to metrics
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Rename reports to metrics
..
Rename reports to metrics
Leftovers from using reports instead of metrics (following
https://gerrit.ovirt.org/#/c/60846/)
Change-
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Send metrics info only if metrics enabled to avoid parsing logic
..
Send metrics info only if metrics enabled to avoid parsing logic
Change-Id: If5df7708acb3ae
Francesco Romani has posted comments on this change.
Change subject: Send metrics info only if metrics enabled to avoid parsing logic
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61869
To unsubscrib
Francesco Romani has posted comments on this change.
Change subject: Send vm info report each sampling interval from VMBulkSampler
..
Patch Set 13: Code-Review+2
performance concerns addressed on 61869
we agreed to do deeper pe
gerrit-hooks has posted comments on this change.
Change subject: Send vm info report each sampling interval from VMBulkSampler
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Francesco Romani has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 10:
jenkins failure is real: 00:03:55.095 ./vdsm/API.py:45: 'vmstatus' imported but
unused
--
To view, vis
Francesco Romani has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 10: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovir
Francesco Romani has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovir
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/61482/12/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 953: if os.
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Re-review vdsm spec
..
Re-review vdsm spec
The patch fixed fedora-review report warnings:
1. Using %{_libdir} instead of explicit path
2. Specifies vdsm-infra
Yaniv Bronhaim has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 10: Verified+1
only rebased.
--
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://g
gerrit-hooks has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: Re-review vdsm spec
..
Patch Set 1:
* #1361659::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1361659::OK, public bug
* Check Product::#1361659::SKI
gerrit-hooks has posted comments on this change.
Change subject: ovs: copy NIC hwaddr to NB
..
Patch Set 15:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195
Petr Horáček has posted comments on this change.
Change subject: ovs: copy NIC hwaddr to NB
..
Patch Set 14: Verified+1
Passed network/*_test.py
--
To view, visit https://gerrit.ovirt.org/61049
To unsubscribe, visit https://g
Francesco Romani has posted comments on this change.
Change subject: configs: move mom to static
..
Patch Set 6: Code-Review-1
(4 comments)
-1 for visibility
https://gerrit.ovirt.org/#/c/61602/6/.gitignore
File .gitignore:
L
Francesco Romani has posted comments on this change.
Change subject: configs: move logger to static
..
Patch Set 5: Code-Review-1
(1 comment)
missing .gitignore updates
https://gerrit.ovirt.org/#/c/61601/5/.gitignore
File .gi
Francesco Romani has posted comments on this change.
Change subject: autoconf: properly sort makefiles
..
Patch Set 4: Code-Review+1
seems ok
--
To view, visit https://gerrit.ovirt.org/61600
To unsubscribe, visit https://gerr
Jenkins CI has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 31: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 30
--
To view, visit https:
Petr Horáček has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 31: Verified+1
Passed network/*_test.py
--
To view, visit https://gerrit.ovirt.org/60404
To unsubscribe, visit https://gerrit.o
Marcin Mirecki has posted comments on this change.
Change subject: vdsm: removing txRate and rxRate from code
..
Patch Set 6:
Verified with:
-master, vdsm with changes applied
-4.0, vdsm with changes applied (to verify compatib
gerrit-hooks has posted comments on this change.
Change subject: configs: move systemd service files to static
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: configs: introduce static dir
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
gerrit-hooks has posted comments on this change.
Change subject: confis: move modprobe files loading to static
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: configs: move sudoers to static
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
gerrit-hooks has posted comments on this change.
Change subject: autoconf: properly sort makefiles
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: configs: move logger to static
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
gerrit-hooks has posted comments on this change.
Change subject: configs: move logrotate to static
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: configs: move mom to static
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: configs: move sysctl to static
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
gerrit-hooks has posted comments on this change.
Change subject: configs: move limits to static
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
gerrit-hooks has posted comments on this change.
Change subject: configs: move kernel module loading to static
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: configs: move rwtab to static
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
gerrit-hooks has posted comments on this change.
Change subject: makefile: remove unused all-local section
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm: removing txRate and rxRate from code
..
Patch Set 6: Code-Review+1
Based on last comment I do not have more concerns about backward compatibility
--
T
Marcin Mirecki has posted comments on this change.
Change subject: vdsm: removing txRate and rxRate from code
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/59544
To unsubscribe, visit https://gerrit.ovi
Marcin Mirecki has posted comments on this change.
Change subject: vdsm: removing txRate and rxRate from code
..
Patch Set 6:
The engine code which receives the stats looks to be immune to missing
rx/txRate.
The incoming value
gerrit-hooks has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 31:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK
gerrit-hooks has posted comments on this change.
Change subject: vdsm: removing txRate and rxRate from code
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: ovs: acquire external ifaces
..
Patch Set 30:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#11
Edward Haas has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 22: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/setti
gerrit-hooks has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 22:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1
Edward Haas has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings
Petr Horáček has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 22: Verified+1
(1 comment)
Passed network/*test.py
https://gerrit.ovirt.org/#/c/60974/21/tests/network/ifacquire_test
Petr Horáček has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 12: Verified+1
Passed utilsTests.py
--
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.
Edward Haas has posted comments on this change.
Change subject: jsonvdscli: change hostname default
..
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/61782/5/tests/stompAsyncDispatcherTests.py
File tests/s
gerrit-hooks has posted comments on this change.
Change subject: migration: enhance legacy downtime algorithm
..
Patch Set 16:
* #1339521::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/56561
To unsubscribe, vi
Edward Haas has posted comments on this change.
Change subject: ifcfg: write current DNS information to a management network's
ifcfg file
..
Patch Set 8:
(1 comment)
Code changes should be accompanied by tests that backs them
Tomas Jelinek has abandoned this change.
Change subject: migration: enhance legacy downtime algorithm
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/56561
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerri
Edward Haas has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 21: Code-Review+1
(1 comment)
Very nice. Only one recommendation for comment.
https://gerrit.ovirt.org/#/c/60974/21/te
gerrit-hooks has posted comments on this change.
Change subject: contrib: jsonrpc: add example script to run a VM
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
Francesco Romani has posted comments on this change.
Change subject: contrib: jsonrpc: add example script to run a VM
..
Patch Set 5: Verified+1
works as expected
--
To view, visit https://gerrit.ovirt.org/61047
To unsubscrib
Simone Tiraboschi has posted comments on this change.
Change subject: jsonvdscli: change hostname default
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61782
To unsubscribe, visit https://gerrit.ovir
Petr Horáček has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 19:
(11 comments)
https://gerrit.ovirt.org/#/c/60974/19/lib/vdsm/network/ifacquire.py
File lib/vdsm/network/ifacquire.
gerrit-hooks has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 21:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1
Edward Haas has posted comments on this change.
Change subject: ovs: copy NIC hwaddr to NB
..
Patch Set 14: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61049
To unsubscribe, visit https://gerrit.ovirt.org/settings
Petr Horáček has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 12:
(2 comments)
https://gerrit.ovirt.org/#/c/61482/9/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 933:
Line 934:
Line
gerrit-hooks has posted comments on this change.
Change subject: ovs: copy NIC hwaddr to NB
..
Patch Set 14:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: write current DNS information to a management network's
ifcfg file
..
Patch Set 8:
(4 comments)
Let me add tests in a separate patch.
https://gerrit.o
gerrit-hooks has posted comments on this change.
Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url foun
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..
Adding get_batch to StatsCache - returns dict with all vms stat
Change-Id: Ic0b19474
gerrit-hooks has posted comments on this change.
Change subject: ovs: copy NIC hwaddr to NB
..
Patch Set 13:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195
gerrit-hooks has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 20:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1
Edward Haas has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 19: Code-Review-1
(11 comments)
https://gerrit.ovirt.org/#/c/60974/19/lib/vdsm/network/ifacquire.py
File lib/vdsm/netwo
Francesco Romani has posted comments on this change.
Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/61768/3//COMMIT_MSG
Commit Message:
Francesco Romani has posted comments on this change.
Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61768
To unsubscribe
gerrit-hooks has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 12:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#119520
Martin Polednik has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/61482/11/lib/vdsm/utils.py
File lib/vdsm/utils.py:
PS11, Line 956: except:
Yaniv Bronhaim has posted comments on this change.
Change subject: automation: fix check-merged.sh
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/61415/10/automation/deploy.sh
File automation/deploy.sh:
Line 50
Lin
gerrit-hooks has posted comments on this change.
Change subject: ovs: copy NIC hwaddr to NB
..
Patch Set 12:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195
gerrit-hooks has posted comments on this change.
Change subject: ovs: copy NIC hwaddr to NB
..
Patch Set 11:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195
Petr Horáček has posted comments on this change.
Change subject: ovs: copy NIC hwaddr to NB
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/61049/9/lib/vdsm/network/ovs/switch.py
File lib/vdsm/network/ovs/switch.py:
Francesco Romani has posted comments on this change.
Change subject: lib: api: allow to return prebuilt responses
..
Patch Set 3: Verified+1
verified with the tests.
--
To view, visit https://gerrit.ovirt.org/61474
To unsubsc
gerrit-hooks has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: lib: api: allow to return prebuilt responses
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: move the api.py module in the common subtree
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
gerrit-hooks has posted comments on this change.
Change subject: WIP: API: more cleanups
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Piotr Kliczewski has posted comments on this change.
Change subject: Send vm info report each sampling interval from VMBulkSampler
..
Patch Set 12:
is it worth adding some tests?
--
To view, visit https://gerrit.ovirt.org/595
Piotr Kliczewski has posted comments on this change.
Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/61768/3//COMMIT_MSG
Commit Message:
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/61482/9/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 933:
Line 934:
Lin
Yaniv Bronhaim has posted comments on this change.
Change subject: automation: fix check-merged.sh
..
Patch Set 10:
(4 comments)
https://gerrit.ovirt.org/#/c/61415/10/automation/deploy.sh
File automation/deploy.sh:
Line 28: d
gerrit-hooks has posted comments on this change.
Change subject: ovs: acquire external ifaces
..
Patch Set 29:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#11
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..
Patch Set 3: Verified+1
fixed pyflakes warnings. started to use atomic and missed them
--
T
gerrit-hooks has posted comments on this change.
Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
Petr Horáček has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 19: Verified+1
Passed ifacquire_test.py
--
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https:
Petr Horáček has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 11: Verified+1
(12 comments)
Passed utilsTests.py
https://gerrit.ovirt.org/#/c/61482/8/lib/vdsm/utils.py
File lib/vdsm/uti
gerrit-hooks has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 19:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1
gerrit-hooks has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 11:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#119520
1 - 100 of 176 matches
Mail list logo