gerrit-hooks has posted comments on this change.
Change subject: Rename reports to metrics
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: net: early IP+link setup
..
Patch Set 10:
* #1364087::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364087::OK, public bug
* Check Product::#136408
Petr Horáček has posted comments on this change.
Change subject: net: early IP+link setup
..
Patch Set 9:
(3 comments)
https://gerrit.ovirt.org/#/c/60371/9//COMMIT_MSG
Commit Message:
PS9, Line 15: collect
> collects
Done
h
Edward Haas has posted comments on this change.
Change subject: net: lookup dhclient file
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61918
To unsubscribe, visit https://gerrit.ovirt.org/settings
Edward Haas has posted comments on this change.
Change subject: net: early IP+link setup
..
Patch Set 9: Code-Review-1
(3 comments)
Some nits
https://gerrit.ovirt.org/#/c/60371/9//COMMIT_MSG
Commit Message:
PS9, Line 15: col
Edward Haas has posted comments on this change.
Change subject: net test: Replacing MonkeyPatch with mock.patch for netinfo_test
..
Patch Set 3: -Verified
(1 comment)
https://gerrit.ovirt.org/#/c/61269/3/tests/network/netinfo_
Adam Litke has posted comments on this change.
Change subject: lvm: Do not rely on return code when handling extendLV errors
..
Patch Set 1: Code-Review-2
Not the correct solution. The patch resolves the issue (proving that it
gerrit-hooks has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 1:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#1364081::OK,
gerrit-hooks has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 1:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#13
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/61955
to review the following change.
Change subject: net: introduce acquire module
..
net: introduce acquire module
This modu
Hello Dan Kenigsberg, Edward Haas,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/61956
to review the following change.
Change subject: ovs: acquire ifaces
..
ovs: acquire ifaces
Switch returns l
Edward Haas has posted comments on this change.
Change subject: network: write out nameservers to ifcfg files
..
Patch Set 11: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/61184/11/lib/vdsm/network/configurators/ifc
gerrit-hooks has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 40:
* #1364081::Update tracker: OK
* Set MODIFIED::bug 1364081#1364081IGNORE, not all related patches are
closed, check
Dan Kenigsberg has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 39: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/60404
To unsubscribe, visit https://gerrit.ovirt.org/set
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ovs: acquire ifaces
..
ovs: acquire ifaces
Switch returns list of used devices, on upper level we should
check if they are owned by us and if not, aqui
gerrit-hooks has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 30:
* #1364081::Update tracker: OK
* Set MODIFIED::bug 1364081#1364081IGNORE, not all related patches are
clos
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: introduce acquire module
..
net: introduce acquire module
This module will be used to acquire ifaces, both persisted by ifcfg and
not persisted. I
gerrit-hooks has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 1:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#1364081
Hello Yaniv Bronhaim, Dan Kenigsberg, Edward Haas,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/61950
to review the following change.
Change subject: utils: atomic file write
..
utils: atomic fi
gerrit-hooks has posted comments on this change.
Change subject: ovs: use Setup class directly
..
Patch Set 3:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#13
Petr Horáček has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 29: Verified+1
Passed network/*_test.py
--
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https:
gerrit-hooks has posted comments on this change.
Change subject: ovs: copy NIC hwaddr to NB
..
Patch Set 19:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#1364
gerrit-hooks has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 39:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#1364081::OK
Dan Kenigsberg has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 29: Code-Review+2
(1 comment)
copy and raise score
https://gerrit.ovirt.org/#/c/60974/28/lib/vdsm/network/ifacquire
gerrit-hooks has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 29:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#1
Francesco Romani has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovir
Francesco Romani has posted comments on this change.
Change subject: configs: move systemd service files to static
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61763
To unsubscribe, visit https://ge
Francesco Romani has posted comments on this change.
Change subject: configs: move kernel module loading to static
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61617
To unsubscribe, visit https://g
Francesco Romani has posted comments on this change.
Change subject: configs: move sysctl to static
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61619
To unsubscribe, visit https://gerrit.ovirt.org
Francesco Romani has posted comments on this change.
Change subject: configs: move limits to static
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/61605/11/static/Makefile.am
File static/Makefile.am:
Line 61:
Francesco Romani has posted comments on this change.
Change subject: configs: move rwtab to static
..
Patch Set 10: Code-Review+1
ok with the move and this patch seems OK, but I wonder if this file is still
relevant
--
To vi
Francesco Romani has posted comments on this change.
Change subject: configs: move logrotate to static
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61616
To unsubscribe, visit https://gerrit.ovirt.
Francesco Romani has posted comments on this change.
Change subject: configs: move limits to static
..
Patch Set 11: Code-Review+1
(1 comment)
seems OK, but please check the inline question
https://gerrit.ovirt.org/#/c/61605/
Petr Horáček has posted comments on this change.
Change subject: network: write out nameservers to ifcfg files
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/61184/11/lib/vdsm/network/configurators/ifcfg.py
File lib
Francesco Romani has posted comments on this change.
Change subject: configs: move sudoers to static
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61603
To unsubscribe, visit https://gerrit.ovirt.or
Francesco Romani has posted comments on this change.
Change subject: configs: move mom to static
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61602
To unsubscribe, visit https://gerrit.ovirt.org/se
Francesco Romani has posted comments on this change.
Change subject: configs: move logger to static
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61601
To unsubscribe, visit https://gerrit.ovirt.org/
Ondřej Svoboda has posted comments on this change.
Change subject: network: write out nameservers to ifcfg files
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/61184/11/lib/vdsm/network/configurators/ifcfg.py
File
Andrej Krejcir has posted comments on this change.
Change subject: Add all MOM calls to jsonrpc client
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/60492
To unsubscribe, visit https://gerrit.ovirt.org/
Petr Horáček has posted comments on this change.
Change subject: network: write out nameservers to ifcfg files
..
Patch Set 11: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/61184/11/lib/vdsm/network/configurators/if
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: Fix toDict method when error is present
..
Patch Set 3: Code-Review-1
-1 for visibility only
--
To view, visit https://gerrit.ovirt.org/60491
To un
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: Fix toDict method when error is present
..
Patch Set 3:
not sure this is a good direction. On which case do you need this?
Do you still need also wit
Martin Sivák has posted comments on this change.
Change subject: Add all MOM calls to jsonrpc client
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60492
To unsubscribe, visit https://gerrit.ovirt.org
Francesco Romani has posted comments on this change.
Change subject: Add all MOM calls to jsonrpc client
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60492
To unsubscribe, visit https://gerrit.ovirt
Francesco Romani has posted comments on this change.
Change subject: Rename reports to metrics
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61870
To unsubscribe, visit https://gerrit.ovirt.org/setti
Martin Polednik has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 7:
Rationale behind this patch (although, I'm not excited having to defend this
mess): engine can
Francesco Romani has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 7: Code-Review-1
I find the linked discussion enlightening, I'm fine with the concept and I
like
Francesco Romani has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 6: Code-Review-1
(1 comment)
looks fine (hence +2 pending), but I have one question, so I -1'd f
Francesco Romani has posted comments on this change.
Change subject: vmxml: move condition from appendNumaTune to buildDomainXML
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61929
To unsubscribe, vi
Francesco Romani has posted comments on this change.
Change subject: hostdev: report device MMIO numa node
..
Patch Set 6: Code-Review-1
(1 comment)
-1 for visibility only, I'd like an improvement of the commit message (more
Edward Haas has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 28: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/setti
gerrit-hooks has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 28:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#1
gerrit-hooks has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 7:
* #1347669::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1347669::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 6:
* #1347669::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1347669::OK, public bug
*
Petr Horáček has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 27: Verified+1
Passed network/*_test.py
--
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https:
gerrit-hooks has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 38:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#1364081::OK
gerrit-hooks has posted comments on this change.
Change subject: ovs: copy NIC hwaddr to NB
..
Patch Set 18:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#1364
gerrit-hooks has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 27:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#1
gerrit-hooks has posted comments on this change.
Change subject: ovs: use Setup class directly
..
Patch Set 2:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#13
Dan Kenigsberg has submitted this change and it was merged.
Change subject: automation: move check-merged to fc24
..
automation: move check-merged to fc24
check-merged repos were moved to fc24 so lago ovirt deploy is
looking fo
gerrit-hooks has posted comments on this change.
Change subject: net: Silently skip persisting a non-existent running-config
..
Patch Set 5:
* #1329387::Update tracker: OK
* Set MODIFIED::bug 1329387#1329387FAILED, ille
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Silently skip persisting a non-existent running-config
..
net: Silently skip persisting a non-existent running-config
In vdsm-store-net-config uni
Dan Kenigsberg has posted comments on this change.
Change subject: net: Silently skip persisting a non-existent running-config
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60744
To unsubscribe, visi
Dan Kenigsberg has posted comments on this change.
Change subject: automation: move check-merged to fc24
..
Patch Set 1: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/61935
To unsubscribe, visit https://ger
gerrit-hooks has posted comments on this change.
Change subject: automation: move check-merged to fc24
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit htt
gerrit-hooks has posted comments on this change.
Change subject: Collect ksm values only if exist
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Collect ksm values only if exist
..
Collect ksm values only if exist
Ksm values appear only if mom is enabled
Change-Id: I5d1aa7830bff26c688a7c0322152
gerrit-hooks has posted comments on this change.
Change subject: net: lookup dhclient file
..
Patch Set 5:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#136408
gerrit-hooks has posted comments on this change.
Change subject: net: early IP+link setup
..
Patch Set 9:
* #1364087::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364087::OK, public bug
* Check Product::#1364087
gerrit-hooks has posted comments on this change.
Change subject: Collect ksm values only if exist
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug
Yaniv Bronhaim has posted comments on this change.
Change subject: Rename reports to metrics
..
Patch Set 3:
only rebased
--
To view, visit https://gerrit.ovirt.org/61870
To unsubscribe, visit https://gerrit.ovirt.org/setting
Piotr Kliczewski has posted comments on this change.
Change subject: Rename reports to metrics
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61870
To unsubscribe, visit https://gerrit.ovirt.org/setti
gerrit-hooks has posted comments on this change.
Change subject: Rename reports to metrics
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Yaniv Bronhaim has posted comments on this change.
Change subject: Rename reports to metrics
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/61870
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: ovs: copy NIC hwaddr to NB
..
Patch Set 17:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#1364
gerrit-hooks has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 37:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#1364081::OK
gerrit-hooks has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 26:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#1
Piotr Kliczewski has posted comments on this change.
Change subject: Collect ksm values only if exist
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61767
To unsubscribe, visit https://gerrit.ovirt.or
Irit Goihman has posted comments on this change.
Change subject: check-merged: remove numactl installation from deploy
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61938
To unsubscribe, visit https://g
Irit Goihman has posted comments on this change.
Change subject: automation: include master repos in check-merged tests
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61936
To unsubscribe, visit https://
Irit Goihman has posted comments on this change.
Change subject: check-merged: install python-mock on lago deploy
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/61937
To unsubscribe, visit https://gerrit
Irit Goihman has posted comments on this change.
Change subject: automation: move check-merged to fc24
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61935
To unsubscribe, visit https://gerrit.ovirt.org/
gerrit-hooks has posted comments on this change.
Change subject: Send metrics info only if metrics enabled to avoid parsing logic
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url fou
gerrit-hooks has posted comments on this change.
Change subject: Send vm info report each sampling interval from VMBulkSampler
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Send metrics info only if metrics enabled to avoid parsing logic
..
Send metrics info only if metrics enabled to avoid parsing logic
Change-Id: If5df77
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Send vm info report each sampling interval from VMBulkSampler
..
Send vm info report each sampling interval from VMBulkSampler
Change-Id: Ia44f97279e37
gerrit-hooks has posted comments on this change.
Change subject: check-merged: remove bond0 hack
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug
gerrit-hooks has posted comments on this change.
Change subject: Add all MOM calls to jsonrpc client
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: Re-review vdsm spec
..
Patch Set 2:
* #1361659::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1361659::OK, public bug
* Check Product::#1361659::SKI
gerrit-hooks has posted comments on this change.
Change subject: packaging: spec: drop default defattr
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Petr Horáček has posted comments on this change.
Change subject: net: early IP+link setup
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/60371/7//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-07-07 18:41:40 +
gerrit-hooks has posted comments on this change.
Change subject: net: early IP+link setup
..
Patch Set 8:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208
Martin Polednik has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 5: -Verified
Keeping unverified to be in sync w/ engine change.
--
To view, visit https://gerrit
Edward Haas has posted comments on this change.
Change subject: ovs: early IP+link setup
..
Patch Set 7: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/60371/7//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-07-
Yaniv Bronhaim has posted comments on this change.
Change subject: check-merged: install python-mock on lago deploy
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61937
To unsubscribe, visit https://g
Yaniv Bronhaim has posted comments on this change.
Change subject: check-merged: remove numactl installation from deploy
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61938
To unsubscribe, visit http
Yaniv Bronhaim has posted comments on this change.
Change subject: automation: include master repos in check-merged tests
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61936
To unsubscribe, visit htt
Yaniv Bronhaim has posted comments on this change.
Change subject: automation: move check-merged to fc24
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61935
To unsubscribe, visit https://gerrit.ovirt
Jakub Niedermertl has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https:/
gerrit-hooks has posted comments on this change.
Change subject: check-mereged: remove bond0 hack
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
1 - 100 of 203 matches
Mail list logo