Dan Kenigsberg has posted comments on this change.
Change subject: net tests: blacklist link_bond_test
..
Patch Set 3: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/64345
To unsubscribe, visit https://gerrit.ovirt.o
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: blacklist link_bond_test
..
Patch Set 3:
but https://gerrit.ovirt.org/64060 passed with no problem; and link_bond_test
passes on my laptop. Can you
Nir Soffer has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 20:
(2 comments)
https://gerrit.ovirt.org/#/c/64377/20/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2698: transi
gerrit-hooks has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
gerrit-hooks has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Nir Soffer has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 1: Code-Review-1
(8 comments)
https://gerrit.ovirt.org/#/c/65102/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 146
Line 14
Adam Litke has uploaded a new change for review.
Change subject: jobs: Fix abort semantics
..
jobs: Fix abort semantics
Prior to this commit jobs.abort was treated as an synchronous operation
and if it returned successfully the
gerrit-hooks has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: tests: Create all instance variables in setUp
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has uploaded a new change for review.
Change subject: tests: Create all instance variables in setUp
..
tests: Create all instance variables in setUp
AcceptorTests added self.reactor attribute in start_acceptor. This l
Nir Soffer has posted comments on this change.
Change subject: acceptor: stop to double close acceptor
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/63685/2/lib/vdsm/protocoldetector.py
File lib/vdsm/protocoldetecto
Nir Soffer has posted comments on this change.
Change subject: acceptor: stop to double close acceptor
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/63685/2/lib/vdsm/protocoldetector.py
File lib/vdsm/protocoldetecto
Piotr Kliczewski has posted comments on this change.
Change subject: acceptor: stop to double close acceptor
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/63685/2/lib/vdsm/protocoldetector.py
File lib/vdsm/protocol
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline usage of image.Image class
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix positional args calling convention
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and i
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove double dict key
..
Patch Set 6:
* #2::Update tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
Nir Soffer has posted comments on this change.
Change subject: sp: Remove double dict key
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/65051/5//COMMIT_MSG
Commit Message:
Line 8:
Line 9: Commit f9cf58b7bced (Make
gerrit-hooks has posted comments on this change.
Change subject: sp: Simplify long lines using continuation \
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove useless continuation to a commented line
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline acquiring of multiple images locks
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline calls to volume methods
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix domain.produceVolume calling convention
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline image namespace locking
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline building domains list for upgrade
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: sp: Do not use rm.acquireResource return value
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
Allon Mureinik has posted comments on this change.
Change subject: sp: Remove double dict key
..
Patch Set 5: Code-Review+1
(1 comment)
+1 on the code, see inline comment wrt the commit message.
https://gerrit.ovirt.org/#/c/6
Nir Soffer has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65007
To unsubscribe, visit https
Nir Soffer has posted comments on this change.
Change subject: acceptor: stop to double close acceptor
..
Patch Set 2: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/63685/2/lib/vdsm/protocoldetector.py
File lib/vdsm/
gerrit-hooks has posted comments on this change.
Change subject: net libvirt: make network/libvirt.py suitable for OVS
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
gerrit-hooks has posted comments on this change.
Change subject: net tests: minor libvirt_tests style refactoring
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: net libvirt ovs: sync libvirt with running_config
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: net tests: separate ifcfg and libvirt unit tests
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: Revert "virt net: Change graphics type from network to address"
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
gerrit-hooks has posted comments on this change.
Change subject: net tests: blacklist link_bond_test
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: Revert "virt net: Change graphics type from network to address"
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
gerrit-hooks has posted comments on this change.
Change subject: net libvirt ovs: sync libvirt with running_config
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: net tests: minor libvirt_tests style refactoring
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: net libvirt: make network/libvirt.py suitable for OVS
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
gerrit-hooks has posted comments on this change.
Change subject: net tests: separate ifcfg and libvirt unit tests
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: net tests: bond tests fails on CI with ctypes.AttributeError
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
Nir Soffer has posted comments on this change.
Change subject: drop dead constant
..
Patch Set 1: Code-Review+1
Can you verify?
--
To view, visit https://gerrit.ovirt.org/65097
To unsubscribe, visit https://gerrit.ovirt.org/s
gerrit-hooks has posted comments on this change.
Change subject: Revert "virt net: Change graphics type from network to address"
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
gerrit-hooks has posted comments on this change.
Change subject: net libvirt: make network/libvirt.py suitable for OVS
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
gerrit-hooks has posted comments on this change.
Change subject: net libvirt ovs: sync libvirt with running_config
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Petr Horáček has uploaded a new change for review.
Change subject: Revert "virt net: Change graphics type from network to address"
..
Revert "virt net: Change graphics type from network to address"
Now we save even OVS networks
Adam Litke has posted comments on this change.
Change subject: drop dead constant
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65097
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-M
gerrit-hooks has posted comments on this change.
Change subject: Fix API schema to align with runtime schema
..
Patch Set 7:
* update_tracker: OK
* Set MODIFIED::bug 1348255#1348255::IGNORE, skipping for branch 'master'
--
Petr Horáček has uploaded a new change for review.
Change subject: net libvirt: make network/libvirt.py suitable for OVS
..
net libvirt: make network/libvirt.py suitable for OVS
Make network/libvirt.py suitable for OVS (add supp
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix API schema to align with runtime schema
..
Fix API schema to align with runtime schema
Change-Id: Ia1b5e90831fd0e4d9e897baaae4afb68f22e3877
Bug-Url
gerrit-hooks has posted comments on this change.
Change subject: drop dead constant
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and i
Dan Kenigsberg has uploaded a new change for review.
Change subject: drop dead constant
..
drop dead constant
It has not been used in code since commit 87f0129.
Change-Id: I1c3651d296ee757752bee659fa08835bd385e91a
Signed-off-by
Nir Soffer has posted comments on this change.
Change subject: sp: Sort dict literal by key
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/65052/5//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2016-10-04 00:17:28
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url
gerrit-hooks has posted comments on this change.
Change subject: acceptor: stop to double close acceptor
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Michal Skrivanek has posted comments on this change.
Change subject: virt: Migration plugins to enable skipping of special OVS
processing for nics
..
Patch Set 2:
It is out of scope of this patch. But the series of patches int
Petr Horáček has posted comments on this change.
Change subject: net tests: minor libvirt_tests style refactoring
..
Patch Set 1: Verified+1
Tests passed.
--
To view, visit https://gerrit.ovirt.org/65091
To unsubscribe, visit
Petr Horáček has uploaded a new change for review.
Change subject: net tests: separate ifcfg and libvirt unit tests
..
net tests: separate ifcfg and libvirt unit tests
Change-Id: Ieca34a3f361586346d76ec22b11554c4a7c6e84d
---
M t
Petr Horáček has posted comments on this change.
Change subject: net tests: separate ifcfg and libvirt unit tests
..
Patch Set 1: Verified+1
Both tests passed.
--
To view, visit https://gerrit.ovirt.org/65090
To unsubscribe,
Petr Horáček has uploaded a new change for review.
Change subject: net tests: minor libvirt_tests style refactoring
..
net tests: minor libvirt_tests style refactoring
Change-Id: I64dedb9859d204082a1516574e9b8650a3e4ffe5
---
M t
Marcin Mirecki has posted comments on this change.
Change subject: virt: Migration plugins to enable skipping of special OVS
processing for nics
..
Patch Set 2:
The hook (vm_migrate_hook.py) was added as part of OVS support
(
gerrit-hooks has posted comments on this change.
Change subject: virt: Try to detect non guest iniated shutdowns
..
Patch Set 6:
* #1341106::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1341106::OK, public bug
*
Michal Skrivanek has posted comments on this change.
Change subject: virt: Migration plugins to enable skipping of special OVS
processing for nics
..
Patch Set 2: Code-Review-1
if this is supposed to bring official ovs support
Michal Skrivanek has posted comments on this change.
Change subject: draft: vm_migration_libvirt_hook_plugins
..
Patch Set 4:
>During vm migration we invoke a libvirt hook: vm_migrate_hook.py.
>This was added recently, and adds
Andrej Krejcir has posted comments on this change.
Change subject: Fix API schema to align with runtime schema
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/64477
To unsubscribe, visit https://gerrit.ov
gerrit-hooks has posted comments on this change.
Change subject: network: filter out 'veth' devices
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 23:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: config: add tunables for container support
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: **WIP** tool: reconfigure containers networks
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 44:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 33:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 31:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 51:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
Allon Mureinik has posted comments on this change.
Change subject: sp: Sort dict literal by key
..
Patch Set 5: Code-Review+1
(2 comments)
+1 on the code, minor corrections to the commit message
https://gerrit.ovirt.org/#/c/6
Piotr Kliczewski has posted comments on this change.
Change subject: Fix API schema to align with runtime schema
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64477
To unsubscribe, visit https://gerr
Milan Zamazal has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 2:
TODO added.
--
To view, visit https://gerrit.ovirt.org/65007
To unsubscribe, visit htt
Milan Zamazal has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 2: Verified+1
No code change since the last verification, so Jenkins is enough.
--
To vie
gerrit-hooks has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 2:
* #1380822::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1380822::OK, publ
Ramesh N has posted comments on this change.
Change subject: py3: make gluster_cli_tests pass
..
Patch Set 3:
@Dan: I manually built and installed the vdsm packages with this patch. I
didn't see any issue with the gluster mana
84 matches
Mail list logo
