Nir Soffer has posted comments on this change. Change subject: acceptor: stop to double close acceptor ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/63685/2/lib/vdsm/protocoldetector.py File lib/vdsm/protocoldetector.py: Line 207 Line 208 Line 209 Line 210 Line 211 > I think this is bad reason. The acceptor should not depend on the reactor f Or - even more minimal fix - how about switching the order? def stop(self): self._acceptor.close() self._ractor.stop() We can move reactor.stop() from here later. -- To view, visit https://gerrit.ovirt.org/63685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a14cfa84c34241dbb511c0348109073b6865087 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
