Adam Litke has posted comments on this change.
Change subject: Fix multiple commands with same name in different vdsm-tool
modules
..
Patch Set 1: (1 inline comment)
File vd
Adam Litke has posted comments on this change.
Change subject: Fix multiple commands with same name in different vdsm-tool
modules
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Patch looks good
Adam Litke has posted comments on this change.
Change subject: Move uninstall preun section to vdsm-unregister
..
Patch Set 1: I would prefer that you didn't submit this
Again, you have moved some code to vdsm-tool but you are
Adam Litke has posted comments on this change.
Change subject: Encapsulate vdsm-unregister into vdsm-tool function
..
Patch Set 1: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/4527
To uns
Adam Litke has posted comments on this change.
Change subject: Encapsulate vdsm-unregister into vdsm-tool function
..
Patch Set 1:
It would help me to justify this patch if it included a use for the new code.
Right now, you h
Adam Litke has posted comments on this change.
Change subject: Move uninstall preun section to vdsm-unregister
..
Patch Set 1: (1 inline comment)
File vdsm/vdsm-unregister.in
Adam Litke has posted comments on this change.
Change subject: Add passwd command to vdsm-tool
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
I am worried that you forgot to configure the passwor
Adam Litke has posted comments on this change.
Change subject: small fix for import in test cases
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
Tested in the source directory and from the installed v
Adam Litke has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 9:
One additional comment. You will need to submit a patch to MOM to change the
initialization sequence since you no longer need to r
Adam Litke has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 9: I would prefer that you didn't submit this
(10 inline comments)
File Makefile.
Adam Litke has posted comments on this change.
Change subject: Remove the parameter of clientIF instance from API
..
Patch Set 5: (1 inline comment)
File vdsm/API.py
Line 993
Adam Litke has posted comments on this change.
Change subject: Remove the parameter of clientIF instance from API
..
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
Compile error needs fixing...
Dan
Adam Litke has posted comments on this change.
Change subject: Fix "unknown device" issue for balloon device
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3901
To unsu
Adam Litke has posted comments on this change.
Change subject: Add some external program path
..
Patch Set 1: I would prefer that you didn't submit this
You shouldn't need all of these after you change your other patch to stop
Adam Litke has posted comments on this change.
Change subject: [WIP] Move vdsmd.init to vdsm-tool
..
Patch Set 1: I would prefer that you didn't submit this
(17 inline comments)
Need to convert more shell commands to python eq
Adam Litke has posted comments on this change.
Change subject: Remove the parameter of clientIF instance from API
..
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
Looks good except for a few small
Adam Litke has posted comments on this change.
Change subject: tests: Verify REST version information
..
Patch Set 1: Verified
If we change our mind on how to represent a version in dsaversion.py then we
will simply need to up
Adam Litke has posted comments on this change.
Change subject: [WIP]change startup process for vdsm and supervdsm
..
Patch Set 4: Fails; I would prefer that you didn't submit this
(15 inline comments)
I performed the following
Adam Litke has uploaded a new change for review.
Change subject: tests: Verify REST version information
..
tests: Verify REST version information
Add a new test to verify the vdsm version information that is returned by
the REST
Adam Litke has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 7: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/2367
To unsubscribe, visit http://gerrit.ovirt.
Adam Litke has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 7:
I would also like to request that a set of tests be added to the functional
test suite to check the MOM integration code.
--
To vi
Adam Litke has posted comments on this change.
Change subject: Remove the parameter of clientIF instance from API
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
..
Adam Litke has posted comments on this change.
Change subject: generate test package for target machine
..
Patch Set 1:
This can be abandoned now, right?
--
To view, visit http://gerrit.ovirt.org/4454
To unsubscribe, visit htt
Adam Litke has posted comments on this change.
Change subject: tests: Add functional tests
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/4452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-M
Adam Litke has posted comments on this change.
Change subject: tests: Package up tests
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/4451
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Messa
Adam Litke has posted comments on this change.
Change subject: tests: Package up tests
..
Patch Set 3: (1 inline comment)
File tests/run_tests.sh.in
Line 2: prefix="@prefix@"
Adam Litke has posted comments on this change.
Change subject: tests: Add functional tests
..
Patch Set 3: No score
Ewoud, you're absolutely right. I have too many open patches floating around
and somehow I lost that particul
Adam Litke has posted comments on this change.
Change subject: tests: Clean up sample text in fileUtilTests.py
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4517
To unsubscribe, visit http://gerrit.ovirt.or
Adam Litke has uploaded a new change for review.
Change subject: tests: Clean up sample text in fileUtilTests.py
..
tests: Clean up sample text in fileUtilTests.py
I understand the value of humor and I am certain no harm was int
Adam Litke has posted comments on this change.
Change subject: tests: Add functional tests
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/4452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-M
Adam Litke has posted comments on this change.
Change subject: tests: Package up tests
..
Patch Set 3: Verified
Added README file to describe how to run the tests.
--
To view, visit http://gerrit.ovirt.org/4451
To unsubscribe,
Adam Litke has posted comments on this change.
Change subject: tests: Add functional tests
..
Patch Set 2: (1 inline comment)
File tests/functional/restTests.py
Line 43:
Adam Litke has posted comments on this change.
Change subject: tests: Package up tests
..
Patch Set 2: (2 inline comments)
File tests/run_tests.sh.in
Line 3: LC_ALL=C PYTHONP
Adam Litke has posted comments on this change.
Change subject: tests: Add functional tests
..
Patch Set 1: (2 inline comments)
File tests/functional/restTests.py
Line 44:
Adam Litke has posted comments on this change.
Change subject: tests: Package up tests
..
Patch Set 1: (1 inline comment)
File tests/Makefile.am
Line 45:cpu_info.out
Adam Litke has posted comments on this change.
Change subject: rest-api: Fix software version parsing
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4447
To unsubscribe, visit http://gerrit.ovirt.org/setting
Adam Litke has posted comments on this change.
Change subject: rest-api: Model VMs
..
Patch Set 6: (2 inline comments)
Commit Message
Line 16: - Create a new VM and launc
Adam Litke has posted comments on this change.
Change subject: rest-api: Model VMs
..
Patch Set 6:
Gal, would you be willing to comment on my discussion thread on vdsm-devel? So
far, no one has been willing to address it.
--
Adam Litke has uploaded a new change for review.
Change subject: tests: Package up tests
..
tests: Package up tests
This patch packages up the test suite so that it can be installed on a target
machine to test the installed vdsm
Adam Litke has uploaded a new change for review.
Change subject: tests: Add functional tests
..
tests: Add functional tests
Currently we only have unit tests that isolate individual components for
testing. It is also useful to
Adam Litke has uploaded a new change for review.
Change subject: rest-api: Fix software version parsing
..
rest-api: Fix software version parsing
Fix the parsing of the software_version field of getVdsCapabilities.
- Properly h
Adam Litke has abandoned this change.
Change subject: libvirt: Fix dev type identifier for balloon devices
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/4319
To unsubscribe, visit http://gerrit.ovirt.org/s
Adam Litke has posted comments on this change.
Change subject: Separate API binding from BindingXMLRPC
..
Patch Set 1: I would prefer that you didn't submit this
I don't really understand the purpose of this. The functions you
Adam Litke has posted comments on this change.
Change subject: Support unicode args in betterPopen
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
Fixes the problem I was seeing with createStoragePool
Adam Litke has posted comments on this change.
Change subject: Split xmlrpc server into its own rpm
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/3892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Adam Litke has posted comments on this change.
Change subject: Make the xmlrpc binding run in a thread
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/3891
To unsubscribe, visit http://gerrit.ovirt.org/settin
Adam Litke has posted comments on this change.
Change subject: rest-api: Add the basic server infrastructure
..
Patch Set 7:
argh... Indeed it is.
--
To view, visit http://gerrit.ovirt.org/2021
To unsubscribe, visit http://ger
Adam Litke has uploaded a new change for review.
Change subject: rest-api: Compact sub-resource link handling
..
rest-api: Compact sub-resource link handling
In the last review, Saggi wanted to see what sub-collection link handl
Adam Litke has posted comments on this change.
Change subject: libvirt: Fix dev type identifier for balloon devices
..
Patch Set 1:
Hi Mark. Thanks for the review. I notice in several places (including in your
pending balloo
Adam Litke has posted comments on this change.
Change subject: hook: balloon - Enable the virtio balloon
..
Patch Set 1: (1 inline comment)
File vdsm_hooks/balloon/before_vm_
Adam Litke has posted comments on this change.
Change subject: rest-api: Model storage connections
..
Patch Set 4:
Yep. In the next series I will be changing this collection to
storageconnectionrefs
--
To view, visit http://
Adam Litke has posted comments on this change.
Change subject: rest-api: Add unit tests
..
Patch Set 4: (3 inline comments)
Thanks for the review. I have addressed all of your comments in my local
version of the patch to be p
Adam Litke has posted comments on this change.
Change subject: Make the xmlrpc binding run in a thread
..
Patch Set 4: (1 inline comment)
File vdsm/BindingXMLRPC.py
Line 2: #
Adam Litke has uploaded a new change for review.
Change subject: libvirt: Fix dev type identifier for balloon devices
..
libvirt: Fix dev type identifier for balloon devices
Libvirt designates a balloon device with the 'memballo
Adam Litke has uploaded a new change for review.
Change subject: hook: balloon - Enable the virtio balloon
..
hook: balloon - Enable the virtio balloon
Currently the virtio balloon is disabled for vdsm guests. Until we decide t
Adam Litke has posted comments on this change.
Change subject: Make the xmlrpc binding run in a thread
..
Patch Set 4: (1 inline comment)
File vdsm/BindingXMLRPC.py
Line 77:
Adam Litke has posted comments on this change.
Change subject: Modify scripts in vdsm_cli/ for PEP8 compliance
..
Patch Set 4: (1 inline comment)
File vdsm_cli/vdsClient.py
L
Adam Litke has posted comments on this change.
Change subject: Introduce API setBalloonTarget
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3669
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: API: getAllTasks{Info|Statuses} does not return all tasks
..
Patch Set 1:
I have proposed a new API on vdsm-devel that "fixes" the behavior of these old
calls. Pl
Adam Litke has posted comments on this change.
Change subject: rest-api: Add the basic server infrastructure
..
Patch Set 5:
Changed the BSD message to a docstring.
--
To view, visit http://gerrit.ovirt.org/2021
To unsubscribe
Adam Litke has posted comments on this change.
Change subject: rest-api: Model storage connections
..
Patch Set 3: (1 inline comment)
File vdsm/rest/templates/Makefile.am
Lin
Adam Litke has posted comments on this change.
Change subject: rest-api: Add the basic server infrastructure
..
Patch Set 5: (1 inline comment)
Made the requested changes.
F
Adam Litke has posted comments on this change.
Change subject: Make the xmlrpc binding run in a thread
..
Patch Set 3: (1 inline comment)
Yep, those comments are easy to miss when viewing patches in the dashboard.
Without a -
Adam Litke has posted comments on this change.
Change subject: Make the xmlrpc binding run in a thread
..
--
To view, visit http://gerrit.ovirt.org/3891
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageTyp
Adam Litke has posted comments on this change.
Change subject: rest-api: Add the basic server infrastructure
..
Patch Set 5:
Added the copyright notice to Dispatcher.py
--
To view, visit http://gerrit.ovirt.org/2021
To unsubsc
Adam Litke has posted comments on this change.
Change subject: rest-api: Add the basic server infrastructure
..
Patch Set 4: (1 inline comment)
File vdsm/rest/Dispatcher.py
L
Adam Litke has posted comments on this change.
Change subject: Split xmlrpc server into its own rpm
..
Patch Set 2: Verified
As Saggi suggested, I verified this on a clean install of Fedora 17. Vdsm runs
fine with and without
Adam Litke has posted comments on this change.
Change subject: [WIP] MOM Integration
..
Patch Set 6: (1 inline comment)
File vdsm/clientIF.py
Line 92:
The interface is MOM a
Adam Litke has posted comments on this change.
Change subject: doc: Add informational message for skipping tests
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3906
To unsubscribe, visit http://gerrit.ovirt.
Adam Litke has posted comments on this change.
Change subject: [WIP] MOM Integration
..
Patch Set 6: (2 inline comments)
File vdsm/clientIF.py
Line 92:
Hi Doron. We are loo
Adam Litke has posted comments on this change.
Change subject: Introduce API setBalloonTarget
..
Patch Set 5: I would prefer that you didn't submit this
(2 inline comments)
Just some suggestions about using a hard-coded defaul
Adam Litke has posted comments on this change.
Change subject: Introduce API setBalloonTarget
..
Patch Set 5: (1 inline comment)
File vdsm/vm.py
Line 405: dev
Adam Litke has posted comments on this change.
Change subject: build: Add an option to skip unit tests
..
Patch Set 1:
Dan, I suppose it has the same effect. Was not aware of this trick with nose.
--
To view, visit http://ger
Adam Litke has posted comments on this change.
Change subject: rest-api: Add unit tests
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Needs update to a new version.
...
Adam Litke has uploaded a new change for review.
Change subject: build: Add an option to skip unit tests
..
build: Add an option to skip unit tests
During development it is common to rebuid vdsm many times. In that case it
is v
Adam Litke has posted comments on this change.
Change subject: add for in hackVdsmModule - taken from Adam Litke
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
Code looks good and verified that the t
Adam Litke has posted comments on this change.
Change subject: Make the xmlrpc binding run in a thread
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3891
To unsubscribe, visit http://gerrit.ovirt.org/settin
Adam Litke has posted comments on this change.
Change subject: Split xmlrpc server into its own rpm
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Adam Litke has uploaded a new change for review.
Change subject: Make the xmlrpc binding run in a thread
..
Make the xmlrpc binding run in a thread
Currently, the xmlrpc binding runs in the vdsmd main thread. To prepare for
mak
Adam Litke has uploaded a new change for review.
Change subject: Split xmlrpc server into its own rpm
..
Split xmlrpc server into its own rpm
We would like to move towards a model where API bindings are optional. This
means tha
Adam Litke has posted comments on this change.
Change subject: Introduce API getBalloonInfo and setBalloonTarget
..
Patch Set 4: Verified; I would prefer that you didn't submit this
(1 inline comment)
Once I fix the error in l
Adam Litke has posted comments on this change.
Change subject: rest-api: Add the basic server infrastructure
..
Patch Set 3: (7 inline comments)
Commit Message
Line 50: Signe
Adam Litke has uploaded a new change for review.
Change subject: rest-api: Model StoragePools
..
rest-api: Model StoragePools
API Implemented:
/api/storagepools
* Create/connect new storage pool and manipulate
Adam Litke has uploaded a new change for review.
Change subject: rest-api: Add unit tests
..
rest-api: Add unit tests
Add a framework and unit tests for the REST API. These tests override the vdsm
API bridge so that the REST co
Adam Litke has uploaded a new change for review.
Change subject: rest-api: Model VMs
..
rest-api: Model VMs
API Implemented:
/api/vms : Virtual machines
* Manipulate virtual machines
* Manipulate VM sub-collec
Adam Litke has uploaded a new change for review.
Change subject: rest-api: Model Tasks
..
rest-api: Model Tasks
API Implemented:
/api/tasks : Asynchronous tasks
* View and manage information about ongoing and c
Adam Litke has uploaded a new change for review.
Change subject: rest-api: Model images
..
rest-api: Model images
API Implemented:
/api/storagedomains//images
* Provide information about images associated with
Adam Litke has uploaded a new change for review.
Change subject: rest-api: Model storage connections
..
rest-api: Model storage connections
API Implemented:
/api/storageconnections
* list, acquire, and release
Adam Litke has uploaded a new change for review.
Change subject: rest-api: Model StorageDomains
..
rest-api: Model StorageDomains
API Implemented:
/api/storagedomains : Manipulate Storage Domains
* Provide comp
Adam Litke has uploaded a new change for review.
Change subject: rest-api: Model volumes
..
rest-api: Model volumes
API Implemented:
/api/storagedomains//volumes
* Manipulate all volumes associated with a stora
Adam Litke has posted comments on this change.
Change subject: [WIP] Add ballooning support
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Looks pretty good. Just a few minor comments/improveme
Adam Litke has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
..
Patch Set 5: (1 inline comment)
File vdsm/API.py
Line 408:
Adam Litke has posted comments on this change.
Change subject: API: getAllTasks{Info|Statuses} does not return all tasks
..
Patch Set 1: (1 inline comment)
File vdsm/storage/
Adam Litke has posted comments on this change.
Change subject: API: getAllTasks{Info|Statuses} does not return all tasks
..
Patch Set 1: (2 inline comments)
File vdsm/Binding
Adam Litke has posted comments on this change.
Change subject: storageServer: Fix isConnected for LocalDirectoryConnections
..
Patch Set 1: Verified
Tested and found that it does fix reconnecting to the same local directory.
-
Adam Litke has abandoned this change.
Change subject: Remove unused ksm code to clean up sudoers
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/3211
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Adam Litke has uploaded a new change for review.
Change subject: API: getAllTasks{Info|Statuses} does not return all tasks
..
API: getAllTasks{Info|Statuses} does not return all tasks
As discussed on the list, I found that the g
Adam Litke has uploaded a new change for review.
Change subject: storageServer: Fix isConnected for LocalDirectoryConnections
..
storageServer: Fix isConnected for LocalDirectoryConnections
The current isConnected method for Loc
Adam Litke has abandoned this change.
Change subject: storageConnection: iterate on a copy of _conDict
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/3578
To unsubscribe, visit http://gerrit.ovirt.org/setti
Adam Litke has uploaded a new change for review.
Change subject: storageConnection: iterate on a copy of _conDict
..
storageConnection: iterate on a copy of _conDict
The method _checkConnections slowly iterates over the dictiona
401 - 500 of 583 matches
Mail list logo
