Adam Litke has posted comments on this change.

Change subject: tests: Add functional tests
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File tests/functional/restTests.py
Line 44:         print e.read()
It shouldn't matter because nose traps output and only prints it on error.  I 
think logging may be overkill.

Line 50:     def assertHTTPError(self, code, fn, *args):
Done

--
To view, visit http://gerrit.ovirt.org/4452
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id33dfabd7c67379351256aad8e09ad0a36e46246
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Wenchao Xia <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to