Dan Kenigsberg has posted comments on this change.
Change subject: compat: py3: capture output of CPopen.communicate
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61393
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Require python-blivet only with gluster-management build
..
Require python-blivet only with gluster-management build
gluster's code uses blivet which
Dan Kenigsberg has posted comments on this change.
Change subject: Require python-blivet only with gluster-management build
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62625
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Vdsm supports only x86, ppc and ppc64
..
Patch Set 2: Code-Review-1
-1 for visibility
--
To view, visit https://gerrit.ovirt.org/62465
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: hook-fcoe is arch depended
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62454/2//COMMIT_MSG
Commit Message:
Line 6:
Line 7: hook-fcoe is arch
Dan Kenigsberg has posted comments on this change.
Change subject: net: don't accept nameservers on a non-default network
..
Patch Set 10:
oVirt does not really care through which network a host's DNS is defined, as
all
Dan Kenigsberg has posted comments on this change.
Change subject: net: don't accept nameservers on a non-default network
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62362
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: add a 'nameservers' property to NetInfo
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62359
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: Introduce nameservers (dns) network api
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61931
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: network: rename reported 'dnss' to 'nameservers' for clarity
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61932
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: add a 'status' parameter to SetupNetworksError
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62361
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: write out nameservers to ifcfg files
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62360
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net test: Rename link_test module to netlink_test
..
net test: Rename link_test module to netlink_test
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: net test: Rename link_test module to netlink_test
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62442
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Adding build-artifacts-manual.sh script
..
Patch Set 1:
could you explain in the commit message what is build-artifacts-manual, and how
is it different from
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Removed unused global
..
Removed unused global
Change-Id: I1d94b83e0ee9df0a8013580cb9cb8200ebdbc84b
Signed-off-by: Yaniv Bronhaim
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm reg: clean up
..
vdsm reg: clean up
Reviewing the vdsm spec found some remaining of vdsm reg
deprecated in early 3.6 versions.
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: spec: remove deprecated BuildRoot macro
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62164
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Vdsm supports only x86, ppc and ppc64
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62465/2/vdsm.spec.in
File vdsm.spec.in:
Line 57: Url:
Dan Kenigsberg has posted comments on this change.
Change subject: Revert "Remove __init__.py file from lib64 vdsm python
directory"
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/62453/3//COMMIT_MSG
Dan Kenigsberg has posted comments on this change.
Change subject: hook-fcoe is arch depended
..
Patch Set 2: Code-Review-1
(1 comment)
-1 for visibility
https://gerrit.ovirt.org/#/c/62454/2//COMMIT_MSG
Commit Message:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: net: early IP+link setup
..
Patch Set 15: Code-Review-1
(3 comments)
-1 is mainly for handling a mismatch with ovsdb.
Dan Kenigsberg has posted comments on this change.
Change subject: net: Report the default gateway flag through caps
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/58351/13/lib/vdsm/network/kernelconfig.py
File
Dan Kenigsberg has abandoned this change.
Change subject: hook-fcoe: enable lldpad and fceo service on boot
..
Abandoned
bug nack'ed from 4.0.2 by ydary.
--
To view, visit https://gerrit.ovirt.org/62365
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move systemd service files to static
..
configs: move systemd service files to static
Part of the move of static files to new directory. The
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move sysctl to static
..
configs: move sysctl to static
Part of the move of static files to new directory. The files are moved
to
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move modprobe files loading to static
..
configs: move modprobe files loading to static
Part of the move of static files to new directory.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move kernel module loading to static
..
configs: move kernel module loading to static
Part of the move of static files to new directory. The
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move logrotate to static
..
configs: move logrotate to static
Part of the move of static files to new directory. The files are moved
to
Dan Kenigsberg has posted comments on this change.
Change subject: hook-fcoe: enable lldpad and fceo service on boot
..
Patch Set 2: Continuous-Integration+1 Verified+1
`make check` ended with an unrelated failure; rpms built
Dan Kenigsberg has posted comments on this change.
Change subject: net: don't accept nameservers on a non-default network
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62167
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: don't accept nameservers on a non-default network
..
net: don't accept nameservers on a non-default network
Currently, only the
Dan Kenigsberg has uploaded a new change for review.
Change subject: hook-fcoe: enable lldpad and fceo service on boot
..
hook-fcoe: enable lldpad and fceo service on boot
When the vdsm-hook-fcoe.rpm is installed, we now start
Dan Kenigsberg has posted comments on this change.
Change subject: net: don't accept nameservers on a non-default network
..
Patch Set 8: Code-Review-1
why is it important to enforce that?
we only care that there is a single
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: add a 'status' parameter to SetupNetworksError
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62166
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: add a 'status' parameter to SetupNetworksError
..
net tests: add a 'status' parameter to SetupNetworksError
Change-Id:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: write out nameservers to ifcfg files
..
net: write out nameservers to ifcfg files
This patch handles setupNetworks' recently introduced
Dan Kenigsberg has posted comments on this change.
Change subject: net: write out nameservers to ifcfg files
..
Patch Set 17: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/61184
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: add a 'nameservers' property to NetInfo
..
Patch Set 3: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/62148
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: add a 'nameservers' property to NetInfo
..
net: add a 'nameservers' property to NetInfo
Functional tests in the following patch will use it.
Dan Kenigsberg has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62268
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: revert net: Libvirt hook that enables ovs-legacy migration
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62121
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: revert net: Libvirt hook that enables ovs-legacy migration
..
revert net: Libvirt hook that enables ovs-legacy migration
Both the integrated and older
Dan Kenigsberg has posted comments on this change.
Change subject: virt net: Support VM migration on OVS based networks
..
Patch Set 17: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/59645
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt net: Support VM migration on OVS based networks
..
virt net: Support VM migration on OVS based networks
With the introduction of OVS as a network
Dan Kenigsberg has posted comments on this change.
Change subject: storage: move outOfProcess module to vdsm storage lib
..
Patch Set 7: Code-Review-1
rebase please!
--
To view, visit https://gerrit.ovirt.org/56576
To
Dan Kenigsberg has posted comments on this change.
Change subject: storage: move threadPool module to vdsm storage lib
..
Patch Set 4: Code-Review-1
marking with -1 as this needs a rebase and reverification.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: Using %{?_smp_mflags} in %install
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/62163/1/vdsm.spec.in
File vdsm.spec.in:
Line 743
Line 744
Line
Dan Kenigsberg has posted comments on this change.
Change subject: Removing deprecated lines from spec
..
Patch Set 2: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/62159
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Removing deprecated lines from spec
..
Removing deprecated lines from spec
rm -rf %{buildroot} and %defattr(-, root, root, -) are not needed
anymore.
Dan Kenigsberg has posted comments on this change.
Change subject: net: early IP+link setup
..
Patch Set 15: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/60371
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Rename reports to metrics
..
Rename reports to metrics
Leftovers from using reports instead of metrics (following
https://gerrit.ovirt.org/#/c/60846/)
Dan Kenigsberg has posted comments on this change.
Change subject: network: write out nameservers to ifcfg files
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/61184/13/tests/network/netfunctestlib.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 2: Code-Review+1
(but I'm waiting for Polednik to drop his -1 or explain it better)
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 2: Code-Review+2
I think that the build script works fine on ppc as well (albeit creating a hook
that we
Dan Kenigsberg has posted comments on this change.
Change subject: automation: use 3.6 repos
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61970
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: automation: use 3.6 repos
..
automation: use 3.6 repos
Change-Id: I739787b39b7ec24d8fc432f007e33cacf0c60ae6
Signed-off-by: Sandro Bonazzola
Dan Kenigsberg has posted comments on this change.
Change subject: Change Source0 after uploading latest tar
..
Patch Set 2:
it sounds very odd to link to a private page on fedorahosted, which can
disappear tomorrow, and
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move rwtab to static
..
configs: move rwtab to static
Part of the move of static files to new directory. The files are moved
to
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move sudoers to static
..
configs: move sudoers to static
Part of the move of static files to new directory. The files are moved
to
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move logger to static
..
configs: move logger to static
Part of the move of static files to new directory. The files are moved
to
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move mom to static
..
configs: move mom to static
Part of the move of static files to new directory. The files are moved
to corresponding
Dan Kenigsberg has posted comments on this change.
Change subject: virt net: Support VM migration on OVS based networks
..
Patch Set 15: Code-Review-1
(1 comment)
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Removed %config(noreplace) from
%{_tmpfilesdir}/%{vdsm_name}.conf
..
Removed %config(noreplace) from %{_tmpfilesdir}/%{vdsm_name}.conf
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Update spec change-log after re-review
..
Update spec change-log after re-review
See topic: https://gerrit.ovirt.org/#/q/topic:spec-review
Bug-Url:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Specifies vdsm-infra version to obsoletes
..
Specifies vdsm-infra version to obsoletes
Change-Id: Ifde739ee3520105d738ad217179da563ce10ddf5
Dan Kenigsberg has posted comments on this change.
Change subject: network: filter out 'veth' devices
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/60821/12/lib/vdsm/network/netinfo/qos.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: virt net: Support VM migration on OVS based networks
..
Patch Set 14: Code-Review-1
(1 comment)
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Require python2-devel specifically to avoid python3 pkg
..
Require python2-devel specifically to avoid python3 pkg
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: Change Source0 after uploading latest tar
..
Patch Set 2: Code-Review-1
I don't understand why this is good/needed.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Using %{_libdir} macro instead of /usr/lib
..
Using %{_libdir} macro instead of /usr/lib
Change-Id: I8c70582236868a0d9d9f37bb3f1fd7527138404f
Dan Kenigsberg has submitted this change and it was merged.
Change subject: packaging: spec: drop default defattr
..
packaging: spec: drop default defattr
Dropping default defattr, not needed since EPEL 6.
Part of Fedora 24
Dan Kenigsberg has submitted this change and it was merged.
Change subject: autoconf: properly sort makefiles
..
autoconf: properly sort makefiles
Adhere to the sorting comment. No reason to have messy list of
makefiles.
Dan Kenigsberg has posted comments on this change.
Change subject: autoconf: properly sort makefiles
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61600
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: introduce static dir
..
configs: introduce static dir
The idea behind new directory is that it'll store (possibly) all files
that are not
Dan Kenigsberg has submitted this change and it was merged.
Change subject: makefile: remove unused all-local section
..
makefile: remove unused all-local section
The section has been emptied in previous changes. Nothing to
Dan Kenigsberg has posted comments on this change.
Change subject: makefile: remove unused all-local section
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61545
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: tighten exception handling in getIfaceCfg
..
Patch Set 3: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/53470
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: virt net: Support VM migration on OVS based networks
..
Patch Set 13: Code-Review-1
(1 comment)
Dan Kenigsberg has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/35181/16/contrib/jsonrpc
File contrib/jsonrpc:
Line 43: ...
Line
Dan Kenigsberg has posted comments on this change.
Change subject: check-merged: remove bond0 hack
..
Patch Set 17: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/61415
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: check-merged: remove bond0 hack
..
check-merged: remove bond0 hack
In the new Fedora 24 image, bonding kernel module wasn't loaded
at vm boot so there
Dan Kenigsberg has posted comments on this change.
Change subject: check-merged: install python-mock on lago deploy
..
Patch Set 2: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/61937
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: check-merged: install python-mock on lago deploy
..
check-merged: install python-mock on lago deploy
python-mock is needed by testlib and it's not
Dan Kenigsberg has submitted this change and it was merged.
Change subject: check-merged: remove numactl installation from deploy
..
check-merged: remove numactl installation from deploy
numactl is installed when vdsn is
Dan Kenigsberg has posted comments on this change.
Change subject: check-merged: remove numactl installation from deploy
..
Patch Set 1: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/61938
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: automation: include master repos in check-merged tests
..
automation: include master repos in check-merged tests
ovirt master repos weren't enabled so
Dan Kenigsberg has posted comments on this change.
Change subject: automation: include master repos in check-merged tests
..
Patch Set 1: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/61936
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ovs: add OVS bridges cleanup to shell_helper
..
ovs: add OVS bridges cleanup to shell_helper
Change-Id: I55addefb42550d88c83548ca31a94e40b7e47184
Dan Kenigsberg has posted comments on this change.
Change subject: ovs: add OVS bridges cleanup to shell_helper
..
Patch Set 2: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/61687
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ovs: use vdsmbr_test name for test bridges
..
ovs: use vdsmbr_test name for test bridges
We should use the same prefix as for 'real' OVS bridge, so we
Dan Kenigsberg has posted comments on this change.
Change subject: ovs: use vdsmbr_test name for test bridges
..
Patch Set 1: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/61905
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: functional tests: fix supervdsmServer test
..
Patch Set 6: Code-Review-1
(2 comments)
Dan Kenigsberg has posted comments on this change.
Change subject: ovs: copy NIC hwaddr to NB
..
Patch Set 19: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/61049
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net test: Cleanup _fakeTypeDetection
..
net test: Cleanup _fakeTypeDetection
Change-Id: I43a456051f9ad4d50fa4ebaff584bc2828980608
Signed-off-by:
Dan Kenigsberg has posted comments on this change.
Change subject: net test: Replacing MonkeyPatch with mock.patch for netinfo_test
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61269
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ovs: copy NIC hwaddr to NB
..
ovs: copy NIC hwaddr to NB
In order to receive the same IP for network as acquired NIC used to
have, we must copy NIC's
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net test: Replacing MonkeyPatch with mock.patch for netinfo_test
..
net test: Replacing MonkeyPatch with mock.patch for netinfo_test
Refactor
Dan Kenigsberg has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 39: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/60404
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ovs: acquire ifaces
..
ovs: acquire ifaces
Switch returns list of used devices, on upper level we should
check if they are owned by us and if not,
601 - 700 of 19925 matches
Mail list logo
