Francesco Romani has posted comments on this change.
Change subject: Adding build-artifacts-manual.sh script
..
Patch Set 3:
It seems the job
Francesco Romani has uploaded a new change for review.
Change subject: tests: mom: create the socket under tmpdir
..
tests: mom: create the socket under tmpdir
Some tests may fail under automation if Vdsm
is built and its test
Francesco Romani has posted comments on this change.
Change subject: v2v: Running virt-v2v with some sane environment
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/62765/2/lib/vdsm/v2v.py
File
Francesco Romani has posted comments on this change.
Change subject: v2v: Add PipelineProc, pipeline wrapper object
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62094
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: v2v: Add PipelineProc, pipeline wrapper object
..
Patch Set 3: Code-Review+1
temporarily lowering my score to not hid Dan's
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: api: Move getAllVmStats hooks and logging from API to clientIF
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60583/2/vdsm/clientIF.py
File
Francesco Romani has posted comments on this change.
Change subject: Revert "configurator: libvirt: do not jump on virtlogd"
..
Patch Set 3: Verified+1
a bit more test gave good result. I think it is good enough for master.
, one example package (as expected):
KENji> 11:20:25 fromani [~]$ rpm -qR vdsm | grep vdsm
config(vdsm) = 4.18.999-439.gitc0c1818.el7.centos
vdsm-hook-vmfex-dev = 4.18.999
vdsm-jsonrpc = 4.18.999
vdsm-python = 4.18.999
vdsm-xmlrpc = 4.18.999
Not sure what else I can check.
--
To view, visit ht
Francesco Romani has submitted this change and it was merged.
Change subject: net: don't accept nameservers on a non-default network
..
net: don't accept nameservers on a non-default network
Currently, only the
Francesco Romani has submitted this change and it was merged.
Change subject: net tests: add a 'status' parameter to SetupNetworksError
..
net tests: add a 'status' parameter to SetupNetworksError
Change-Id:
Francesco Romani has submitted this change and it was merged.
Change subject: net: write out nameservers to ifcfg files
..
net: write out nameservers to ifcfg files
This patch handles setupNetworks' recently introduced
Francesco Romani has submitted this change and it was merged.
Change subject: network: rename reported 'dnss' to 'nameservers' for clarity
..
network: rename reported 'dnss' to 'nameservers' for clarity
Change-Id:
Francesco Romani has submitted this change and it was merged.
Change subject: net: add a 'nameservers' property to NetInfo
..
net: add a 'nameservers' property to NetInfo
Functional tests in the following patch will use it.
Francesco Romani has submitted this change and it was merged.
Change subject: net: Introduce nameservers (dns) network api
..
net: Introduce nameservers (dns) network api
oVirt is required to preserve and manage the
Francesco Romani has uploaded a new change for review.
Change subject: build: require only the same version, not release
..
build: require only the same version, not release
The various vdsm subpackages where requiring
Francesco Romani has posted comments on this change.
Change subject: enabling ppc64le builds for vdsm
..
Patch Set 17: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: network: ifup: shorten name of the thread
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62617/2/lib/vdsm/network/configurators/ifcfg.py
File
Francesco Romani has posted comments on this change.
Change subject: network: ifup: shorten name of the thread
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/62617/1/lib/vdsm/network/configurators/ifcfg.py
File
Francesco Romani has posted comments on this change.
Change subject: virt: migration: switch to concurrent.thread()
..
Patch Set 10: Verified+1
verification still holds.
--
To view, visit https://gerrit.ovirt.org/61463
To
Francesco Romani has uploaded a new change for review.
Change subject: network: ifup: shorten name of the thread
..
network: ifup: shorten name of the thread
We shorten the name of the thread optionally used by
the _ifup()
Francesco Romani has uploaded a new change for review.
Change subject: network: dhclient: shorten name of the thread
..
network: dhclient: shorten name of the thread
We shorten the name of the DhcpClient worker thread to
make
Francesco Romani has posted comments on this change.
Change subject: virt: migration: switch to concurrent.thread()
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/61463/9/vdsm/virt/migration.py
File
Francesco Romani has submitted this change and it was merged.
Change subject: automation: fix lago repo for fc24
..
automation: fix lago repo for fc24
Moving lago repository to fc24 which wasn't previously available.
Francesco Romani has posted comments on this change.
Change subject: automation: fix lago repo for fc24
..
Patch Set 2:
trivial patch, has plenty of ACKs, doesn't touch production code: I'm taking it
with no further ado :)
Francesco Romani has posted comments on this change.
Change subject: network: switch to concurrent.thread()
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/61459/9/lib/vdsm/network/configurators/ifcfg.py
File
Francesco Romani has posted comments on this change.
Change subject: tests: bootstrap the livemerge tests
..
Patch Set 4:
oops, thanks. Fixed.
--
To view, visit https://gerrit.ovirt.org/62253
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: vm: periodic: fix stats age reporting
..
vm: periodic: fix stats age reporting
We need to report the Vm responsiveness, because it is one
important
Francesco Romani has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62418
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: tests: sampling: add FakeClock helper
..
tests: sampling: add FakeClock helper
Add a more robust FakeClock implementation, to be used
in a upcoming
Francesco Romani has submitted this change and it was merged.
Change subject: virt: sampling: add is_empty() method to StatsSample
..
virt: sampling: add is_empty() method to StatsSample
One upcoming patch wants to fill the
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: add is_empty() method to StatsSample
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62417
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: tests: sampling: add FakeClock helper
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62416
To unsubscribe, visit
Francesco Romani has uploaded a new change for review.
Change subject: migration: more debug logs for connection
..
migration: more debug logs for connection
Now that we have real debug logs and saner default log configuration,
Francesco Romani has uploaded a new change for review.
Change subject: migration: add low-level socket timeout
..
migration: add low-level socket timeout
Helpful to troubleshoot werird failures like
rhbz#134
Change-Id:
Francesco Romani has uploaded a new change for review.
Change subject: migration: coalesce join() into stop()
..
migration: coalesce join() into stop()
we always call join() after stop(), so coalesce the two
method in stop().
Francesco Romani has uploaded a new change for review.
Change subject: virt: migration: rename classes
..
virt: migration: rename classes
Now that the classes in migration.py use composition over inheritance,
we can rename them
Francesco Romani has posted comments on this change.
Change subject: virt: migration: switch to concurrent.thread()
..
Patch Set 9: Verified+1
Verified running patched vdsm and checking the thread names with 'htop'
Tested
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: shorten executor thread system names
..
Patch Set 7: Verified+1
Verified running patched vdsm and checking the thread names with 'htop'
Tested
Francesco Romani has posted comments on this change.
Change subject: virt: vmchannels: use shorter name for thread
..
Patch Set 2: Verified+1
Verified running patched vdsm and checking the thread names with 'htop'
Tested
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: yajsonrpc: switch to concurrent.thread()
..
Patch Set 8: Verified+1
Verified running patched vdsm and checking the thread names with 'htop'
Tested
Francesco Romani has posted comments on this change.
Change subject: lib: concurrent: fallback python name for system
..
Patch Set 2: Verified+1
verified running Vdsm and checking the thread names with 'htop'
--
To view,
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: shorten executor thread system names
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/61978/6/lib/vdsm/rpc/bindingjsonrpc.py
File
Francesco Romani has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60640
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: devices: add is_hostdevice attribute
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62063
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: hostdev: properly set is_hostdevice
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62064
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: hostdev: report device MMIO numa node
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60637
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: kvm2ovirt: use None if no password is given
..
Patch Set 2: Verified+1
verified adding logs to libvirtconnection.py. Then run kvm2ovirt without passwd
file
Francesco Romani has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/59031/7/lib/vdsm/host/rngsources.py
File
Francesco Romani has posted comments on this change.
Change subject: kvm2ovirt: use None if no password is given
..
Patch Set 1:
rebased as requested.
--
To view, visit https://gerrit.ovirt.org/62547
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: kvm2ovirt: add dry run option
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/62257/1/helpers/kvm2ovirt
File helpers/kvm2ovirt:
Line 99
Line 100
Francesco Romani has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/59031/7/lib/vdsm/host/rngsources.py
File
Francesco Romani has uploaded a new change for review.
Change subject: kvm2ovirt: use None if no password is given
..
kvm2ovirt: use None if no password is given
If no password file is given as parameter, we should use
None as
Francesco Romani has posted comments on this change.
Change subject: kvm2ovirt: Fixes issue in importing VMs with libvirt uri
qemu+tcp
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62052/2/helpers/kvm2ovirt
File
Francesco Romani has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/59031/7/lib/vdsm/host/rngsources.py
File
Francesco Romani has posted comments on this change.
Change subject: WIP vm: add utility to get sublogger
..
Patch Set 4: Code-Review-1 Verified-1
broken as per Nir's comments.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: WIP vm: add utility to get sublogger
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/61992/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 222:
Francesco Romani has uploaded a new change for review.
Change subject: migration: more logs for connection
..
migration: more logs for connection
Add additional debug logs to help troubleshoot
weird issues like rhbz#134
Francesco Romani has uploaded a new change for review.
Change subject: migration: add low-level socket timeout
..
migration: add low-level socket timeout
Helpful to troubleshoot werird failures like
rhbz#134
Change-Id:
Francesco Romani has submitted this change and it was merged.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
virt: Fix of Executor._active_workers crash on modification
Executor._active_workers
Francesco Romani has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62402
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: virt: Limit the number of workers in executor
..
virt: Limit the number of workers in executor
In some situations, periodic operations may hang
Francesco Romani has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 1: Verified+1
re-verified on branch, using the same steps as master branch.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: add is_empty() method to StatsSample
..
Patch Set 1: Verified+1
verified with the tests and with 62418
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
Patch Set 1:
no-brainer once parent patch is in.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62403
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 1: Code-Review+1
will have myself another review cycle (worst case ETA tomorrow) -- for extra
Francesco Romani has submitted this change and it was merged.
Change subject: periodic: always re-schedule operations
..
periodic: always re-schedule operations
when one periodic.Operation() try to dispatch itself
to the
Francesco Romani has posted comments on this change.
Change subject: periodic: always re-schedule operations
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62401
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
Patch Set 1: Verified+1
verified with 62402
--
To view, visit https://gerrit.ovirt.org/62403
Francesco Romani has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 1: Verified+1
re-verified on-branch the same way as master patch:
[root@goji ~]# grep 'Too many'
Francesco Romani has posted comments on this change.
Change subject: periodic: always re-schedule operations
..
Patch Set 1: Verified+1
Verified on-branch the same way as master patch and ovirt-4.0 patch:
Francesco Romani has posted comments on this change.
Change subject: tests: sampling: add FakeClock helper
..
Patch Set 1: Verified+1
if tests pass, we are good to go.
--
To view, visit https://gerrit.ovirt.org/62416
To
Hello Dan Kenigsberg, Martin Polednik,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62416
to review the following change.
Change subject: tests: sampling: add FakeClock helper
..
tests:
Hello Dan Kenigsberg, Martin Polednik,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62418
to review the following change.
Change subject: vm: periodic: fix stats age reporting
..
vm: periodic:
Hello Dan Kenigsberg, Martin Polednik,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62417
to review the following change.
Change subject: virt: sampling: add is_empty() method to StatsSample
..
Francesco Romani has submitted this change and it was merged.
Change subject: tests: sampling: add FakeClock helper
..
tests: sampling: add FakeClock helper
Add a more robust FakeClock implementation, to be used
in a upcoming
Francesco Romani has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61822
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: vm: periodic: fix stats age reporting
..
vm: periodic: fix stats age reporting
We need to report the Vm responsiveness, because it is one
important
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: add is_empty() method to StatsSample
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61821
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: tests: sampling: add FakeClock helper
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61820
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: virt: sampling: add is_empty() method to StatsSample
..
virt: sampling: add is_empty() method to StatsSample
One upcoming patch wants to fill the
Francesco Romani has posted comments on this change.
Change subject: Rename reports to metrics
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62147
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: Rename reports to metrics
..
Rename reports to metrics
Leftovers from using reports instead of metrics (following
Francesco Romani has posted comments on this change.
Change subject: Send metrics info only if metrics enabled to avoid parsing logic
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62146
To
Francesco Romani has submitted this change and it was merged.
Change subject: Send metrics info only if metrics enabled to avoid parsing logic
..
Send metrics info only if metrics enabled to avoid parsing logic
Change-Id:
Francesco Romani has submitted this change and it was merged.
Change subject: Send vm info report each sampling interval from VMBulkSampler
..
Send vm info report each sampling interval from VMBulkSampler
Change-Id:
Francesco Romani has posted comments on this change.
Change subject: Send vm info report each sampling interval from VMBulkSampler
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62145
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62144
To
Francesco Romani has submitted this change and it was merged.
Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..
Adding get_batch to StatsCache - returns dict with all vms stat
Change-Id:
Francesco Romani has submitted this change and it was merged.
Change subject: automation: build also vhostmd hook
..
automation: build also vhostmd hook
In 3.6 we shipped vdsm-hook-vhostmd as part of our VDSM releases.
In 4.0
Hello Nir Soffer, Milan Zamazal,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62402
to review the following change.
Change subject: virt: Limit the number of workers in executor
..
virt: Limit
Hello Dan Kenigsberg, Milan Zamazal,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62401
to review the following change.
Change subject: periodic: always re-schedule operations
..
periodic:
Hello Milan Zamazal,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62403
to review the following change.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
virt: Fix
Francesco Romani has submitted this change and it was merged.
Change subject: periodic: always re-schedule operations
..
periodic: always re-schedule operations
when one periodic.Operation() try to dispatch itself
to the
Francesco Romani has submitted this change and it was merged.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
virt: Fix of Executor._active_workers crash on modification
Executor._active_workers
Francesco Romani has posted comments on this change.
Change subject: periodic: always re-schedule operations
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61889
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: virt: Limit the number of workers in executor
..
virt: Limit the number of workers in executor
In some situations, periodic operations may hang
Francesco Romani has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61769
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61770
To unsubscribe,
501 - 600 of 9835 matches
Mail list logo
