Change in vdsm[master]: API: modernize VM methods

From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: API: modernize VM methods .. API: modernize VM methods This patch adds the wrapping using @api.method around

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 20: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public

Change in vdsm[master]: API: modernize VM methods

Milan Zamazal has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 19: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py File vdsm/API.py: Line 125: Line 126:

Change in vdsm[master]: API: modernize VM methods

Nir Soffer has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 18: (2 comments) https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py File vdsm/API.py: Line 346 Line 347 Line 348 Line 349

Change in vdsm[master]: API: modernize VM methods

Piotr Kliczewski has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 19: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61475 To unsubscribe, visit

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 19: * update_tracker: OK * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid

Change in vdsm[master]: API: modernize VM methods

Francesco Romani has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py File vdsm/API.py: Line 333: """ Line 334:

Change in vdsm[master]: API: modernize VM methods

Francesco Romani has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/61475/18//COMMIT_MSG Commit Message: PS18, Line 9: all > Actually not

Change in vdsm[master]: API: modernize VM methods

Francesco Romani has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 18: (6 comments) The problem is that I don't know how the meaningfully split this patch without using one patch per

Change in vdsm[master]: API: modernize VM methods

Michal Skrivanek has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 18: (3 comments) indeed we should avoid semantics change, but please do not split into hundred little patches,

Change in vdsm[master]: API: modernize VM methods

Nir Soffer has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 18: (2 comments) I think this patch is too big, lets change first the easy places where replacing the duplicate code with

Change in vdsm[master]: API: modernize VM methods

Arik Hadas has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py File vdsm/API.py: Line 263: """ Line 264:

Change in vdsm[master]: API: modernize VM methods

Milan Zamazal has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 18: Code-Review-1 (6 comments) Nice change, but we should be careful and double check. I'm afraid there are some

Change in vdsm[master]: API: modernize VM methods

Nir Soffer has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py File vdsm/API.py: Line 263: """ Line 264:

Change in vdsm[master]: API: modernize VM methods

Arik Hadas has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py File vdsm/API.py: Line 263: """ Line 264:

Change in vdsm[master]: API: modernize VM methods

Nir Soffer has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 18: Can we get reviews from the virt guys? -- To view, visit https://gerrit.ovirt.org/61475 To unsubscribe, visit

Change in vdsm[master]: API: modernize VM methods

Michal Skrivanek has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 18: 2:1 for line removals, that's always a good thing! -- To view, visit https://gerrit.ovirt.org/61475 To

Change in vdsm[master]: API: modernize VM methods

Francesco Romani has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 18: Verified+1 fixed a bug in VM.migrate (unrelated hunk sneaked in). Now seems to work with the basic VM flows,

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 18: * update_tracker: OK * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid

Change in vdsm[master]: API: modernize VM methods

Francesco Romani has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 17: basic VM flows works, but migrations is broken. Investigating. -- To view, visit https://gerrit.ovirt.org/61475

Change in vdsm[master]: API: modernize VM methods

Piotr Kliczewski has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 17: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61475 To unsubscribe, visit

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 17: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: API: modernize VM methods

Francesco Romani has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/61475/9/vdsm/API.py File vdsm/API.py: Line 37: from vdsm import

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 16: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: API: modernize VM methods

Piotr Kliczewski has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 15: Nice cleanup, please respond to Nir's comments. -- To view, visit https://gerrit.ovirt.org/61475 To unsubscribe,

Change in vdsm[master]: API: modernize VM methods

Nir Soffer has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 15: Code-Review-1 Please address comments from version 9: https://gerrit.ovirt.org/#/c/61475/9/vdsm/API.py -- To view,

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: API: modernize VM methods

Nir Soffer has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/61475/9/vdsm/API.py File vdsm/API.py: Line 37: from vdsm import supervdsm

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: API: modernize VM methods

Irit Goihman has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61475 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: API: modernize VM methods

Francesco Romani has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/61475/5/vdsm/API.py File vdsm/API.py: Line 37: from vdsm import

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: