Ayal Baron has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 14: Looks good to me, approved
I still don't like the fact that _getVolsTree doesn't return a dictionary
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 14: I would prefer that you didn't submit this
(2 inline comments)
minor comments.
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 14: Verified; No score
/me tired of commenting on comments.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 13: I would prefer that you didn't submit this
(1 inline comment)
:-(
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 12: I would prefer that you didn't submit this
(1 inline comment)
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 11: (2 inline comments)
File
Haim Ateya has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 11: Verified
tested extensively on both block file domains running most of the core
scenarios: copy,
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 11: I would prefer that you didn't submit this
(7 inline comments)
Ayal Baron has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 11: I would prefer that you didn't submit this
Same comments as before
--
To view, visit
Eduardo has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 8: (1 inline comment)
File vdsm/storage/blockSD.py
Line
Igor Lvovsky has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 8: Looks good to me, but someone else must approve
(3 inline comments)
Only minor comments
Ayal Baron has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 8: (5 inline comments)
Commit Message
Line 10:
Ayal Baron has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 7: (1 inline comment)
File vdsm/storage/blockSD.py
Igor Lvovsky has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 7: (1 inline comment)
File vdsm/storage/blockSD.py
Ayal Baron has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 7: (1 inline comment)
File vdsm/storage/fileSD.py
Ayal Baron has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 7: I would prefer that you didn't submit this
(8 inline comments)
Eduardo has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 7: (7 inline comments)
Commit Message
Line 7: BZ#788640
Ayal Baron has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 7: (5 inline comments)
Commit Message
Line 7:
18 matches
Mail list logo