Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-05-22 Thread abaron
Ayal Baron has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 14: Looks good to me, approved I still don't like the fact that _getVolsTree doesn't return a dictionary

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-05-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 14: I would prefer that you didn't submit this (2 inline comments) minor comments.

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-05-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 14: Verified; No score /me tired of commenting on comments. -- To view, visit

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-05-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 13: I would prefer that you didn't submit this (1 inline comment) :-(

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-05-15 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 12: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-05-14 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 11: (2 inline comments) File

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-05-13 Thread Haim Ateya
Haim Ateya has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 11: Verified tested extensively on both block file domains running most of the core scenarios: copy,

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-05-13 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 11: I would prefer that you didn't submit this (7 inline comments)

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-05-11 Thread abaron
Ayal Baron has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 11: I would prefer that you didn't submit this Same comments as before -- To view, visit

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-05-08 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 8: (1 inline comment) File vdsm/storage/blockSD.py Line

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-05-07 Thread ilvovsky
Igor Lvovsky has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 8: Looks good to me, but someone else must approve (3 inline comments) Only minor comments

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-05-07 Thread abaron
Ayal Baron has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 8: (5 inline comments) Commit Message Line 10:

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-05-01 Thread abaron
Ayal Baron has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 7: (1 inline comment) File vdsm/storage/blockSD.py

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-04-30 Thread ilvovsky
Igor Lvovsky has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 7: (1 inline comment) File vdsm/storage/blockSD.py

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-04-30 Thread abaron
Ayal Baron has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 7: (1 inline comment) File vdsm/storage/fileSD.py

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-04-29 Thread abaron
Ayal Baron has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 7: I would prefer that you didn't submit this (8 inline comments)

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-04-29 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 7: (7 inline comments) Commit Message Line 7: BZ#788640

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-04-29 Thread abaron
Ayal Baron has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 7: (5 inline comments) Commit Message Line 7: