Ayal Baron has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
......................................................................
Patch Set 8: (5 inline comments)
....................................................
Commit Message
Line 10: information based only in SD properties, without reading
s/in/on/
Line 14: In addition the number of storage access is strongly lowered.
s/simultaneosly/simultaneously/
s/access is strongly lowered/accesses is greatly reduced/
....................................................
File vdsm/storage/blockSD.py
Line 142: if lv.name not in SPECIAL_LVS:
change to elif
Line 157: res[vName] = {'imgs': [], 'parent': None}
This loop should not be here (getVolsTree should set it)
Line 160: res[vName]['parent'] = vPar
This assignment shouldn't be here either (getVolsTree should set it)
--
To view, visit http://gerrit.ovirt.org/3462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eccf5ca100bd354aa09208ca60bb112fb697063
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
